131980 2014-04-22 02:39:32 -0700 Buildfix after r167650 broke non-Cocoa builds 2014-04-22 04:06:06 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 pmolnar.u-szeged pmolnar.u-szeged bfulgham commit-queue mario oldest_to_newest 1002846 0 pmolnar.u-szeged 2014-04-22 02:39:32 -0700 Buildfix after r167650 broke non-Cocoa builds 1002847 1 229873 pmolnar.u-szeged 2014-04-22 02:42:56 -0700 Created attachment 229873 patch #ifdef-ed out the Mac specific line to fix the non-Cocoa builds. 1002850 2 229873 mario 2014-04-22 02:47:43 -0700 Comment on attachment 229873 patch Sounds good to me, although we should let bfulgham now about it anyway 1002855 3 229873 commit-queue 2014-04-22 03:17:23 -0700 Comment on attachment 229873 patch Rejecting attachment 229873 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 229873, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: 131980. Found no modified ChangeLogs, cannot create a commit message. All changes require a ChangeLog. See: http://webkit.org/coding/contributing.html Found no modified ChangeLogs, cannot create a commit message. All changes require a ChangeLog. See: http://webkit.org/coding/contributing.html Found no modified ChangeLogs, cannot create a commit message. All changes require a ChangeLog. See: http://webkit.org/coding/contributing.html Updating OpenSource Current branch master is up to date. Full output: http://webkit-queues.appspot.com/results/4802375017562112 1002858 4 229873 pnormand 2014-04-22 03:45:21 -0700 Comment on attachment 229873 patch Missing ChangeLog, prepare-ChangeLog can help with that. 1002862 5 mario 2014-04-22 03:56:56 -0700 (In reply to comment #4) > (From update of attachment 229873 [details]) > Missing ChangeLog, prepare-ChangeLog can help with that. Opps, that's right. Sorry for my quick review 1002863 6 pmolnar.u-szeged 2014-04-22 04:05:40 -0700 (In reply to comment #5) > (In reply to comment #4) > > (From update of attachment 229873 [details] [details]) > > Missing ChangeLog, prepare-ChangeLog can help with that. > > Opps, that's right. Sorry for my quick review Sorry, added the ChangeLog and landed patch in r167654. 229873 2014-04-22 02:42:56 -0700 2014-04-22 03:45:21 -0700 patch buildfix-167650.patch text/plain 735 pmolnar.u-szeged ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRXZlbnRIYW5kbGVyLmNwcCBiL1NvdXJj ZS9XZWJDb3JlL3BhZ2UvRXZlbnRIYW5kbGVyLmNwcAppbmRleCA2YTc0NjlkLi42YjFiMDJiIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0V2ZW50SGFuZGxlci5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvcGFnZS9FdmVudEhhbmRsZXIuY3BwCkBAIC0yNTc2LDcgKzI1NzYsMTEgQEAg Ym9vbCBFdmVudEhhbmRsZXI6OmhhbmRsZVdoZWVsRXZlbnQoY29uc3QgUGxhdGZvcm1XaGVlbEV2 ZW50JiBlKQogICAgIFNjcm9sbGFibGVBcmVhKiBzY3JvbGxhYmxlQXJlYSA9IG51bGxwdHI7CiAg ICAgcGxhdGZvcm1QcmVwYXJlRm9yV2hlZWxFdmVudHMoZSwgcmVzdWx0LCBlbGVtZW50LCBzY3Jv bGxhYmxlQ29udGFpbmVyLCBzY3JvbGxhYmxlQXJlYSwgaXNPdmVyV2lkZ2V0KTsKIAorI2lmIFBM QVRGT1JNKENPQ09BKQogICAgIGlmIChlLnBoYXNlKCkgPT0gUGxhdGZvcm1XaGVlbEV2ZW50UGhh c2VOb25lICYmIGUubW9tZW50dW1QaGFzZSgpID09IFBsYXRmb3JtV2hlZWxFdmVudFBoYXNlTm9u ZSkgeworI2Vsc2UKKyAgICBpZiAoIWUudXNlTGF0Y2hlZEV2ZW50RWxlbWVudCgpKSB7CisjZW5k aWYKICAgICAgICAgbV9sYXRjaGVkV2hlZWxFdmVudEVsZW1lbnQgPSBudWxscHRyOwogICAgICAg ICBtX3ByZXZpb3VzV2hlZWxTY3JvbGxlZEVsZW1lbnQgPSBudWxscHRyOwogICAgIH0K