131970 2014-04-21 21:15:02 -0700 [WebKit2] Cleanup the build from unused parameter in WebProcess Module 2014-04-29 23:20:49 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified VERIFIED FIXED P2 Normal --- 1 shiva.jm webkit-unassigned bunhere cmarcelo commit-queue luiz noam sergio thorton zeno oldest_to_newest 1002803 0 shiva.jm 2014-04-21 21:15:02 -0700 Found unused parameter in WebProcess Module during webkit-efl port build. [ 95%] Building CXX object Source/WebKit2/CMakeFiles/WebKit2.dir/WebProcess/WebPage/efl/WebInspectorEfl.cpp.o /home/shiva.jm/webkit-git/svngit/WebKit/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:209:6: warning: unused parameter ‘graphicsLayer’ [-Wunused-parameter] void CoordinatedLayerTreeHost::paintLayerContents(const GraphicsLayer* graphicsLayer, GraphicsContext& graphicsContext, const IntRect& clipRect) ^ /home/shiva.jm/webkit-git/svngit/WebKit/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:209:6: warning: unused parameter ‘graphicsContext’ [-Wunused-parameter] /home/shiva.jm/webkit-git/svngit/WebKit/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:209:6: warning: unused parameter ‘clipRect’ [-Wunused-parameter] [ 95%] Building CXX object Source/WebKit2/CMakeFiles/WebKit2.dir/WebProcess/WebPage/efl/WebPageEfl.cpp.o 1002822 1 229866 shiva.jm 2014-04-21 23:17:25 -0700 Created attachment 229866 Fix a build warning by removing the parameters in function paintLayerContents() to fix build warnings Created a patch to Fix a build warning by removing the parameters in function paintLayerContents() to fix build warnings 1002896 2 229866 commit-queue 2014-04-22 08:19:29 -0700 Comment on attachment 229866 Fix a build warning by removing the parameters in function paintLayerContents() to fix build warnings Clearing flags on attachment: 229866 Committed r167660: <http://trac.webkit.org/changeset/167660> 1002897 3 commit-queue 2014-04-22 08:19:33 -0700 All reviewed patches have been landed. Closing bug. 1005302 4 shiva.jm 2014-04-29 23:20:49 -0700 Bug is fixed tested in version 167979. 229866 2014-04-21 23:17:25 -0700 2014-04-22 08:19:29 -0700 Fix a build warning by removing the parameters in function paintLayerContents() to fix build warnings Patch text/plain 1555 shiva.jm SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2NzY1MCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE0LTA0LTIxICBTaGl2YWt1 bWFyIEpNICA8c2hpdmEuam1Ac2Ftc3VuZy5jb20+CisKKyAgICAgICAgW1dlYktpdDJdIENsZWFu dXAgdGhlIGJ1aWxkIGZyb20gdW51c2VkIHBhcmFtZXRlciBpbiBXZWJQcm9jZXNzIE1vZHVsZSAK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMTk3MAor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeCBhIGJ1 aWxkIHdhcm5pbmcgYnkgcmVtb3ZpbmcgdGhlIHBhcmFtZXRlcnMgaW4gZnVuY3Rpb24gcGFpbnRM YXllckNvbnRlbnRzKCkgdG8gZml4IGJ1aWxkIHdhcm5pbmcuCisKKyAgICAgICAgKiBXZWJQcm9j ZXNzL1dlYlBhZ2UvQ29vcmRpbmF0ZWRHcmFwaGljcy9Db29yZGluYXRlZExheWVyVHJlZUhvc3Qu Y3BwOgorICAgICAgICAoV2ViS2l0OjpDb29yZGluYXRlZExheWVyVHJlZUhvc3Q6OnBhaW50TGF5 ZXJDb250ZW50cyk6CisKIDIwMTQtMDQtMjEgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBh cHBsZS5jb20+CiAKICAgICAgICAgW3drMl0gRG9uJ3Qgc2VuZCBpbnRyaW5zaWMgY29udGVudCBz aXplIHVwZGF0ZXMgd2l0aCBkaXJ0eSBsYXlvdXQKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1dlYlBy b2Nlc3MvV2ViUGFnZS9Db29yZGluYXRlZEdyYXBoaWNzL0Nvb3JkaW5hdGVkTGF5ZXJUcmVlSG9z dC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL0Nv b3JkaW5hdGVkR3JhcGhpY3MvQ29vcmRpbmF0ZWRMYXllclRyZWVIb3N0LmNwcAkocmV2aXNpb24g MTY3NjQ3KQorKysgU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL0Nvb3JkaW5hdGVk R3JhcGhpY3MvQ29vcmRpbmF0ZWRMYXllclRyZWVIb3N0LmNwcAkod29ya2luZyBjb3B5KQpAQCAt MjA2LDcgKzIwNiw3IEBAIHZvaWQgQ29vcmRpbmF0ZWRMYXllclRyZWVIb3N0OjpsYXllckZsdXMK ICAgICBwZXJmb3JtU2NoZWR1bGVkTGF5ZXJGbHVzaCgpOwogfQogCi12b2lkIENvb3JkaW5hdGVk TGF5ZXJUcmVlSG9zdDo6cGFpbnRMYXllckNvbnRlbnRzKGNvbnN0IEdyYXBoaWNzTGF5ZXIqIGdy YXBoaWNzTGF5ZXIsIEdyYXBoaWNzQ29udGV4dCYgZ3JhcGhpY3NDb250ZXh0LCBjb25zdCBJbnRS ZWN0JiBjbGlwUmVjdCkKK3ZvaWQgQ29vcmRpbmF0ZWRMYXllclRyZWVIb3N0OjpwYWludExheWVy Q29udGVudHMoY29uc3QgR3JhcGhpY3NMYXllciosIEdyYXBoaWNzQ29udGV4dCYsIGNvbnN0IElu dFJlY3QmKQogewogfQogCg==