<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>131969</bug_id>
          
          <creation_ts>2014-04-21 21:10:45 -0700</creation_ts>
          <short_desc>[WebKit2] Cleanup the build from unused parameter in UIProcess Module</short_desc>
          <delta_ts>2014-06-04 02:53:58 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit2</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Shivakumar J M">shiva.jm</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>alice.barraclough</cc>
    
    <cc>bunhere</cc>
    
    <cc>cdumez</cc>
    
    <cc>commit-queue</cc>
    
    <cc>gyuyoung.kim</cc>
    
    <cc>ossy</cc>
    
    <cc>sergio</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1002801</commentid>
    <comment_count>0</comment_count>
    <who name="Shivakumar J M">shiva.jm</who>
    <bug_when>2014-04-21 21:10:45 -0700</bug_when>
    <thetext>Found unused parameter in UIProcess Module during webkit-efl port build. These issue seems to be introduced by issue https://bugs.webkit.org/show_bug.cgi?id=131776, need to confirm with Alice once

/home/shiva.jm/webkit-git/svngit/WebKit/Source/WebKit2/UIProcess/WebFindClient.cpp:33:6: warning: unused parameter ‘matchIndex’ [-Wunused-parameter]
 void WebFindClient::didFindString(WebPageProxy* page, const String&amp; string, uint32_t matchCount, int32_t matchIndex)
      ^
[ 88%] Building CXX object Source/WebKit2/CMakeFiles/WebKit2.dir/UIProcess/WebFramePolicyListenerProxy.cpp.o

[ 89%] Building CXX object Source/WebKit2/CMakeFiles/WebKit2.dir/UIProcess/API/C/WKPreferences.cpp.o
/home/shiva.jm/webkit-git/svngit/WebKit/Source/WebKit2/UIProcess/API/C/WKPage.cpp:709:22: warning: unused parameter ‘matchIndex’ [-Wunused-parameter]
         virtual void didFindString(WebPageProxy* page, const String&amp; string, uint32_t matchCount, int32_t matchIndex) override
                      ^
[ 89%] Building CXX object Source/WebKit2/CMakeFiles/WebKit2.dir/UIProcess/API/C/WKProtectionSpace.cpp.o</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1006864</commentid>
    <comment_count>1</comment_count>
      <attachid>230888</attachid>
    <who name="Shivakumar J M">shiva.jm</who>
    <bug_when>2014-05-05 22:27:30 -0700</bug_when>
    <thetext>Created attachment 230888
Fix unused parameter by using UNUSED_PARAM macro

Fix unused parameter by using UNUSED_PARAM macro</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1006865</commentid>
    <comment_count>2</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2014-05-05 22:30:26 -0700</bug_when>
    <thetext>Attachment 230888 did not pass style-queue:


ERROR: LayoutTests/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1006866</commentid>
    <comment_count>3</comment_count>
      <attachid>230888</attachid>
    <who name="Shivakumar J M">shiva.jm</who>
    <bug_when>2014-05-05 22:35:02 -0700</bug_when>
    <thetext>Comment on attachment 230888
Fix unused parameter by using UNUSED_PARAM macro

&gt;Index: Source/WebKit2/ChangeLog
&gt;===================================================================
&gt;--- Source/WebKit2/ChangeLog	(revision 168348)
&gt;+++ Source/WebKit2/ChangeLog	(working copy)
&gt;@@ -1,3 +1,17 @@
&gt;+2014-05-05  Shivakumar JM  &lt;shiva.jm@samsung.com&gt;
&gt;+
&gt;+        Cleanup the build from unused parameter in UIProcess Module
&gt;+        https://bugs.webkit.org/show_bug.cgi?id=131969
&gt;+
&gt;+        Reviewed by NOBODY (OOPS!).
&gt;+
&gt;+        Fix unused parameter by using UNUSED_PARAM macro
&gt;+
&gt;+        * UIProcess/API/C/WKPage.cpp:
&gt;+        (WKPageSetPageFindClient):
&gt;+        * UIProcess/WebFindClient.cpp:
&gt;+        (WebKit::WebFindClient::didFindString):
&gt;+
&gt; 2014-05-05  Jeremy Jones  &lt;jeremyj@apple.com&gt;
&gt; 
&gt;         Implement scan backward and forward in video fullscreen.
&gt;Index: Source/WebKit2/UIProcess/WebFindClient.cpp
&gt;===================================================================
&gt;--- Source/WebKit2/UIProcess/WebFindClient.cpp	(revision 168348)
&gt;+++ Source/WebKit2/UIProcess/WebFindClient.cpp	(working copy)
&gt;@@ -32,6 +32,8 @@ namespace WebKit {
&gt; 
&gt; void WebFindClient::didFindString(WebPageProxy* page, const String&amp; string, uint32_t matchCount, int32_t matchIndex)
&gt; {
&gt;+    UNUSED_PARAM(matchIndex);
&gt;+
&gt;     if (!m_client.didFindString)
&gt;         return;
&gt; 
&gt;Index: Source/WebKit2/UIProcess/API/C/WKPage.cpp
&gt;===================================================================
&gt;--- Source/WebKit2/UIProcess/API/C/WKPage.cpp	(revision 168348)
&gt;+++ Source/WebKit2/UIProcess/API/C/WKPage.cpp	(working copy)
&gt;@@ -704,6 +704,8 @@ void WKPageSetPageFindClient(WKPageRef p
&gt;     private:
&gt;         virtual void didFindString(WebPageProxy* page, const String&amp; string, uint32_t matchCount, int32_t matchIndex) override
&gt;         {
&gt;+            UNUSED_PARAM(matchIndex);
&gt;+
&gt;             if (!m_client.didFindString)
&gt;                 return;
&gt;             
&gt;Index: LayoutTests/ChangeLog
&gt;===================================================================</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1006900</commentid>
    <comment_count>4</comment_count>
      <attachid>230895</attachid>
    <who name="Shivakumar J M">shiva.jm</who>
    <bug_when>2014-05-06 02:46:33 -0700</bug_when>
    <thetext>Created attachment 230895
Patch

Fix unused parameter by using UNUSED_PARAM macro, uploaded new patch again, since some problem was there in create patch for first time.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1006904</commentid>
    <comment_count>5</comment_count>
      <attachid>230895</attachid>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2014-05-06 03:40:25 -0700</bug_when>
    <thetext>Comment on attachment 230895
Patch

In WebKit style we prefer omitting the name of the argument to UNUSED_PARAM.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1006907</commentid>
    <comment_count>6</comment_count>
      <attachid>230896</attachid>
    <who name="Shivakumar J M">shiva.jm</who>
    <bug_when>2014-05-06 04:01:34 -0700</bug_when>
    <thetext>Created attachment 230896
Patch

Fixed unused parameter by omitting the parameter name, updated the patch with review comments</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1007276</commentid>
    <comment_count>7</comment_count>
      <attachid>230896</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2014-05-07 03:40:17 -0700</bug_when>
    <thetext>Comment on attachment 230896
Patch

Clearing flags on attachment: 230896

Committed r168419: &lt;http://trac.webkit.org/changeset/168419&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1007277</commentid>
    <comment_count>8</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2014-05-07 03:40:22 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1009458</commentid>
    <comment_count>9</comment_count>
    <who name="Shivakumar J M">shiva.jm</who>
    <bug_when>2014-05-14 22:52:27 -0700</bug_when>
    <thetext>Bug is fixed, tested in version 168886.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1013278</commentid>
    <comment_count>10</comment_count>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2014-06-04 02:53:58 -0700</bug_when>
    <thetext>Please don&apos;t change resolved/fixed state of the bugs.
See https://bugs.webkit.org/show_bug.cgi?id=133062#c7 for details.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>230888</attachid>
            <date>2014-05-05 22:27:30 -0700</date>
            <delta_ts>2014-05-06 02:46:33 -0700</delta_ts>
            <desc>Fix unused parameter by using UNUSED_PARAM macro</desc>
            <filename>Patch_131969.txt</filename>
            <type>text/plain</type>
            <size>3451</size>
            <attacher name="Shivakumar J M">shiva.jm</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi
S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2ODM0OCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n
ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE0LTA1LTA1ICBTaGl2YWt1
bWFyIEpNICA8c2hpdmEuam1Ac2Ftc3VuZy5jb20+CisKKyAgICAgICAgQ2xlYW51cCB0aGUgYnVp
bGQgZnJvbSB1bnVzZWQgcGFyYW1ldGVyIGluIFVJUHJvY2VzcyBNb2R1bGUKKyAgICAgICAgaHR0
cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMTk2OQorCisgICAgICAgIFJl
dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeCB1bnVzZWQgcGFyYW1ldGVy
IGJ5IHVzaW5nIFVOVVNFRF9QQVJBTSBtYWNybworCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9D
L1dLUGFnZS5jcHA6CisgICAgICAgIChXS1BhZ2VTZXRQYWdlRmluZENsaWVudCk6CisgICAgICAg
ICogVUlQcm9jZXNzL1dlYkZpbmRDbGllbnQuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJGaW5k
Q2xpZW50OjpkaWRGaW5kU3RyaW5nKToKKwogMjAxNC0wNS0wNSAgSmVyZW15IEpvbmVzICA8amVy
ZW15akBhcHBsZS5jb20+CiAKICAgICAgICAgSW1wbGVtZW50IHNjYW4gYmFja3dhcmQgYW5kIGZv
cndhcmQgaW4gdmlkZW8gZnVsbHNjcmVlbi4KSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz
cy9XZWJGaW5kQ2xpZW50LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nl
c3MvV2ViRmluZENsaWVudC5jcHAJKHJldmlzaW9uIDE2ODM0OCkKKysrIFNvdXJjZS9XZWJLaXQy
L1VJUHJvY2Vzcy9XZWJGaW5kQ2xpZW50LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzIsNiArMzIs
OCBAQCBuYW1lc3BhY2UgV2ViS2l0IHsKIAogdm9pZCBXZWJGaW5kQ2xpZW50OjpkaWRGaW5kU3Ry
aW5nKFdlYlBhZ2VQcm94eSogcGFnZSwgY29uc3QgU3RyaW5nJiBzdHJpbmcsIHVpbnQzMl90IG1h
dGNoQ291bnQsIGludDMyX3QgbWF0Y2hJbmRleCkKIHsKKyAgICBVTlVTRURfUEFSQU0obWF0Y2hJ
bmRleCk7CisKICAgICBpZiAoIW1fY2xpZW50LmRpZEZpbmRTdHJpbmcpCiAgICAgICAgIHJldHVy
bjsKIApJbmRleDogU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9DL1dLUGFnZS5jcHAKPT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9DL1dLUGFnZS5jcHAJKHJl
dmlzaW9uIDE2ODM0OCkKKysrIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQy9XS1BhZ2Uu
Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC03MDQsNiArNzA0LDggQEAgdm9pZCBXS1BhZ2VTZXRQYWdl
RmluZENsaWVudChXS1BhZ2VSZWYgcAogICAgIHByaXZhdGU6CiAgICAgICAgIHZpcnR1YWwgdm9p
ZCBkaWRGaW5kU3RyaW5nKFdlYlBhZ2VQcm94eSogcGFnZSwgY29uc3QgU3RyaW5nJiBzdHJpbmcs
IHVpbnQzMl90IG1hdGNoQ291bnQsIGludDMyX3QgbWF0Y2hJbmRleCkgb3ZlcnJpZGUKICAgICAg
ICAgeworICAgICAgICAgICAgVU5VU0VEX1BBUkFNKG1hdGNoSW5kZXgpOworCiAgICAgICAgICAg
ICBpZiAoIW1fY2xpZW50LmRpZEZpbmRTdHJpbmcpCiAgICAgICAgICAgICAgICAgcmV0dXJuOwog
ICAgICAgICAgICAgCkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g
TGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAxNjgzNDgpCisrKyBMYXlvdXRUZXN0cy9D
aGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMiBAQAorMjAxNC0wNS0wNSAgU2hp
dmFrdW1hciBKTSAgPHNoaXZhLmptQHNhbXN1bmcuY29tPgorCisgICAgICAgIE5lZWQgYSBzaG9y
dCBkZXNjcmlwdGlvbiAoT09QUyEpLgorICAgICAgICBOZWVkIHRoZSBidWcgVVJMIChPT1BTISku
CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0
Zm9ybS9lZmwvaHR0cC90ZXN0cy9taXNjL3Nsb3ctbG9hZGluZy1tYXNrLWV4cGVjdGVkLnR4dDoK
KwogMjAxNC0wNS0wNSAgQW5kcmVhcyBLbGluZyAgPGFrbGluZ0BhcHBsZS5jb20+CiAKICAgICAg
ICAgTWFyayBodHRwL3Rlc3RzL21lZGlhL2hscy92aWRlby1jb250cm9scy1saXZlLXN0cmVhbS5o
dG1sIGFzIFdvbnRGaXggb24gTW91bnRhaW4gTGlvbi4KSW5kZXg6IExheW91dFRlc3RzL3BsYXRm
b3JtL2VmbC9odHRwL3Rlc3RzL21pc2Mvc2xvdy1sb2FkaW5nLW1hc2stZXhwZWN0ZWQudHh0Cj09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT0KLS0tIExheW91dFRlc3RzL3BsYXRmb3JtL2VmbC9odHRwL3Rlc3RzL21pc2Mvc2xv
dy1sb2FkaW5nLW1hc2stZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAxNjgzNDgpCisrKyBMYXlvdXRU
ZXN0cy9wbGF0Zm9ybS9lZmwvaHR0cC90ZXN0cy9taXNjL3Nsb3ctbG9hZGluZy1tYXNrLWV4cGVj
dGVkLnR4dAkod29ya2luZyBjb3B5KQpAQCAtMCwwICsxLDEzIEBACitsYXllciBhdCAoMCwwKSBz
aXplIDgwMHg2MDAKKyAgUmVuZGVyVmlldyBhdCAoMCwwKSBzaXplIDgwMHg2MDAKK2xheWVyIGF0
ICgwLDApIHNpemUgODAweDQ4OAorICBSZW5kZXJCbG9jayB7SFRNTH0gYXQgKDAsMCkgc2l6ZSA4
MDB4NDg4CisgICAgUmVuZGVyQm9keSB7Qk9EWX0gYXQgKDgsMTYpIHNpemUgNzg0eDQ2MgorICAg
ICAgUmVuZGVyQmxvY2sge1B9IGF0ICgwLDApIHNpemUgNzg0eDM2CisgICAgICAgIFJlbmRlclRl
eHQgeyN0ZXh0fSBhdCAoMCwwKSBzaXplIDczOXgzNQorICAgICAgICAgIHRleHQgcnVuIGF0ICgw
LDApIHdpZHRoIDczOTogIlRlc3RzIHRoYXQgbWFza2VkIGVsZW1lbnRzIGRvIG5vdCByZW5kZXIg
dW50aWwgdGhlaXIgbWFzayBpbWFnZXMgYXJlIGZ1bGx5IGxvYWRlZC4gWW91IHNob3VsZCBub3Qg
c2VlIGFueSBibHVlIGJveGVzIgorICAgICAgICAgIHRleHQgcnVuIGF0ICgwLDE4KSB3aWR0aCA0
MzogImJlbG93LiIKK2xheWVyIGF0ICgxOCw2OCkgc2l6ZSAyMDB4MjAwCisgIFJlbmRlckJsb2Nr
IHtESVZ9IGF0ICgxMCw1Mikgc2l6ZSAyMDB4MjAwIFtiZ2NvbG9yPSMwMDAwRkZdCitsYXllciBh
dCAoMTgsMjc4KSBzaXplIDIwMHgyMDAKKyAgUmVuZGVyQmxvY2sge0RJVn0gYXQgKDEwLDI2Mikg
c2l6ZSAyMDB4MjAwIFtiZ2NvbG9yPSMwMDAwRkZdCg==
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>230895</attachid>
            <date>2014-05-06 02:46:33 -0700</date>
            <delta_ts>2014-05-06 04:01:34 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-131969.patch</filename>
            <type>text/plain</type>
            <size>1839</size>
            <attacher name="Shivakumar J M">shiva.jm</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi
S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2ODM1MikKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n
ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE0LTA1LTA2ICBTaGl2YWt1
bWFyIEpNICA8c2hpdmEuam1Ac2Ftc3VuZy5jb20+CisKKyAgICAgICAgQ2xlYW51cCB0aGUgYnVp
bGQgZnJvbSB1bnVzZWQgcGFyYW1ldGVyIGluIFVJUHJvY2VzcyBNb2R1bGUKKyAgICAgICAgaHR0
cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMTk2OQorCisgICAgICAgIFJl
dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeGVkIHVudXNlZCBwYXJhbWV0
ZXIgYnkgdXNpbmcgVU5VU0VEX1BBUkFNIG1hY3JvCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJ
L0MvV0tQYWdlLmNwcDoKKyAgICAgICAgKFdLUGFnZVNldFBhZ2VGaW5kQ2xpZW50KToKKyAgICAg
ICAgKiBVSVByb2Nlc3MvV2ViRmluZENsaWVudC5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYkZp
bmRDbGllbnQ6OmRpZEZpbmRTdHJpbmcpOgorCiAyMDE0LTA1LTA1ICBKZXJlbXkgSm9uZXMgIDxq
ZXJlbXlqQGFwcGxlLmNvbT4KIAogICAgICAgICBJbXBsZW1lbnQgc2NhbiBiYWNrd2FyZCBhbmQg
Zm9yd2FyZCBpbiB2aWRlbyBmdWxsc2NyZWVuLgpJbmRleDogU291cmNlL1dlYktpdDIvVUlQcm9j
ZXNzL1dlYkZpbmRDbGllbnQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1VJUHJv
Y2Vzcy9XZWJGaW5kQ2xpZW50LmNwcAkocmV2aXNpb24gMTY4MzUyKQorKysgU291cmNlL1dlYktp
dDIvVUlQcm9jZXNzL1dlYkZpbmRDbGllbnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zMiw2ICsz
Miw4IEBAIG5hbWVzcGFjZSBXZWJLaXQgewogCiB2b2lkIFdlYkZpbmRDbGllbnQ6OmRpZEZpbmRT
dHJpbmcoV2ViUGFnZVByb3h5KiBwYWdlLCBjb25zdCBTdHJpbmcmIHN0cmluZywgdWludDMyX3Qg
bWF0Y2hDb3VudCwgaW50MzJfdCBtYXRjaEluZGV4KQogeworICAgIFVOVVNFRF9QQVJBTShtYXRj
aEluZGV4KTsKKwogICAgIGlmICghbV9jbGllbnQuZGlkRmluZFN0cmluZykKICAgICAgICAgcmV0
dXJuOwogCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0MvV0tQYWdlLmNwcAo9
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0MvV0tQYWdlLmNwcAko
cmV2aXNpb24gMTY4MzUyKQorKysgU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9DL1dLUGFn
ZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTcwNCw2ICs3MDQsOCBAQCB2b2lkIFdLUGFnZVNldFBh
Z2VGaW5kQ2xpZW50KFdLUGFnZVJlZiBwCiAgICAgcHJpdmF0ZToKICAgICAgICAgdmlydHVhbCB2
b2lkIGRpZEZpbmRTdHJpbmcoV2ViUGFnZVByb3h5KiBwYWdlLCBjb25zdCBTdHJpbmcmIHN0cmlu
ZywgdWludDMyX3QgbWF0Y2hDb3VudCwgaW50MzJfdCBtYXRjaEluZGV4KSBvdmVycmlkZQogICAg
ICAgICB7CisgICAgICAgICAgICBVTlVTRURfUEFSQU0obWF0Y2hJbmRleCk7CisKICAgICAgICAg
ICAgIGlmICghbV9jbGllbnQuZGlkRmluZFN0cmluZykKICAgICAgICAgICAgICAgICByZXR1cm47
CiAgICAgICAgICAgICAK
</data>
<flag name="review"
          id="255284"
          type_id="1"
          status="-"
          setter="ossy"
    />
    <flag name="commit-queue"
          id="255285"
          type_id="3"
          status="-"
          setter="ossy"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>230896</attachid>
            <date>2014-05-06 04:01:34 -0700</date>
            <delta_ts>2014-05-07 03:40:17 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-131969-review.patch</filename>
            <type>text/plain</type>
            <size>1992</size>
            <attacher name="Shivakumar J M">shiva.jm</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi
S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2ODM1MikKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n
ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE0LTA1LTA2ICBTaGl2YWt1
bWFyIEpNICA8c2hpdmEuam1Ac2Ftc3VuZy5jb20+CisKKyAgICAgICAgQ2xlYW51cCB0aGUgYnVp
bGQgZnJvbSB1bnVzZWQgcGFyYW1ldGVyIGluIFVJUHJvY2VzcyBNb2R1bGUKKyAgICAgICAgaHR0
cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMTk2OQorCisgICAgICAgIFJl
dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeGVkIHVudXNlZCBwYXJhbWV0
ZXIgYnkgb21pdHRpbmcgdGhlIHBhcmFtZXRlciBuYW1lCisKKyAgICAgICAgKiBVSVByb2Nlc3Mv
QVBJL0MvV0tQYWdlLmNwcDoKKyAgICAgICAgKFdLUGFnZVNldFBhZ2VGaW5kQ2xpZW50KToKKyAg
ICAgICAgKiBVSVByb2Nlc3MvV2ViRmluZENsaWVudC5jcHA6CisgICAgICAgIChXZWJLaXQ6Oldl
YkZpbmRDbGllbnQ6OmRpZEZpbmRTdHJpbmcpOgorCiAyMDE0LTA1LTA1ICBKZXJlbXkgSm9uZXMg
IDxqZXJlbXlqQGFwcGxlLmNvbT4KIAogICAgICAgICBJbXBsZW1lbnQgc2NhbiBiYWNrd2FyZCBh
bmQgZm9yd2FyZCBpbiB2aWRlbyBmdWxsc2NyZWVuLgpJbmRleDogU291cmNlL1dlYktpdDIvVUlQ
cm9jZXNzL1dlYkZpbmRDbGllbnQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1VJ
UHJvY2Vzcy9XZWJGaW5kQ2xpZW50LmNwcAkocmV2aXNpb24gMTY4MzUyKQorKysgU291cmNlL1dl
YktpdDIvVUlQcm9jZXNzL1dlYkZpbmRDbGllbnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zMCw3
ICszMCw3IEBACiAKIG5hbWVzcGFjZSBXZWJLaXQgewogCi12b2lkIFdlYkZpbmRDbGllbnQ6OmRp
ZEZpbmRTdHJpbmcoV2ViUGFnZVByb3h5KiBwYWdlLCBjb25zdCBTdHJpbmcmIHN0cmluZywgdWlu
dDMyX3QgbWF0Y2hDb3VudCwgaW50MzJfdCBtYXRjaEluZGV4KQordm9pZCBXZWJGaW5kQ2xpZW50
OjpkaWRGaW5kU3RyaW5nKFdlYlBhZ2VQcm94eSogcGFnZSwgY29uc3QgU3RyaW5nJiBzdHJpbmcs
IHVpbnQzMl90IG1hdGNoQ291bnQsIGludDMyX3QpCiB7CiAgICAgaWYgKCFtX2NsaWVudC5kaWRG
aW5kU3RyaW5nKQogICAgICAgICByZXR1cm47CkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nl
c3MvQVBJL0MvV0tQYWdlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nl
c3MvQVBJL0MvV0tQYWdlLmNwcAkocmV2aXNpb24gMTY4MzUyKQorKysgU291cmNlL1dlYktpdDIv
VUlQcm9jZXNzL0FQSS9DL1dLUGFnZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTcwMiw3ICs3MDIs
NyBAQCB2b2lkIFdLUGFnZVNldFBhZ2VGaW5kQ2xpZW50KFdLUGFnZVJlZiBwCiAgICAgICAgIH0K
IAogICAgIHByaXZhdGU6Ci0gICAgICAgIHZpcnR1YWwgdm9pZCBkaWRGaW5kU3RyaW5nKFdlYlBh
Z2VQcm94eSogcGFnZSwgY29uc3QgU3RyaW5nJiBzdHJpbmcsIHVpbnQzMl90IG1hdGNoQ291bnQs
IGludDMyX3QgbWF0Y2hJbmRleCkgb3ZlcnJpZGUKKyAgICAgICAgdmlydHVhbCB2b2lkIGRpZEZp
bmRTdHJpbmcoV2ViUGFnZVByb3h5KiBwYWdlLCBjb25zdCBTdHJpbmcmIHN0cmluZywgdWludDMy
X3QgbWF0Y2hDb3VudCwgaW50MzJfdCkgb3ZlcnJpZGUKICAgICAgICAgewogICAgICAgICAgICAg
aWYgKCFtX2NsaWVudC5kaWRGaW5kU3RyaW5nKQogICAgICAgICAgICAgICAgIHJldHVybjsK
</data>

          </attachment>
      

    </bug>

</bugzilla>