131959 2014-04-21 16:46:01 -0700 [Mac] Difficulty gesture scrolling vertically with trackpad after scrolling horizontally 2014-04-21 20:58:57 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 bfulgham bfulgham bfulgham thorton oldest_to_newest 1002713 0 bfulgham 2014-04-21 16:46:01 -0700 Sites with specific markup could encounter a problem where performing a horizontal scroll inside a div contained within a larger scrolling overflow could prevent subsequent vertical mouse wheel gestures from bubbling up to the enclosing div. This was caused by the "scrolledToTop" or "scrolledToBottom" methods to improperly return false when the div was actually at the maximum scroll. I'm investigating why the result was sometimes incorrect (see Bug 131958) separately, but we can sidestep the issue by recognizing that scrollable areas that have a style encoded with "overflow-y = hidden" should always report that they are at the maximum scroll position. 1002715 1 229840 bfulgham 2014-04-21 16:52:57 -0700 Created attachment 229840 Patch 1002718 2 229840 simon.fraser 2014-04-21 17:03:03 -0700 Comment on attachment 229840 Patch Can this have a testcase? 1002719 3 bfulgham 2014-04-21 17:05:30 -0700 Committed r167634: <http://trac.webkit.org/changeset/167634> 1002720 4 bfulgham 2014-04-21 17:06:04 -0700 (In reply to comment #2) > (From update of attachment 229840 [details]) > Can this have a testcase? A new testcase will be added as part of Bug 131958. 1002798 5 bfulgham 2014-04-21 20:58:57 -0700 <rdar://problem/16654523> 229840 2014-04-21 16:52:57 -0700 2014-04-21 17:03:02 -0700 Patch bug-131959-20140421165236.patch text/plain 3121 bfulgham SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2NzYzMikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDE0LTA0LTIxICBCcmVudCBG dWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIFtNYWNdIERpZmZpY3VsdHkg Z2VzdHVyZSBzY3JvbGxpbmcgdmVydGljYWxseSB3aXRoIHRyYWNrcGFkIGFmdGVyIHNjcm9sbGlu ZyBob3Jpem9udGFsbHkgCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xMzE5NTkKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzE2NjU0NTIzPgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGFnZS9tYWMvRXZl bnRIYW5kbGVyTWFjLm1tOgorICAgICAgICAoV2ViQ29yZTo6ZGVsdGFJc1ByZWRvbWluYW50bHlW ZXJ0aWNhbCk6IEFkZGVkLgorICAgICAgICAoV2ViQ29yZTo6c2Nyb2xsZWRUb0VkZ2VJbkRvbWlu YW50RGlyZWN0aW9uKTogT25seSBjb25zaWRlciBjdXJyZW50IG1vdXNlIHdoZWVsIGV2ZW50LiBX ZSBkb24ndCBjYXJlIGFib3V0CisgICAgICAgIG92ZXJhbGwgaGlzdG9yeSB3aGVuIGRlY2lkaW5n IGlmIHdlIGFyZSBidW1waW5nIGFnYWluc3QgdGhlIGVkZ2Ugb2YgYSBzY3JvbGxhYmxlIHJlZ2lv bi4gU2hvcnQtY2lyY3VpdCBpZgorICAgICAgICB0aGUgZWxlbWVudCBzdHlsZSBpbmRpY2F0ZXMg dGhhdCBvdmVyZmxvdyBpcyBoaWRkZW4sIHNpbmNlIHRoaXMgbWVhbnMgdGhlcmUgaXMgbm8gc2Ny b2xsIHBvc3NpYmxlIGluIHRoYXQKKyAgICAgICAgZGlyZWN0aW9uLgorICAgICAgICAoV2ViQ29y ZTo6RXZlbnRIYW5kbGVyOjpwbGF0Zm9ybVByZXBhcmVGb3JXaGVlbEV2ZW50cyk6IFVwZGF0ZSBm b3IgbmV3IHNpZ25hdHVyZS4KKwogMjAxNC0wNC0yMSAgRXJpYyBDYXJsc29uICA8ZXJpYy5jYXJs c29uQGFwcGxlLmNvbT4KIAogICAgICAgICBbTWFjXSBpbXBsZW1lbnQgV2ViS2l0RGF0YUN1ZQpJ bmRleDogU291cmNlL1dlYkNvcmUvcGFnZS9tYWMvRXZlbnRIYW5kbGVyTWFjLm1tCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BhZ2UvbWFjL0V2ZW50SGFuZGxlck1hYy5tbQkocmV2aXNp b24gMTY3NTkyKQorKysgU291cmNlL1dlYkNvcmUvcGFnZS9tYWMvRXZlbnRIYW5kbGVyTWFjLm1t CSh3b3JraW5nIGNvcHkpCkBAIC03NTIsMTUgKzc1MiwzMSBAQCBzdGF0aWMgQ29udGFpbmVyTm9k ZSogZmluZEVuY2xvc2luZ1Njcm9sCiAgICAgcmV0dXJuIG51bGxwdHI7CiB9CiAKLXN0YXRpYyBi b29sIHNjcm9sbGVkVG9FZGdlSW5Eb21pbmFudERpcmVjdGlvbihjb25zdCBTY3JvbGxhYmxlQXJl YSYgYXJlYSwgRG9taW5hbnRTY3JvbGxHZXN0dXJlRGlyZWN0aW9uIGRpcmVjdGlvbiwgZmxvYXQg ZGVsdGFYLCBmbG9hdCBkZWx0YVkpCitzdGF0aWMgYm9vbCBkZWx0YUlzUHJlZG9taW5hbnRseVZl cnRpY2FsKGZsb2F0IGRlbHRhWCwgZmxvYXQgZGVsdGFZKQogewotICAgIGlmIChEb21pbmFudFNj cm9sbEdlc3R1cmVEaXJlY3Rpb246Okhvcml6b250YWwgPT0gZGlyZWN0aW9uICYmIGRlbHRhWCkg eworICAgIHJldHVybiBzdGQ6OmFicyhkZWx0YVkpID4gc3RkOjphYnMoZGVsdGFYKTsKK30KKyAg ICAKK3N0YXRpYyBib29sIHNjcm9sbGVkVG9FZGdlSW5Eb21pbmFudERpcmVjdGlvbihjb25zdCBD b250YWluZXJOb2RlJiBjb250YWluZXIsIGNvbnN0IFNjcm9sbGFibGVBcmVhJiBhcmVhLCBmbG9h dCBkZWx0YVgsIGZsb2F0IGRlbHRhWSkKK3sKKyAgICBpZiAoIWNvbnRhaW5lci5yZW5kZXJlcigp KQorICAgICAgICByZXR1cm4gdHJ1ZTsKKworICAgIGNvbnN0IFJlbmRlclN0eWxlJiBzdHlsZSA9 IGNvbnRhaW5lci5yZW5kZXJlcigpLT5zdHlsZSgpOworCisgICAgaWYgKCFkZWx0YUlzUHJlZG9t aW5hbnRseVZlcnRpY2FsKGRlbHRhWCwgZGVsdGFZKSAmJiBkZWx0YVgpIHsKKyAgICAgICAgaWYg KHN0eWxlLm92ZXJmbG93WCgpID09IE9ISURERU4pCisgICAgICAgICAgICByZXR1cm4gdHJ1ZTsK KwogICAgICAgICBpZiAoZGVsdGFYIDwgMCkKICAgICAgICAgICAgIHJldHVybiBhcmVhLnNjcm9s bGVkVG9SaWdodCgpOwogICAgICAgICAKICAgICAgICAgcmV0dXJuIGFyZWEuc2Nyb2xsZWRUb0xl ZnQoKTsKICAgICB9Ci0gICAgCisKKyAgICBpZiAoc3R5bGUub3ZlcmZsb3dZKCkgPT0gT0hJRERF TikKKyAgICAgICAgcmV0dXJuIHRydWU7CisKICAgICBpZiAoZGVsdGFZIDwgMCkKICAgICAgICAg cmV0dXJuIGFyZWEuc2Nyb2xsZWRUb0JvdHRvbSgpOwogICAgIApAQCAtNzkwLDcgKzgwNiw3IEBA IHZvaWQgRXZlbnRIYW5kbGVyOjpwbGF0Zm9ybVByZXBhcmVGb3JXaGUKICAgICAKICAgICBpZiAo d2hlZWxFdmVudC5zaG91bGRDb25zaWRlckxhdGNoaW5nKCkpIHsKICAgICAgICAgaWYgKHNjcm9s bGFibGVBcmVhKQotICAgICAgICAgICAgbV9zdGFydGVkR2VzdHVyZUF0U2Nyb2xsTGltaXQgPSBz Y3JvbGxlZFRvRWRnZUluRG9taW5hbnREaXJlY3Rpb24oKnNjcm9sbGFibGVBcmVhLCBtX3JlY2Vu dFdoZWVsRXZlbnREZWx0YVRyYWNrZXItPmRvbWluYW50U2Nyb2xsR2VzdHVyZURpcmVjdGlvbigp LCB3aGVlbEV2ZW50LmRlbHRhWCgpLCB3aGVlbEV2ZW50LmRlbHRhWSgpKTsKKyAgICAgICAgICAg IG1fc3RhcnRlZEdlc3R1cmVBdFNjcm9sbExpbWl0ID0gc2Nyb2xsZWRUb0VkZ2VJbkRvbWluYW50 RGlyZWN0aW9uKCpzY3JvbGxhYmxlQ29udGFpbmVyLCAqc2Nyb2xsYWJsZUFyZWEsIHdoZWVsRXZl bnQuZGVsdGFYKCksIHdoZWVsRXZlbnQuZGVsdGFZKCkpOwogICAgICAgICBlbHNlCiAgICAgICAg ICAgICBtX3N0YXJ0ZWRHZXN0dXJlQXRTY3JvbGxMaW1pdCA9IGZhbHNlOwogICAgICAgICBtX2xh dGNoZWRXaGVlbEV2ZW50RWxlbWVudCA9IHdoZWVsRXZlbnRUYXJnZXQ7Cg==