131955 2014-04-21 14:49:30 -0700 topContentInset does not play well with fullscreen elements 2014-04-21 15:23:25 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 bdakin webkit-unassigned bdakin jer.noble sam simon.fraser thorton oldest_to_newest 1002695 0 bdakin 2014-04-21 14:49:30 -0700 If you take an element (such as a <video>) fullscreen when you have a topContentInset set, there will be an inset-sized gap at the top of the fullscreen video. <rdar://problem/16651925> 1002698 1 229838 bdakin 2014-04-21 14:57:19 -0700 Created attachment 229838 Patch 1002699 2 bdakin 2014-04-21 15:23:25 -0700 http://trac.webkit.org/changeset/167630 229838 2014-04-21 14:57:19 -0700 2014-04-21 15:02:41 -0700 Patch for-review.txt text/plain 5937 bdakin SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2NzYyOSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI0IEBACisyMDE0LTA0LTIxICBCZXRoIERh a2luICA8YmRha2luQGFwcGxlLmNvbT4KKworICAgICAgICB0b3BDb250ZW50SW5zZXQgZG9lcyBu b3QgcGxheSB3ZWxsIHdpdGggZnVsbHNjcmVlbiBlbGVtZW50cworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMxOTU1CisgICAgICAgIC1hbmQgY29ycmVz cG9uZGluZy0KKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzE2NjUxOTI1PgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENhbGxpbmcgc2V0TmVlZHNMYXlv dXQoKSBpcyBub3Qgc3VmZmljaWVudCB3aGVuIHRoZSB0b3BDb250ZW50SW5zZXQgaGFzIGNoYW5n ZWQgCisgICAgICAgIGR5bmFtaWNhbGx5LiBXZSBuZWVkIHRvIHBlcmZvcm0gdGhlIGxheW91dCBy aWdodCBhd2F5IGFuZCB1cGRhdGUgdGhlIHNjcm9sbGJhcnMuIAorICAgICAgICBUaGlzIHdvcmtz IGNvbXBsZXRlbHkgd2hlbiB0aGUgaW5zZXQgY2hhbmdlcyBkdWUgdG8gZW50ZXJpbmcvZXhpdGlu ZyBmdWxsc2NyZWVuLCAKKyAgICAgICAgYnV0IEkgbGVmdCBhIEZJWE1FIGJlaGluZCBiZWNhdXNl IGl0IGlzIHBvc3NpYmxlIHRvIGNoYW5nZSB0aGUgaW5zZXQgZHluYW1pY2FsbHkgCisgICAgICAg IGp1c3QgdGhyb3VnaCB0aGUgV0syIEFQSSBhbmQgZW5kIHVwIGluIGEgc2l0dWF0aW9uIHdoZXJl IGV2ZXJ5dGhpbmcgbG9va3MgcmlnaHQgCisgICAgICAgIGV4Y2VwdCBmb3IgdGhlIHNjcm9sbGJh cnMuIAorICAgICAgICAqIHBhZ2UvRnJhbWVWaWV3LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkZy YW1lVmlldzo6dG9wQ29udGVudEluc2V0RGlkQ2hhbmdlKToKKyAgICAgICAgKiBwYWdlL0ZyYW1l Vmlldy5oOgorICAgICAgICAqIHBhZ2UvUGFnZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpQYWdl OjpzZXRUb3BDb250ZW50SW5zZXQpOgorCiAyMDE0LTA0LTE4ICBKb24gSG9uZXljdXR0ICA8amhv bmV5Y3V0dEBhcHBsZS5jb20+CiAKICAgICAgICAgRW1wdHkgUmVuZGVySW5saW5lIG9iamVjdHMg c2hvdWxkIG5vdCBiZSBsaW5lIGJyZWFrIG9iamVjdHMuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9w YWdlL0ZyYW1lVmlldy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGFnZS9GcmFt ZVZpZXcuY3BwCShyZXZpc2lvbiAxNjc2MDIpCisrKyBTb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1l Vmlldy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTk0OSw2ICs5NDksMTggQEAgZmxvYXQgRnJhbWVW aWV3Ojp0b3BDb250ZW50SW5zZXQoKSBjb25zdAogICAgIHJldHVybiBwYWdlID8gcGFnZS0+dG9w Q29udGVudEluc2V0KCkgOiAwOwogfQogICAgIAordm9pZCBGcmFtZVZpZXc6OnRvcENvbnRlbnRJ bnNldERpZENoYW5nZSgpCit7CisgICAgUmVuZGVyVmlldyogcmVuZGVyVmlldyA9IHRoaXMtPnJl bmRlclZpZXcoKTsKKyAgICBpZiAoIXJlbmRlclZpZXcpCisgICAgICAgIHJldHVybjsKKyAgICAK KyAgICAvLyBGSVhNRTogPHJkYXI6Ly9wcm9ibGVtLzE2NjQyMjMyPiBUaGlzIGNhbGwgdG8gdXBk YXRlU2Nyb2xsYmFycygpIGlzIG5vdCBhY3R1YWxseSBzdWZmaWNpZW50IHRvIGZpeAorICAgIC8v IHRoZSBzY3JvbGxiYXJzIGlmIHRoZSBjb250ZW50SW5zZXQgY2hhbmdlcyBkeW5hbWljYWxseS4g CisgICAgbGF5b3V0KCk7CisgICAgdXBkYXRlU2Nyb2xsYmFycyhzY3JvbGxPZmZzZXQoKSk7Cit9 CisgICAgCiBib29sIEZyYW1lVmlldzo6aGFzQ29tcG9zaXRlZENvbnRlbnQoKSBjb25zdAogewog ICAgIGlmIChSZW5kZXJWaWV3KiByZW5kZXJWaWV3ID0gdGhpcy0+cmVuZGVyVmlldygpKQpJbmRl eDogU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuaAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5oCShyZXZpc2lvbiAxNjc2MDIpCisrKyBTb3VyY2UvV2Vi Q29yZS9wYWdlL0ZyYW1lVmlldy5oCSh3b3JraW5nIGNvcHkpCkBAIC00NTEsNiArNDUxLDcgQEAg cHVibGljOgogICAgIHZvaWQgc2V0Rm9vdGVySGVpZ2h0KGludCk7CiAKICAgICB2aXJ0dWFsIGZs b2F0IHRvcENvbnRlbnRJbnNldCgpIGNvbnN0IG92ZXJyaWRlOworICAgIHZvaWQgdG9wQ29udGVu dEluc2V0RGlkQ2hhbmdlKCk7CiAKICAgICB2aXJ0dWFsIHZvaWQgd2lsbFN0YXJ0TGl2ZVJlc2l6 ZSgpIG92ZXJyaWRlOwogICAgIHZpcnR1YWwgdm9pZCB3aWxsRW5kTGl2ZVJlc2l6ZSgpIG92ZXJy aWRlOwpJbmRleDogU291cmNlL1dlYkNvcmUvcGFnZS9QYWdlLmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV2ViQ29yZS9wYWdlL1BhZ2UuY3BwCShyZXZpc2lvbiAxNjc2MDIpCisrKyBTb3VyY2Uv V2ViQ29yZS9wYWdlL1BhZ2UuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC03NzksOCArNzc5LDkgQEAg dm9pZCBQYWdlOjpzZXRUb3BDb250ZW50SW5zZXQoZmxvYXQgY29udAogICAgICAgICByZXR1cm47 CiAgICAgCiAgICAgbV90b3BDb250ZW50SW5zZXQgPSBjb250ZW50SW5zZXQ7Ci0gICAgaWYgKFJl bmRlclZpZXcqIHJlbmRlclZpZXcgPSBtYWluRnJhbWUoKS5jb250ZW50UmVuZGVyZXIoKSkKLSAg ICAgICAgcmVuZGVyVmlldy0+c2V0TmVlZHNMYXlvdXQoKTsKKyAgICAKKyAgICBpZiAoRnJhbWVW aWV3KiB2aWV3ID0gbWFpbkZyYW1lKCkudmlldygpKQorICAgICAgICB2aWV3LT50b3BDb250ZW50 SW5zZXREaWRDaGFuZ2UoKTsKIH0KICAgICAKIHZvaWQgUGFnZTo6c2V0U2hvdWxkU3VwcHJlc3NT Y3JvbGxiYXJBbmltYXRpb25zKGJvb2wgc3VwcHJlc3NBbmltYXRpb25zKQpJbmRleDogU291cmNl L1dlYktpdDIvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxv ZwkocmV2aXNpb24gMTY3NjI5KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCSh3b3JraW5n IGNvcHkpCkBAIC0xLDMgKzEsMjQgQEAKKzIwMTQtMDQtMjEgIEJldGggRGFraW4gIDxiZGFraW5A YXBwbGUuY29tPgorCisgICAgICAgIHRvcENvbnRlbnRJbnNldCBkb2VzIG5vdCBwbGF5IHdlbGwg d2l0aCBmdWxsc2NyZWVuIGVsZW1lbnRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xMzE5NTUKKyAgICAgICAgLWFuZCBjb3JyZXNwb25kaW5nLQorICAg ICAgICA8cmRhcjovL3Byb2JsZW0vMTY2NTE5MjU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgSWYgeW91IHRha2UgYW4gZWxlbWVudCAoc3VjaCBhcyBh IDx2aWRlbz4pIGZ1bGxzY3JlZW4gd2hlbiB5b3UgaGF2ZSBhIAorICAgICAgICB0b3BDb250ZW50 SW5zZXQgc2V0LCB0aGVyZSB3aWxsIGJlIGFuIGluc2V0LXNpemVkIGdhcCBhdCB0aGUgdG9wIG9m IHRoZSBmdWxsc2NyZWVuIAorICAgICAgICB2aWRlby4KKworICAgICAgICBTYXZlIGFuZCByZXN0 b3JlIHRoZSB0b3BDb250ZW50SW5zZXQgd2hlbmV2ZXIgdGhlIHNjcm9sbCBwb3NpdGlvbiBpcyBz YXZlZCBhbmQgCisgICAgICAgIHJlc3RvcmVkLgorICAgICAgICAqIFdlYlByb2Nlc3MvRnVsbFNj cmVlbi9XZWJGdWxsU2NyZWVuTWFuYWdlci5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYkZ1bGxT Y3JlZW5NYW5hZ2VyOjpXZWJGdWxsU2NyZWVuTWFuYWdlcik6CisgICAgICAgIChXZWJLaXQ6Oldl YkZ1bGxTY3JlZW5NYW5hZ2VyOjpzYXZlU2Nyb2xsUG9zaXRpb24pOgorICAgICAgICAoV2ViS2l0 OjpXZWJGdWxsU2NyZWVuTWFuYWdlcjo6cmVzdG9yZVNjcm9sbFBvc2l0aW9uKToKKyAgICAgICAg KiBXZWJQcm9jZXNzL0Z1bGxTY3JlZW4vV2ViRnVsbFNjcmVlbk1hbmFnZXIuaDoKKwogMjAxNC0w NC0yMSAgR2F2aW4gQmFycmFjbG91Z2ggIDxiYXJhY2xvdWdoQGFwcGxlLmNvbT4KIAogICAgICAg ICBEb24ndCB1c2UgUHJvY2Vzc0Fzc2VydGlvbiBvbiBzaW11bGF0b3IKSW5kZXg6IFNvdXJjZS9X ZWJLaXQyL1dlYlByb2Nlc3MvRnVsbFNjcmVlbi9XZWJGdWxsU2NyZWVuTWFuYWdlci5jcHAKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9GdWxsU2NyZWVuL1dlYkZ1bGxT Y3JlZW5NYW5hZ2VyLmNwcAkocmV2aXNpb24gMTY3NjAyKQorKysgU291cmNlL1dlYktpdDIvV2Vi UHJvY2Vzcy9GdWxsU2NyZWVuL1dlYkZ1bGxTY3JlZW5NYW5hZ2VyLmNwcAkod29ya2luZyBjb3B5 KQpAQCAtNjUsNyArNjUsOCBAQCBQYXNzUmVmUHRyPFdlYkZ1bGxTY3JlZW5NYW5hZ2VyPiBXZWJG dWxsCiB9CiAKIFdlYkZ1bGxTY3JlZW5NYW5hZ2VyOjpXZWJGdWxsU2NyZWVuTWFuYWdlcihXZWJQ YWdlKiBwYWdlKQotICAgIDogbV9wYWdlKHBhZ2UpCisgICAgOiBtX3RvcENvbnRlbnRJbnNldCgw KQorICAgICwgbV9wYWdlKHBhZ2UpCiB7CiB9CiAgICAgCkBAIC0xNTYsMTAgKzE1NywxMyBAQCB2 b2lkIFdlYkZ1bGxTY3JlZW5NYW5hZ2VyOjpjbG9zZSgpCiB2b2lkIFdlYkZ1bGxTY3JlZW5NYW5h Z2VyOjpzYXZlU2Nyb2xsUG9zaXRpb24oKQogewogICAgIG1fc2Nyb2xsUG9zaXRpb24gPSBtX3Bh Z2UtPmNvcmVQYWdlKCktPm1haW5GcmFtZSgpLnZpZXcoKS0+c2Nyb2xsUG9zaXRpb24oKTsKKyAg ICBtX3RvcENvbnRlbnRJbnNldCA9IG1fcGFnZS0+Y29yZVBhZ2UoKS0+dG9wQ29udGVudEluc2V0 KCk7CisgICAgbV9wYWdlLT5jb3JlUGFnZSgpLT5zZXRUb3BDb250ZW50SW5zZXQoMCk7CiB9CiAK IHZvaWQgV2ViRnVsbFNjcmVlbk1hbmFnZXI6OnJlc3RvcmVTY3JvbGxQb3NpdGlvbigpCiB7Cisg ICAgbV9wYWdlLT5jb3JlUGFnZSgpLT5zZXRUb3BDb250ZW50SW5zZXQobV90b3BDb250ZW50SW5z ZXQpOwogICAgIG1fcGFnZS0+Y29yZVBhZ2UoKS0+bWFpbkZyYW1lKCkudmlldygpLT5zZXRTY3Jv bGxQb3NpdGlvbihtX3Njcm9sbFBvc2l0aW9uKTsKIH0KIApJbmRleDogU291cmNlL1dlYktpdDIv V2ViUHJvY2Vzcy9GdWxsU2NyZWVuL1dlYkZ1bGxTY3JlZW5NYW5hZ2VyLmgKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9GdWxsU2NyZWVuL1dlYkZ1bGxTY3JlZW5NYW5h Z2VyLmgJKHJldmlzaW9uIDE2NzYwMikKKysrIFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvRnVs bFNjcmVlbi9XZWJGdWxsU2NyZWVuTWFuYWdlci5oCSh3b3JraW5nIGNvcHkpCkBAIC03OSw2ICs3 OSw3IEBAIHByb3RlY3RlZDoKICAgICBXZWJDb3JlOjpJbnRSZWN0IG1faW5pdGlhbEZyYW1lOwog ICAgIFdlYkNvcmU6OkludFJlY3QgbV9maW5hbEZyYW1lOwogICAgIFdlYkNvcmU6OkludFBvaW50 IG1fc2Nyb2xsUG9zaXRpb247CisgICAgZmxvYXQgbV90b3BDb250ZW50SW5zZXQ7CiAgICAgUmVm UHRyPFdlYlBhZ2U+IG1fcGFnZTsKICAgICBSZWZQdHI8V2ViQ29yZTo6RWxlbWVudD4gbV9lbGVt ZW50OwogfTsK