131944 2014-04-21 12:28:03 -0700 Need default WKNavigationDelegate behavior 2014-04-21 14:37:16 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca oldest_to_newest 1002614 0 andersca 2014-04-21 12:28:03 -0700 Need default WKNavigationDelegate behavior 1002615 1 229821 andersca 2014-04-21 12:28:31 -0700 Created attachment 229821 Patch 1002622 2 229821 mitz 2014-04-21 12:47:29 -0700 Comment on attachment 229821 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=229821&action=review > Source/WebKit2/UIProcess/Cocoa/NavigationState.mm:229 > +#if !PLATFORM(IOS) > + if (![nsURLRequest.URL isFileURL]) > + [[NSWorkspace sharedWorkspace] openURL:nsURLRequest.URL]; > +#endif This should be #if USE(APPKIT). 1002627 3 andersca 2014-04-21 12:51:25 -0700 Committed r167611: <http://trac.webkit.org/changeset/167611> 1002684 4 ap 2014-04-21 14:37:16 -0700 Looks like this broke WKNavigation.DidFailProvisionalNavigation: http://build.webkit.org/builders/Apple%20Mavericks%20Debug%20WK1%20(Tests)/builds/4812/steps/run-api-tests/logs/stdio Note: Google Test filter = WKNavigation.DidFailProvisionalNavigation [==========] Running 1 test from 1 test case. [----------] Global test environment set-up. [----------] 1 test from WKNavigation [ RUN ] WKNavigation.DidFailProvisionalNavigation Timeout LEAK: 1 WebPage LEAK: 1 WebFrame 229821 2014-04-21 12:28:31 -0700 2014-04-21 12:47:29 -0700 Patch bug-131944-20140421122809.patch text/plain 4218 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTY3NjAzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMGY3YzkyZjc0MTQ4ZDMx NjJlZmMyMjIxZWY5Mjg3NjI1MDkxYjQyZC4uZDc1MjBiZGY5Y2Y0NzM2Zjk5NzY4NTUwOTM3MzVm ZGMwMWQzNGY3OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE5IEBACiAyMDE0LTA0LTIxICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKKyAgICAgICAgTmVlZCBkZWZhdWx0 IFdLTmF2aWdhdGlvbkRlbGVnYXRlIGJlaGF2aW9yCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzE5NDQKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzE1 OTQ5ODIyPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFBvcnQgdGhlIFdlYktpdDEgZGVmYXVsdCBkZWxlZ2F0ZSBiZWhhdmlvciBvdmVyLgorCisgICAg ICAgICogVUlQcm9jZXNzL0NvY29hL05hdmlnYXRpb25TdGF0ZS5tbToKKyAgICAgICAgKFdlYktp dDo6TmF2aWdhdGlvblN0YXRlOjpQb2xpY3lDbGllbnQ6OmRlY2lkZVBvbGljeUZvck5hdmlnYXRp b25BY3Rpb24pOgorICAgICAgICAoV2ViS2l0OjpOYXZpZ2F0aW9uU3RhdGU6OlBvbGljeUNsaWVu dDo6ZGVjaWRlUG9saWN5Rm9yUmVzcG9uc2UpOgorCisyMDE0LTA0LTIxICBBbmRlcnMgQ2FybHNz b24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CisKICAgICAgICAgQ2hlY2sgdGhlIGNvbS5hcHBsZS5z ZWN1cml0eS5uZXR3b3JrLmNsaWVudCBlbnRpdGxlbWVudCBmb3IgYWxsIHByb2Nlc3NlcwogICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMxOTQyCiAgICAg ICAgIDxyZGFyOi8vcHJvYmxlbS8xMjM1NDE4OD4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9Db2NvYS9OYXZpZ2F0aW9uU3RhdGUubW0gYi9Tb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvQ29jb2EvTmF2aWdhdGlvblN0YXRlLm1tCmluZGV4IDFiMWFjYzA5ZTNiMmRmZDMzZGVl NzE3ZDNkMmY3M2NmMzI3MjM0MTUuLmUxOTNiODkwZjQ1YmFjOGNjYzg3ZTU1YzY2NjI3MGMwNjY5 YjNiM2UgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9Db2NvYS9OYXZpZ2F0 aW9uU3RhdGUubW0KKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0NvY29hL05hdmlnYXRp b25TdGF0ZS5tbQpAQCAtMjEwLDggKzIxMCwyNCBAQCBOYXZpZ2F0aW9uU3RhdGU6OlBvbGljeUNs aWVudDo6flBvbGljeUNsaWVudCgpCiB2b2lkIE5hdmlnYXRpb25TdGF0ZTo6UG9saWN5Q2xpZW50 OjpkZWNpZGVQb2xpY3lGb3JOYXZpZ2F0aW9uQWN0aW9uKFdlYlBhZ2VQcm94eSosIFdlYkZyYW1l UHJveHkqIGRlc3RpbmF0aW9uRnJhbWUsIGNvbnN0IE5hdmlnYXRpb25BY3Rpb25EYXRhJiBuYXZp Z2F0aW9uQWN0aW9uRGF0YSwgV2ViRnJhbWVQcm94eSogc291cmNlRnJhbWUsIGNvbnN0IFdlYkNv cmU6OlJlc291cmNlUmVxdWVzdCYgb3JpZ2luYWxSZXF1ZXN0LCBjb25zdCBXZWJDb3JlOjpSZXNv dXJjZVJlcXVlc3QmIHJlcXVlc3QsIFJlZlB0cjxXZWJGcmFtZVBvbGljeUxpc3RlbmVyUHJveHk+ IGxpc3RlbmVyLCBBUEk6Ok9iamVjdCogdXNlckRhdGEpCiB7CiAgICAgaWYgKCFtX25hdmlnYXRp b25TdGF0ZS5tX25hdmlnYXRpb25EZWxlZ2F0ZU1ldGhvZHMud2ViVmlld0RlY2lkZVBvbGljeUZv ck5hdmlnYXRpb25BY3Rpb25EZWNpc2lvbkhhbmRsZXIpIHsKLSAgICAgICAgLy8gRklYTUU6IDxy ZGFyOi8vcHJvYmxlbS8xNTk0OTgyMj4gRmlndXJlIG91dCB3aGF0IHRoZSAiZGVmYXVsdCBkZWxl Z2F0ZSBiZWhhdmlvciIgc2hvdWxkIGJlIGhlcmUuCi0gICAgICAgIGxpc3RlbmVyLT51c2UoKTsK KyAgICAgICAgaWYgKCFkZXN0aW5hdGlvbkZyYW1lKSB7CisgICAgICAgICAgICBsaXN0ZW5lci0+ dXNlKCk7CisgICAgICAgICAgICByZXR1cm47CisgICAgICAgIH0KKworICAgICAgICBOU1VSTFJl cXVlc3QgKm5zVVJMUmVxdWVzdCA9IHJlcXVlc3QubnNVUkxSZXF1ZXN0KFdlYkNvcmU6OkRvTm90 VXBkYXRlSFRUUEJvZHkpOworICAgICAgICBpZiAoW05TVVJMQ29ubmVjdGlvbiBjYW5IYW5kbGVS ZXF1ZXN0Om5zVVJMUmVxdWVzdF0pIHsKKyAgICAgICAgICAgIGxpc3RlbmVyLT51c2UoKTsKKyAg ICAgICAgICAgIHJldHVybjsKKyAgICAgICAgfQorCisgICAgICAgIC8vIEEgZmlsZSBVUkwgc2hv dWxkbid0IGZhbGwgdGhyb3VnaCB0byBoZXJlLCBidXQgaWYgaXQgZGlkLAorICAgICAgICAvLyBp dCB3b3VsZCBiZSBhIHNlY3VyaXR5IHJpc2sgdG8gb3BlbiBpdC4KKyNpZiAhUExBVEZPUk0oSU9T KQorICAgICAgICBpZiAoIVtuc1VSTFJlcXVlc3QuVVJMIGlzRmlsZVVSTF0pCisgICAgICAgICAg ICBbW05TV29ya3NwYWNlIHNoYXJlZFdvcmtzcGFjZV0gb3BlblVSTDpuc1VSTFJlcXVlc3QuVVJM XTsKKyNlbmRpZgorICAgICAgICBsaXN0ZW5lci0+aWdub3JlKCk7CiAgICAgICAgIHJldHVybjsK ICAgICB9CiAKQEAgLTI2Niw4ICsyODIsMjIgQEAgdm9pZCBOYXZpZ2F0aW9uU3RhdGU6OlBvbGlj eUNsaWVudDo6ZGVjaWRlUG9saWN5Rm9yTmV3V2luZG93QWN0aW9uKFdlYlBhZ2VQcm94eSoKIHZv aWQgTmF2aWdhdGlvblN0YXRlOjpQb2xpY3lDbGllbnQ6OmRlY2lkZVBvbGljeUZvclJlc3BvbnNl KFdlYlBhZ2VQcm94eSosIFdlYkZyYW1lUHJveHkqIGZyYW1lLCBjb25zdCBXZWJDb3JlOjpSZXNv dXJjZVJlc3BvbnNlJiByZXNvdXJjZVJlc3BvbnNlLCBjb25zdCBXZWJDb3JlOjpSZXNvdXJjZVJl cXVlc3QmIHJlc291cmNlUmVxdWVzdCwgYm9vbCBjYW5TaG93TUlNRVR5cGUsIFJlZlB0cjxXZWJG cmFtZVBvbGljeUxpc3RlbmVyUHJveHk+IGxpc3RlbmVyLCBBUEk6Ok9iamVjdCogdXNlckRhdGEp CiB7CiAgICAgaWYgKCFtX25hdmlnYXRpb25TdGF0ZS5tX25hdmlnYXRpb25EZWxlZ2F0ZU1ldGhv ZHMud2ViVmlld0RlY2lkZVBvbGljeUZvck5hdmlnYXRpb25SZXNwb25zZURlY2lzaW9uSGFuZGxl cikgewotICAgICAgICAvLyBGSVhNRTogPHJkYXI6Ly9wcm9ibGVtLzE1OTQ5ODIyPiBGaWd1cmUg b3V0IHdoYXQgdGhlICJkZWZhdWx0IGRlbGVnYXRlIGJlaGF2aW9yIiBzaG91bGQgYmUgaGVyZS4K LSAgICAgICAgbGlzdGVuZXItPnVzZSgpOworICAgICAgICBOU1VSTCAqdXJsID0gcmVzb3VyY2VS ZXNwb25zZS5uc1VSTFJlc3BvbnNlKCkuVVJMOworICAgICAgICBpZiAoW3VybCBpc0ZpbGVVUkxd KSB7CisgICAgICAgICAgICBCT09MIGlzRGlyZWN0b3J5ID0gTk87CisgICAgICAgICAgICBCT09M IGV4aXN0cyA9IFtbTlNGaWxlTWFuYWdlciBkZWZhdWx0TWFuYWdlcl0gZmlsZUV4aXN0c0F0UGF0 aDp1cmwucGF0aCBpc0RpcmVjdG9yeTomaXNEaXJlY3RvcnldOworCisgICAgICAgICAgICBpZiAo ZXhpc3RzICYmICFpc0RpcmVjdG9yeSAmJiBjYW5TaG93TUlNRVR5cGUpCisgICAgICAgICAgICAg ICAgbGlzdGVuZXItPnVzZSgpOworICAgICAgICAgICAgZWxzZQorICAgICAgICAgICAgICAgIGxp c3RlbmVyLT5pZ25vcmUoKTsKKyAgICAgICAgICAgIHJldHVybjsKKyAgICAgICAgfQorCisgICAg ICAgIGlmIChjYW5TaG93TUlNRVR5cGUpCisgICAgICAgICAgICBsaXN0ZW5lci0+dXNlKCk7Cisg ICAgICAgIGVsc2UKKyAgICAgICAgICAgIGxpc3RlbmVyLT5pZ25vcmUoKTsKICAgICAgICAgcmV0 dXJuOwogICAgIH0KIApAQCAtMjc1LDcgKzMwNSw2IEBAIHZvaWQgTmF2aWdhdGlvblN0YXRlOjpQ b2xpY3lDbGllbnQ6OmRlY2lkZVBvbGljeUZvclJlc3BvbnNlKFdlYlBhZ2VQcm94eSosIFdlYkZy CiAgICAgaWYgKCFuYXZpZ2F0aW9uRGVsZWdhdGUpCiAgICAgICAgIHJldHVybjsKIAotICAgIC8v IEZJWE1FOiBTZXQgdXAgdGhlIG5hdmlnYXRpb24gcmVzcG9uc2Ugb2JqZWN0LgogICAgIGF1dG8g bmF2aWdhdGlvblJlc3BvbnNlID0gYWRvcHROUyhbW1dLTmF2aWdhdGlvblJlc3BvbnNlIGFsbG9j XSBpbml0XSk7CiAKICAgICBbbmF2aWdhdGlvblJlc3BvbnNlIHNldEZyYW1lOmFkb3B0TlMoW1tX S0ZyYW1lSW5mbyBhbGxvY10gaW5pdFdpdGhXZWJGcmFtZVByb3h5OipmcmFtZV0pLmdldCgpXTsK