131936 2014-04-21 10:59:33 -0700 http/tests/cache/subresource-failover-to-network.html is flaky 2014-04-21 11:55:43 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ap ap commit-queue oldest_to_newest 1002560 0 ap 2014-04-21 10:59:33 -0700 http/tests/cache/subresource-failover-to-network.html is buggy. It tries to use testRunner queueing, but what actually happens is: - on first load, the test queues JS execution to submit a form, plus two history navigations. - but when it navigates back to main page, the same script runs again, queuing the same sequence again! And then it's nothing but pure luck that makes the test test pass on some platforms. Also, the test sets a cookie and doesn't reset it, which is sad. 1002563 1 229810 ap 2014-04-21 11:05:50 -0700 Created attachment 229810 proposed fix 1002590 2 229810 commit-queue 2014-04-21 11:55:41 -0700 Comment on attachment 229810 proposed fix Clearing flags on attachment: 229810 Committed r167601: <http://trac.webkit.org/changeset/167601> 1002591 3 commit-queue 2014-04-21 11:55:43 -0700 All reviewed patches have been landed. Closing bug. 229810 2014-04-21 11:05:50 -0700 2014-04-21 11:55:41 -0700 proposed fix subresource-failover-to-network.txt text/plain 4007 ap SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDE2NzU5NSkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE0LTA0LTIxICBBbGV4ZXkgUHJvc2t1cnlh a292ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIGh0dHAvdGVzdHMvY2FjaGUvc3VicmVzb3Vy Y2UtZmFpbG92ZXItdG8tbmV0d29yay5odG1sIGlzIGZsYWt5CisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzE5MzYKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgdGVzdCB3YXMgcmFjeSwgYmVjYXVzZSBp dCB3YXMgdW5pbnRlbnRpb25hbGx5IHF1ZXVpbmcgVGVzdFJ1bm5lciBvcGVyYXRpb25zCisgICAg ICAgIHR3aWNlLiBBbHNvLCBpdCBmYWlsZWQgdG8gY2xlYW4gdXAgaXRzIGNvb2tpZS4KKworICAg ICAgICBSZXdyb3RlIHRvIG5vdCB1c2UgVGVzdFJ1bm5lciBxdWV1aW5nLCBtYWtpbmcgdGhlIHRl c3Qgd29yayBpbiBicm93c2VyLgorCisgICAgICAgICogaHR0cC90ZXN0cy9jYWNoZS9yZXNvdXJj ZXMvc3VicmVzb3VyY2UtZmFpbG92ZXItdG8tbmV0d29yay5jZ2k6CisgICAgICAgICogaHR0cC90 ZXN0cy9jYWNoZS9zdWJyZXNvdXJjZS1mYWlsb3Zlci10by1uZXR3b3JrLmh0bWw6CisKIDIwMTQt MDQtMjEgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEBhcHBsZS5jb20+CiAKICAgICAgICAgUkVH UkVTU0lPTiAocjE2NzUzMCk6IEFTU0VSVChtX3NlbGZUaW1lIDw9IG1fdG90YWxUaW1lKSBvbiB0 ZXN0cyB0aGF0IHJ1biBhZnRlciBjZXJ0YWluIEluc3BlY3RvciB0ZXN0cwpJbmRleDogTGF5b3V0 VGVzdHMvaHR0cC90ZXN0cy9jYWNoZS9zdWJyZXNvdXJjZS1mYWlsb3Zlci10by1uZXR3b3JrLmh0 bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9jYWNoZS9zdWJyZXNvdXJj ZS1mYWlsb3Zlci10by1uZXR3b3JrLmh0bWwJKHJldmlzaW9uIDE2NzUxMSkKKysrIExheW91dFRl c3RzL2h0dHAvdGVzdHMvY2FjaGUvc3VicmVzb3VyY2UtZmFpbG92ZXItdG8tbmV0d29yay5odG1s CSh3b3JraW5nIGNvcHkpCkBAIC0xLDE5ICsxLDI2IEBACiA8Ym9keT4KIDxzY3JpcHQ+Ci0gIGlm ICgidGVzdFJ1bm5lciIgaW4gd2luZG93KSB7Ci0gICAgdGVzdFJ1bm5lci5kdW1wQXNUZXh0KCk7 CitmdW5jdGlvbiB0ZXN0KCkgeworICBpZiAoIXNlc3Npb25TdG9yYWdlLnN1YnJlc291cmNlRmFp bG92ZXJUb05ldHdvcmtMb2FkZWRCZWZvcmUpIHsKKyAgICBpZiAod2luZG93LnRlc3RSdW5uZXIp IHsKKyAgICAgIHRlc3RSdW5uZXIuZHVtcEFzVGV4dCgpOworICAgICAgdGVzdFJ1bm5lci53YWl0 VW50aWxEb25lKCk7CisgICAgfQorICAgIHNlc3Npb25TdG9yYWdlLnN1YnJlc291cmNlRmFpbG92 ZXJUb05ldHdvcmtMb2FkZWRCZWZvcmUgPSB0cnVlOwogCi0gICAgZG9jdW1lbnQuY29va2llID0g InJlc3VsdD1GQUlMIgorICAgIGRvY3VtZW50LmNvb2tpZSA9ICJzdWJyZXNvdXJjZUZhaWxvdmVy VG9OZXR3b3JrPUZBSUwiOwogCiAgICAgLy8gVGhlIHJlc3VsdHMgb2YgdGhlIGZvcm0gc3VibWlz c2lvbiBpcyBhIHBhZ2UgdGhhdCBwZXJmb3JtcyBhIG5vbi0KICAgICAvLyBjYWNoZWFibGUgc3lu YyBYSFIgcmVxdWVzdC4gIFVwb24gcmV0dXJuaW5nIHRvIHRoYXQgcGFnZSwgd2UgZXhwZWN0IHRo ZQogICAgIC8vIHN5bmMgWEhSIHJlcXVlc3QgdG8gc3RpbGwgc3VjY2VlZC4gIFRoaXMgcmVsaWVz IG9uIGl0IGxvYWRpbmcgZnJvbSB0aGUKICAgICAvLyBuZXR3b3JrIGFuZCBub3QgYmVpbmcgcmVz dHJpY3RlZCB0byBsb2FkaW5nIGZyb20gdGhlIGNhY2hlIChhcyB0aGUgbWFpbgogICAgIC8vIHBh Z2UgaXMpLgotICAgIHRlc3RSdW5uZXIucXVldWVMb2FkaW5nU2NyaXB0KCJkb2N1bWVudC5mb3Jt c1swXS5zdWJtaXQoKSIpOwotICAgIHRlc3RSdW5uZXIucXVldWVCYWNrTmF2aWdhdGlvbigxKTsK LSAgICB0ZXN0UnVubmVyLnF1ZXVlRm9yd2FyZE5hdmlnYXRpb24oMSk7Ci0gIH0KKyAgICBzZXRU aW1lb3V0KCBmdW5jdGlvbigpIHsgZG9jdW1lbnQuZm9ybXNbMF0uc3VibWl0KCk7IH0sIDApOwor ICB9IGVsc2UKKyAgICBoaXN0b3J5LmZvcndhcmQoKTsKK30KKworb25sb2FkID0gdGVzdDsKIDwv c2NyaXB0PgogPGZvcm0gbWV0aG9kPSJQT1NUIiBhY3Rpb249InJlc291cmNlcy9zdWJyZXNvdXJj ZS1mYWlsb3Zlci10by1uZXR3b3JrLmNnaSIgZW5jdHlwZT0ibXVsdGlwYXJ0L2Zvcm0tZGF0YSI+ CiAgIDxpbnB1dCB0eXBlPSJzdWJtaXQiPgpAQCAtMjcsNCArMzQsNiBAQCBXaGVuIG5hdmlnYXRp bmcgYmFjayB0byBhIHBhZ2UgdGhhdCByZXN1CiBpcyBsb2FkZWQgd2l0aCB0aGUgUmV0dXJuQ2Fj aGVEYXRhRG9udExvYWQgY2FjaGUgcG9saWN5LiAgSXQgaXMgaW1wb3J0YW50IHRoYXQKIHN1YnJl c291cmNlcyAoaW5jbHVkaW5nIFhNTEh0dHBSZXF1ZXN0IGluc3RhbmNlcykgZG8gbm90IGluaGVy aXQgdGhpcyBjYWNoZQogcG9saWN5LgorPHA+CitUaGlzIHRlc3QgZG9lc24ndCB3b3JrIGluIGJy b3dzZXIsIGJlY2F1c2UgaXQgZXhwZWN0cyBwYWdlIGNhY2hlIHRvIGJlIGRpc2FibGVkLgogPC9i b2R5PgpJbmRleDogTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9jYWNoZS9yZXNvdXJjZXMvc3VicmVz b3VyY2UtZmFpbG92ZXItdG8tbmV0d29yay5jZ2kKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMv aHR0cC90ZXN0cy9jYWNoZS9yZXNvdXJjZXMvc3VicmVzb3VyY2UtZmFpbG92ZXItdG8tbmV0d29y ay5jZ2kJKHJldmlzaW9uIDE2NzUxMSkKKysrIExheW91dFRlc3RzL2h0dHAvdGVzdHMvY2FjaGUv cmVzb3VyY2VzL3N1YnJlc291cmNlLWZhaWxvdmVyLXRvLW5ldHdvcmsuY2dpCSh3b3JraW5nIGNv cHkpCkBAIC02LDcgKzYsNiBAQCBwcmludCA8PEVPRgogPHNjcmlwdD4KIHRyeSB7CiAgIHZhciBy ZXN1bHQgPSBkb2N1bWVudC5jb29raWUuc3BsaXQoJzsnKVswXS5zcGxpdCgnPScpWzFdOwotICBk b2N1bWVudC5jb29raWUgPSAicmVzdWx0PVBBU1MiOyAvLyBmb3IgbmV4dCB0aW1lCiAKICAgdmFy IHIgPSBuZXcgWE1MSHR0cFJlcXVlc3QoKTsKICAgci5vcGVuKCdQT1NUJywgJ2VjaG8tbm8tc3Rv cmUuY2dpJywgZmFsc2UpOwpAQCAtMTUsNSArMTQsMTYgQEAgdHJ5IHsKIH0gY2F0Y2ggKGUpIHsK ICAgZG9jdW1lbnQud3JpdGUoZSk7CiB9CitpZiAoIXNlc3Npb25TdG9yYWdlLnN1YnJlc291cmNl RmFpbG92ZXJUb05ldHdvcmtDR0lMb2FkZWRCZWZvcmUpIHsKKyAgc2Vzc2lvblN0b3JhZ2Uuc3Vi cmVzb3VyY2VGYWlsb3ZlclRvTmV0d29ya0NHSUxvYWRlZEJlZm9yZSA9IHRydWU7CisgIGRvY3Vt ZW50LmNvb2tpZSA9ICJzdWJyZXNvdXJjZUZhaWxvdmVyVG9OZXR3b3JrPVBBU1MiOyAvLyBmb3Ig bmV4dCB0aW1lCisgIGhpc3RvcnkuYmFjaygpOworfSBlbHNlIHsKKyAgc2Vzc2lvblN0b3JhZ2Uu cmVtb3ZlSXRlbSgic3VicmVzb3VyY2VGYWlsb3ZlclRvTmV0d29ya0xvYWRlZEJlZm9yZSIpOwor ICBzZXNzaW9uU3RvcmFnZS5yZW1vdmVJdGVtKCJzdWJyZXNvdXJjZUZhaWxvdmVyVG9OZXR3b3Jr Q0dJTG9hZGVkQmVmb3JlIik7CisgIGRvY3VtZW50LmNvb2tpZSA9ICJzdWJyZXNvdXJjZUZhaWxv dmVyVG9OZXR3b3JrPTsgZXhwaXJlcz1UaHUsIDAxIEphbiAxOTcwIDAwOjAwOjAxIEdNVDsiOwor ICBpZiAod2luZG93LnRlc3RSdW5uZXIpCisgICAgdGVzdFJ1bm5lci5ub3RpZnlEb25lKCk7Cit9 CiA8L3NjcmlwdD4KIEVPRgo=