131935 2014-04-21 10:35:50 -0700 REGRESSION(r167591): ARM64 and ARM traditional builds broken 2014-04-21 11:11:14 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 msaboff msaboff oldest_to_newest 1002551 0 msaboff 2014-04-21 10:35:50 -0700 Changeset r167591 made a call to store8(MacroAssembler::TrustedImm32, MacroAssembler::Address) that isn't implemented on ARM64 and ARM traditional platforms. Those functions need to be added. 1002553 1 229806 msaboff 2014-04-21 10:39:24 -0700 Created attachment 229806 Patch 1002556 2 229806 mhahnenberg 2014-04-21 10:41:57 -0700 Comment on attachment 229806 Patch r=me 1002571 3 msaboff 2014-04-21 11:11:14 -0700 Committed r167599: <http://trac.webkit.org/changeset/167599> 229806 2014-04-21 10:39:24 -0700 2014-04-21 10:41:57 -0700 Patch 131935.patch text/plain 4065 msaboff SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTY3NTk1KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBA CisyMDE0LTA0LTIxICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAg ICAgIFJFR1JFU1NJT04ocjE2NzU5MSk6IEFSTTY0IGFuZCBBUk0gdHJhZGl0aW9uYWwgYnVpbGRz IGJyb2tlbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTMxOTM1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg QWRkZWQgc3RvcmU4KFRydXN0ZWRJbW0zMiwgTWFjcm9Bc3NlbWJsZXI6OkFkZHJlc3MpIHRvIHRo ZSBBUk0gdHJhZGl0aW9uYWwgYW5kIEFSTTY0CisgICAgICAgIG1hY3JvIGFzc2VtYmxlcnMuICBB ZGRlZCBhIG5ldyB0ZXN0IGZvciB0aGUgb3JpZ2luYWwgcGF0Y2guCisKKyAgICAgICAgKiBhc3Nl bWJsZXIvTWFjcm9Bc3NlbWJsZXJBUk0uaDoKKyAgICAgICAgKEpTQzo6TWFjcm9Bc3NlbWJsZXJB Uk06OnN0b3JlOCk6CisgICAgICAgICogYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyQVJNNjQuaDoK KyAgICAgICAgKEpTQzo6TWFjcm9Bc3NlbWJsZXJBUk02NDo6c3RvcmU4KToKKyAgICAgICAgKiB0 ZXN0cy9zdHJlc3MvZGZnLWNyZWF0ZS1hcmd1bWVudHMtaW5saW5lLWFsbG9jLmpzOiBOZXcgdGVz dC4KKwogMjAxNC0wNC0yMSAgTWFyayBIYWhuZW5iZXJnICA8bWhhaG5lbmJlcmdAYXBwbGUuY29t PgogCiAgICAgICAgIElubGluZSBhbGxvY2F0ZSBBcmd1bWVudHMgb2JqZWN0cyBpbiB0aGUgREZH CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyQVJN NjQuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3Jv QXNzZW1ibGVyQVJNNjQuaAkocmV2aXNpb24gMTY3NTkyKQorKysgU291cmNlL0phdmFTY3JpcHRD b3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlckFSTTY0LmgJKHdvcmtpbmcgY29weSkKQEAgLTEw OTMsNiArMTA5MywxNSBAQCBwdWJsaWM6CiAgICAgICAgIG1fYXNzZW1ibGVyLnN0cmIoc3JjLCBt ZW1vcnlUZW1wUmVnaXN0ZXIsIDApOwogICAgIH0KIAorICAgIHZvaWQgc3RvcmU4KFJlZ2lzdGVy SUQgc3JjLCBJbXBsaWNpdEFkZHJlc3MgYWRkcmVzcykKKyAgICB7CisgICAgICAgIGlmICh0cnlT dG9yZVdpdGhPZmZzZXQ8OD4oc3JjLCBhZGRyZXNzLmJhc2UsIGFkZHJlc3Mub2Zmc2V0KSkKKyAg ICAgICAgICAgIHJldHVybjsKKworICAgICAgICBzaWduRXh0ZW5kMzJUb1B0cihUcnVzdGVkSW1t MzIoYWRkcmVzcy5vZmZzZXQpLCBnZXRDYWNoZWRNZW1vcnlUZW1wUmVnaXN0ZXJJREFuZEludmFs aWRhdGUoKSk7CisgICAgICAgIG1fYXNzZW1ibGVyLnN0cjw4PihzcmMsIGFkZHJlc3MuYmFzZSwg bWVtb3J5VGVtcFJlZ2lzdGVyKTsKKyAgICB9CisKICAgICB2b2lkIHN0b3JlOChUcnVzdGVkSW1t MzIgaW1tLCB2b2lkKiBhZGRyZXNzKQogICAgIHsKICAgICAgICAgaWYgKCFpbW0ubV92YWx1ZSkg ewpAQCAtMTEwNCw2ICsxMTEzLDE2IEBAIHB1YmxpYzoKICAgICAgICAgc3RvcmU4KGRhdGFUZW1w UmVnaXN0ZXIsIGFkZHJlc3MpOwogICAgIH0KIAorICAgIHZvaWQgc3RvcmU4KFRydXN0ZWRJbW0z MiBpbW0sIEltcGxpY2l0QWRkcmVzcyBhZGRyZXNzKQorICAgIHsKKyAgICAgICAgaWYgKCFpbW0u bV92YWx1ZSkgeworICAgICAgICAgICAgc3RvcmU4KEFSTTY0UmVnaXN0ZXJzOjp6ciwgYWRkcmVz cyk7CisgICAgICAgICAgICByZXR1cm47CisgICAgICAgIH0KKworICAgICAgICBtb3ZlKGltbSwg Z2V0Q2FjaGVkRGF0YVRlbXBSZWdpc3RlcklEQW5kSW52YWxpZGF0ZSgpKTsKKyAgICAgICAgc3Rv cmU4KGRhdGFUZW1wUmVnaXN0ZXIsIGFkZHJlc3MpOworICAgIH0KIAogICAgIC8vIEZsb2F0aW5n LXBvaW50IG9wZXJhdGlvbnM6CiAKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJs ZXIvTWFjcm9Bc3NlbWJsZXJBUk0uaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENv cmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyQVJNLmgJKHJldmlzaW9uIDE2NzU5MikKKysrIFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJBUk0uaAkod29ya2lu ZyBjb3B5KQpAQCAtNDU5LDEyICs0NTksMjMgQEAgcHVibGljOgogICAgICAgICBtX2Fzc2VtYmxl ci5iYXNlSW5kZXhUcmFuc2ZlcjMyKEFSTUFzc2VtYmxlcjo6U3RvcmVVaW50OCwgc3JjLCBhZGRy ZXNzLmJhc2UsIGFkZHJlc3MuaW5kZXgsIHN0YXRpY19jYXN0PGludD4oYWRkcmVzcy5zY2FsZSks IGFkZHJlc3Mub2Zmc2V0KTsKICAgICB9CiAKKyAgICB2b2lkIHN0b3JlOChSZWdpc3RlcklEIHNy YywgSW1wbGljaXRBZGRyZXNzIGFkZHJlc3MpCisgICAgeworICAgICAgICBtX2Fzc2VtYmxlci5k dHJVcChBUk1Bc3NlbWJsZXI6OlN0b3JlVWludDgsIHNyYywgYWRkcmVzcy5iYXNlLCBhZGRyZXNz Lm9mZnNldCk7CisgICAgfQorCiAgICAgdm9pZCBzdG9yZTgoUmVnaXN0ZXJJRCBzcmMsIGNvbnN0 IHZvaWQqIGFkZHJlc3MpCiAgICAgewogICAgICAgICBtb3ZlKFRydXN0ZWRJbW1QdHIoYWRkcmVz cyksIEFSTVJlZ2lzdGVyczo6UzApOwogICAgICAgICBtX2Fzc2VtYmxlci5kdHJVcChBUk1Bc3Nl bWJsZXI6OlN0b3JlVWludDgsIHNyYywgQVJNUmVnaXN0ZXJzOjpTMCwgMCk7CiAgICAgfQogCisg ICAgdm9pZCBzdG9yZTgoVHJ1c3RlZEltbTMyIGltbSwgSW1wbGljaXRBZGRyZXNzIGFkZHJlc3Mp CisgICAgeworICAgICAgICBtb3ZlKGltbSwgQVJNUmVnaXN0ZXJzOjpTMSk7CisgICAgICAgIHN0 b3JlOChBUk1SZWdpc3RlcnM6OlMxLCBhZGRyZXNzKTsKKyAgICB9CisKICAgICB2b2lkIHN0b3Jl OChUcnVzdGVkSW1tMzIgaW1tLCBjb25zdCB2b2lkKiBhZGRyZXNzKQogICAgIHsKICAgICAgICAg bW92ZShUcnVzdGVkSW1tMzIocmVpbnRlcnByZXRfY2FzdDxBUk1Xb3JkPihhZGRyZXNzKSksIEFS TVJlZ2lzdGVyczo6UzApOwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3Rlc3RzL3N0cmVz cy9kZmctY3JlYXRlLWFyZ3VtZW50cy1pbmxpbmUtYWxsb2MuanMKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL3Rlc3RzL3N0cmVzcy9kZmctY3JlYXRlLWFyZ3VtZW50cy1pbmxp bmUtYWxsb2MuanMJKHJldmlzaW9uIDApCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvdGVzdHMv c3RyZXNzL2RmZy1jcmVhdGUtYXJndW1lbnRzLWlubGluZS1hbGxvYy5qcwkod29ya2luZyBjb3B5 KQpAQCAtMCwwICsxLDE5IEBACit2YXIgZm9vID0gZnVuY3Rpb24obykgeworICAgIHZhciBhID0g QXJyYXkucHJvdG90eXBlLnNsaWNlLmNhbGwoYXJndW1lbnRzKTsKKyAgICB2YXIgc3VtID0gMDsK KyAgICBmb3IgKHZhciBpID0gMDsgaSA8IGEubGVuZ3RoOyArK2kpCisgICAgICAgIHN1bSArPSBh W2ldLng7CisgICAgcmV0dXJuIHN1bTsKK307CisKK25vSW5saW5lKGZvbyk7CisKK3ZhciBuaXRl cnMgPSAxMDAwMDsKK3ZhciB0b3RhbCA9IDA7Cit2YXIgbyA9IHt4OiA0Mn07Citmb3IgKHZhciBp ID0gMDsgaSA8IG5pdGVyczsgKytpKSB7CisgICAgdG90YWwgKz0gZm9vKG8sIG8sIG8pOworfQor CitpZiAodG90YWwgIT0gNDIgKiAzICogbml0ZXJzKQorICAgIHRocm93IG5ldyBFcnJvcigiSW5j b3JyZWN0IHJlc3VsdCEiKTsK