131933 2014-04-21 04:35:37 -0700 AX: [ATK] caret-moved not emitted by text directly in html body 2017-03-11 10:46:52 -0800 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) PC Linux NEW Gtk, InRadar P2 Normal --- 1 jarekczek webkit-unassigned bugs-noreply jdiggs webkit-bug-importer oldest_to_newest 1002528 0 229799 jarekczek 2014-04-21 04:35:37 -0700 Created attachment 229799 patch with a test case Under some circumstances text enclosed directly in <body> does not behave like text. atk_text_set_caret_offset does not allow to position the cursor inside it and caret-moved events are not emitted. The simple example is as follows: <html><body> <div>div1</div>abc<div>div2</div> </body></html> Divs are accessible, but the text between them is not. If there were no misleading divs, the text alone is accessible. Once a div after or before is added, the problem arises. I prepared a test case for that. To make such tests easier I prepared a helper testWebkitAtkCaretWalk method. So in this testatk.c diff there is also a test case for bug #130941 included. The name of the test for this bug report is caretInBody. 1002529 1 webkit-bug-importer 2014-04-21 04:37:14 -0700 <rdar://problem/16673736> 1004342 2 jarekczek 2014-04-26 08:07:17 -0700 First clue. In Source/WebCore/accessibility/AccessibilityRenderObject.cpp, function AccessibilityRenderObject::textUnderElement, line 664, we have a comment: // For anonymous blocks, we work around not having a direct node to create a range from // defining one based in the two external positions defining the boundaries of the subtree. But when we set cursor position, we rely on visiblePositionForIndex, the same file, line 1859. There it returns empty position for anonymous blocks (!node). 229799 2014-04-21 04:35:37 -0700 2014-04-21 04:35:37 -0700 patch with a test case caret_walk_test_1_0.patch text/plain 6887 jarekczek SW5kZXg6IFRvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0R3RrL3Rlc3RhdGsuYwo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBUb29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdEd0ay90ZXN0YXRrLmMJ KHJldmlzaW9uIDE2NjQwNSkKKysrIFRvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0R3Rr L3Rlc3RhdGsuYwkod29ya2luZyBjb3B5KQpAQCAtNTEsMTAgKzUxLDI0IEBACiAKIHN0YXRpYyBj b25zdCBjaGFyKiB0ZXh0Rm9yQ2FyZXRCcm93c2luZyA9ICI8aHRtbD48Ym9keT48aDE+QSB0ZXh0 IGhlYWRlcjwvaDE+PHA+QSBwYXJhZ3JhcGggPGEgaHJlZj0naHR0cDovL2Zvby5iYXIuYmF6Lyc+ d2l0aCBhIGxpbms8L2E+IGluIHRoZSBtaWRkbGU8L3A+PG9sPjxsaT5BIGxpc3QgaXRlbTwvbGk+ PGxpPjxzcGFuIHN0eWxlPSdkaXNwbGF5OmJsb2NrOyc+QmxvY2sgc3BhbiBpbiBhIGxpc3QgaXRl bTwvc3Bhbj48c3Bhbj5JbmxpbmUgc3BhbiBpbiBhIGxpc3QgaXRlbTwvc3Bhbj48L2xpPjxsaT48 YSBocmVmPSdmb28nPjxzcGFuIHN0eWxlPSdkaXNwbGF5OmJsb2NrOyc+QmxvY2sgc3BhbiBpbiBh IGxpbmsgaW4gYSBsaXN0IGl0ZW08L3NwYW4+PHNwYW4+SW5saW5lIHNwYW4gaW4gYSBsaW5rIGlu IGEgbGlzdCBpdGVtPC9zcGFuPjwvYT48L2xpPjwvb2w+PHNlbGVjdD48b3B0aW9uIHNlbGVjdGVk IHZhbHVlPSdmb28nPkFuIG9wdGlvbiBpbiBhIGNvbWJvIGJveDwvb3B0aW9uPjwvc2VsZWN0Pjxp bnB1dCB0eXBlPSd0ZXh0JyBuYW1lPSdmb28nIHZhbHVlPSdmb28gYmFyIGJheicgLz48dGFibGU+ PHRyPjx0ZD5hIHRhYmxlIGNlbGw8L3RkPjx0ZD48L3RkPjx0ZD48YSBocmVmPSdmb28nPjxzcGFu IHN0eWxlPSdkaXNwbGF5OmJsb2NrOyc+QmxvY2sgc3BhbiBpbiBhIGxpbmsgaW4gYSB0YWJsZSBj ZWxsPC9zcGFuPjxzcGFuPklubGluZSBzcGFuIGluIGEgbGluayBpbiBhIHRhYmxlIGNlbGw8L3Nw YW4+PC9hPjwvdGQ+PHRkPjxzcGFuIHN0eWxlPSdkaXNwbGF5OmJsb2NrOyc+QmxvY2sgc3BhbiBp biBhIHRhYmxlIGNlbGw8L3NwYW4+PHNwYW4+SW5saW5lIHNwYW4gaW4gYSB0YWJsZSBjZWxsPC9z cGFuPjwvdGQ+PC90cj48L3RhYmxlPjxoND48YSBocmVmPSdmb28nPjxzcGFuIHN0eWxlPSdkaXNw bGF5OmJsb2NrOyc+QmxvY2sgc3BhbiBpbiBhIGxpbmsgaW4gYSBoZWFkaW5nPC9zcGFuPjxzcGFu PklubGluZSBzcGFuIGluIGEgbGluayBpbiBhIGhlYWRpbmc8L3NwYW4+PC9oND48aDQ+PHNwYW4g c3R5bGU9J2Rpc3BsYXk6YmxvY2s7Jz5CbG9jayBzcGFuIGluIGEgaGVhZGluZzwvc3Bhbj48c3Bh bj5JbmxpbmUgc3BhbiBpbiBhIGhlYWRpbmc8L3NwYW4+PC9oND48L2JvZHk+PC9odG1sPiI7CiAK K3N0YXRpYyBjb25zdCBjaGFyKiB0ZXh0Rm9yQ2FyZXRBQmxvY2sgPSAiPGh0bWw+PGJvZHk+XG5c Cis8ZGl2PlxuXAorPHA+UGFyYSAxPC9wPlxuXAorPGRpdj5cblwKKzxhIHN0eWxlPVwiZGlzcGxh eTpibG9jaztcIiBocmVmPVwiYW55dGhpbmdcIj5BbiBhIHRhZyB3aXRoIGhyZWY8L2E+XG5cCis8 cD5QYXJhIDI8L3A+XG5cCis8L2Rpdj5cblwKKzwvZGl2PlxuXAorPC9ib2R5PjwvaHRtbD5cbiI7 CisKK3N0YXRpYyBjb25zdCBjaGFyKiB0ZXh0Rm9yQ2FyZXRJbkJvZHkgPSAiPGh0bWw+PGJvZHk+ PGRpdj4xPC9kaXY+Qm9keTxkaXY+MjwvZGl2PjwvYm9keT48L2h0bWw+IjsKKwogc3RhdGljIGNv bnN0IGNoYXIqIHRleHRGb3JTZWxlY3Rpb25zID0gIjxodG1sPjxib2R5PjxwPkEgcGFyYWdyYXBo IHdpdGggcGxhaW4gdGV4dDwvcD48cD5BIHBhcmFncmFwaCB3aXRoIDxhIGhyZWY9J2h0dHA6Ly93 ZWJraXQub3JnJz5hIGxpbms8L2E+IGluIHRoZSBtaWRkbGU8L3A+PG9sPjxsaT5BIGxpc3QgaXRl bTwvbGk+PC9vbD48c2VsZWN0PjwvYm9keT48L2h0bWw+IjsKIAogc3RhdGljIGNvbnN0IGNoYXIq IHRleHRXaXRoQXR0cmlidXRlcyA9ICI8aHRtbD48aGVhZD48c3R5bGU+LnN0MSB7Zm9udC1mYW1p bHk6IG1vbm9zcGFjZTsgY29sb3I6cmdiKDEyMCwxMjEsMTIyKTt9IC5zdDIge3RleHQtZGVjb3Jh dGlvbjp1bmRlcmxpbmU7IGJhY2tncm91bmQtY29sb3I6cmdiKDgwLDgxLDgyKTt9PC9zdHlsZT48 L2hlYWQ+PGJvZHk+PHAgc3R5bGU9XCJmb250LXNpemU6MTQ7IHRleHQtYWxpZ246cmlnaHQ7XCI+ VGhpcyBpcyB0aGUgPGk+Zmlyc3Q8L2k+PGI+IHNlbnRlbmNlIG9mIHRoaXMgdGV4dC48L2I+PC9w PjxwIGNsYXNzPVwic3QxXCI+VGhpcyBzZW50ZW5jZSBzaG91bGQgaGF2ZSBhbiBzdHlsZSBhcHBs aWVkIDxzcGFuIGNsYXNzPVwic3QyXCI+YW5kIHRoaXMgcGFydCBzaG91bGQgaGF2ZSBhbm90aGVy IG9uZTwvc3Bhbj4uPC9wPjxwPng8c3ViPjE8L3N1Yj48c3VwPjI8L3N1cD49eDxzdWI+Mjwvc3Vi PjxzdXA+Mzwvc3VwPjwvcD48cCBzdHlsZT1cInRleHQtYWxpZ246Y2VudGVyO1wiPlRoaXMgc2Vu dGVuY2UgaXMgdGhlIDxzdHJpa2U+bGFzdDwvc3RyaWtlPiBvbmUuPC9wPjwvYm9keT48L2h0bWw+ IjsKIAorc3RhdGljIGNvbnN0IGNoYXIqIG5vTW92ZVN0ciA9ICJubyBtb3ZlIjsKKwogc3RhdGlj IEF0a09iamVjdCogZ2V0V2ViQXJlYU9iamVjdChXZWJLaXRXZWJWaWV3KiB3ZWJWaWV3KQogewog ICAgIC8qIE1hbnVhbGx5IHNwaW4gdGhlIG1haW4gY29udGV4dCB0byBtYWtlIHN1cmUgdGhlIGFj Y2Vzc2libGUKQEAgLTg3LDYgKzEwMSw4NSBAQAogICAgIHRleHRDYXJldE1vdmVkUmVzdWx0ID0g Z19zdHJkdXBfcHJpbnRmKCJ8JXN8JWR8IiwgYXRrX3JvbGVfZ2V0X25hbWUocm9sZSksIHBvcyk7 CiB9CiAKKy8vIENvbm5lY3Qgc2lnbmFsIHRvIHRoZSBnaXZlbiBhdGsgb2JqZWN0IGFuZCBhbGwg aXRzIGRlc2NlbmRhbnRzCisvLyByZWN1cnNpdmVseSwgdG8gbWFrZSBzdXJlIGl0J3MgYWx3YXlz IGNhdWdodC4KK3N0YXRpYyB2b2lkIHRlc3RXZWJraXRBdGtDb25uZWN0UmVjdXIoQXRrT2JqZWN0 ICpwYXJlbnQsCisgICAgZ2NoYXIgKnNpZ25hbCwgR0NhbGxiYWNrIGhhbmRsZXIpCit7CisgICAg aW50IGlDaGlsZCA9IDA7CisgICAgaW50IGNDaGlsZCA9IGF0a19vYmplY3RfZ2V0X25fYWNjZXNz aWJsZV9jaGlsZHJlbihwYXJlbnQpOworICAgIGlmIChBVEtfSVNfVEVYVChwYXJlbnQpKQorICAg ICAgICBnX3NpZ25hbF9jb25uZWN0KHBhcmVudCwgInRleHQtY2FyZXQtbW92ZWQiLCBoYW5kbGVy LCAwKTsKKyAgICBmb3IgKGlDaGlsZCA9IDA7IGlDaGlsZCA8IGNDaGlsZDsgaUNoaWxkKyspIHsK KyAgICAgICAgQXRrT2JqZWN0ICpjaGlsZCA9IGF0a19vYmplY3RfcmVmX2FjY2Vzc2libGVfY2hp bGQocGFyZW50LCBpQ2hpbGQpOworICAgICAgICB0ZXN0V2Via2l0QXRrQ29ubmVjdFJlY3VyKGNo aWxkLCBzaWduYWwsIGhhbmRsZXIpOworICAgICAgICBnX29iamVjdF91bnJlZihjaGlsZCk7Cisg ICAgfQorfQorCisvLyBXYWxrcyB0aGUgZ2l2ZW4gaHRtbCBzb3VyY2Ugd2l0aCB0aGUgd2Via2l0 IGNhcmV0IGFuZCBleHBlY3RzIGNhcmV0LW1vdmVkCisvLyBldmVudHMgd2l0aCBldmVyeSBzdGVw LiBGYWlscyBpZiB0aGUgZXZlbnQgaXMgbm90IGRlbGl2ZXJlZC4KK3N0YXRpYyB2b2lkIHRlc3RX ZWJraXRBdGtDYXJldFdhbGsoY29uc3QgY2hhciAqaHRtbFNvdXJjZSkKK3sKKyAgICBXZWJLaXRX ZWJWaWV3KiB3ZWJWaWV3ID0gV0VCS0lUX1dFQl9WSUVXKHdlYmtpdF93ZWJfdmlld19uZXcoKSk7 CisgICAgZ19vYmplY3RfcmVmX3Npbmsod2ViVmlldyk7CisgICAgR3RrQWxsb2NhdGlvbiBhbGxv Y2F0aW9uID0geyAwLCAwLCA4MDAsIDYwMCB9OworICAgIGd0a193aWRnZXRfc2l6ZV9hbGxvY2F0 ZShHVEtfV0lER0VUKHdlYlZpZXcpLCAmYWxsb2NhdGlvbik7CisgICAgd2Via2l0X3dlYl92aWV3 X2xvYWRfc3RyaW5nKHdlYlZpZXcsIGh0bWxTb3VyY2UsIDAsIDAsIDApOworCisgICAgQXRrT2Jq ZWN0KiBvYmplY3QgPSBnZXRXZWJBcmVhT2JqZWN0KHdlYlZpZXcpOworICAgIGdfYXNzZXJ0KG9i amVjdCk7CisKKyAgICBpbnQgY0NoaWxkID0gYXRrX29iamVjdF9nZXRfbl9hY2Nlc3NpYmxlX2No aWxkcmVuKG9iamVjdCk7CisgICAgLy9wcmludGYoInJvb3QgY2hpbGRyZW4gY291bnQ6ICVkXG4i LCBjQ2hpbGQpOworICAgIHRlc3RXZWJraXRBdGtDb25uZWN0UmVjdXIob2JqZWN0LCAidGV4dC1j YXJldC1tb3ZlZCIsCisgICAgICAgIEdfQ0FMTEJBQ0sodGV4dENhcmV0TW92ZWRDYWxsYmFjaykp OworCisgICAgaW50IGlDaGlsZDsKKyAgICBmb3IoaUNoaWxkID0gMDsgaUNoaWxkIDwgY0NoaWxk OyBpQ2hpbGQrKykgeworICAgICAgICBBdGtPYmplY3QgKmNoaWxkID0gYXRrX29iamVjdF9yZWZf YWNjZXNzaWJsZV9jaGlsZChvYmplY3QsIGlDaGlsZCk7CisgICAgICAgIGdjaGFyICphbGxUZXh0 ID0gYXRrX3RleHRfZ2V0X3RleHQoQVRLX1RFWFQoY2hpbGQpLCAwLCAtMSk7CisgICAgICAgIGlu dCBMID0gYXRrX3RleHRfZ2V0X2NoYXJhY3Rlcl9jb3VudChBVEtfVEVYVChjaGlsZCkpOworICAg ICAgICAvLyBwbGFjZSB0aGUgY3Vyc29yIGF0IG9mZnNldCBkaWZmZXJlbnQgdGhhbiAwLCBjYXVz ZSB3ZSBzdGFydCBmcm9tIDAKKyAgICAgICAgYXRrX3RleHRfc2V0X2NhcmV0X29mZnNldChBVEtf VEVYVChjaGlsZCksIDEpOworICAgICAgICAvL3ByaW50ZigiYWxsOiVzXG4iLCBhbGxUZXh0KTsK KyAgICAgICAgaW50IGk7CisgICAgICAgIGZvciAoaSA9IDA7IGkgPCBMOyBpKyspIHsKKyAgICAg ICAgICAgIGdfZnJlZSh0ZXh0Q2FyZXRNb3ZlZFJlc3VsdCk7CisgICAgICAgICAgICB0ZXh0Q2Fy ZXRNb3ZlZFJlc3VsdCA9IGdfc3RyZHVwKG5vTW92ZVN0cik7CisgICAgICAgICAgICBpbnQgcmVz dWx0ID0gYXRrX3RleHRfc2V0X2NhcmV0X29mZnNldChBVEtfVEVYVChjaGlsZCksIGkpOworICAg ICAgICAgICAgLy9wcmludGYoIndhbGsgc3RlcCAlZCwgY2FyZXQgbW92ZWQgcmVzdWx0OiAlcywg Y2hhcmFjdGVyOiclYycgKCVkKVxuIiwKKyAgICAgICAgICAgIC8vICAgIGksIHRleHRDYXJldE1v dmVkUmVzdWx0LGFsbFRleHRbaV0sIChpbnQpYWxsVGV4dFtpXSk7CisgICAgICAgICAgICBnX2Fz c2VydF9jbXBpbnQocmVzdWx0LCA9PSwgVFJVRSk7CisgICAgICAgICAgICBpZiAoZ19zdHJjbXAw KHRleHRDYXJldE1vdmVkUmVzdWx0LCBub01vdmVTdHIpID09IDApIHsKKyAgICAgICAgICAgICAg ICBwcmludGYoImNhcmV0LW1vdmVkIG5vdCByZWNlaXZlZCBpbiBjaGlsZCAlZCwgb2Zmc2V0ICVk LCBjaGFyYWN0ZXI6JyVjJyAoJWQpXG4iLAorICAgICAgICAgICAgICAgICAgICBpQ2hpbGQsIGks IGFsbFRleHRbaV0sIChpbnQpYWxsVGV4dFtpXSk7CisgICAgICAgICAgICB9CisgICAgICAgICAg ICBnX2Fzc2VydF9jbXBzdHIodGV4dENhcmV0TW92ZWRSZXN1bHQsICE9LCBub01vdmVTdHIpOwor ICAgICAgICAgICAgLy8gd2Fsa2luZyBvdmVyIGxpbmUgZW5kaW5ncyBkb2VzIG5vdCBhbHdheXMg ZW1pdCB0aGUgc2lnbmFsLAorICAgICAgICAgICAgLy8gc28gbW92ZSB0aGUgY3Vyc29yIGFydGlm aWNpYWxseSBpbiBzdWNoIGNhc2VzCisgICAgICAgICAgICBpZiAoYWxsVGV4dFtpXSA9PSAxMCkK KyAgICAgICAgICAgICAgICBhdGtfdGV4dF9zZXRfY2FyZXRfb2Zmc2V0KEFUS19URVhUKGNoaWxk KSwgMCk7CisgICAgICAgIH0KKyAgICAgICAgZ19vYmplY3RfdW5yZWYoY2hpbGQpOworICAgICAg ICBnX2ZyZWUoYWxsVGV4dCk7CisgICAgfQorCisgICAgZ19mcmVlKHRleHRDYXJldE1vdmVkUmVz dWx0KTsKKyAgICB0ZXh0Q2FyZXRNb3ZlZFJlc3VsdCA9IE5VTEw7CisgICAgZ19vYmplY3RfdW5y ZWYod2ViVmlldyk7Cit9CisKK3N0YXRpYyB2b2lkIHRlc3RXZWJraXRBdGtDYXJldEFCbG9jaygp Cit7CisgICAgdGVzdFdlYmtpdEF0a0NhcmV0V2Fsayh0ZXh0Rm9yQ2FyZXRBQmxvY2spOworfQor CitzdGF0aWMgdm9pZCB0ZXN0V2Via2l0QXRrQ2FyZXRJbkJvZHkoKQoreworICAgIHRlc3RXZWJr aXRBdGtDYXJldFdhbGsodGV4dEZvckNhcmV0SW5Cb2R5KTsKK30KKwogc3RhdGljIHZvaWQgdGVz dFdlYmtpdEF0a0NhcmV0T2Zmc2V0cygpCiB7CiAgICAgV2ViS2l0V2ViVmlldyogd2ViVmlldyA9 IFdFQktJVF9XRUJfVklFVyh3ZWJraXRfd2ViX3ZpZXdfbmV3KCkpOwpAQCAtMjAzLDYgKzI5Niw3 IEBACiAgICAgZ19hc3NlcnRfY21waW50KG9mZnNldCwgPT0sIDIpOwogCiAgICAgZ19mcmVlKHRl eHRDYXJldE1vdmVkUmVzdWx0KTsKKyAgICB0ZXh0Q2FyZXRNb3ZlZFJlc3VsdCA9IE5VTEw7CiAK ICAgICBnX29iamVjdF91bnJlZihwYXJhZ3JhcGgpOwogICAgIGdfb2JqZWN0X3VucmVmKGxpbmsp OwpAQCAtMTQ1NSw2ICsxNTQ5LDggQEAKICNlbmRpZgogCiAgICAgZ190ZXN0X2J1Z19iYXNlKCJo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy8iKTsKKyAgICBnX3Rlc3RfYWRkX2Z1bmMoIi93ZWJraXQv YXRrL2NhcmV0QUJsb2NrIiwgdGVzdFdlYmtpdEF0a0NhcmV0QUJsb2NrKTsKKyAgICBnX3Rlc3Rf YWRkX2Z1bmMoIi93ZWJraXQvYXRrL2NhcmV0SW5Cb2R5IiwgdGVzdFdlYmtpdEF0a0NhcmV0SW5C b2R5KTsKICAgICBnX3Rlc3RfYWRkX2Z1bmMoIi93ZWJraXQvYXRrL2NhcmV0T2Zmc2V0cyIsIHRl c3RXZWJraXRBdGtDYXJldE9mZnNldHMpOwogICAgIGdfdGVzdF9hZGRfZnVuYygiL3dlYmtpdC9h dGsvY2FyZXRPZmZzZXRzQW5kRXh0cmFub3VzV2hpdGVTcGFjZXMiLCB0ZXN0V2Via2l0QXRrQ2Fy ZXRPZmZzZXRzQW5kRXh0cmFub3VzV2hpdGVTcGFjZXMpOwogICAgIGdfdGVzdF9hZGRfZnVuYygi L3dlYmtpdC9hdGsvY29tYm9Cb3giLCB0ZXN0V2Via2l0QXRrQ29tYm9Cb3gpOwo=