131932 2014-04-21 02:30:28 -0700 Micro-optimize the way we hand NodeLists to JSC. 2014-04-21 11:21:47 -0700 1 1 1 Unclassified WebKit Bindings 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kling kling commit-queue esprehn+autocc ggaren kangil.han oldest_to_newest 1002517 0 kling 2014-04-21 02:30:28 -0700 Micro-optimize the way we hand NodeLists to JSC. 1002518 1 229795 kling 2014-04-21 02:30:57 -0700 Created attachment 229795 Patch 1002521 2 229795 commit-queue 2014-04-21 03:16:08 -0700 Comment on attachment 229795 Patch Clearing flags on attachment: 229795 Committed r167589: <http://trac.webkit.org/changeset/167589> 1002522 3 commit-queue 2014-04-21 03:16:13 -0700 All reviewed patches have been landed. Closing bug. 1002576 4 ggaren 2014-04-21 11:21:47 -0700 Can we call this "inlineAdd". "Fast" should never appear in any function names. 229795 2014-04-21 02:30:57 -0700 2014-04-21 03:16:08 -0700 Patch bug-131932.diff text/plain 3623 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA0YjBkYWE5Li5hZTcwOWNjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkg QEAKKzIwMTQtMDQtMjEgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgorCisgICAg ICAgIE1pY3JvLW9wdGltaXplIHRoZSB3YXkgd2UgaGFuZCBOb2RlTGlzdHMgdG8gSlNDLgorICAg ICAgICA8aHR0cHM6Ly93ZWJraXQub3JnL2IvMTMxOTMyPgorCisgICAgICAgIFVzZSBIYXNoTWFw OjpmYXN0QWRkKCkgd2hlbiByZXR1cm5pbmcgY2FjaGVkIG5vZGUgbGlzdHMgYW5kIGNvbGxlY3Rp b25zLgorICAgICAgICAxMC45JSBwcm9ncmVzc2lvbiBvbiBCaW5kaW5ncy9nZXQtZWxlbWVudHMt YnktdGFnLW5hbWUuaHRtbAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgICogZG9tL05vZGVSYXJlRGF0YS5oOgorICAgICAgICAoV2ViQ29yZTo6Tm9kZUxp c3RzTm9kZURhdGE6OmFkZENhY2hlV2l0aEF0b21pY05hbWUpOgorICAgICAgICAoV2ViQ29yZTo6 Tm9kZUxpc3RzTm9kZURhdGE6OmFkZENhY2hlV2l0aE5hbWUpOgorICAgICAgICAoV2ViQ29yZTo6 Tm9kZUxpc3RzTm9kZURhdGE6OmFkZENhY2hlV2l0aFF1YWxpZmllZE5hbWUpOgorICAgICAgICAo V2ViQ29yZTo6Tm9kZUxpc3RzTm9kZURhdGE6OmFkZENhY2hlZENvbGxlY3Rpb24pOgorCiAyMDE0 LTA0LTIxICBDb21taXQgUXVldWUgIDxjb21taXQtcXVldWVAd2Via2l0Lm9yZz4KIAogICAgICAg ICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMTY3NTg0LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvZG9tL05vZGVSYXJlRGF0YS5oIGIvU291cmNlL1dlYkNvcmUvZG9tL05vZGVSYXJlRGF0 YS5oCmluZGV4IDk5MjQ1ZDYuLjZkMDIyMzEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Rv bS9Ob2RlUmFyZURhdGEuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vTm9kZVJhcmVEYXRhLmgK QEAgLTEyMCw3ICsxMjAsNyBAQCBwdWJsaWM6CiAgICAgdGVtcGxhdGU8dHlwZW5hbWUgVCwgdHlw ZW5hbWUgQ29udGFpbmVyVHlwZT4KICAgICBQYXNzUmVmPFQ+IGFkZENhY2hlV2l0aEF0b21pY05h bWUoQ29udGFpbmVyVHlwZSYgY29udGFpbmVyLCBjb25zdCBBdG9taWNTdHJpbmcmIG5hbWUpCiAg ICAgewotICAgICAgICBOb2RlTGlzdEF0b21pY05hbWVDYWNoZU1hcDo6QWRkUmVzdWx0IHJlc3Vs dCA9IG1fYXRvbWljTmFtZUNhY2hlcy5hZGQobmFtZWROb2RlTGlzdEtleTxUPihuYW1lKSwgbnVs bHB0cik7CisgICAgICAgIE5vZGVMaXN0QXRvbWljTmFtZUNhY2hlTWFwOjpBZGRSZXN1bHQgcmVz dWx0ID0gbV9hdG9taWNOYW1lQ2FjaGVzLmZhc3RBZGQobmFtZWROb2RlTGlzdEtleTxUPihuYW1l KSwgbnVsbHB0cik7CiAgICAgICAgIGlmICghcmVzdWx0LmlzTmV3RW50cnkpCiAgICAgICAgICAg ICByZXR1cm4gc3RhdGljX2Nhc3Q8VCY+KCpyZXN1bHQuaXRlcmF0b3ItPnZhbHVlKTsKIApAQCAt MTMyLDcgKzEzMiw3IEBAIHB1YmxpYzoKICAgICB0ZW1wbGF0ZTx0eXBlbmFtZSBUPgogICAgIFBh c3NSZWY8VD4gYWRkQ2FjaGVXaXRoTmFtZShDb250YWluZXJOb2RlJiBub2RlLCBjb25zdCBTdHJp bmcmIG5hbWUpCiAgICAgewotICAgICAgICBOb2RlTGlzdE5hbWVDYWNoZU1hcDo6QWRkUmVzdWx0 IHJlc3VsdCA9IG1fbmFtZUNhY2hlcy5hZGQobmFtZWROb2RlTGlzdEtleTxUPihuYW1lKSwgbnVs bHB0cik7CisgICAgICAgIE5vZGVMaXN0TmFtZUNhY2hlTWFwOjpBZGRSZXN1bHQgcmVzdWx0ID0g bV9uYW1lQ2FjaGVzLmZhc3RBZGQobmFtZWROb2RlTGlzdEtleTxUPihuYW1lKSwgbnVsbHB0cik7 CiAgICAgICAgIGlmICghcmVzdWx0LmlzTmV3RW50cnkpCiAgICAgICAgICAgICByZXR1cm4gc3Rh dGljX2Nhc3Q8VCY+KCpyZXN1bHQuaXRlcmF0b3ItPnZhbHVlKTsKIApAQCAtMTQ0LDcgKzE0NCw3 IEBAIHB1YmxpYzoKICAgICBQYXNzUmVmPFRhZ05vZGVMaXN0PiBhZGRDYWNoZVdpdGhRdWFsaWZp ZWROYW1lKENvbnRhaW5lck5vZGUmIG5vZGUsIGNvbnN0IEF0b21pY1N0cmluZyYgbmFtZXNwYWNl VVJJLCBjb25zdCBBdG9taWNTdHJpbmcmIGxvY2FsTmFtZSkKICAgICB7CiAgICAgICAgIFF1YWxp ZmllZE5hbWUgbmFtZShudWxsQXRvbSwgbG9jYWxOYW1lLCBuYW1lc3BhY2VVUkkpOwotICAgICAg ICBUYWdOb2RlTGlzdENhY2hlTlM6OkFkZFJlc3VsdCByZXN1bHQgPSBtX3RhZ05vZGVMaXN0Q2Fj aGVOUy5hZGQobmFtZSwgbnVsbHB0cik7CisgICAgICAgIFRhZ05vZGVMaXN0Q2FjaGVOUzo6QWRk UmVzdWx0IHJlc3VsdCA9IG1fdGFnTm9kZUxpc3RDYWNoZU5TLmZhc3RBZGQobmFtZSwgbnVsbHB0 cik7CiAgICAgICAgIGlmICghcmVzdWx0LmlzTmV3RW50cnkpCiAgICAgICAgICAgICByZXR1cm4g KnJlc3VsdC5pdGVyYXRvci0+dmFsdWU7CiAKQEAgLTE1Niw3ICsxNTYsNyBAQCBwdWJsaWM6CiAg ICAgdGVtcGxhdGU8dHlwZW5hbWUgVCwgdHlwZW5hbWUgQ29udGFpbmVyVHlwZT4KICAgICBQYXNz UmVmPFQ+IGFkZENhY2hlZENvbGxlY3Rpb24oQ29udGFpbmVyVHlwZSYgY29udGFpbmVyLCBDb2xs ZWN0aW9uVHlwZSBjb2xsZWN0aW9uVHlwZSwgY29uc3QgQXRvbWljU3RyaW5nJiBuYW1lKQogICAg IHsKLSAgICAgICAgQ29sbGVjdGlvbkNhY2hlTWFwOjpBZGRSZXN1bHQgcmVzdWx0ID0gbV9jYWNo ZWRDb2xsZWN0aW9ucy5hZGQobmFtZWRDb2xsZWN0aW9uS2V5KGNvbGxlY3Rpb25UeXBlLCBuYW1l KSwgbnVsbHB0cik7CisgICAgICAgIENvbGxlY3Rpb25DYWNoZU1hcDo6QWRkUmVzdWx0IHJlc3Vs dCA9IG1fY2FjaGVkQ29sbGVjdGlvbnMuZmFzdEFkZChuYW1lZENvbGxlY3Rpb25LZXkoY29sbGVj dGlvblR5cGUsIG5hbWUpLCBudWxscHRyKTsKICAgICAgICAgaWYgKCFyZXN1bHQuaXNOZXdFbnRy eSkKICAgICAgICAgICAgIHJldHVybiBzdGF0aWNfY2FzdDxUJj4oKnJlc3VsdC5pdGVyYXRvci0+ dmFsdWUpOwogCkBAIC0xNjgsNyArMTY4LDcgQEAgcHVibGljOgogICAgIHRlbXBsYXRlPHR5cGVu YW1lIFQsIHR5cGVuYW1lIENvbnRhaW5lclR5cGU+CiAgICAgUGFzc1JlZjxUPiBhZGRDYWNoZWRD b2xsZWN0aW9uKENvbnRhaW5lclR5cGUmIGNvbnRhaW5lciwgQ29sbGVjdGlvblR5cGUgY29sbGVj dGlvblR5cGUpCiAgICAgewotICAgICAgICBDb2xsZWN0aW9uQ2FjaGVNYXA6OkFkZFJlc3VsdCBy ZXN1bHQgPSBtX2NhY2hlZENvbGxlY3Rpb25zLmFkZChuYW1lZENvbGxlY3Rpb25LZXkoY29sbGVj dGlvblR5cGUsIHN0YXJBdG9tKSwgbnVsbHB0cik7CisgICAgICAgIENvbGxlY3Rpb25DYWNoZU1h cDo6QWRkUmVzdWx0IHJlc3VsdCA9IG1fY2FjaGVkQ29sbGVjdGlvbnMuZmFzdEFkZChuYW1lZENv bGxlY3Rpb25LZXkoY29sbGVjdGlvblR5cGUsIHN0YXJBdG9tKSwgbnVsbHB0cik7CiAgICAgICAg IGlmICghcmVzdWx0LmlzTmV3RW50cnkpCiAgICAgICAgICAgICByZXR1cm4gc3RhdGljX2Nhc3Q8 VCY+KCpyZXN1bHQuaXRlcmF0b3ItPnZhbHVlKTsKIAo=