131916 2014-04-20 11:01:56 -0700 iOS and non-iOS RemoteCommandListener::create() functions should use std::make_unique<>() 2014-04-21 03:49:41 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zan zan darin oldest_to_newest 1002405 0 zan 2014-04-20 11:01:56 -0700 iOS and non-iOS RemoteCommandListener::create() functions should use std::make_unique<>() 1002406 1 229770 zan 2014-04-20 11:07:11 -0700 Created attachment 229770 Patch 1002440 2 229770 darin 2014-04-20 19:45:57 -0700 Comment on attachment 229770 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=229770&action=review I guess this is OK. It does seem slightly unsafe that the constructor is public given that it would be incorrect to use it on iOS, but still better than a “naked new”. > Source/WebCore/platform/RemoteCommandListener.h:42 > + RemoteCommandListener(RemoteCommandListenerClient& client) : m_client(client) { }; No semicolon needed. 1002523 3 zan 2014-04-21 03:49:41 -0700 Committed r167590: <http://trac.webkit.org/changeset/167590> 229770 2014-04-20 11:07:11 -0700 2014-04-20 19:45:56 -0700 Patch bug-131916-20140420110647.patch text/plain 3062 zan SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2NzU2OCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDE0LTA0LTIwICBaYW4gRG9i ZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KKworICAgICAgICBpT1MgYW5kIG5vbi1pT1Mg UmVtb3RlQ29tbWFuZExpc3RlbmVyOjpjcmVhdGUoKSBmdW5jdGlvbnMgc2hvdWxkIHVzZSBzdGQ6 Om1ha2VfdW5pcXVlPD4oKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTMxOTE2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgQSBmb2xsb3ctdXAgdG8gcjE2NzE5Ny4gTWFrZSBSZW1vdGVDb21tYW5kTGlzdGVu ZXIgY3RvciBwdWJsaWMgYW5kIHVzZSBzdGQ6Om1ha2VfdW5pcXVlPD4oKQorICAgICAgICBpbiBi b3RoIHZlcnNpb25zIG9mIFJlbW90ZUNvbW1hbmRMaXN0ZW5lcjo6Y3JlYXRlKCkgZnVuY3Rpb25z IChpT1MgYW5kIG5vbi1pT1MpLgorCisgICAgICAgICogcGxhdGZvcm0vUmVtb3RlQ29tbWFuZExp c3RlbmVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbW90ZUNvbW1hbmRMaXN0ZW5lcjo6Y3Jl YXRlKToKKyAgICAgICAgKiBwbGF0Zm9ybS9SZW1vdGVDb21tYW5kTGlzdGVuZXIuaDoKKyAgICAg ICAgKFdlYkNvcmU6OlJlbW90ZUNvbW1hbmRMaXN0ZW5lcjo6UmVtb3RlQ29tbWFuZExpc3RlbmVy KToKKyAgICAgICAgKiBwbGF0Zm9ybS9pb3MvUmVtb3RlQ29tbWFuZExpc3RlbmVySU9TLm1tOgor ICAgICAgICAoV2ViQ29yZTo6UmVtb3RlQ29tbWFuZExpc3RlbmVyOjpjcmVhdGUpOgorCiAyMDE0 LTA0LTIwICBBbnR0aSBLb2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KIAogICAgICAgICBUZXh0 IGJvdW5kaW5nIGJveCBjb21wdXRhdGlvbiBmb3Igc2ltcGxlIGxpbmUgbGF5b3V0IGlzIHdyb25n CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9SZW1vdGVDb21tYW5kTGlzdGVuZXIuY3Bw Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1JlbW90ZUNvbW1hbmRMaXN0 ZW5lci5jcHAJKHJldmlzaW9uIDE2NzU2NikKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1Jl bW90ZUNvbW1hbmRMaXN0ZW5lci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTMxLDcgKzMxLDcgQEAg bmFtZXNwYWNlIFdlYkNvcmUgewogI2lmICFQTEFURk9STShJT1MpCiBzdGQ6OnVuaXF1ZV9wdHI8 UmVtb3RlQ29tbWFuZExpc3RlbmVyPiBSZW1vdGVDb21tYW5kTGlzdGVuZXI6OmNyZWF0ZShSZW1v dGVDb21tYW5kTGlzdGVuZXJDbGllbnQmIGNsaWVudCkKIHsKLSAgICByZXR1cm4gc3RkOjp1bmlx dWVfcHRyPFJlbW90ZUNvbW1hbmRMaXN0ZW5lcj4obmV3IFJlbW90ZUNvbW1hbmRMaXN0ZW5lcihj bGllbnQpKTsKKyAgICByZXR1cm4gc3RkOjptYWtlX3VuaXF1ZTxSZW1vdGVDb21tYW5kTGlzdGVu ZXI+KGNsaWVudCk7CiB9CiAjZW5kaWYKIApJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v UmVtb3RlQ29tbWFuZExpc3RlbmVyLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vUmVtb3RlQ29tbWFuZExpc3RlbmVyLmgJKHJldmlzaW9uIDE2NzU2NikKKysrIFNvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL1JlbW90ZUNvbW1hbmRMaXN0ZW5lci5oCSh3b3JraW5nIGNvcHkp CkBAIC0zOSwxMSArMzksMTAgQEAgcHVibGljOgogY2xhc3MgUmVtb3RlQ29tbWFuZExpc3RlbmVy IHsKIHB1YmxpYzoKICAgICBzdGF0aWMgc3RkOjp1bmlxdWVfcHRyPFJlbW90ZUNvbW1hbmRMaXN0 ZW5lcj4gY3JlYXRlKFJlbW90ZUNvbW1hbmRMaXN0ZW5lckNsaWVudCYpOworICAgIFJlbW90ZUNv bW1hbmRMaXN0ZW5lcihSZW1vdGVDb21tYW5kTGlzdGVuZXJDbGllbnQmIGNsaWVudCkgOiBtX2Ns aWVudChjbGllbnQpIHsgfTsKICAgICB2aXJ0dWFsIH5SZW1vdGVDb21tYW5kTGlzdGVuZXIoKSB7 IH0KIAogcHJvdGVjdGVkOgotICAgIFJlbW90ZUNvbW1hbmRMaXN0ZW5lcihSZW1vdGVDb21tYW5k TGlzdGVuZXJDbGllbnQmIGNsaWVudCkgOiBtX2NsaWVudChjbGllbnQpIHsgfTsKLQogICAgIFJl bW90ZUNvbW1hbmRMaXN0ZW5lckNsaWVudCYgbV9jbGllbnQ7CiB9OwogCkluZGV4OiBTb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9pb3MvUmVtb3RlQ29tbWFuZExpc3RlbmVySU9TLm1tCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2lvcy9SZW1vdGVDb21tYW5kTGlzdGVuZXJJ T1MubW0JKHJldmlzaW9uIDE2NzU2NikKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2lvcy9S ZW1vdGVDb21tYW5kTGlzdGVuZXJJT1MubW0JKHdvcmtpbmcgY29weSkKQEAgLTQxLDcgKzQxLDcg QEAgbmFtZXNwYWNlIFdlYkNvcmUgewogCiBzdGQ6OnVuaXF1ZV9wdHI8UmVtb3RlQ29tbWFuZExp c3RlbmVyPiBSZW1vdGVDb21tYW5kTGlzdGVuZXI6OmNyZWF0ZShSZW1vdGVDb21tYW5kTGlzdGVu ZXJDbGllbnQmIGNsaWVudCkKIHsKLSAgICByZXR1cm4gc3RkOjp1bmlxdWVfcHRyPFJlbW90ZUNv bW1hbmRMaXN0ZW5lcj4obmV3IFJlbW90ZUNvbW1hbmRMaXN0ZW5lcklPUyhjbGllbnQpKTsKKyAg ICByZXR1cm4gc3RkOjptYWtlX3VuaXF1ZTxSZW1vdGVDb21tYW5kTGlzdGVuZXJJT1M+KGNsaWVu dCk7CiB9CiAKIFJlbW90ZUNvbW1hbmRMaXN0ZW5lcklPUzo6UmVtb3RlQ29tbWFuZExpc3RlbmVy SU9TKFJlbW90ZUNvbW1hbmRMaXN0ZW5lckNsaWVudCYgY2xpZW50KQo=