131908 2014-04-19 22:17:48 -0700 [Mac] Unable to select 'Off' or 'Auto' from track menu when tracks consist of unsupported track types 2014-04-20 21:28:59 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 bfulgham bfulgham bfulgham calvaris commit-queue eric.carlson esprehn+autocc glenn gyuyoung.kim jer.noble philipj sergio oldest_to_newest 1002342 0 bfulgham 2014-04-19 22:17:48 -0700 When Webkit is asked to display a media track menu with out-of-band tracks of an unsupported track type (e.g., TTML), you are not able to select the 'Off' menu item. There is no user-visible impact here (since the track doesn't display whether it is selected or not), but it's unexpected behavior to select the 'Off' menu element, but for the menu to not show an 'Off' checked state. 1002343 1 229756 bfulgham 2014-04-19 22:21:22 -0700 Created attachment 229756 Patch 1002344 2 229756 bfulgham 2014-04-19 22:21:59 -0700 Comment on attachment 229756 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=229756&action=review > Source/WebCore/html/HTMLMediaElement.cpp:3717 > + } else if (trackToSelect == TextTrack::captionMenuOffItem()) { I'm not sure if this would be better to just incorporate into the loop above? 1002444 3 229756 eric.carlson 2014-04-20 20:23:29 -0700 Comment on attachment 229756 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=229756&action=review > Source/WebCore/ChangeLog:10 > + (WebCore::HTMLMediaElement::parseAttribute): When the user selects 'Off', make sure the currently 'showing' prepare-ChangeLog doesn't like something about HTMLMediaElement.cpp so it thinks all changes are in parseAttribute, so you should fix this entry manually. >> Source/WebCore/html/HTMLMediaElement.cpp:3717 >> + } else if (trackToSelect == TextTrack::captionMenuOffItem()) { > > I'm not sure if this would be better to just incorporate into the loop above? It could be, but I think it is probably easier to follow the logic this way. > Source/WebCore/html/HTMLMediaElement.cpp:3720 > + if (!trackToSelect || track != trackToSelect) trackToSelect is TextTrack::captionMenuOffItem so it can't be NULL, and TextTrack::captionMenuOffItem won't be in textTracks(), so this check can be removed. 1002460 4 bfulgham 2014-04-20 21:28:59 -0700 Committed r167578: <http://trac.webkit.org/changeset/167578> 229756 2014-04-19 22:21:22 -0700 2014-04-20 20:23:28 -0700 Patch bug-131908-20140419222102.patch text/plain 1693 bfulgham SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2NzU2MykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE0LTA0LTE5ICBCcmVudCBG dWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIFtNYWNdIFVuYWJsZSB0byBz ZWxlY3QgJ09mZicgb3IgJ0F1dG8nIGZyb20gdHJhY2sgbWVudSB3aGVuIHRyYWNrcyBjb25zaXN0 IG9mIHVuc3VwcG9ydGVkIHRyYWNrIHR5cGVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xMzE5MDgKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzE1OTk5 ODgyPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog aHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxNZWRpYUVs ZW1lbnQ6OnBhcnNlQXR0cmlidXRlKTogV2hlbiB0aGUgdXNlciBzZWxlY3RzICdPZmYnLCBtYWtl IHN1cmUgdGhlIGN1cnJlbnRseSAnc2hvd2luZycKKyAgICAgICAgdHJhY2sgaXMgc3dpdGNoZWQg dG8gJ2Rpc2FibGVkJy4KKwogMjAxNC0wNC0xOSAgWmFsYW4gQnVqdGFzICA8emFsYW5AYXBwbGUu Y29tPgogCiAgICAgICAgIFN1YnBpeGVsIHJlbmRlcmluZzogUmVuZGVyTGF5ZXIncyBjbGlwcGlu ZyBzaG91bGQgc25hcCB0byBkZXZpY2UgcGl4ZWwgYm91bmRhcmllcy4KSW5kZXg6IFNvdXJjZS9X ZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dl YkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcAkocmV2aXNpb24gMTY3NTYyKQorKysgU291 cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcAkod29ya2luZyBjb3B5KQpAQCAt MzcxNCw2ICszNzE0LDEyIEBAIHZvaWQgSFRNTE1lZGlhRWxlbWVudDo6c2V0U2VsZWN0ZWRUZXh0 VHIKICAgICAgICAgICAgIGVsc2UKICAgICAgICAgICAgICAgICB0cmFjay0+c2V0TW9kZShUZXh0 VHJhY2s6OnNob3dpbmdLZXl3b3JkKCkpOwogICAgICAgICB9CisgICAgfSBlbHNlIGlmICh0cmFj a1RvU2VsZWN0ID09IFRleHRUcmFjazo6Y2FwdGlvbk1lbnVPZmZJdGVtKCkpIHsKKyAgICAgICAg Zm9yIChpbnQgaSA9IDAsIGxlbmd0aCA9IHRyYWNrTGlzdC0+bGVuZ3RoKCk7IGkgPCBsZW5ndGg7 ICsraSkgeworICAgICAgICAgICAgVGV4dFRyYWNrKiB0cmFjayA9IHRyYWNrTGlzdC0+aXRlbShp KTsKKyAgICAgICAgICAgIGlmICghdHJhY2tUb1NlbGVjdCB8fCB0cmFjayAhPSB0cmFja1RvU2Vs ZWN0KQorICAgICAgICAgICAgICAgIHRyYWNrLT5zZXRNb2RlKFRleHRUcmFjazo6ZGlzYWJsZWRL ZXl3b3JkKCkpOworICAgICAgICB9CiAgICAgfQogCiAgICAgQ2FwdGlvblVzZXJQcmVmZXJlbmNl cyogY2FwdGlvblByZWZlcmVuY2VzID0gZG9jdW1lbnQoKS5wYWdlKCkgPyBkb2N1bWVudCgpLnBh Z2UoKS0+Z3JvdXAoKS5jYXB0aW9uUHJlZmVyZW5jZXMoKSA6IDA7Cg==