131900 2014-04-19 14:01:45 -0700 Make it easier to check if an integer sum would overflow 2014-04-19 14:14:31 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 130684 1 fpizlo fpizlo barraclough benjamin cmarcelo commit-queue darin ggaren mark.lam mhahnenberg msaboff oliver sam oldest_to_newest 1002268 0 fpizlo 2014-04-19 14:01:45 -0700 Patch forthcoming. 1002269 1 229746 fpizlo 2014-04-19 14:04:42 -0700 Created attachment 229746 the patch 1002273 2 fpizlo 2014-04-19 14:14:31 -0700 Landed in http://trac.webkit.org/changeset/167548 229746 2014-04-19 14:04:42 -0700 2014-04-19 14:09:39 -0700 the patch blah.patch text/plain 4539 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTY3NTQ2KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBA CisyMDE0LTA0LTE5ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg TWFrZSBpdCBlYXNpZXIgdG8gY2hlY2sgaWYgYW4gaW50ZWdlciBzdW0gd291bGQgb3ZlcmZsb3cK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMTkwMAor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogZGZnL0RG R09wZXJhdGlvbnMuY3BwOgorICAgICAgICAqIHJ1bnRpbWUvT3BlcmF0aW9ucy5oOgorICAgICAg ICAoSlNDOjpqc1N0cmluZyk6CisKIDIwMTQtMDQtMTkgIEZpbGlwIFBpemxvICA8ZnBpemxvQGFw cGxlLmNvbT4KIAogICAgICAgICBBZGRyZXNzIHNvbWUgZmVlZGJhY2sgb24gaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMDY4NC4KSW5kZXg6IFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9kZmcvREZHT3BlcmF0aW9ucy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFT Y3JpcHRDb3JlL2RmZy9ERkdPcGVyYXRpb25zLmNwcAkocmV2aXNpb24gMTY3NTQ0KQorKysgU291 cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdPcGVyYXRpb25zLmNwcAkod29ya2luZyBjb3B5KQpA QCAtOTY4LDggKzk2OCw4IEBAIEpTQ2VsbCogSklUX09QRVJBVElPTiBvcGVyYXRpb25NYWtlUm9w ZTIKIHsKICAgICBWTSYgdm0gPSBleGVjLT52bSgpOwogICAgIE5hdGl2ZUNhbGxGcmFtZVRyYWNl ciB0cmFjZXIoJnZtLCBleGVjKTsKLSAgICAKLSAgICBpZiAoc3RhdGljX2Nhc3Q8aW50MzJfdD4o bGVmdC0+bGVuZ3RoKCkgKyByaWdodC0+bGVuZ3RoKCkpIDwgMCkgeworCisgICAgaWYgKHN1bU92 ZXJmbG93czxpbnQzMl90PihsZWZ0LT5sZW5ndGgoKSwgcmlnaHQtPmxlbmd0aCgpKSkgewogICAg ICAgICB0aHJvd091dE9mTWVtb3J5RXJyb3IoZXhlYyk7CiAgICAgICAgIHJldHVybiBudWxscHRy OwogICAgIH0KQEAgLTk4MiwxMCArOTgyLDcgQEAgSlNDZWxsKiBKSVRfT1BFUkFUSU9OIG9wZXJh dGlvbk1ha2VSb3BlMwogICAgIFZNJiB2bSA9IGV4ZWMtPnZtKCk7CiAgICAgTmF0aXZlQ2FsbEZy YW1lVHJhY2VyIHRyYWNlcigmdm0sIGV4ZWMpOwogCi0gICAgQ2hlY2tlZDxpbnQzMl90LCBSZWNv cmRPdmVyZmxvdz4gbGVuZ3RoID0gYS0+bGVuZ3RoKCk7Ci0gICAgbGVuZ3RoICs9IGItPmxlbmd0 aCgpOwotICAgIGxlbmd0aCArPSBjLT5sZW5ndGgoKTsKLSAgICBpZiAobGVuZ3RoLmhhc092ZXJm bG93ZWQoKSkgeworICAgIGlmIChzdW1PdmVyZmxvd3M8aW50MzJfdD4oYS0+bGVuZ3RoKCksIGIt Pmxlbmd0aCgpLCBjLT5sZW5ndGgoKSkpIHsKICAgICAgICAgdGhyb3dPdXRPZk1lbW9yeUVycm9y KGV4ZWMpOwogICAgICAgICByZXR1cm4gbnVsbHB0cjsKICAgICB9CkluZGV4OiBTb3VyY2UvSmF2 YVNjcmlwdENvcmUvcnVudGltZS9PcGVyYXRpb25zLmgKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0ph dmFTY3JpcHRDb3JlL3J1bnRpbWUvT3BlcmF0aW9ucy5oCShyZXZpc2lvbiAxNjc1NDIpCisrKyBT b3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9PcGVyYXRpb25zLmgJKHdvcmtpbmcgY29weSkK QEAgLTQ0LDcgKzQ0LDcgQEAgQUxXQVlTX0lOTElORSBKU1ZhbHVlIGpzU3RyaW5nKEV4ZWNTdGF0 ZQogICAgIGludDMyX3QgbGVuZ3RoMiA9IHMyLT5sZW5ndGgoKTsKICAgICBpZiAoIWxlbmd0aDIp CiAgICAgICAgIHJldHVybiBzMTsKLSAgICBpZiAoKGxlbmd0aDEgKyBsZW5ndGgyKSA8IDApCisg ICAgaWYgKHN1bU92ZXJmbG93czxpbnQzMl90PihsZW5ndGgxLCBsZW5ndGgyKSkKICAgICAgICAg cmV0dXJuIHRocm93T3V0T2ZNZW1vcnlFcnJvcihleGVjKTsKIAogICAgIHJldHVybiBKU1JvcGVT dHJpbmc6OmNyZWF0ZSh2bSwgczEsIHMyKTsKQEAgLTY4LDkgKzY4LDcgQEAgQUxXQVlTX0lOTElO RSBKU1ZhbHVlIGpzU3RyaW5nKEV4ZWNTdGF0ZQogICAgIGlmICghbGVuZ3RoMykKICAgICAgICAg cmV0dXJuIGpzU3RyaW5nKGV4ZWMsIGpzU3RyaW5nKHZtLCB1MSksIGpzU3RyaW5nKHZtLCB1Mikp OwogCi0gICAgaWYgKChsZW5ndGgxICsgbGVuZ3RoMikgPCAwKQotICAgICAgICByZXR1cm4gdGhy b3dPdXRPZk1lbW9yeUVycm9yKGV4ZWMpOwotICAgIGlmICgobGVuZ3RoMSArIGxlbmd0aDIgKyBs ZW5ndGgzKSA8IDApCisgICAgaWYgKHN1bU92ZXJmbG93czxpbnQzMl90PihsZW5ndGgxLCBsZW5n dGgyLCBsZW5ndGgzKSkKICAgICAgICAgcmV0dXJuIHRocm93T3V0T2ZNZW1vcnlFcnJvcihleGVj KTsKIAogICAgIHJldHVybiBKU1JvcGVTdHJpbmc6OmNyZWF0ZShleGVjLT52bSgpLCBqc1N0cmlu Zyh2bSwgdTEpLCBqc1N0cmluZyh2bSwgdTIpLCBqc1N0cmluZyh2bSwgdTMpKTsKSW5kZXg6IFNv dXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hhbmdlTG9nCShy ZXZpc2lvbiAxNjc1NDYpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDE0IEBACisyMDE0LTA0LTE5ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5j b20+CisKKyAgICAgICAgTWFrZSBpdCBlYXNpZXIgdG8gY2hlY2sgaWYgYW4gaW50ZWdlciBzdW0g d291bGQgb3ZlcmZsb3cKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTEzMTkwMAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgICogd3RmL0NoZWNrZWRBcml0aG1ldGljLmg6CisgICAgICAgIChXVEY6OmNoZWNrZWRT dW0pOgorICAgICAgICAoV1RGOjpzdW1PdmVyZmxvd3MpOgorCiAyMDE0LTA0LTE4ICBDb21taXQg UXVldWUgIDxjb21taXQtcXVldWVAd2Via2l0Lm9yZz4KIAogICAgICAgICBVbnJldmlld2VkLCBy b2xsaW5nIG91dCByMTY3NTI3LgpJbmRleDogU291cmNlL1dURi93dGYvQ2hlY2tlZEFyaXRobWV0 aWMuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV1RGL3d0Zi9DaGVja2VkQXJpdGhtZXRpYy5oCShy ZXZpc2lvbiAxNjc1NDIpCisrKyBTb3VyY2UvV1RGL3d0Zi9DaGVja2VkQXJpdGhtZXRpYy5oCSh3 b3JraW5nIGNvcHkpCkBAIC03MTYsNiArNzE2LDI1IEBAIHR5cGVkZWYgQ2hlY2tlZDxpbnQ2NF90 LCBSZWNvcmRPdmVyZmxvdz4KIHR5cGVkZWYgQ2hlY2tlZDx1aW50NjRfdCwgUmVjb3JkT3ZlcmZs b3c+IENoZWNrZWRVaW50NjQ7CiB0eXBlZGVmIENoZWNrZWQ8c2l6ZV90LCBSZWNvcmRPdmVyZmxv dz4gQ2hlY2tlZFNpemU7CiAKK3RlbXBsYXRlPHR5cGVuYW1lIFQsIHR5cGVuYW1lIFU+CitDaGVj a2VkPFQsIFJlY29yZE92ZXJmbG93PiBjaGVja2VkU3VtKFUgdmFsdWUpCit7CisgICAgcmV0dXJu IENoZWNrZWQ8VCwgUmVjb3JkT3ZlcmZsb3c+KHZhbHVlKTsKK30KK3RlbXBsYXRlPHR5cGVuYW1l IFQsIHR5cGVuYW1lIFUsIHR5cGVuYW1lLi4uIEFyZ3M+CitDaGVja2VkPFQsIFJlY29yZE92ZXJm bG93PiBjaGVja2VkU3VtKFUgdmFsdWUsIEFyZ3MuLi4gYXJncykKK3sKKyAgICByZXR1cm4gQ2hl Y2tlZDxULCBSZWNvcmRPdmVyZmxvdz4odmFsdWUpICsgY2hlY2tlZFN1bTxUPihhcmdzLi4uKTsK K30KKworLy8gU29tZXRpbWVzLCB5b3UganVzdCB3YW50IHRvIGNoZWNrIGlmIHNvbWUgbWF0aCB3 b3VsZCBvdmVyZmxvdyAtIHRoZSBjb2RlIHRvIGRvIHRoZSBtYXRoIGlzCisvLyBhbHJlYWR5IGlu IHBsYWNlLCBhbmQgeW91IHdhbnQgdG8gZ3VhcmQgaXQuCisKK3RlbXBsYXRlPHR5cGVuYW1lIFQs IHR5cGVuYW1lLi4uIEFyZ3M+IGJvb2wgc3VtT3ZlcmZsb3dzKEFyZ3MuLi4gYXJncykKK3sKKyAg ICByZXR1cm4gY2hlY2tlZFN1bTxUPihhcmdzLi4uKS5oYXNPdmVyZmxvd2VkKCk7Cit9CisKIH0K IAogdXNpbmcgV1RGOjpDaGVja2VkOwpAQCAtNzMwLDUgKzc0OSw3IEBAIHVzaW5nIFdURjo6Q2hl Y2tlZFVpbnQzMjsKIHVzaW5nIFdURjo6Q2hlY2tlZEludDY0OwogdXNpbmcgV1RGOjpDaGVja2Vk VWludDY0OwogdXNpbmcgV1RGOjpDaGVja2VkU2l6ZTsKK3VzaW5nIFdURjo6Y2hlY2tlZFN1bTsK K3VzaW5nIFdURjo6c3VtT3ZlcmZsb3dzOwogCiAjZW5kaWYK