131895 2014-04-19 13:48:03 -0700 bmalloc: Improved alignment in LargeChunk 2014-04-19 16:02:35 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ggaren ggaren kling sam oldest_to_newest 1002258 0 ggaren 2014-04-19 13:48:03 -0700 bmalloc: Improved alignment in LargeChunk 1002261 1 229744 ggaren 2014-04-19 13:49:51 -0700 Created attachment 229744 Patch 1002277 2 229744 kling 2014-04-19 14:37:54 -0700 Comment on attachment 229744 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=229744&action=review OK r=me > Source/bmalloc/ChangeLog:12 > + Techincally, the previous alignment was harmless, but I would prefer, > + dear reader, not to have to explain the interlocking set of > + circumstances that made it so. Typo, technically. 1002296 3 ggaren 2014-04-19 16:02:35 -0700 Committed r167554: <http://trac.webkit.org/changeset/167554> 229744 2014-04-19 13:49:51 -0700 2014-04-19 14:37:54 -0700 Patch bug-131895-20140419134929.patch text/plain 2113 ggaren SW5kZXg6IFNvdXJjZS9ibWFsbG9jL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvYm1h bGxvYy9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2NzU0NikKKysrIFNvdXJjZS9ibWFsbG9jL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE0LTA0LTE5ICBHZW9mZnJl eSBHYXJlbiAgPGdnYXJlbkBhcHBsZS5jb20+CisKKyAgICAgICAgYm1hbGxvYzogSW1wcm92ZWQg YWxpZ25tZW50IGluIExhcmdlQ2h1bmsKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTEzMTg5NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogYm1hbGxvYy9DaHVuay5oOgorICAgICAgICAqIGJtYWxsb2MvTGFy Z2VDaHVuay5oOiBBbGlnbiB0byB2bVBhZ2VTaXplIGp1c3QgbGlrZSBDaHVuayBkb2VzLgorICAg ICAgICBUZWNoaW5jYWxseSwgdGhlIHByZXZpb3VzIGFsaWdubWVudCB3YXMgaGFybWxlc3MsIGJ1 dCBJIHdvdWxkIHByZWZlciwKKyAgICAgICAgZGVhciByZWFkZXIsIG5vdCB0byBoYXZlIHRvIGV4 cGxhaW4gdGhlIGludGVybG9ja2luZyBzZXQgb2YKKyAgICAgICAgY2lyY3Vtc3RhbmNlcyB0aGF0 IG1hZGUgaXQgc28uCisKIDIwMTQtMDQtMTkgIEdlb2ZmcmV5IEdhcmVuICA8Z2dhcmVuQGFwcGxl LmNvbT4KIAogICAgICAgICBSb2xsZWQgb3V0IHIxNjc1MDIgYmVjYXVzZSBpdCBjYXVzZWQgYSBj cmFzaCBvbiB0aGUgZmFjZWJvb2sgYmVuY2htYXJrLgpJbmRleDogU291cmNlL2JtYWxsb2MvYm1h bGxvYy9DaHVuay5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9ibWFsbG9jL2JtYWxsb2MvQ2h1bmsu aAkocmV2aXNpb24gMTY3NTQ2KQorKysgU291cmNlL2JtYWxsb2MvYm1hbGxvYy9DaHVuay5oCSh3 b3JraW5nIGNvcHkpCkBAIC02Miw4ICs2Miw4IEBAIHByaXZhdGU6CiAgICAgUGFnZSBtX3BhZ2Vz W3BhZ2VDb3VudF07CiAKICAgICAvLyBBbGlnbiB0byB2bVBhZ2VTaXplIHRvIGF2b2lkIHNoYXJp bmcgcGh5c2ljYWwgcGFnZXMgd2l0aCBtZXRhZGF0YS4KLSAgICAvLyBPdGhlcndpc2UsIHdlJ2xs IGNvbmZ1c2UgdGhlIHNjYXZlbmdlciBpbnRvIHNjYXZlbmdpbmcgbWV0YWRhdGEuCi0gICAgIGFs aWduYXModm1QYWdlU2l6ZSkgY2hhciBtX21lbW9yeVtdOworICAgIC8vIE90aGVyd2lzZSwgd2Un bGwgY29uZnVzZSB0aGUgc2NhdmVuZ2VyIGludG8gdHJ5aW5nIHRvIHNjYXZlbmdlIG1ldGFkYXRh LgorICAgIGFsaWduYXModm1QYWdlU2l6ZSkgY2hhciBtX21lbW9yeVtdOwogfTsKIAogdGVtcGxh dGU8Y2xhc3MgVHJhaXRzPgpJbmRleDogU291cmNlL2JtYWxsb2MvYm1hbGxvYy9MYXJnZUNodW5r LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL2JtYWxsb2MvYm1hbGxvYy9MYXJnZUNodW5rLmgJKHJl dmlzaW9uIDE2NzU0NikKKysrIFNvdXJjZS9ibWFsbG9jL2JtYWxsb2MvTGFyZ2VDaHVuay5oCSh3 b3JraW5nIGNvcHkpCkBAIC02NCw3ICs2NCwxMCBAQCBwcml2YXRlOgogICAgIC8vIFdlIHVzZSB0 aGUgWCdzIGZvciBib3VuZGFyeSB0YWdzIGFuZCB0aGUgTydzIGZvciBlZGdlIHNlbnRpbmVscy4K IAogICAgIEJvdW5kYXJ5VGFnIG1fYm91bmRhcnlUYWdzW2JvdW5kYXJ5VGFnQ291bnRdOwotICAg IGFsaWduYXMobGFyZ2VBbGlnbm1lbnQpIGNoYXIgbV9tZW1vcnlbXTsKKworICAgIC8vIEFsaWdu IHRvIHZtUGFnZVNpemUgdG8gYXZvaWQgc2hhcmluZyBwaHlzaWNhbCBwYWdlcyB3aXRoIG1ldGFk YXRhLgorICAgIC8vIE90aGVyd2lzZSwgd2UnbGwgY29uZnVzZSB0aGUgc2NhdmVuZ2VyIGludG8g dHJ5aW5nIHRvIHNjYXZlbmdlIG1ldGFkYXRhLgorICAgIGFsaWduYXModm1QYWdlU2l6ZSkgY2hh ciBtX21lbW9yeVtdOwogfTsKIAogaW5saW5lIExhcmdlQ2h1bmsqIExhcmdlQ2h1bms6OmNyZWF0 ZSgpCg==