131892 2014-04-19 12:17:22 -0700 Slap ALWAYS_INLINE on Element attribute lookup things. 2014-04-19 13:41:10 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kling kling cmarcelo commit-queue esprehn+autocc kangil.han oldest_to_newest 1002238 0 kling 2014-04-19 12:17:22 -0700 Slap ALWAYS_INLINE on Element attribute lookup things. 1002239 1 229739 kling 2014-04-19 12:17:51 -0700 Created attachment 229739 Patch 1002245 2 229739 ggaren 2014-04-19 12:48:56 -0700 Comment on attachment 229739 Patch r=me These functions are pretty big. Is it really a win to inline them? 1002252 3 229739 commit-queue 2014-04-19 13:41:07 -0700 Comment on attachment 229739 Patch Clearing flags on attachment: 229739 Committed r167545: <http://trac.webkit.org/changeset/167545> 1002253 4 commit-queue 2014-04-19 13:41:10 -0700 All reviewed patches have been landed. Closing bug. 229739 2014-04-19 12:17:51 -0700 2014-04-19 13:41:06 -0700 Patch bug-131892.diff text/plain 4034 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAwMGJhZTA0Li43NzNmMGYwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkg QEAKKzIwMTQtMDQtMTkgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgorCisgICAg ICAgIFNsYXAgQUxXQVlTX0lOTElORSBvbiBFbGVtZW50IGF0dHJpYnV0ZSBsb29rdXAgdGhpbmdz LgorICAgICAgICA8aHR0cHM6Ly93ZWJraXQub3JnL2IvMTMxODkyPgorCisgICAgICAgIE1vc3Qg b2YgdGhlICJpbmxpbmUiIGhlbHBlcnMgZm9yIHNldHRpbmcvZ2V0dGluZyBhdHRyaWJ1dGVzIHdl cmUgbm90CisgICAgICAgIGFjdHVhbGx5IGdldHRpbmcgaW5saW5lZCBieSB0aGUgY29tcGlsZXIs IHNvIGxldCdzIG1ha2UgdGhhdCBoYXBwZW4uCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBkb20vRWxlbWVudC5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpFbGVtZW50OjpzeW5jaHJvbml6ZUF0dHJpYnV0ZSk6CisgICAgICAgICogZG9tL0VsZW1lbnRE YXRhLmg6CisgICAgICAgIChXZWJDb3JlOjpFbGVtZW50RGF0YTo6ZmluZEF0dHJpYnV0ZUJ5TmFt ZSk6CisgICAgICAgIChXZWJDb3JlOjpFbGVtZW50RGF0YTo6ZmluZEF0dHJpYnV0ZUluZGV4QnlO YW1lKToKKwogMjAxNC0wNC0xOCAgSm9uIEhvbmV5Y3V0dCAgPGpob25leWN1dHRAYXBwbGUuY29t PgogCiAgICAgICAgIEhhcmRlbiBSZW5kZXJJbmxpbmU6OmlubGluZUVsZW1lbnRDb250aW51YXRp b24oKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnQuY3BwIGIvU291cmNl L1dlYkNvcmUvZG9tL0VsZW1lbnQuY3BwCmluZGV4IGFjYjI0NmUuLjRmOGY5MzggMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9k b20vRWxlbWVudC5jcHAKQEAgLTM3Nyw3ICszNzcsNyBAQCB2b2lkIEVsZW1lbnQ6OnN5bmNocm9u aXplQWxsQXR0cmlidXRlcygpIGNvbnN0CiAgICAgfQogfQogCi1pbmxpbmUgdm9pZCBFbGVtZW50 OjpzeW5jaHJvbml6ZUF0dHJpYnV0ZShjb25zdCBRdWFsaWZpZWROYW1lJiBuYW1lKSBjb25zdAor QUxXQVlTX0lOTElORSB2b2lkIEVsZW1lbnQ6OnN5bmNocm9uaXplQXR0cmlidXRlKGNvbnN0IFF1 YWxpZmllZE5hbWUmIG5hbWUpIGNvbnN0CiB7CiAgICAgaWYgKCFlbGVtZW50RGF0YSgpKQogICAg ICAgICByZXR1cm47CkBAIC0zOTMsNyArMzkzLDcgQEAgaW5saW5lIHZvaWQgRWxlbWVudDo6c3lu Y2hyb25pemVBdHRyaWJ1dGUoY29uc3QgUXVhbGlmaWVkTmFtZSYgbmFtZSkgY29uc3QKICAgICB9 CiB9CiAKLWlubGluZSB2b2lkIEVsZW1lbnQ6OnN5bmNocm9uaXplQXR0cmlidXRlKGNvbnN0IEF0 b21pY1N0cmluZyYgbG9jYWxOYW1lKSBjb25zdAorQUxXQVlTX0lOTElORSB2b2lkIEVsZW1lbnQ6 OnN5bmNocm9uaXplQXR0cmlidXRlKGNvbnN0IEF0b21pY1N0cmluZyYgbG9jYWxOYW1lKSBjb25z dAogewogICAgIC8vIFRoaXMgdmVyc2lvbiBvZiBzeW5jaHJvbml6ZUF0dHJpYnV0ZSgpIGlzIHN0 cmVhbWxpbmVkIGZvciB0aGUgY2FzZSB3aGVyZSB5b3UgZG9uJ3QgaGF2ZSBhIGZ1bGwgUXVhbGlm aWVkTmFtZSwKICAgICAvLyBlLmcgd2hlbiBjYWxsZWQgZnJvbSBET00gQVBJLgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnREYXRhLmggYi9Tb3VyY2UvV2ViQ29yZS9kb20v RWxlbWVudERhdGEuaAppbmRleCBlMDY4MTkyLi45ODYwMjllIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9kb20vRWxlbWVudERhdGEuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVu dERhdGEuaApAQCAtMjYyLDcgKzI2Miw3IEBAIGlubGluZSBBdHRyaWJ1dGVJdGVyYXRvckFjY2Vz c29yIEVsZW1lbnREYXRhOjphdHRyaWJ1dGVzSXRlcmF0b3IoKSBjb25zdAogICAgIHJldHVybiBB dHRyaWJ1dGVJdGVyYXRvckFjY2Vzc29yKHN0YXRpY19jYXN0PGNvbnN0IFNoYXJlYWJsZUVsZW1l bnREYXRhKj4odGhpcyktPm1fYXR0cmlidXRlQXJyYXksIGFycmF5U2l6ZSgpKTsKIH0KIAotaW5s aW5lIGNvbnN0IEF0dHJpYnV0ZSogRWxlbWVudERhdGE6OmZpbmRBdHRyaWJ1dGVCeU5hbWUoY29u c3QgQXRvbWljU3RyaW5nJiBuYW1lLCBib29sIHNob3VsZElnbm9yZUF0dHJpYnV0ZUNhc2UpIGNv bnN0CitBTFdBWVNfSU5MSU5FIGNvbnN0IEF0dHJpYnV0ZSogRWxlbWVudERhdGE6OmZpbmRBdHRy aWJ1dGVCeU5hbWUoY29uc3QgQXRvbWljU3RyaW5nJiBuYW1lLCBib29sIHNob3VsZElnbm9yZUF0 dHJpYnV0ZUNhc2UpIGNvbnN0CiB7CiAgICAgdW5zaWduZWQgaW5kZXggPSBmaW5kQXR0cmlidXRl SW5kZXhCeU5hbWUobmFtZSwgc2hvdWxkSWdub3JlQXR0cmlidXRlQ2FzZSk7CiAgICAgaWYgKGlu ZGV4ICE9IGF0dHJpYnV0ZU5vdEZvdW5kKQpAQCAtMjcwLDcgKzI3MCw3IEBAIGlubGluZSBjb25z dCBBdHRyaWJ1dGUqIEVsZW1lbnREYXRhOjpmaW5kQXR0cmlidXRlQnlOYW1lKGNvbnN0IEF0b21p Y1N0cmluZyYgbmFtCiAgICAgcmV0dXJuIDA7CiB9CiAKLWlubGluZSB1bnNpZ25lZCBFbGVtZW50 RGF0YTo6ZmluZEF0dHJpYnV0ZUluZGV4QnlOYW1lKGNvbnN0IFF1YWxpZmllZE5hbWUmIG5hbWUp IGNvbnN0CitBTFdBWVNfSU5MSU5FIHVuc2lnbmVkIEVsZW1lbnREYXRhOjpmaW5kQXR0cmlidXRl SW5kZXhCeU5hbWUoY29uc3QgUXVhbGlmaWVkTmFtZSYgbmFtZSkgY29uc3QKIHsKICAgICBjb25z dCBBdHRyaWJ1dGUqIGF0dHJpYnV0ZXMgPSBhdHRyaWJ1dGVCYXNlKCk7CiAgICAgZm9yICh1bnNp Z25lZCBpID0gMCwgY291bnQgPSBsZW5ndGgoKTsgaSA8IGNvdW50OyArK2kpIHsKQEAgLTI4Miw3 ICsyODIsNyBAQCBpbmxpbmUgdW5zaWduZWQgRWxlbWVudERhdGE6OmZpbmRBdHRyaWJ1dGVJbmRl eEJ5TmFtZShjb25zdCBRdWFsaWZpZWROYW1lJiBuYW1lKQogCiAvLyBXZSB1c2UgYSBib29sZWFu IHBhcmFtZXRlciBpbnN0ZWFkIG9mIGNhbGxpbmcgc2hvdWxkSWdub3JlQXR0cmlidXRlQ2FzZSBz byB0aGF0IHRoZSBjYWxsZXIKIC8vIGNhbiB0dW5lIHRoZSBiZWhhdmlvciAoaGFzQXR0cmlidXRl IGlzIGNhc2Ugc2Vuc2l0aXZlIHdoZXJlYXMgZ2V0QXR0cmlidXRlIGlzIG5vdCkuCi1pbmxpbmUg dW5zaWduZWQgRWxlbWVudERhdGE6OmZpbmRBdHRyaWJ1dGVJbmRleEJ5TmFtZShjb25zdCBBdG9t aWNTdHJpbmcmIG5hbWUsIGJvb2wgc2hvdWxkSWdub3JlQXR0cmlidXRlQ2FzZSkgY29uc3QKK0FM V0FZU19JTkxJTkUgdW5zaWduZWQgRWxlbWVudERhdGE6OmZpbmRBdHRyaWJ1dGVJbmRleEJ5TmFt ZShjb25zdCBBdG9taWNTdHJpbmcmIG5hbWUsIGJvb2wgc2hvdWxkSWdub3JlQXR0cmlidXRlQ2Fz ZSkgY29uc3QKIHsKICAgICBjb25zdCBBdHRyaWJ1dGUqIGF0dHJpYnV0ZXMgPSBhdHRyaWJ1dGVC YXNlKCk7CiAgICAgYm9vbCBkb1Nsb3dDaGVjayA9IHNob3VsZElnbm9yZUF0dHJpYnV0ZUNhc2U7 CkBAIC0zMDIsNyArMzAyLDcgQEAgaW5saW5lIHVuc2lnbmVkIEVsZW1lbnREYXRhOjpmaW5kQXR0 cmlidXRlSW5kZXhCeU5hbWUoY29uc3QgQXRvbWljU3RyaW5nJiBuYW1lLAogICAgIHJldHVybiBh dHRyaWJ1dGVOb3RGb3VuZDsKIH0KIAotaW5saW5lIGNvbnN0IEF0dHJpYnV0ZSogRWxlbWVudERh dGE6OmZpbmRBdHRyaWJ1dGVCeU5hbWUoY29uc3QgUXVhbGlmaWVkTmFtZSYgbmFtZSkgY29uc3QK K0FMV0FZU19JTkxJTkUgY29uc3QgQXR0cmlidXRlKiBFbGVtZW50RGF0YTo6ZmluZEF0dHJpYnV0 ZUJ5TmFtZShjb25zdCBRdWFsaWZpZWROYW1lJiBuYW1lKSBjb25zdAogewogICAgIGNvbnN0IEF0 dHJpYnV0ZSogYXR0cmlidXRlcyA9IGF0dHJpYnV0ZUJhc2UoKTsKICAgICBmb3IgKHVuc2lnbmVk IGkgPSAwLCBjb3VudCA9IGxlbmd0aCgpOyBpIDwgY291bnQ7ICsraSkgewo=