131878 2014-04-18 21:00:50 -0700 Fix AVPlayerController leak on pages with video 2014-04-19 15:13:13 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 joepeck webkit-unassigned commit-queue eric.carlson glenn jeremyj-wk jer.noble philipj sergio oldest_to_newest 1002142 0 joepeck 2014-04-18 21:00:50 -0700 I was seeing leaks of an AVPlayerController allocated with this stack: ... | WebKit::WebContext::createWebPage(WebKit::PageClient&, WebKit::WebPageConfiguration) | WebKit::WebProcessProxy::createWebPage(WebKit::PageClient&, WebKit::WebPageConfiguration const&) | WebKit::WebPageProxy::create(WebKit::PageClient&, WebKit::WebProcessProxy&, unsigned long long, WebKit::WebPageConfiguration const&) | WebKit::WebPageProxy::WebPageProxy(WebKit::PageClient&, WebKit::WebProcessProxy&, unsigned long long, WebKit::WebPageConfiguration const&) | WebKit::WebVideoFullscreenManagerProxy::create(WebKit::WebPageProxy&) | WebKit::WebVideoFullscreenManagerProxy::WebVideoFullscreenManagerProxy(WebKit::WebPageProxy&) | WebCore::WebVideoFullscreenInterfaceAVKit::setWebVideoFullscreenModel(WebCore::WebVideoFullscreenModel*) | -[WebAVPlayerController init] | _objc_rootAlloc | class_createInstance | calloc | malloc_zone_calloc The allocation was: self.playerControllerProxy = [[classAVPlayerController alloc] init]; This is a (retain) property which will +1 the incoming object, so the alloc/init needs to be balanced. 1002143 1 229711 joepeck 2014-04-18 21:02:47 -0700 Created attachment 229711 [PATCH] Proposed Fix 1002291 2 229711 commit-queue 2014-04-19 15:13:08 -0700 Comment on attachment 229711 [PATCH] Proposed Fix Clearing flags on attachment: 229711 Committed r167551: <http://trac.webkit.org/changeset/167551> 1002292 3 commit-queue 2014-04-19 15:13:13 -0700 All reviewed patches have been landed. Closing bug. 229711 2014-04-18 21:02:47 -0700 2014-04-19 15:13:08 -0700 [PATCH] Proposed Fix leak2.patch text/plain 1391 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAxYmFmZDFjLi41NjZkOTdlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTQtMDQtMTggIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKwor ICAgICAgICBGaXggQVZQbGF5ZXJDb250cm9sbGVyIGxlYWsgb24gcGFnZXMgd2l0aCB2aWRlbwor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMxODc4CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9y bS9pb3MvV2ViVmlkZW9GdWxsc2NyZWVuSW50ZXJmYWNlQVZLaXQubW06CisgICAgICAgICgtW1dl YkFWUGxheWVyQ29udHJvbGxlciBpbml0XSk6CisgICAgICAgIEFzc2lnbmluZyB0byB0aGUgcmV0 YWluIHByb3BlcnR5IHdpbGwgaW5jcmVtZW50IHRoZSBjb3VudCwKKyAgICAgICAgc28gYmFsYW5j ZSB0aGUgYWxsb2Mgd2l0aCBhbiBhdXRvcmVsZWFzZS4KKwogMjAxNC0wNC0xNCAgU2ltb24gRnJh c2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KIAogICAgICAgICBSdW4gZmlsdGVyIGFuaW1h dGlvbnMgaW4gdGhlIFVJIHByb2Nlc3Mgd2l0aCBVSS1zaWRlIGNvbXBvc2l0aW5nCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pb3MvV2ViVmlkZW9GdWxsc2NyZWVuSW50ZXJm YWNlQVZLaXQubW0gYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pb3MvV2ViVmlkZW9GdWxsc2Ny ZWVuSW50ZXJmYWNlQVZLaXQubW0KaW5kZXggZWM2Yjc0My4uZDFmYTZlYyAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW9zL1dlYlZpZGVvRnVsbHNjcmVlbkludGVyZmFjZUFW S2l0Lm1tCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2lvcy9XZWJWaWRlb0Z1bGxzY3Jl ZW5JbnRlcmZhY2VBVktpdC5tbQpAQCAtMTIxLDcgKzEyMSw3IEBAIFNPRlRfTElOSyhDb3JlTWVk aWEsIENNVGltZVN1YnRyYWN0LCBDTVRpbWUsIChDTVRpbWUgbWludWVuZCwgQ01UaW1lIHN1YnRy YWhlbmQpCiAgICAgICAgIHJldHVybiBzZWxmOwogICAgIAogICAgIGluaXRBVlBsYXllckNvbnRy b2xsZXIoKTsKLSAgICBzZWxmLnBsYXllckNvbnRyb2xsZXJQcm94eSA9IFtbY2xhc3NBVlBsYXll ckNvbnRyb2xsZXIgYWxsb2NdIGluaXRdOworICAgIHNlbGYucGxheWVyQ29udHJvbGxlclByb3h5 ID0gW1tbY2xhc3NBVlBsYXllckNvbnRyb2xsZXIgYWxsb2NdIGluaXRdIGF1dG9yZWxlYXNlXTsK ICAgICByZXR1cm4gc2VsZjsKIH0KIAo=