131877 2014-04-18 20:41:59 -0700 Fix leak of UIScreenEdgePanGestureRecognizer in WKSwipeTransitionController 2014-04-19 15:16:57 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 joepeck webkit-unassigned commit-queue oldest_to_newest 1002134 0 joepeck 2014-04-18 20:41:59 -0700 I was seeing leaks of UIScreenEdgePanGestureRecognizer related data allocated in WKSwipeTransitionController. Seems we should be autoreleasing the recognizer we are creating because this file is not ARC. 1002136 1 229709 joepeck 2014-04-18 20:42:41 -0700 Created attachment 229709 [PATCH] Proposed Fix 1002293 2 229709 commit-queue 2014-04-19 15:16:54 -0700 Comment on attachment 229709 [PATCH] Proposed Fix Clearing flags on attachment: 229709 Committed r167552: <http://trac.webkit.org/changeset/167552> 1002294 3 commit-queue 2014-04-19 15:16:57 -0700 All reviewed patches have been landed. Closing bug. 229709 2014-04-18 20:42:41 -0700 2014-04-19 15:16:53 -0700 [PATCH] Proposed Fix leak1.patch text/plain 1288 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBiOTY1MzQ2Li41MDk0ZGNmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTUg QEAKIDIwMTQtMDQtMTggIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAor ICAgICAgICBGaXggbGVhayBvZiBVSVNjcmVlbkVkZ2VQYW5HZXN0dXJlUmVjb2duaXplciBpbiBX S1N3aXBlVHJhbnNpdGlvbkNvbnRyb2xsZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTEzMTg3NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL2lvcy9WaWV3R2VzdHVyZUNvbnRyb2xsZXJJ T1MubW06CisgICAgICAgICgtW1dLU3dpcGVUcmFuc2l0aW9uQ29udHJvbGxlciBnZXN0dXJlUmVj b2duaXplckZvckludGVyYWN0aXZlVHJhbnNpdGlvbjpXaXRoVGFyZ2V0OmFjdGlvbjpdKToKKwor MjAxNC0wNC0xOCAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgorCiAgICAg ICAgIENvcnJlY3Qgc29tZSBpc3N1ZXMgc21hbGwgaXNzdWVzIGluIFdLMiBmaWxlIHVwbG9hZCBJ bmplY3RlZEJ1bmRsZSBBUElzCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xMzE4NTIKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L2lvcy9WaWV3R2VzdHVyZUNvbnRyb2xsZXJJT1MubW0gYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvaW9zL1ZpZXdHZXN0dXJlQ29udHJvbGxlcklPUy5tbQppbmRleCAyZDE2YmE5Li5jMzJmOWZh IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvaW9zL1ZpZXdHZXN0dXJlQ29u dHJvbGxlcklPUy5tbQorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvaW9zL1ZpZXdHZXN0 dXJlQ29udHJvbGxlcklPUy5tbQpAQCAtMTE2LDcgKzExNiw3IEBAIHN0YXRpYyBjb25zdCBzdGQ6 OmNocm9ubzo6c2Vjb25kcyBzd2lwZVNuYXBzaG90UmVtb3ZhbFdhdGNoZG9nRHVyYXRpb24gPSAz X3M7CiAgICAgICAgIFtyZWNvZ25pemVyIHNldEVkZ2VzOlVJUmVjdEVkZ2VSaWdodF07CiAgICAg ICAgIGJyZWFrOwogICAgIH0KLSAgICByZXR1cm4gcmVjb2duaXplcjsKKyAgICByZXR1cm4gW3Jl Y29nbml6ZXIgYXV0b3JlbGVhc2VdOwogfQogCiBAZW5kCg==