131860 2014-04-18 15:14:15 -0700 [iOS] REGRESSION (r167039): WebKit incorrectly sets a background process assertion state when displaying a PDF 2014-04-18 15:50:16 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 131453 1 aestes aestes thorton oldest_to_newest 1002041 0 aestes 2014-04-18 15:14:15 -0700 [iOS] REGRESSION (r167039): WebKit incorrectly sets a background process assertion state when displaying a PDF 1002042 1 aestes 2014-04-18 15:14:34 -0700 <rdar://problem/16631282> 1002044 2 229678 aestes 2014-04-18 15:18:08 -0700 Created attachment 229678 Patch 1002047 3 229678 thorton 2014-04-18 15:23:39 -0700 Comment on attachment 229678 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=229678&action=review > Source/WebKit2/UIProcess/ios/PageClientImplIOS.mm:130 > - return [m_contentView window]; > + return [m_webView window]; We also need to notify the view state that it needs to recompute when WKWebView goes into/out of window, just like WKContentView does: WKWebView - (void)didMoveToWindow { _page->viewStateDidChange(ViewState::IsInWindow); } 1002049 4 229678 thorton 2014-04-18 15:25:49 -0700 Comment on attachment 229678 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=229678&action=review >> Source/WebKit2/UIProcess/ios/PageClientImplIOS.mm:130 >> + return [m_webView window]; > > We also need to notify the view state that it needs to recompute when WKWebView goes into/out of window, just like WKContentView does: > WKWebView > > - (void)didMoveToWindow > { > _page->viewStateDidChange(ViewState::IsInWindow); > } And the reason is, we want to background e.g. the network process if you have a PDF currently loaded and then remove the WKWebView (so the WKContentView didMoveToWindow won't get called, and won't viewStateDidChange, so WKWebView has to do it). There's also no real reason to do it in WKContentView's didMoveToWindow, since it will only change on WKWebView's. 1002055 5 aestes 2014-04-18 15:49:09 -0700 Committed r167512: <http://trac.webkit.org/changeset/167512> 229678 2014-04-18 15:18:08 -0700 2014-04-18 15:25:49 -0700 Patch bug-131860-20140418151747.patch text/plain 1631 aestes U3VidmVyc2lvbiBSZXZpc2lvbjogMTY3NDU2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNDAzMGNhNGUwYWQzZTQ5 MmUzMWJkMjVkMTY0MmUwZGJjMzE2ZWE4Zi4uM2NhZTBlNDgyMzAyN2ZhOTI0YWE2MDM5YTE3YmU1 MDY3YjNjYTE5ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE0LTA0LTE4ICBBbmR5 IEVzdGVzICA8YWVzdGVzQGFwcGxlLmNvbT4KKworICAgICAgICBbaU9TXSBSRUdSRVNTSU9OIChy MTY3MDM5KTogV2ViS2l0IGluY29ycmVjdGx5IHNldHMgYSBiYWNrZ3JvdW5kIHByb2Nlc3MgYXNz ZXJ0aW9uIHN0YXRlIHdoZW4gZGlzcGxheWluZyBhIFBERgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMxODYwCisgICAgICAgIDxyZGFyOi8vcHJvYmxl bS8xNjYzMTI4Mj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBXZSB3ZXJlIGJhc2luZyBvdXIgcHJvY2VzcyBhc3NlcnRpb24gc3RhdGUgb24gd2hldGhl ciBvciBub3QgdGhlCisgICAgICAgIHByb2Nlc3MgaGFkIGEgV0tDb250ZW50VmlldyBpbiBhIHdp bmRvdywgYnV0IHdoZW4gZGlzcGxheWluZyBhIFBERgorICAgICAgICB3ZSd2ZSByZW1vdmVkIHRo ZSBXS0NvbnRlbnRWaWV3IGZyb20gdGhlIHdpbmRvdy4gQmFzZSB0aGlzIGRlY2lzaW9uCisgICAg ICAgIGluc3RlYWQgb24gd2hldGhlciBvciBub3QgdGhlIFdLV2ViVmlldyBpcyBpbiB0aGUgd2lu ZG93LgorCisgICAgICAgICogVUlQcm9jZXNzL2lvcy9QYWdlQ2xpZW50SW1wbElPUy5tbToKKyAg ICAgICAgKFdlYktpdDo6UGFnZUNsaWVudEltcGw6OmlzVmlld0luV2luZG93KToKKwogMjAxNC0w NC0xNyAgRGFyaW4gQWRsZXIgIDxkYXJpbkBhcHBsZS5jb20+CiAKICAgICAgICAgUmVtb3ZlIHVz ZSBvZiBkZXByZWNhdGVkRGVsZXRlQWxsVmFsdWVzIGluIE5QUmVtb3RlT2JqZWN0TWFwOjpwbHVn aW5EZXN0cm95ZWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3MvUGFn ZUNsaWVudEltcGxJT1MubW0gYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvaW9zL1BhZ2VDbGll bnRJbXBsSU9TLm1tCmluZGV4IGU5MTI0MzgyNDRjOGEzMzQ1YjdjMTFiYTVkY2Y4MWE3NzJlODNl ZTguLjgwMjZiODUzODZjNzFjYmQ2N2Q3MzEzZjhmYmViMDVkOTBjZDU0OGUgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3MvUGFnZUNsaWVudEltcGxJT1MubW0KKysrIGIv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2lvcy9QYWdlQ2xpZW50SW1wbElPUy5tbQpAQCAtMTI3 LDcgKzEyNyw3IEBAIGJvb2wgUGFnZUNsaWVudEltcGw6OmlzVmlld1Zpc2libGUoKQogCiBib29s IFBhZ2VDbGllbnRJbXBsOjppc1ZpZXdJbldpbmRvdygpCiB7Ci0gICAgcmV0dXJuIFttX2NvbnRl bnRWaWV3IHdpbmRvd107CisgICAgcmV0dXJuIFttX3dlYlZpZXcgd2luZG93XTsKIH0KIAogdm9p ZCBQYWdlQ2xpZW50SW1wbDo6cHJvY2Vzc0RpZEV4aXQoKQo=