131833 2014-04-17 18:02:41 -0700 [Mac] AttributedStringTest API tests fail with async text input 2014-04-18 10:08:50 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ap ap thorton oldest_to_newest 1001785 0 ap 2014-04-17 18:02:41 -0700 WKView doesn't implement old NSTextInputClient methods when async text input is enabled. 1001786 1 229605 ap 2014-04-17 18:05:21 -0700 Created attachment 229605 proposed fix 1001933 2 229605 enrica 2014-04-18 10:05:42 -0700 Comment on attachment 229605 proposed fix Looks good to me. 1001937 3 ap 2014-04-18 10:08:50 -0700 Committed <http://trac.webkit.org/r167491>. 229605 2014-04-17 18:05:21 -0700 2014-04-18 10:05:41 -0700 proposed fix AttributedStringTest.txt text/plain 4540 ap SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE2NzQ3MykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDIwIEBACisyMDE0LTA0LTE3ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29t PgorCisgICAgICAgIFtNYWNdIEF0dHJpYnV0ZWRTdHJpbmdUZXN0IEFQSSB0ZXN0cyBmYWlsIHdp dGggYXN5bmMgdGV4dCBpbnB1dAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTMxODMzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgRG9uJ3QgcnVuIHN5bmMgTlNUZXh0SW5wdXRDbGllbnQgdGVzdHMgd2hlcmUg d2UgZG9uJ3QgaW1wbGVtZW50IHRoZXNlIGNhbGxzLgorCisgICAgICAgICogVGVzdFdlYktpdEFQ SS9UZXN0cy9tYWMvQXR0cmlidXRlZFN0cmluZy5tbToKKyAgICAgICAgKFRlc3RXZWJLaXRBUEk6 OkF0dHJpYnV0ZWRTdHJpbmdUZXN0X0N1c3RvbUZvbnQ6OmRpZExvYWRVUkwpOgorICAgICAgICAo VGVzdFdlYktpdEFQSTo6QXR0cmlidXRlZFN0cmluZ1Rlc3RfQ3VzdG9tRm9udDo6cnVuU3luY1Rl c3QpOgorICAgICAgICAoVGVzdFdlYktpdEFQSTo6QXR0cmlidXRlZFN0cmluZ1Rlc3RfU3RyaWtl dGhyb3VnaDo6ZGlkTG9hZFVSTCk6CisgICAgICAgIChUZXN0V2ViS2l0QVBJOjpBdHRyaWJ1dGVk U3RyaW5nVGVzdF9TdHJpa2V0aHJvdWdoOjpydW5TeW5jVGVzdCk6CisgICAgICAgIChUZXN0V2Vi S2l0QVBJOjpBdHRyaWJ1dGVkU3RyaW5nVGVzdF9DdXN0b21Gb250OjpydW5UZXN0KTogRGVsZXRl ZC4KKyAgICAgICAgKFRlc3RXZWJLaXRBUEk6OkF0dHJpYnV0ZWRTdHJpbmdUZXN0X1N0cmlrZXRo cm91Z2g6OnJ1blRlc3QpOiBEZWxldGVkLgorCiAyMDE0LTA0LTE2ICBCcmVudCBGdWxnaGFtICA8 YmZ1bGdoYW1AYXBwbGUuY29tPgogCiAgICAgICAgIFtXaW5dIEEgZmV3IGZpbmFsIGNsZWFudXBz IHRvIHRoZSBEYXRhT2JqZWN0IGNsYXNzZXMuCkluZGV4OiBUb29scy9UZXN0V2ViS2l0QVBJL1Rl c3RzL21hYy9BdHRyaWJ1dGVkU3RyaW5nLm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1Rlc3RXZWJL aXRBUEkvVGVzdHMvbWFjL0F0dHJpYnV0ZWRTdHJpbmcubW0JKHJldmlzaW9uIDE2NzQ0NSkKKysr IFRvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvbWFjL0F0dHJpYnV0ZWRTdHJpbmcubW0JKHdvcmtp bmcgY29weSkKQEAgLTM4LDI2ICszOCwzMiBAQCBzdGF0aWMgTlNBdHRyaWJ1dGVkU3RyaW5nICph dHRyaWJ1dGVkU3RyCiAgICAgcmV0dXJuIFsoTlNWaWV3IDxOU1RleHRJbnB1dD4gKilbW1t3ZWJW aWV3IG1haW5GcmFtZV0gZnJhbWVWaWV3XSBkb2N1bWVudFZpZXddIGF0dHJpYnV0ZWRTdWJzdHJp bmdGcm9tUmFuZ2U6cmFuZ2VdOwogfQogCisjaWYgX19NQUNfT1NfWF9WRVJTSU9OX01JTl9SRVFV SVJFRCA8PSAxMDkwCiBzdGF0aWMgTlNBdHRyaWJ1dGVkU3RyaW5nICphdHRyaWJ1dGVkU3RyaW5n KFdLVmlldyAqd2tWaWV3LCBOU1JhbmdlIHJhbmdlKQogewogICAgIE5TUmFuZ2UgYWN0dWFsUmFu Z2U7CiAgICAgcmV0dXJuIFt3a1ZpZXcgYXR0cmlidXRlZFN1YnN0cmluZ0ZvclByb3Bvc2VkUmFu Z2U6cmFuZ2UgYWN0dWFsUmFuZ2U6JmFjdHVhbFJhbmdlXTsKIH0KLQorI2VuZGlmCiAKIGNsYXNz IEF0dHJpYnV0ZWRTdHJpbmdUZXN0X0N1c3RvbUZvbnQgOiBwdWJsaWMgV2ViS2l0QWdub3N0aWNU ZXN0IHsKIHB1YmxpYzoKLSAgICB0ZW1wbGF0ZSA8dHlwZW5hbWUgVmlldz4gdm9pZCBydW5UZXN0 KFZpZXcpOworICAgIHRlbXBsYXRlIDx0eXBlbmFtZSBWaWV3PiB2b2lkIHJ1blN5bmNUZXN0KFZp ZXcpOwogCiAgICAgLy8gV2ViS2l0QWdub3N0aWNUZXN0Ci0gICAgdmlydHVhbCB2b2lkIGRpZExv YWRVUkwoV2ViVmlldyAqd2ViVmlldykgeyBydW5UZXN0KHdlYlZpZXcpOyB9Ci0gICAgdmlydHVh bCB2b2lkIGRpZExvYWRVUkwoV0tWaWV3ICp3a1ZpZXcpIHsgcnVuVGVzdCh3a1ZpZXcpOyB9Cisg ICAgdmlydHVhbCB2b2lkIGRpZExvYWRVUkwoV2ViVmlldyAqd2ViVmlldykgeyBydW5TeW5jVGVz dCh3ZWJWaWV3KTsgfQorI2lmIF9fTUFDX09TX1hfVkVSU0lPTl9NSU5fUkVRVUlSRUQgPD0gMTA5 MAorICAgIHZpcnR1YWwgdm9pZCBkaWRMb2FkVVJMKFdLVmlldyAqd2tWaWV3KSB7IHJ1blN5bmNU ZXN0KHdrVmlldyk7IH0KKyNlbHNlCisgICAgLy8gRklYTUU6IFJlaW1wbGVtZW50IHRoZSB0ZXN0 IHVzaW5nIGFzeW5jIE5TVGV4dElucHV0Q2xpZW50IGludGVyZmFjZS4KKyAgICB2aXJ0dWFsIHZv aWQgZGlkTG9hZFVSTChXS1ZpZXcgKndrVmlldykgeyB9CisjZW5kaWYKIAogICAgIHZpcnR1YWwg TlNVUkwgKnVybCgpIGNvbnN0IHsgcmV0dXJuIFtbTlNCdW5kbGUgbWFpbkJ1bmRsZV0gVVJMRm9y UmVzb3VyY2U6QCJhdHRyaWJ1dGVkU3RyaW5nQ3VzdG9tRm9udCIgd2l0aEV4dGVuc2lvbjpAImh0 bWwiIHN1YmRpcmVjdG9yeTpAIlRlc3RXZWJLaXRBUEkucmVzb3VyY2VzIl07IH0KIH07CiAKIHRl bXBsYXRlIDx0eXBlbmFtZSBWaWV3Pgotdm9pZCBBdHRyaWJ1dGVkU3RyaW5nVGVzdF9DdXN0b21G b250OjpydW5UZXN0KFZpZXcgdmlldykKK3ZvaWQgQXR0cmlidXRlZFN0cmluZ1Rlc3RfQ3VzdG9t Rm9udDo6cnVuU3luY1Rlc3QoVmlldyB2aWV3KQogewogICAgIE5TQXR0cmlidXRlZFN0cmluZyAq YXR0clN0cmluZyA9IGF0dHJpYnV0ZWRTdHJpbmcodmlldywgTlNNYWtlUmFuZ2UoMCwgNSkpOwog ICAgIEVYUEVDVF9XS19TVFJFUSgiTG9yZW0iLCBbYXR0clN0cmluZyBzdHJpbmddKTsKQEAgLTY4 LDI0ICs3NCwzMSBAQCBURVNUX0YoQXR0cmlidXRlZFN0cmluZ1Rlc3RfQ3VzdG9tRm9udCwgCiAg ICAgcnVuV2ViS2l0MVRlc3QoKTsKIH0KIAorI2lmIF9fTUFDX09TX1hfVkVSU0lPTl9NSU5fUkVR VUlSRUQgPD0gMTA5MAogVEVTVF9GKEF0dHJpYnV0ZWRTdHJpbmdUZXN0X0N1c3RvbUZvbnQsIFdl YktpdDIpCiB7CiAgICAgcnVuV2ViS2l0MlRlc3QoKTsKIH0KKyNlbmRpZgogCiBjbGFzcyBBdHRy aWJ1dGVkU3RyaW5nVGVzdF9TdHJpa2V0aHJvdWdoIDogcHVibGljIFdlYktpdEFnbm9zdGljVGVz dCB7CiBwdWJsaWM6Ci0gICAgdGVtcGxhdGUgPHR5cGVuYW1lIFZpZXc+IHZvaWQgcnVuVGVzdChW aWV3KTsKKyAgICB0ZW1wbGF0ZSA8dHlwZW5hbWUgVmlldz4gdm9pZCBydW5TeW5jVGVzdChWaWV3 KTsKIAogICAgIC8vIFdlYktpdEFnbm9zdGljVGVzdAotICAgIHZpcnR1YWwgdm9pZCBkaWRMb2Fk VVJMKFdlYlZpZXcgKndlYlZpZXcpIHsgcnVuVGVzdCh3ZWJWaWV3KTsgfQotICAgIHZpcnR1YWwg dm9pZCBkaWRMb2FkVVJMKFdLVmlldyAqd2tWaWV3KSB7IHJ1blRlc3Qod2tWaWV3KTsgfQorICAg IHZpcnR1YWwgdm9pZCBkaWRMb2FkVVJMKFdlYlZpZXcgKndlYlZpZXcpIHsgcnVuU3luY1Rlc3Qo d2ViVmlldyk7IH0KKyNpZiBfX01BQ19PU19YX1ZFUlNJT05fTUlOX1JFUVVJUkVEIDw9IDEwOTAK KyAgICB2aXJ0dWFsIHZvaWQgZGlkTG9hZFVSTChXS1ZpZXcgKndrVmlldykgeyBydW5TeW5jVGVz dCh3a1ZpZXcpOyB9CisjZWxzZQorICAgIC8vIEZJWE1FOiBSZWltcGxlbWVudCB0aGUgdGVzdCB1 c2luZyBhc3luYyBOU1RleHRJbnB1dENsaWVudCBpbnRlcmZhY2UuCisgICAgdmlydHVhbCB2b2lk IGRpZExvYWRVUkwoV0tWaWV3ICp3a1ZpZXcpIHsgfQorI2VuZGlmCiAKICAgICB2aXJ0dWFsIE5T VVJMICp1cmwoKSBjb25zdCB7IHJldHVybiBbW05TQnVuZGxlIG1haW5CdW5kbGVdIFVSTEZvclJl c291cmNlOkAiYXR0cmlidXRlZFN0cmluZ1N0cmlrZXRocm91Z2giIHdpdGhFeHRlbnNpb246QCJo dG1sIiBzdWJkaXJlY3Rvcnk6QCJUZXN0V2ViS2l0QVBJLnJlc291cmNlcyJdOyB9CiB9OwogCiB0 ZW1wbGF0ZSA8dHlwZW5hbWUgVmlldz4KLXZvaWQgQXR0cmlidXRlZFN0cmluZ1Rlc3RfU3RyaWtl dGhyb3VnaDo6cnVuVGVzdChWaWV3IHZpZXcpCit2b2lkIEF0dHJpYnV0ZWRTdHJpbmdUZXN0X1N0 cmlrZXRocm91Z2g6OnJ1blN5bmNUZXN0KFZpZXcgdmlldykKIHsKICAgICBOU0F0dHJpYnV0ZWRT dHJpbmcgKmF0dHJTdHJpbmcgPSBhdHRyaWJ1dGVkU3RyaW5nKHZpZXcsIE5TTWFrZVJhbmdlKDAs IDUpKTsKIApAQCAtMTAyLDkgKzExNSwxMSBAQCBURVNUX0YoQXR0cmlidXRlZFN0cmluZ1Rlc3Rf U3RyaWtldGhyb3VnCiAgICAgcnVuV2ViS2l0MVRlc3QoKTsKIH0KIAorI2lmIF9fTUFDX09TX1hf VkVSU0lPTl9NSU5fUkVRVUlSRUQgPD0gMTA5MAogVEVTVF9GKEF0dHJpYnV0ZWRTdHJpbmdUZXN0 X1N0cmlrZXRocm91Z2gsIFdlYktpdDIpCiB7CiAgICAgcnVuV2ViS2l0MlRlc3QoKTsKIH0KKyNl bmRpZgogCiB9IC8vIG5hbWVzcGFjZSBUZXN0V2ViS2l0QVBJCg==