131823 2014-04-17 15:28:03 -0700 FTL::fail() should manage memory "correctly" 2014-04-17 15:31:38 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 fpizlo fpizlo barraclough ggaren mark.lam mhahnenberg msaboff oliver sam oldest_to_newest 1001722 0 fpizlo 2014-04-17 15:28:03 -0700 We have some objects that the DFG::Plan points to but that are owned by DFG::Graph until such time as they are owned by DFG::JITCode. It's weird, and a lot of this is a deeper spaghetti that needs to be fixed. But for now, at least make FTL::fail() follow the protocol for InlineCallFrames. 1001725 1 229584 fpizlo 2014-04-17 15:29:31 -0700 Created attachment 229584 the patch 1001726 2 fpizlo 2014-04-17 15:31:38 -0700 Landed in http://trac.webkit.org/changeset/167456 229584 2014-04-17 15:29:31 -0700 2014-04-17 15:30:15 -0700 the patch blah.patch text/plain 1239 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTY3NDU1KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBA CisyMDE0LTA0LTE3ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg RlRMOjpmYWlsKCkgc2hvdWxkIG1hbmFnZSBtZW1vcnkgImNvcnJlY3RseSIKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMTgyMworICAgICAgICA8cmRh cjovL3Byb2JsZW0vMTYzODQyOTc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBmdGwvRlRMRmFpbC5jcHA6CisgICAgICAgIChKU0M6OkZUTDo6ZmFp bCk6CisKIDIwMTQtMDQtMTcgIEZpbGlwIFBpemxvICA8ZnBpemxvQGFwcGxlLmNvbT4KIAogICAg ICAgICBQcmVkaWN0aW9uIHByb3BhZ2F0b3Igc2hvdWxkIGNvcnJlY3RseSBtb2RlbCBJbnQ1MnMg Zmxvd2luZyB0aHJvdWdoIGFyZ3VtZW50cwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2Z0 bC9GVExGYWlsLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZnRsL0ZU TEZhaWwuY3BwCShyZXZpc2lvbiAxNjc0MzMpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZnRs L0ZUTEZhaWwuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00MCw2ICs0MCw5IEBAIHZvaWQgZmFpbChT dGF0ZSYgc3RhdGUpCiB7CiAgICAgc3RhdGUuZ3JhcGgubV9wbGFuLmZpbmFsaXplciA9IGFkb3B0 UHRyKG5ldyBGYWlsZWRGaW5hbGl6ZXIoc3RhdGUuZ3JhcGgubV9wbGFuKSk7CiAgICAgCisgICAg aWYgKCFzdGF0ZS5ncmFwaC5tX2lubGluZUNhbGxGcmFtZXMtPmlzRW1wdHkoKSkKKyAgICAgICAg c3RhdGUuaml0Q29kZS0+Y29tbW9uLmlubGluZUNhbGxGcmFtZXMgPSBzdGQ6Om1vdmUoc3RhdGUu Z3JhcGgubV9pbmxpbmVDYWxsRnJhbWVzKTsKKwogICAgIGlmIChzdGF0ZS5tb2R1bGUpCiAgICAg ICAgIGxsdm0tPkRpc3Bvc2VNb2R1bGUoc3RhdGUubW9kdWxlKTsKIH0K