131813 2014-04-17 13:50:52 -0700 _webProcessIdentifier should return 0 if the web process crashed 2014-04-17 15:39:55 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 psolanki psolanki andersca mitz psolanki oldest_to_newest 1001680 0 psolanki 2014-04-17 13:50:52 -0700 Add SPI to see if web process is live or got killed 1001681 1 229572 psolanki 2014-04-17 13:52:05 -0700 Created attachment 229572 Patch 1001683 2 229572 andersca 2014-04-17 13:53:48 -0700 Comment on attachment 229572 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=229572&action=review > Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:1411 > +- (BOOL)_isValid > +{ > + return _page->isValid(); > +} I think this name is too generic. How about _hasWebProcess? > Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h:121 > +- (BOOL)_isValid; This should be a property. 1001698 3 psolanki 2014-04-17 14:16:47 -0700 Better way - just make _webProcessIdentifier return 0 if the process was killed. 1001704 4 229577 psolanki 2014-04-17 14:27:30 -0700 Created attachment 229577 Patch 1001729 5 psolanki 2014-04-17 15:39:55 -0700 Committed r167457: <http://trac.webkit.org/changeset/167457> 229572 2014-04-17 13:52:05 -0700 2014-04-17 14:27:28 -0700 Patch bug-131813-20140417135144.patch text/plain 1937 psolanki U3VidmVyc2lvbiBSZXZpc2lvbjogMTY3MzIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYmE2MTlkZWQwYTc5NzNm YjFhZDcxOGQzYzQxOWY4ZTRlNzEwZjlmNC4uYzlmNzMzNmMxZGUwYjljMmNiYmY1Y2UzNGFlNWE4 OTE1MzYyNzQ1NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE0LTA0LTE3ICBQcmF0 aWsgU29sYW5raSAgPHBzb2xhbmtpQGFwcGxlLmNvbT4KKworICAgICAgICBBZGQgU1BJIHRvIHNl ZSBpZiB3ZWIgcHJvY2VzcyBpcyBsaXZlIG9yIGdvdCBraWxsZWQKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMTgxMworICAgICAgICA8cmRhcjovL3By b2JsZW0vMTY2NTA2MDU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgRXhwb3NlIFdlYlBhZ2VQcm94eTo6aXNWYWxpZCgpIHdoaWNoIHRlbGxzIHVzIGlm IHRoZSBwcm9jZXNzIGJhY2tpbmcgdGhlIHBhZ2UgaXMgYWxpdmUgb3Igbm90LgorCisgICAgICAg ICogVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXcubW06CisgICAgICAgICgtW1dLV2ViVmll dyBfaXNWYWxpZF0pOgorICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3UHJp dmF0ZS5oOgorCiAyMDE0LTA0LTE1ICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUu Y29tPgogCiAgICAgICAgIFtpT1MgV0syXSBQYWdlcyBvZnRlbiBibGFuayBvbiBmaXJzdCBsb2Fk IGlmIHBhZ2UgbG9hZGVkIGJ5IHR5cGluZyB0aGUgVVJMCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29hL1dLV2ViVmlldy5tbSBiL1NvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3Lm1tCmluZGV4IGI0M2I4Mzc1MTBhMjcwODcyNzQ0 OWFmMTdkMjAxOTE3ZWU5YTRjZjcuLjllNzdkNjI4ZDFlZjZlOTVlOWZkYzBjY2M5NjhhNGZhODNm MmU3YjcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tX ZWJWaWV3Lm1tCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJW aWV3Lm1tCkBAIC0xNDA1LDYgKzE0MDUsMTEgQEAgLSAoTlNVUkwgKilhY3RpdmVVUkwKICAgICBy ZXR1cm4gc2VsZi5VUkw7CiB9CiAKKy0gKEJPT0wpX2lzVmFsaWQKK3sKKyAgICByZXR1cm4gX3Bh Z2UtPmlzVmFsaWQoKTsKK30KKwogI2Vsc2UKIAogI3ByYWdtYSBtYXJrIC0gT1MgWC1zcGVjaWZp YyBtZXRob2RzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29h L1dLV2ViVmlld1ByaXZhdGUuaCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2Ev V0tXZWJWaWV3UHJpdmF0ZS5oCmluZGV4IGE3NDA4MTAzNjI2MWE5ZWFkMjAzZTA4MjdkZTE1Yzgw OWYxNzFjNDMuLjg3N2IzZGIyMTQ4ODk3OWRhNmUzZTBkMmE4YTFiYjk5OGI4OTY0NDIgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3UHJpdmF0 ZS5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3UHJp dmF0ZS5oCkBAIC0xMTgsNiArMTE4LDggQEAgdHlwZWRlZiBOU19PUFRJT05TKE5TVUludGVnZXIs IF9XS0ZpbmRPcHRpb25zKSB7CiAKIC0gKFVJVmlldyAqKV92aWV3Rm9yRmluZFVJOwogCistIChC T09MKV9pc1ZhbGlkOworCiAvLyBGSVhNRTogUmVtb3ZlIHRoaXMgb25jZSBub2JvZHkgdXNlcyBp dC4KIEBwcm9wZXJ0eSAobm9uYXRvbWljLCByZWFkb25seSkgTlNVUkwgKmFjdGl2ZVVSTDsKIAo= 229577 2014-04-17 14:27:30 -0700 2014-04-17 15:30:12 -0700 Patch bug-131813-20140417142709.patch text/plain 1366 psolanki U3VidmVyc2lvbiBSZXZpc2lvbjogMTY3MzIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYmE2MTlkZWQwYTc5NzNm YjFhZDcxOGQzYzQxOWY4ZTRlNzEwZjlmNC4uZjYwOWRhNTZmNmRhNDM1MzMyYjU5N2QwYjM1ZTU0 MWEwMzg5OTA4NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE0LTA0LTE3ICBQcmF0 aWsgU29sYW5raSAgPHBzb2xhbmtpQGFwcGxlLmNvbT4KKworICAgICAgICBfd2ViUHJvY2Vzc0lk ZW50aWZpZXIgc2hvdWxkIHJldHVybiAwIGlmIHRoZSB3ZWIgcHJvY2VzcyBjcmFzaGVkCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzE4MTMKKyAgICAg ICAgPHJkYXI6Ly9wcm9ibGVtLzE2NjUwNjA1PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXcubW06 CisgICAgICAgICgtW1dLV2ViVmlldyBfaGFzV2ViUHJvY2Vzc10pOgorICAgICAgICAqIFVJUHJv Y2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3UHJpdmF0ZS5oOgorCiAyMDE0LTA0LTE1ICBTaW1vbiBG cmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFtpT1MgV0syXSBQYWdl cyBvZnRlbiBibGFuayBvbiBmaXJzdCBsb2FkIGlmIHBhZ2UgbG9hZGVkIGJ5IHR5cGluZyB0aGUg VVJMCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29hL1dLV2Vi Vmlldy5tbSBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3Lm1t CmluZGV4IGI0M2I4Mzc1MTBhMjcwODcyNzQ0OWFmMTdkMjAxOTE3ZWU5YTRjZjcuLjBmMmUwYThi NGZjMGVjODE5ZjAzNzgzMTdmN2Q0NDJhYjI5YmIzMjMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3Lm1tCisrKyBiL1NvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3Lm1tCkBAIC05NDksNyArOTQ5LDcgQEAgLSAo dm9pZClfc2V0Q3VzdG9tVXNlckFnZW50OihOU1N0cmluZyAqKV9jdXN0b21Vc2VyQWdlbnQKIAog LSAocGlkX3QpX3dlYlByb2Nlc3NJZGVudGlmaWVyCiB7Ci0gICAgcmV0dXJuIF9wYWdlLT5wcm9j ZXNzSWRlbnRpZmllcigpOworICAgIHJldHVybiBfcGFnZS0+aXNWYWxpZCgpID8gX3BhZ2UtPnBy b2Nlc3NJZGVudGlmaWVyKCkgOiAwOwogfQogCiAtIChOU0RhdGEgKilfc2Vzc2lvblN0YXRlCg==