131798 2014-04-17 11:37:41 -0700 REGRESSION: ASSERT(!typeInfo().hasImpureGetOwnPropertySlot() || typeInfo().newImpurePropertyFiresWatchpoints()) on jquery tests 2014-04-17 20:02:17 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar, Regression P2 Normal --- 131810 1 ap fpizlo ddkilzer fpizlo oldest_to_newest 1001624 0 ap 2014-04-17 11:37:41 -0700 jquery tests started to fail with assertions very frequently yesterday: http://build.webkit.org/results/Apple%20MountainLion%20(Leaks)/r167385%20(10109)/jquery/attributes-crash-log.txt ASSERT(!typeInfo().hasImpureGetOwnPropertySlot() || typeInfo().newImpurePropertyFiresWatchpoints()) Thread 17 Crashed:: JSC Compilation Thread 0 com.apple.JavaScriptCore 0x000000010e5e544a WTFCrash + 42 (Assertions.cpp:333) 1 com.apple.JavaScriptCore 0x000000010e20453e JSC::Structure::takesSlowPathInDFGForImpureProperty() + 174 (Structure.h:149) 2 com.apple.JavaScriptCore 0x000000010e203172 JSC::GetByIdStatus::computeForStubInfo(JSC::ConcurrentJITLocker const&, JSC::CodeBlock*, JSC::StructureStubInfo*, WTF::StringImpl*) + 1586 (GetByIdStatus.cpp:221) 3 com.apple.JavaScriptCore 0x000000010e2029a3 JSC::GetByIdStatus::computeFor(JSC::CodeBlock*, WTF::HashMap<JSC::CodeOrigin, JSC::StructureStubInfo*, JSC::CodeOriginApproximateHash, WTF::HashTraits<JSC::CodeOrigin>, WTF::HashTraits<JSC::StructureStubInfo*> >&, unsigned int, WTF::StringImpl*) + 179 (GetByIdStatus.cpp:151) 4 com.apple.JavaScriptCore 0x000000010e203eef JSC::GetByIdStatus::computeFor(JSC::CodeBlock*, JSC::CodeBlock*, WTF::HashMap<JSC::CodeOrigin, JSC::StructureStubInfo*, JSC::CodeOriginApproximateHash, WTF::HashTraits<JSC::CodeOrigin>, WTF::HashTraits<JSC::StructureStubInfo*> >&, WTF::HashMap<JSC::CodeOrigin, JSC::StructureStubInfo*, JSC::CodeOriginApproximateHash, WTF::HashTraits<JSC::CodeOrigin>, WTF::HashTraits<JSC::StructureStubInfo*> >&, JSC::CodeOrigin, WTF::StringImpl*) + 703 (GetByIdStatus.cpp:325) 5 com.apple.JavaScriptCore 0x000000010e019514 JSC::DFG::ByteCodeParser::parseBlock(unsigned int) + 15412 (DFGByteCodeParser.cpp:2660) 6 com.apple.JavaScriptCore 0x000000010e013a02 JSC::DFG::ByteCodeParser::parseCodeBlock() + 1970 (DFGByteCodeParser.cpp:3600) 7 com.apple.JavaScriptCore 0x000000010e01f8d8 JSC::DFG::ByteCodeParser::parse() + 968 (DFGByteCodeParser.cpp:3660) 8 com.apple.JavaScriptCore 0x000000010e01fc0e JSC::DFG::parse(JSC::DFG::Graph&) + 62 (DFGByteCodeParser.cpp:3685) 9 com.apple.JavaScriptCore 0x000000010e13a111 JSC::DFG::Plan::compileInThreadImpl(JSC::DFG::LongLivedState&) + 193 (DFGPlan.cpp:193) 1001627 1 ap 2014-04-17 11:40:04 -0700 Hmm, looks like most of the tests crashes once, and were good since then, but jquery/attributes.html is not. 1001628 2 ap 2014-04-17 11:40:18 -0700 s/crashes/crashed/ 1001656 3 fpizlo 2014-04-17 13:20:43 -0700 OMG I hate this assertion so much. It's time to kill it. 1001678 4 229571 fpizlo 2014-04-17 13:48:14 -0700 Created attachment 229571 the patch 1001715 5 fpizlo 2014-04-17 15:20:54 -0700 Landed in http://trac.webkit.org/changeset/167452 1001822 6 ddkilzer 2014-04-17 20:02:17 -0700 <rdar://problem/15705242> 229571 2014-04-17 13:48:14 -0700 2014-04-17 13:59:14 -0700 the patch blah.patch text/plain 2684 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTY3NDUxKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBA CisyMDE0LTA0LTE3ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg UkVHUkVTU0lPTjogQVNTRVJUKCF0eXBlSW5mbygpLmhhc0ltcHVyZUdldE93blByb3BlcnR5U2xv dCgpIHx8IHR5cGVJbmZvKCkubmV3SW1wdXJlUHJvcGVydHlGaXJlc1dhdGNocG9pbnRzKCkpIG9u IGpxdWVyeSB0ZXN0cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTMxNzk4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisgICAg ICAgIAorICAgICAgICBTb21lIGRheSwgd2Ugd2lsbCBmaXggaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTEzMTgxMCBhbmQgc29tZSB2ZXJzaW9uCisgICAgICAgIG9mIHRo aXMgYXNzZXJ0aW9uIGNhbiByZXR1cm4uIEZvciBub3csIGl0J3Mgbm90IGNsZWFyIHRoYXQgdGhl IGFzc2VydGlvbiBpcyBndWFyZGluZworICAgICAgICBhbnkgdHJ1bHkgdW5kZXNpcmFibGUgYmVo YXZpb3IgLSBzbyBpdCBzaG91bGQganVzdCBnbyBhd2F5IGFuZCBiZSByZXBsYWNlZCB3aXRoIGEK KyAgICAgICAgRklYTUUuCisKKyAgICAgICAgKiBieXRlY29kZS9HZXRCeUlkU3RhdHVzLmNwcDoK KyAgICAgICAgKEpTQzo6R2V0QnlJZFN0YXR1czo6Y29tcHV0ZUZvclN0dWJJbmZvKToKKyAgICAg ICAgKiBydW50aW1lL1N0cnVjdHVyZS5oOgorICAgICAgICAoSlNDOjpTdHJ1Y3R1cmU6OnRha2Vz U2xvd1BhdGhJbkRGR0ZvckltcHVyZVByb3BlcnR5KToKKwogMjAxNC0wNC0xNyAgRGF2aWQgS2ls emVyICA8ZGRraWx6ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIEJsaW5kIGF0dGVtcHQgdG8gZml4 IFdpbmRvd3MgYnVpbGQgYWZ0ZXIgcjE2NjgzNwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3Jl L2J5dGVjb2RlL0dldEJ5SWRTdGF0dXMuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9ieXRlY29kZS9HZXRCeUlkU3RhdHVzLmNwcAkocmV2aXNpb24gMTY3NDUxKQorKysg U291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL0dldEJ5SWRTdGF0dXMuY3BwCSh3b3JraW5n IGNvcHkpCkBAIC0yMTgsNiArMjE4LDEzIEBAIEdldEJ5SWRTdGF0dXMgR2V0QnlJZFN0YXR1czo6 Y29tcHV0ZUZvclMKICAgICAgICAgICAgIEFTU0VSVCghbGlzdC0+YXQobGlzdEluZGV4KS5kb2Vz Q2FsbHMoKSk7CiAgICAgICAgICAgICAKICAgICAgICAgICAgIFN0cnVjdHVyZSogc3RydWN0dXJl ID0gbGlzdC0+YXQobGlzdEluZGV4KS5zdHJ1Y3R1cmUoKTsKKyAgICAgICAgICAgIAorICAgICAg ICAgICAgLy8gRklYTUU6IFdlIHNob3VsZCBhc3NlcnQgdGhhdCB3ZSBuZXZlciBzZWUgYSBzdHJ1 Y3R1cmUgdGhhdAorICAgICAgICAgICAgLy8gaGFzSW1wdXJlR2V0T3duUHJvcGVydHlTbG90KCkg YnV0IGZvciB3aGljaCB3ZSBkb24ndAorICAgICAgICAgICAgLy8gbmV3SW1wdXJlUHJvcGVydHlG aXJlc1dhdGNocG9pbnRzKCkuIFdlJ3JlIG5vdCBhdCBhIHBvaW50IHdoZXJlIHdlIGNhbiBkbwor ICAgICAgICAgICAgLy8gdGhhdCwgeWV0LgorICAgICAgICAgICAgLy8gaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMTgxMAorICAgICAgICAgICAgCiAgICAgICAgICAg ICBpZiAoc3RydWN0dXJlLT50YWtlc1Nsb3dQYXRoSW5ERkdGb3JJbXB1cmVQcm9wZXJ0eSgpKQog ICAgICAgICAgICAgICAgIHJldHVybiBHZXRCeUlkU3RhdHVzKFRha2VzU2xvd1BhdGgsIHRydWUp OwogICAgICAgICAgICAgCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9TdHJ1 Y3R1cmUuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9TdHJ1 Y3R1cmUuaAkocmV2aXNpb24gMTY3NDUxKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRp bWUvU3RydWN0dXJlLmgJKHdvcmtpbmcgY29weSkKQEAgLTE0Niw3ICsxNDYsNiBAQCBwdWJsaWM6 CiAgICAgLy8gREZHIGZyb20gaW5saW5pbmcgcHJvcGVydHkgYWNjZXNzZXMgc2luY2Ugc3RydWN0 dXJlcyBkb24ndCB0cmFuc2l0aW9uIHdoZW4gYSBuZXcgaW1wdXJlIHByb3BlcnR5IGFwcGVhcnMu CiAgICAgYm9vbCB0YWtlc1Nsb3dQYXRoSW5ERkdGb3JJbXB1cmVQcm9wZXJ0eSgpCiAgICAgewot ICAgICAgICBBU1NFUlQoIXR5cGVJbmZvKCkuaGFzSW1wdXJlR2V0T3duUHJvcGVydHlTbG90KCkg fHwgdHlwZUluZm8oKS5uZXdJbXB1cmVQcm9wZXJ0eUZpcmVzV2F0Y2hwb2ludHMoKSk7CiAgICAg ICAgIHJldHVybiB0eXBlSW5mbygpLmhhc0ltcHVyZUdldE93blByb3BlcnR5U2xvdCgpOwogICAg IH0KIAo=