131795 2014-04-17 09:26:30 -0700 [GTK] [Gardening] Update some test expectations for GTK 2022-02-28 00:04:00 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 elima webkit-unassigned clopez commit-queue oldest_to_newest 1001574 0 elima 2014-04-17 09:26:30 -0700 [GTK] [Gardening] Update some test expectations for GTK 1001575 1 229553 elima 2014-04-17 09:27:10 -0700 Created attachment 229553 Patch 1001598 2 229553 commit-queue 2014-04-17 10:26:43 -0700 Comment on attachment 229553 Patch Rejecting attachment 229553 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 229553, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit /Volumes/Data/EWS/WebKit/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://webkit-queues.appspot.com/results/5244854577659904 1001599 3 clopez 2014-04-17 10:29:05 -0700 (In reply to comment #2) > (From update of attachment 229553 [details]) > Rejecting attachment 229553 [details] from commit-queue. > > Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 229553, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit > > /Volumes/Data/EWS/WebKit/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). > > Full output: http://webkit-queues.appspot.com/results/5244854577659904 I think you forgot to add the "Unreviewed GTK gardening..." phrase to the changelog 1001615 4 229562 elima 2014-04-17 11:09:07 -0700 Created attachment 229562 Patch 1001637 5 clopez 2014-04-17 12:07:16 -0700 Seems this was already manually landed by mrobinson on http://trac.webkit.org/changeset/167438 I guess you can close this bug 1001638 6 elima 2014-04-17 12:13:13 -0700 Martin Robinson already committed the first patch. Thank you. Closing. 229553 2014-04-17 09:27:10 -0700 2014-04-17 11:08:58 -0700 Patch bug-131795-20140417182648.patch text/plain 3390 elima U3VidmVyc2lvbiBSZXZpc2lvbjogMTY3NDI1CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggYTlkYTM4NTAyNzM1NzUyYWQyN2Uz ZTUxMTcyOTY1MTc1MGY1NzAyZi4uZjc2ZGVhYjZmM2IxMDQ3MDQwZTFjMGIxMzM1ZjZhZWYxMmVj ZmRiOCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE0LTA0LTE3ICBFZHVhcmRvIExpbWEgTWl0 ZXYgIDxlbGltYUBpZ2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdIFtHYXJkZW5pbmddIFVwZGF0 ZXMgR1RLIHRlc3QgZXhwZWN0YXRpb25zCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ndGsvVGVzdEV4 cGVjdGF0aW9uczoKKyAgICAgICAgICAtIE1hcmtlZCBhcyBmbGFreQorICAgICAgICAgICAgLSBm YXN0L2ZyYW1lcy9mcmFtZS1wcm9ncmFtbWF0aWMtbm9yZXNpemUuaHRtbAorICAgICAgICAgICAg LSBmYXN0L2ZyYW1lcy9mcmFtZS13aXRoLW5vcmVzaXplLWNhbi1iZS1yZXNpemVkLWFmdGVyLXJl bW92YWwtb2Ytbm9yZXNpemUuaHRtbAorICAgICAgICAgICAgLSBmYXN0L2ZyYW1lcy9mcmFtZS13 aXRoLW5vcmVzaXplLWNhbi1iZS1yZXNpemVkLWFmdGVyLXNldHRpbmctbm9SZXNpemUtdG8tZmFs c2UuaHRtbAorICAgICAgICAgIC0gUmVtb3ZlZCBiZWNhdXNlIGFyZSBwYXNzaW5nIG5vdworICAg ICAgICAgICAgLSBmYXN0L2RvbS9nYy1kb20tdHJlZS1saWZldGltZS5odG1sCisgICAgICAgICAg ICAtIGh0dHAvdGVzdHMvbG9hZGluZy9hdXRoZW50aWNhdGlvbi1hZnRlci1yZWRpcmVjdC1zdG9y ZXMtd3JvbmctY3JlZGVudGlhbHMvYXV0aGVudGljYXRpb24tYWZ0ZXItcmVkaXJlY3Qtc3RvcmVz LXdyb25nLWNyZWRlbnRpYWxzLmh0bWwKKyAgICAgICAgICAgIC0gZWRpdGluZy9lZGl0YWJpbGl0 eS9pZ25vcmVkLWNvbnRlbnQuaHRtbAorCiAyMDE0LTA0LTE3ICBJb24gUm9zY2EgIDxyb3NjYUBh ZG9iZS5jb20+CiAKICAgICAgICAgW0NTUyBCbGVuZGluZ10gSXNvbGF0aW9uIGRlc2NlbmRhbnQg ZGVwZW5kZW50IGZsYWdzIGFyZSBub3QgdXBkYXRlZCBjb3JyZWN0bHkKZGlmZiAtLWdpdCBhL0xh eW91dFRlc3RzL3BsYXRmb3JtL2d0ay9UZXN0RXhwZWN0YXRpb25zIGIvTGF5b3V0VGVzdHMvcGxh dGZvcm0vZ3RrL1Rlc3RFeHBlY3RhdGlvbnMKaW5kZXggMTg4NTEyMDgxNmQwOWQ1YjI0ZmQ0YmI3 ZDJkOGIwMDAyNmY4OWE0Ni4uYzI2ZjEyZjc0NWY0NDZjYjZhNzIwZjc4ZDcxMzdjYWI1ZmNjNzQ3 OSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1Rlc3RFeHBlY3RhdGlvbnMK KysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1Rlc3RFeHBlY3RhdGlvbnMKQEAgLTE0ODAs NiArMTQ4MCw5IEBAIHdlYmtpdC5vcmcvYi83NzYzMSBmYXN0L211bHRpY29sL3NwYW4vc3Bhbi1h cy1pbW1lZGlhdGUtY2hpbGQtcHJvcGVydHktcmVtb3ZhbC5oCiB3ZWJraXQub3JnL2IvNzc2MzEg ZmFzdC9tdWx0aWNvbC9zcGFuL3NwYW4tYXMtaW1tZWRpYXRlLWNvbHVtbnMtY2hpbGQtcmVtb3Zh bC5odG1sIFsgRmFpbHVyZSBdCiAKIHdlYmtpdC5vcmcvYi84MDEyOSBmYXN0L2ZyYW1lcy9mbGF0 dGVuaW5nL2ZyYW1lc2V0LWZsYXR0ZW5pbmctYWR2YW5jZWQuaHRtbCBbIEZhaWx1cmUgXQord2Vi a2l0Lm9yZy9iLzEzMTc5MyBmYXN0L2ZyYW1lcy9mcmFtZS1wcm9ncmFtbWF0aWMtbm9yZXNpemUu aHRtbCBbIEZhaWx1cmUgUGFzcyBdCit3ZWJraXQub3JnL2IvMTMxNzk0IGZhc3QvZnJhbWVzL2Zy YW1lLXdpdGgtbm9yZXNpemUtY2FuLWJlLXJlc2l6ZWQtYWZ0ZXItcmVtb3ZhbC1vZi1ub3Jlc2l6 ZS5odG1sIFsgRmFpbHVyZSBQYXNzIF0KK3dlYmtpdC5vcmcvYi8xMzE3OTQgZmFzdC9mcmFtZXMv ZnJhbWUtd2l0aC1ub3Jlc2l6ZS1jYW4tYmUtcmVzaXplZC1hZnRlci1zZXR0aW5nLW5vUmVzaXpl LXRvLWZhbHNlLmh0bWwgWyBGYWlsdXJlIFBhc3MgXQogCiB3ZWJraXQub3JnL2IvODk2NjMgZWRp dGluZy9kZWxldGluZy9kZWxldGUtMzgwMDgzNC1maXguaHRtbCBbIEZhaWx1cmUgXQogCkBAIC0x NjEzLDEzICsxNjE2LDkgQEAgd2Via2l0Lm9yZy9iLzExODIyMiBmYXN0L3RleHQvaW50ZXJuYXRp b25hbC9zeW50aGVzaXplZC1pdGFsaWMtdmVydGljYWwuaHRtbCBbIEkKIAogd2Via2l0Lm9yZy9i LzExODQxNiBzdG9yYWdlL3dlYnNxbC9zcWwtZXJyb3ItY29kZXMuaHRtbCBbIEZhaWx1cmUgXQog Ci13ZWJraXQub3JnL2IvMTE4NDIwIFsgUmVsZWFzZSBdIGZhc3QvZG9tL2djLWRvbS10cmVlLWxp ZmV0aW1lLmh0bWwgWyBGYWlsdXJlIF0KLQogIyBNYXkgdGFrZSB0b28gbG9uZyBvbiB0aGUgYm90 cy4KIEJ1ZyhHVEspIG1hdGhtbC92ZXJ5LWxhcmdlLXN0cmV0Y2h5LW9wZXJhdG9ycy5odG1sIFsg UGFzcyBUaW1lb3V0IF0KIAotd2Via2l0Lm9yZy9iLzExOTg0MCBodHRwL3Rlc3RzL2xvYWRpbmcv YXV0aGVudGljYXRpb24tYWZ0ZXItcmVkaXJlY3Qtc3RvcmVzLXdyb25nLWNyZWRlbnRpYWxzL2F1 dGhlbnRpY2F0aW9uLWFmdGVyLXJlZGlyZWN0LXN0b3Jlcy13cm9uZy1jcmVkZW50aWFscy5odG1s IFsgRmFpbHVyZSBdCi0KIHdlYmtpdC5vcmcvYi8xMTk4NDEgZmFzdC9zdWItcGl4ZWwvc3ViLXBp eGVsLWNvbXBvc2l0ZWQtbGF5ZXJzLmh0bWwgWyBJbWFnZU9ubHlGYWlsdXJlIF0KIAogd2Via2l0 Lm9yZy9iLzEyMDEwNSBodHRwL3Rlc3RzL25hdmlnYXRpb24vcG9zdC1mcmFtZXMtZ29iYWNrMS11 bmNhY2hlZC5odG1sIFsgRmFpbHVyZSBdCkBAIC0xNzU4LDggKzE3NTcsNiBAQCB3ZWJraXQub3Jn L2IvMTIyNTExIHdlYmtpdC5vcmcvYi8xMjA0MDEgZmFzdC9yZWdpb25zL3NlbGVjdGlvbi9zZWxl Y3RpbmctdGV4dC1pbgogIyBQYXN0ZUJvYXJkOjpwbGFpblRleHQoKSBkb2VzIG5vdCBzdXBwb3J0 IGZpbGUgbmFtZXMuCiB3ZWJraXQub3JnL2IvOTkwNzAgZWRpdGluZy9wYXN0ZWJvYXJkL2RyYWct ZmlsZXMtdG8tZWRpdGFibGUtZWxlbWVudC5odG1sIFsgRmFpbHVyZSBdCiAKLXdlYmtpdC5vcmcv Yi8xMzE2MTkgZWRpdGluZy9lZGl0YWJpbGl0eS9pZ25vcmVkLWNvbnRlbnQuaHRtbCBbIEZhaWx1 cmUgXQotCiAjIE9wZXJhLXN1Ym1pdHRlZCB0ZXN0cyB0byBXM0MgZm9yIDx0cmFjaz4sIGEgbG90 IG9mIGZhaWx1cmVzIHN0aWxsLgogd2Via2l0Lm9yZy9iLzEwMzkyNiBtZWRpYS90cmFjay9vcGVy YS9pZGwvbWVkaWEtaWRsLXRlc3RzLmh0bWwgWyBTa2lwIF0KIHdlYmtpdC5vcmcvYi8xMDM5MjYg bWVkaWEvdHJhY2svb3BlcmEvaW50ZXJmYWNlcy9IVE1MRWxlbWVudC9IVE1MTWVkaWFFbGVtZW50 L2Nyb3NzT3JpZ2luLmh0bWwgWyBTa2lwIF0K 229562 2014-04-17 11:09:07 -0700 2022-02-28 00:04:00 -0800 Patch bug-131795-20140417200844.patch text/plain 3364 elima U3VidmVyc2lvbiBSZXZpc2lvbjogMTY3NDI1CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggYTlkYTM4NTAyNzM1NzUyYWQyN2Uz ZTUxMTcyOTY1MTc1MGY1NzAyZi4uOTYwY2E4NjQ0YjZlM2U0ZjkwZDI4YTQ5YzA5N2Q4NTE5MjFh M2EzOCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE0LTA0LTE3ICBFZHVhcmRvIExpbWEgTWl0 ZXYgIDxlbGltYUBpZ2FsaWEuY29tPgorCisgICAgICAgIFVucmV2aWV3ZWQgZ2FyZGVuaW5nLgor CisgICAgICAgICogcGxhdGZvcm0vZ3RrL1Rlc3RFeHBlY3RhdGlvbnM6CisgICAgICAgICAgLSBN YXJrZWQgYXMgZmxha3kKKyAgICAgICAgICAgIC0gZmFzdC9mcmFtZXMvZnJhbWUtcHJvZ3JhbW1h dGljLW5vcmVzaXplLmh0bWwKKyAgICAgICAgICAgIC0gZmFzdC9mcmFtZXMvZnJhbWUtd2l0aC1u b3Jlc2l6ZS1jYW4tYmUtcmVzaXplZC1hZnRlci1yZW1vdmFsLW9mLW5vcmVzaXplLmh0bWwKKyAg ICAgICAgICAgIC0gZmFzdC9mcmFtZXMvZnJhbWUtd2l0aC1ub3Jlc2l6ZS1jYW4tYmUtcmVzaXpl ZC1hZnRlci1zZXR0aW5nLW5vUmVzaXplLXRvLWZhbHNlLmh0bWwKKyAgICAgICAgICAtIFJlbW92 ZWQgYmVjYXVzZSBhcmUgcGFzc2luZyBub3cKKyAgICAgICAgICAgIC0gZmFzdC9kb20vZ2MtZG9t LXRyZWUtbGlmZXRpbWUuaHRtbAorICAgICAgICAgICAgLSBodHRwL3Rlc3RzL2xvYWRpbmcvYXV0 aGVudGljYXRpb24tYWZ0ZXItcmVkaXJlY3Qtc3RvcmVzLXdyb25nLWNyZWRlbnRpYWxzL2F1dGhl bnRpY2F0aW9uLWFmdGVyLXJlZGlyZWN0LXN0b3Jlcy13cm9uZy1jcmVkZW50aWFscy5odG1sCisg ICAgICAgICAgICAtIGVkaXRpbmcvZWRpdGFiaWxpdHkvaWdub3JlZC1jb250ZW50Lmh0bWwKKwog MjAxNC0wNC0xNyAgSW9uIFJvc2NhICA8cm9zY2FAYWRvYmUuY29tPgogCiAgICAgICAgIFtDU1Mg QmxlbmRpbmddIElzb2xhdGlvbiBkZXNjZW5kYW50IGRlcGVuZGVudCBmbGFncyBhcmUgbm90IHVw ZGF0ZWQgY29ycmVjdGx5CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvVGVz dEV4cGVjdGF0aW9ucyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9UZXN0RXhwZWN0YXRpb25z CmluZGV4IDE4ODUxMjA4MTZkMDlkNWIyNGZkNGJiN2QyZDhiMDAwMjZmODlhNDYuLmMyNmYxMmY3 NDVmNDQ2Y2I2YTcyMGY3OGQ3MTM3Y2FiNWZjYzc0NzkgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3Rz L3BsYXRmb3JtL2d0ay9UZXN0RXhwZWN0YXRpb25zCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3Jt L2d0ay9UZXN0RXhwZWN0YXRpb25zCkBAIC0xNDgwLDYgKzE0ODAsOSBAQCB3ZWJraXQub3JnL2Iv Nzc2MzEgZmFzdC9tdWx0aWNvbC9zcGFuL3NwYW4tYXMtaW1tZWRpYXRlLWNoaWxkLXByb3BlcnR5 LXJlbW92YWwuaAogd2Via2l0Lm9yZy9iLzc3NjMxIGZhc3QvbXVsdGljb2wvc3Bhbi9zcGFuLWFz LWltbWVkaWF0ZS1jb2x1bW5zLWNoaWxkLXJlbW92YWwuaHRtbCBbIEZhaWx1cmUgXQogCiB3ZWJr aXQub3JnL2IvODAxMjkgZmFzdC9mcmFtZXMvZmxhdHRlbmluZy9mcmFtZXNldC1mbGF0dGVuaW5n LWFkdmFuY2VkLmh0bWwgWyBGYWlsdXJlIF0KK3dlYmtpdC5vcmcvYi8xMzE3OTMgZmFzdC9mcmFt ZXMvZnJhbWUtcHJvZ3JhbW1hdGljLW5vcmVzaXplLmh0bWwgWyBGYWlsdXJlIFBhc3MgXQord2Vi a2l0Lm9yZy9iLzEzMTc5NCBmYXN0L2ZyYW1lcy9mcmFtZS13aXRoLW5vcmVzaXplLWNhbi1iZS1y ZXNpemVkLWFmdGVyLXJlbW92YWwtb2Ytbm9yZXNpemUuaHRtbCBbIEZhaWx1cmUgUGFzcyBdCit3 ZWJraXQub3JnL2IvMTMxNzk0IGZhc3QvZnJhbWVzL2ZyYW1lLXdpdGgtbm9yZXNpemUtY2FuLWJl LXJlc2l6ZWQtYWZ0ZXItc2V0dGluZy1ub1Jlc2l6ZS10by1mYWxzZS5odG1sIFsgRmFpbHVyZSBQ YXNzIF0KIAogd2Via2l0Lm9yZy9iLzg5NjYzIGVkaXRpbmcvZGVsZXRpbmcvZGVsZXRlLTM4MDA4 MzQtZml4Lmh0bWwgWyBGYWlsdXJlIF0KIApAQCAtMTYxMywxMyArMTYxNiw5IEBAIHdlYmtpdC5v cmcvYi8xMTgyMjIgZmFzdC90ZXh0L2ludGVybmF0aW9uYWwvc3ludGhlc2l6ZWQtaXRhbGljLXZl cnRpY2FsLmh0bWwgWyBJCiAKIHdlYmtpdC5vcmcvYi8xMTg0MTYgc3RvcmFnZS93ZWJzcWwvc3Fs LWVycm9yLWNvZGVzLmh0bWwgWyBGYWlsdXJlIF0KIAotd2Via2l0Lm9yZy9iLzExODQyMCBbIFJl bGVhc2UgXSBmYXN0L2RvbS9nYy1kb20tdHJlZS1saWZldGltZS5odG1sIFsgRmFpbHVyZSBdCi0K ICMgTWF5IHRha2UgdG9vIGxvbmcgb24gdGhlIGJvdHMuCiBCdWcoR1RLKSBtYXRobWwvdmVyeS1s YXJnZS1zdHJldGNoeS1vcGVyYXRvcnMuaHRtbCBbIFBhc3MgVGltZW91dCBdCiAKLXdlYmtpdC5v cmcvYi8xMTk4NDAgaHR0cC90ZXN0cy9sb2FkaW5nL2F1dGhlbnRpY2F0aW9uLWFmdGVyLXJlZGly ZWN0LXN0b3Jlcy13cm9uZy1jcmVkZW50aWFscy9hdXRoZW50aWNhdGlvbi1hZnRlci1yZWRpcmVj dC1zdG9yZXMtd3JvbmctY3JlZGVudGlhbHMuaHRtbCBbIEZhaWx1cmUgXQotCiB3ZWJraXQub3Jn L2IvMTE5ODQxIGZhc3Qvc3ViLXBpeGVsL3N1Yi1waXhlbC1jb21wb3NpdGVkLWxheWVycy5odG1s IFsgSW1hZ2VPbmx5RmFpbHVyZSBdCiAKIHdlYmtpdC5vcmcvYi8xMjAxMDUgaHR0cC90ZXN0cy9u YXZpZ2F0aW9uL3Bvc3QtZnJhbWVzLWdvYmFjazEtdW5jYWNoZWQuaHRtbCBbIEZhaWx1cmUgXQpA QCAtMTc1OCw4ICsxNzU3LDYgQEAgd2Via2l0Lm9yZy9iLzEyMjUxMSB3ZWJraXQub3JnL2IvMTIw NDAxIGZhc3QvcmVnaW9ucy9zZWxlY3Rpb24vc2VsZWN0aW5nLXRleHQtaW4KICMgUGFzdGVCb2Fy ZDo6cGxhaW5UZXh0KCkgZG9lcyBub3Qgc3VwcG9ydCBmaWxlIG5hbWVzLgogd2Via2l0Lm9yZy9i Lzk5MDcwIGVkaXRpbmcvcGFzdGVib2FyZC9kcmFnLWZpbGVzLXRvLWVkaXRhYmxlLWVsZW1lbnQu aHRtbCBbIEZhaWx1cmUgXQogCi13ZWJraXQub3JnL2IvMTMxNjE5IGVkaXRpbmcvZWRpdGFiaWxp dHkvaWdub3JlZC1jb250ZW50Lmh0bWwgWyBGYWlsdXJlIF0KLQogIyBPcGVyYS1zdWJtaXR0ZWQg dGVzdHMgdG8gVzNDIGZvciA8dHJhY2s+LCBhIGxvdCBvZiBmYWlsdXJlcyBzdGlsbC4KIHdlYmtp dC5vcmcvYi8xMDM5MjYgbWVkaWEvdHJhY2svb3BlcmEvaWRsL21lZGlhLWlkbC10ZXN0cy5odG1s IFsgU2tpcCBdCiB3ZWJraXQub3JnL2IvMTAzOTI2IG1lZGlhL3RyYWNrL29wZXJhL2ludGVyZmFj ZXMvSFRNTEVsZW1lbnQvSFRNTE1lZGlhRWxlbWVudC9jcm9zc09yaWdpbi5odG1sIFsgU2tpcCBd Cg==