13179 2007-03-24 07:40:22 -0700 REGRESSION (r20410): In debug builds, loading a certain page is suspended until redisplay is forced 2007-03-24 16:31:29 -0700 1 1 1 Unclassified WebKit New Bugs 523.x (Safari 3) Mac OS X 10.4 RESOLVED FIXED http://digg.com/design InRadar, Regression P1 Normal --- 1 mitz webkit-unassigned bdakin ddkilzer hyatt oldest_to_newest 17638 0 mitz 2007-03-24 07:40:22 -0700 Steps to reproduce: 1) With a debug build of TOT WebKit and Safari 2.0.4, open the URL. Wait for it to finish loading. 2) Close the window. 3) Open a new window a load the same URL in it. While waiting for it to finish loading, do not move the window or Safari to the background. Expected result: The page should finish loading in step 3. Actual result: In step 3, the page does not finish loading and the window remains blank until you move the window or Safari to the background. This forces redisplay (to update active state), which makes the page resume loading and finally finish. Regression: Regressed in <http://trac.webkit.org/projects/webkit/changeset/20410>. Notes: Seems to affect only debug builds and only with Tiger Safari. 17639 1 mrowe 2007-03-24 07:41:06 -0700 <rdar://problem/5086424> 17640 2 mitz 2007-03-24 08:44:08 -0700 I didn't debug this through, but it seems like FrameView::needsLayout() would have been a more appropriate place to add the root->needsLayout() check in r20410. That would have matched more closely the behavior prior to r20324. FrameView::layoutPending() should only be about layout scheduling. 17641 3 13797 mitz 2007-03-24 08:53:53 -0700 Created attachment 13797 Move the root->needsLayout() check to FrameView::needsLayout() I tried the link from bug 13155 a few times to verify that this does not bring back the assertion failure. 17642 4 ddkilzer 2007-03-24 09:04:24 -0700 (In reply to comment #3) > I tried the link from bug 13155 a few times to verify that this does not bring > back the assertion failure. There is another way this assertion is hit that hasn't been fixed yet. (I filed a Radar for it, but didn't file a corresponding Bugzilla bug yet.) Here are the steps to reproduce. 1. Open Safari/WebKit. 2. Go to: http://ln-s.net/ 3. Click in the text field. 4. Hit Enter. 17489 5 13797 hyatt 2007-03-24 16:20:21 -0700 Comment on attachment 13797 Move the root->needsLayout() check to FrameView::needsLayout() r=me 17492 6 hyatt 2007-03-24 16:31:29 -0700 Landed in r20474. 13797 2007-03-24 08:53:53 -0700 2007-03-24 16:20:21 -0700 Move the root->needsLayout() check to FrameView::needsLayout() 13179_r1.patch text/plain 1862 mitz SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAyMDQ3MCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMDctMDMtMjQgIE1pdHogUGV0dGVsICA8bWl0ekB3ZWJraXQub3Jn PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIC0gZml4 IGh0dHA6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMTc5CisgICAgICAgICAg UkVHUkVTU0lPTiAocjIwNDEwKTogSW4gZGVidWcgYnVpbGRzLCBsb2FkaW5nIGEgY2VydGFpbiBw YWdlIGlzIHN1c3BlbmRlZCB1bnRpbCByZWRpc3BsYXkgaXMgZm9yY2VkCisKKyAgICAgICAgTW92 ZWQgdGhlIHJvb3QtPm5lZWRzTGF5b3V0KCkgY2hlY2sgZnJvbSBsYXlvdXRQZW5kaW5nKCkgdG8g bmVlZHNMYXlvdXQoKQorICAgICAgICB0byByZXN0b3JlIHRoZSBiZWhhdmlvciBiZWZvcmUgcjIw MzI0LgorCisgICAgICAgICogcGFnZS9GcmFtZVZpZXcuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 RnJhbWVWaWV3OjpsYXlvdXRQZW5kaW5nKToKKyAgICAgICAgKFdlYkNvcmU6OkZyYW1lVmlldzo6 bmVlZHNMYXlvdXQpOgorCiAyMDA3LTAzLTI1ICBNYXJrIFJvd2UgIDxtcm93ZUBhcHBsZS5jb20+ CiAKICAgICAgICAgRml4IGluY29ycmVjdCByYWRhciBudW1iZXIuCkluZGV4OiBXZWJDb3JlL3Bh Z2UvRnJhbWVWaWV3LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmNw cAkocmV2aXNpb24gMjA0NzApCisrKyBXZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmNwcAkod29ya2lu ZyBjb3B5KQpAQCAtNjkyLDE1ICs2OTIsMTUgQEAgdm9pZCBGcmFtZVZpZXc6OnNjaGVkdWxlUmVs YXlvdXRPZlN1YnRyZQogCiBib29sIEZyYW1lVmlldzo6bGF5b3V0UGVuZGluZygpIGNvbnN0CiB7 Ci0gICAgLy8gSXQgaXMgcG9zc2libGUgdGhhdCBvdXIgZG9jdW1lbnQgd2lsbCBub3QgaGF2ZSBh IGJvZHkgeWV0LiBJZiB0aGlzIGlzIHRoZSBjYXNlLCAKLSAgICAvLyB0aGVuIHdlIGFyZSBub3Qg YWxsb3dlZCB0byBzY2hlZHVsZSBsYXlvdXRzIHlldCwgc28gdGhlcmUgd29uJ3QgYmUgYSB0aW1l ci4KLSAgICBSZW5kZXJWaWV3KiByb290ID0gc3RhdGljX2Nhc3Q8UmVuZGVyVmlldyo+KG1fZnJh bWUtPnJlbmRlcmVyKCkpOwotICAgIHJldHVybiBkLT5sYXlvdXRUaW1lci5pc0FjdGl2ZSgpIHx8 IChyb290ICYmIHJvb3QtPm5lZWRzTGF5b3V0KCkpOworICAgIHJldHVybiBkLT5sYXlvdXRUaW1l ci5pc0FjdGl2ZSgpOwogfQogCiBib29sIEZyYW1lVmlldzo6bmVlZHNMYXlvdXQoKSBjb25zdAog ewotICAgIHJldHVybiBsYXlvdXRQZW5kaW5nKCk7CisgICAgLy8gSXQgaXMgcG9zc2libGUgdGhh dCBvdXIgZG9jdW1lbnQgd2lsbCBub3QgaGF2ZSBhIGJvZHkgeWV0LiBJZiB0aGlzIGlzIHRoZSBj YXNlLCAKKyAgICAvLyB0aGVuIHdlIGFyZSBub3QgYWxsb3dlZCB0byBzY2hlZHVsZSBsYXlvdXRz IHlldCwgc28gd2Ugd29uJ3QgYmUgcGVuZGluZyBsYXlvdXQuCisgICAgUmVuZGVyVmlldyogcm9v dCA9IHN0YXRpY19jYXN0PFJlbmRlclZpZXcqPihtX2ZyYW1lLT5yZW5kZXJlcigpKTsKKyAgICBy ZXR1cm4gbGF5b3V0UGVuZGluZygpIHx8IChyb290ICYmIHJvb3QtPm5lZWRzTGF5b3V0KCkpOwog fQogCiB2b2lkIEZyYW1lVmlldzo6c2V0TmVlZHNMYXlvdXQoKQo=