131756 2014-04-16 13:39:05 -0700 Fix CodeGenerator.pm to only write files if the generated content has changed 2016-11-10 19:03:07 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED LATER P2 Normal --- 1 bjonesbe bjonesbe ap cdumez cgarcia commit-queue fujii mjs sam oldest_to_newest 1001305 0 bjonesbe 2014-04-16 13:39:05 -0700 Fix CodeGenerator.pm to only write files if the generated content has changed 1001307 1 229475 bjonesbe 2014-04-16 13:41:32 -0700 Created attachment 229475 Patch 1001308 2 229475 sam 2014-04-16 13:42:49 -0700 Comment on attachment 229475 Patch Sweet! 1001326 3 229475 commit-queue 2014-04-16 14:14:52 -0700 Comment on attachment 229475 Patch Clearing flags on attachment: 229475 Committed r167384: <http://trac.webkit.org/changeset/167384> 1001327 4 commit-queue 2014-04-16 14:14:56 -0700 All reviewed patches have been landed. Closing bug. 1001583 5 ap 2014-04-17 09:38:44 -0700 I thought that we decided against this approach several times before, because it means that input files will always be newer than the outputs, so we will be running CodeGenerator.pm on most inputs every time. Am I missing something? 1001620 6 bjonesbe 2014-04-17 11:31:10 -0700 (In reply to comment #5) > I thought that we decided against this approach several times before, because it means that input files will always be newer than the outputs, so we will be running CodeGenerator.pm on most inputs every time. > > Am I missing something? You're right, that is a problem with this change. I believe I can fix that problem, however. I'll work on a fix for that today. 1001711 7 bjonesbe 2014-04-17 15:11:22 -0700 (In reply to comment #6) > (In reply to comment #5) > > I thought that we decided against this approach several times before, because it means that input files will always be newer than the outputs, so we will be running CodeGenerator.pm on most inputs every time. > > > > Am I missing something? > > You're right, that is a problem with this change. I believe I can fix that problem, however. I'll work on a fix for that today. I have a fix for the Mac build in Bug 131820. 1001787 8 bjonesbe 2014-04-17 18:05:50 -0700 Reverted r167384 for reason: Sounds like this isn't the right fix, and causes generation to run far too often. Committed r167474: <http://trac.webkit.org/changeset/167474> 1004794 9 bjonesbe 2014-04-28 17:30:31 -0700 I have no brilliant ideas on fixing this in the near term, so closing for now. 1250116 10 fujii 2016-11-10 19:03:07 -0800 generate-bindings-all.pl solves the original problem in a different approach. * Bug 161433 – [CMake] CMake does not support the dep files for implicit dependency * Bug 164054 – generate-bindings-all.pl should recompile supplemented IDL if its supplemental IDL are added or removed * Bug 164121 – [CMake] Changing enabled features should trigger recompiling all IDL 229475 2014-04-16 13:41:32 -0700 2014-04-16 14:14:52 -0700 Patch bug-131756-20140416134110.patch text/plain 1777 bjonesbe U3VidmVyc2lvbiBSZXZpc2lvbjogMTY3MzY2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDFhYWUzMDM5ZWEwMTFh Y2U2NzY4OTM3NmRiNzMxNGE3YTdkOWRiNy4uNmZlZDgxZjc2NGU4MWIzNGE4ZmU4MDU3NzUwOTcy ZDZmNTRmOTZmZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE0LTA0LTE2ICBCZW0g Sm9uZXMtQmV5ICA8YmpvbmVzYmVAYWRvYmUuY29tPgorCisgICAgICAgIEZpeCBDb2RlR2VuZXJh dG9yLnBtIHRvIG9ubHkgd3JpdGUgZmlsZXMgaWYgdGhlIGdlbmVyYXRlZCBjb250ZW50IGhhcyBj aGFuZ2VkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x MzE3NTYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBU byBpbXByb3ZlIGJ1aWxkIHNwZWVkLCBkb24ndCB0b3VjaCBnZW5lcmF0ZWQgZmlsZXMgdW5sZXNz IHRoZSBuZXdseQorICAgICAgICBnZW5lcmF0ZWQgY29udGVudCBpcyBhY3R1YWxseSBkaWZmZXJl bnQuCisKKyAgICAgICAgKiBiaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3IucG06CisgICAg ICAgIChVcGRhdGVGaWxlKToKKwogMjAxNC0wNC0xNSAgQnJlbnQgRnVsZ2hhbSAgPGJmdWxnaGFt QGFwcGxlLmNvbT4KIAogICAgICAgICBbV2luXSBFbGltaW5hdGUgdXNlIG9mIGRlbGV0ZUFsbFZh bHVlcyBpbiBXaW5kb3dzIEZpbGVzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5n cy9zY3JpcHRzL0NvZGVHZW5lcmF0b3IucG0gYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3Jp cHRzL0NvZGVHZW5lcmF0b3IucG0KaW5kZXggODRhMzQxYjMwOWM1YWE0NDBjOGFhN2I5YjBmMGM4 NmQ0YjBmODhjYS4uYmEyYmZhOTI4MGQzMWY2NGY4N2JiYjBlZDQyOTAzOTM4YzI3MDlhYyAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yLnBt CisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvci5wbQpA QCAtMTY2LDkgKzE2NiwxNiBAQCBzdWIgVXBkYXRlRmlsZQogICAgIG15ICRmaWxlTmFtZSA9IHNo aWZ0OwogICAgIG15ICRjb250ZW50cyA9IHNoaWZ0OwogCi0gICAgb3BlbiBGSCwgIj4gJGZpbGVO YW1lIiBvciBkaWUgIkNvdWxkbid0IG9wZW4gJGZpbGVOYW1lOiAkIVxuIjsKLSAgICBwcmludCBG SCAkY29udGVudHM7Ci0gICAgY2xvc2UgRkg7CisgICAgaWYgKC1lICRmaWxlTmFtZSkgeworICAg ICAgICBvcGVuIG15ICRmaCwgIjwiLCAkZmlsZU5hbWUgb3IgZGllICJDb3VsZG4ndCBvcGVuICRm aWxlTmFtZTogJCFcbiI7CisgICAgICAgIG15ICRvbGRjb250ZW50cyA9IGpvaW4gJycsIDwkZmg+ OworICAgICAgICBjbG9zZSAkZmggb3IgZGllICJDb3VsZG4ndCBjbG9zZSAkZmlsZU5hbWU6ICQh XG4iOworICAgICAgICByZXR1cm4gaWYgJGNvbnRlbnRzIGVxICRvbGRjb250ZW50czsKKyAgICB9 CisKKyAgICBvcGVuIG15ICRmaCwgIj4iLCAkZmlsZU5hbWUgb3IgZGllICJDb3VsZG4ndCBvcGVu ICRmaWxlTmFtZTogJCFcbiI7CisgICAgcHJpbnQgJGZoICRjb250ZW50czsKKyAgICBjbG9zZSAk Zmggb3IgZGllICJDb3VsZG4ndCBjbG9zZSAkZmlsZU5hbWU6ICQhXG4iCiB9CiAKIHN1YiBGb3JB bGxQYXJlbnRzCg==