131743 2014-04-16 10:45:06 -0700 Unreviewed, ARMv7 buildfix after r167336. 2014-07-29 05:21:42 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 aperez aperez gustavo ossy zan oldest_to_newest 1001211 0 aperez 2014-04-16 10:45:06 -0700 Unreviewed, ARMv7 buildfix after r167336. 1001213 1 229457 aperez 2014-04-16 10:46:19 -0700 Created attachment 229457 Patch 1001537 2 aperez 2014-04-17 07:08:13 -0700 The patch does not fix the build, build log: In file included from ../../Source/JavaScriptCore/assembler/MacroAssembler.h:32:0, from ../../Source/JavaScriptCore/jit/GPRInfo.h:29, from ../../Source/JavaScriptCore/bytecode/ValueRecovery.h:31, from ../../Source/JavaScriptCore/bytecode/CodeOrigin.h:32, from ../../Source/JavaScriptCore/jit/ClosureCallStubRoutine.h:31, from ../../Source/JavaScriptCore/bytecode/CallLinkInfo.h:29, from ../../Source/JavaScriptCore/bytecode/CodeBlock.h:37, from ../../Source/JavaScriptCore/llint/LLIntOffsetsExtractor.cpp:29: ../../Source/JavaScriptCore/assembler/MacroAssemblerARMv7.h:1522:10: error: ‘JSC::AbstractMacroAssembler<JSC::ARMv7Assembler>::Jump JSC::MacroAssemblerARMv7::branchAdd32(JSC::MacroAssemblerARMv7::ResultCondition, JSC::AbstractMacroAssembler<JSC::ARMv7Assembler>::Address, JSC::AbstractMacroAssembler<JSC::ARMv7Assembler>::RegisterID)’ cannot be overloaded Jump branchAdd32(ResultCondition cond, Address src, RegisterID dest) ^ ../../Source/JavaScriptCore/assembler/MacroAssemblerARMv7.h:1511:10: error: with ‘JSC::AbstractMacroAssembler<JSC::ARMv7Assembler>::Jump JSC::MacroAssemblerARMv7::branchAdd32(JSC::MacroAssemblerARMv7::ResultCondition, JSC::AbstractMacroAssembler<JSC::ARMv7Assembler>::Address, JSC::AbstractMacroAssembler<JSC::ARMv7Assembler>::RegisterID)’ Jump branchAdd32(ResultCondition cond, Address src, RegisterID dest) ^ ../../Source/JavaScriptCore/assembler/MacroAssemblerARMv7.h: In member function ‘JSC::AbstractMacroAssembler<JSC::ARMv7Assembler>::Jump JSC::MacroAssemblerARMv7::branchAdd32(JSC::MacroAssemblerARMv7::ResultCondition, JSC::AbstractMacroAssembler<JSC::ARMv7Assembler>::Address, JSC::AbstractMacroAssembler<JSC::ARMv7Assembler>::RegisterID)’: ../../Source/JavaScriptCore/assembler/MacroAssemblerARMv7.h:1513:62: error: ‘getCachedDataTempRegisterIDAndInvalidate’ was not declared in this scope load32(src, getCachedDataTempRegisterIDAndInvalidate()); ^ [6/5048] cd /webkit/gtk-linux-arm-release/build/WebKitBuild/Release/Tools/T...arm-release/build/WebKitBuild/Release/DerivedSources/ForwardingHeaders soup ninja: build stopped: subcommand failed. 1001568 3 229552 aperez 2014-04-17 09:09:49 -0700 Created attachment 229552 Patch 1001650 4 229552 ggaren 2014-04-17 13:06:12 -0700 Comment on attachment 229552 Patch This is out-of-date. 1025442 5 zan 2014-07-29 05:16:36 -0700 Is this still valid? 1025443 6 ossy 2014-07-29 05:21:42 -0700 (In reply to comment #5) > Is this still valid? no, fix was landed in https://trac.webkit.org/changeset/167354 229457 2014-04-16 10:46:19 -0700 2014-04-17 09:09:40 -0700 Patch bug-131743-20140416204732.patch text/plain 1461 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMTY3MzUzCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA2 MzYxODk1ZmM4YmQ5NTUxZWI0NWJkNjI0NTQ2NzE5YjZiYjcwMThkLi5iYWVjZmI3YzEyN2RlMjdj NTUwOGY0NzljMzRiNDFmYTMzYjc4ZDIzIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMSBAQAorMjAxNC0wNC0xNiAgQWRyaWFuIFBlcmV6IGRlIENhc3RybyAgPGFwZXJlekBp Z2FsaWEuY29tPgorCisgICAgICAgIFVucmV2aWV3ZWQsIEFSTXY3IGJ1aWxkZml4IGFmdGVyIHIx NjczMzYuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x MzE3NDMKKworICAgICAgICAqIGFzc2VtYmxlci9NYWNyb0Fzc2VtYmxlckFSTXY3Lmg6CisgICAg ICAgIChKU0M6Ok1hY3JvQXNzZW1ibGVyQVJNdjc6OmJyYW5jaEFkZDMyKTogQWRkIG1pc3Npbmcg ZnVuY3Rpb24uCisKIDIwMTQtMDQtMTYgIEdhYm9yIFJhcGNzYW55aSAgPHJnYWJvckB3ZWJraXQu b3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIEFSTTY0IGJ1aWxkZml4IGFmdGVyIHIxNjczMzYu CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1i bGVyQVJNdjcuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJs ZXJBUk12Ny5oCmluZGV4IDJiOGE0ODlmNTgyMTY2Yzc2YmRhMDg0MGU2MzdhYjgxMDhjM2VmZWQu LjEzMTMzNGI2NjVjYWExMjdlMjYxYmM0Y2IyOTRlNWM0MGVjNGQzYTQgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJBUk12Ny5oCisrKyBi L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJBUk12Ny5oCkBA IC0xNTA4LDYgKzE1MDgsMTIgQEAgcHVibGljOgogICAgICAgICByZXR1cm4gSnVtcChtYWtlQnJh bmNoKGNvbmQpKTsKICAgICB9CiAKKyAgICBKdW1wIGJyYW5jaEFkZDMyKFJlc3VsdENvbmRpdGlv biBjb25kLCBBZGRyZXNzIHNyYywgUmVnaXN0ZXJJRCBkZXN0KQorICAgIHsKKyAgICAgICAgbG9h ZDMyKHNyYywgZ2V0Q2FjaGVkRGF0YVRlbXBSZWdpc3RlcklEQW5kSW52YWxpZGF0ZSgpKTsKKyAg ICAgICAgcmV0dXJuIGJyYW5jaEFkZDMyKGNvbmQsIGRlc3QsIGRhdGFUZW1wUmVnaXN0ZXIsIGRl c3QpOworICAgIH0KKwogICAgIEp1bXAgYnJhbmNoQWRkMzIoUmVzdWx0Q29uZGl0aW9uIGNvbmQs IFJlZ2lzdGVySUQgc3JjLCBSZWdpc3RlcklEIGRlc3QpCiAgICAgewogICAgICAgICByZXR1cm4g YnJhbmNoQWRkMzIoY29uZCwgZGVzdCwgc3JjLCBkZXN0KTsK 229552 2014-04-17 09:09:49 -0700 2014-04-17 13:06:12 -0700 Patch bug-131743-20140417191102.patch text/plain 1487 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMTY3NDI4CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAz MTZiMmViMmI4YjMwNWMyMmIxYThjZGZiMTZjYWQxYTM5MWIyOTBmLi5jODc5ZDdjNTFlY2U0MmJi M2MxNzM3ZmRjY2I4NzMxMDhmZTc5ZjQ4IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMSBAQAorMjAxNC0wNC0xNiAgQWRyaWFuIFBlcmV6IGRlIENhc3RybyAgPGFwZXJlekBp Z2FsaWEuY29tPgorCisgICAgICAgIFVucmV2aWV3ZWQsIEFSTXY3IGJ1aWxkZml4IGFmdGVyIHIx NjczMzYuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x MzE3NDMKKworICAgICAgICAqIGFzc2VtYmxlci9NYWNyb0Fzc2VtYmxlckFSTXY3Lmg6CisgICAg ICAgIChKU0M6Ok1hY3JvQXNzZW1ibGVyQVJNdjc6OmJyYW5jaEFkZDMyKTogQWRkIG1pc3Npbmcg ZnVuY3Rpb24uCisKIDIwMTQtMDQtMTcgIERhcmluIEFkbGVyICA8ZGFyaW5AYXBwbGUuY29tPgog CiAgICAgICAgIEFkZCBzZXBhcmF0ZSBmbGFnIGZvciBJbmRleGVkRGF0YWJhc2UgaW4gd29ya2Vy cyBzaW5jZSB0aGUgY3VycmVudCBpbXBsZW1lbnRhdGlvbiBpcyBub3QgdGhyZWFkc2FmZQpkaWZm IC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlckFS TXY3LmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyQVJN djcuaAppbmRleCA0MWNjYjA4MGQ2MDZjNTU3ZDBmNmUyNTdkNzlkODYzZmVkYjgwOTQ3Li5mNDRm YTdiMWYwYTRmMWY2NzBhOWU2YTNmNzU1YWI1MWU1ZGY4YWEwIDEwMDY0NAotLS0gYS9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyQVJNdjcuaAorKysgYi9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyQVJNdjcuaApAQCAtMTUw OCw2ICsxNTA4LDEyIEBAIHB1YmxpYzoKICAgICAgICAgcmV0dXJuIEp1bXAobWFrZUJyYW5jaChj b25kKSk7CiAgICAgfQogCisgICAgSnVtcCBicmFuY2hBZGQzMihSZXN1bHRDb25kaXRpb24gY29u ZCwgQWRkcmVzcyBzcmMsIFJlZ2lzdGVySUQgZGVzdCkKKyAgICB7CisgICAgICAgIGxvYWQzMihz cmMsIGRhdGFUZW1wUmVnaXN0ZXIpOworICAgICAgICByZXR1cm4gYnJhbmNoQWRkMzIoY29uZCwg ZGVzdCwgZGF0YVRlbXBSZWdpc3RlciwgZGVzdCk7CisgICAgfQorCiAgICAgSnVtcCBicmFuY2hB ZGQzMihSZXN1bHRDb25kaXRpb24gY29uZCwgUmVnaXN0ZXJJRCBzcmMsIFJlZ2lzdGVySUQgZGVz dCkKICAgICB7CiAgICAgICAgIHJldHVybiBicmFuY2hBZGQzMihjb25kLCBkZXN0LCBzcmMsIGRl c3QpOwo=