131742 2014-04-16 10:37:08 -0700 Convert the boolean param of Image::startAnimation() to an enum 2014-04-16 10:51:59 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 simon.fraser simon.fraser commit-queue d-r fmalita gyuyoung.kim pdr schenney sergio simon.fraser oldest_to_newest 1001203 0 simon.fraser 2014-04-16 10:37:08 -0700 Convert the boolean param of Image::startAnimation() to an enum 1001205 1 229456 simon.fraser 2014-04-16 10:37:49 -0700 Created attachment 229456 Patch 1001215 2 simon.fraser 2014-04-16 10:51:59 -0700 https://trac.webkit.org/r167356 229456 2014-04-16 10:37:49 -0700 2014-04-16 10:39:03 -0700 Patch bug-131742-20140416103727.patch text/plain 6588 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMTY3MzE5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWJmZWUwNTgzMTU0MWE3 NzQ0MGY5NjllMmY1MjgyNTM4ZWI0MjYzOS4uOGYwZDQ0NTM0YzAyM2RiNWFlMTUzMzYxMDFmNjJk YTFiMGQwODFlYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE0LTA0LTE2ICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIENvbnZlcnQgdGhl IGJvb2xlYW4gcGFyYW0gb2YgSW1hZ2U6OnN0YXJ0QW5pbWF0aW9uKCkgdG8gYW4gZW51bQorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMxNzQyCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVXNlIGFuIGVudW0g dG8gbWFrZSB0aGUgY29kZSBtb3JlIHJlYWRhYmxlLgorCisgICAgICAgICogcGxhdGZvcm0vZ3Jh cGhpY3MvQml0bWFwSW1hZ2UuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Qml0bWFwSW1hZ2U6OnN0 YXJ0QW5pbWF0aW9uKToKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9CaXRtYXBJbWFnZS5o OgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL0ltYWdlLmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OkltYWdlOjpkcmF3VGlsZWQpOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL0ltYWdl Lmg6CisgICAgICAgIChXZWJDb3JlOjpJbWFnZTo6c3RhcnRBbmltYXRpb24pOgorICAgICAgICAq IHN2Zy9ncmFwaGljcy9TVkdJbWFnZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTVkdJbWFnZTo6 c3RhcnRBbmltYXRpb24pOgorICAgICAgICAqIHN2Zy9ncmFwaGljcy9TVkdJbWFnZS5oOgorCiAy MDE0LTA0LTE1ICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCiAgICAg ICAgIExheWVyVHJlZUFzVGV4dEJlaGF2aW9yIHNob3VsZCBiZSBpbiB0aGUgV2ViQ29yZSBuYW1l c3BhY2UKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0JpdG1h cEltYWdlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0JpdG1hcEltYWdl LmNwcAppbmRleCBmYWQ5ODQzMWE0NmFiMDBiMzU1YzZlZTNjMTUzNDI4MzNjNTkwMmY0Li4xNGIy YjU0OGFkNTllMWVkYzcxNjFhMTFjNDkzMGViMTBmYzdjMWUzIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9CaXRtYXBJbWFnZS5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvQml0bWFwSW1hZ2UuY3BwCkBAIC01MzksNyArNTM5LDcg QEAgYm9vbCBCaXRtYXBJbWFnZTo6c2hvdWxkQW5pbWF0ZSgpCiAgICAgcmV0dXJuIChyZXBldGl0 aW9uQ291bnQoZmFsc2UpICE9IGNBbmltYXRpb25Ob25lICYmICFtX2FuaW1hdGlvbkZpbmlzaGVk ICYmIGltYWdlT2JzZXJ2ZXIoKSk7CiB9CiAKLXZvaWQgQml0bWFwSW1hZ2U6OnN0YXJ0QW5pbWF0 aW9uKGJvb2wgY2F0Y2hVcElmTmVjZXNzYXJ5KQordm9pZCBCaXRtYXBJbWFnZTo6c3RhcnRBbmlt YXRpb24oQ2F0Y2hVcEFuaW1hdGlvbiBjYXRjaFVwSWZOZWNlc3NhcnkpCiB7CiAgICAgaWYgKG1f ZnJhbWVUaW1lciB8fCAhc2hvdWxkQW5pbWF0ZSgpIHx8IGZyYW1lQ291bnQoKSA8PSAxKQogICAg ICAgICByZXR1cm47CkBAIC01OTMsNyArNTkzLDcgQEAgdm9pZCBCaXRtYXBJbWFnZTo6c3RhcnRB bmltYXRpb24oYm9vbCBjYXRjaFVwSWZOZWNlc3NhcnkpCiAgICAgaWYgKG5leHRGcmFtZSA9PSAw ICYmIG1fcmVwZXRpdGlvbnNDb21wbGV0ZSA9PSAwICYmIG1fZGVzaXJlZEZyYW1lU3RhcnRUaW1l IDwgdGltZSkKICAgICAgICAgbV9kZXNpcmVkRnJhbWVTdGFydFRpbWUgPSB0aW1lOwogCi0gICAg aWYgKCFjYXRjaFVwSWZOZWNlc3NhcnkgfHwgdGltZSA8IG1fZGVzaXJlZEZyYW1lU3RhcnRUaW1l KSB7CisgICAgaWYgKGNhdGNoVXBJZk5lY2Vzc2FyeSA9PSBEb05vdENhdGNoVXAgfHwgdGltZSA8 IG1fZGVzaXJlZEZyYW1lU3RhcnRUaW1lKSB7CiAgICAgICAgIC8vIEhhdmVuJ3QgeWV0IHJlYWNo ZWQgdGltZSBmb3IgbmV4dCBmcmFtZSB0byBzdGFydDsgZGVsYXkgdW50aWwgdGhlbi4KICAgICAg ICAgbV9mcmFtZVRpbWVyID0gc3RkOjptYWtlX3VuaXF1ZTxUaW1lcjxCaXRtYXBJbWFnZT4+KHRo aXMsICZCaXRtYXBJbWFnZTo6YWR2YW5jZUFuaW1hdGlvbik7CiAgICAgICAgIG1fZnJhbWVUaW1l ci0+c3RhcnRPbmVTaG90KHN0ZDo6bWF4KG1fZGVzaXJlZEZyYW1lU3RhcnRUaW1lIC0gdGltZSwg MC4pKTsKQEAgLTYzNiw3ICs2MzYsNyBAQCB2b2lkIEJpdG1hcEltYWdlOjpzdGFydEFuaW1hdGlv bihib29sIGNhdGNoVXBJZk5lY2Vzc2FyeSkKICAgICAgICAgICAgIC8vIHNpdHVhdGlvbiB0aGUg YmVzdCB3ZSBjYW4gZG8gaXMgdG8gc2ltcGx5IGNoYW5nZSBmcmFtZXMgYXMgZmFzdAogICAgICAg ICAgICAgLy8gYXMgcG9zc2libGUsIHNvIGZvcmNlIHN0YXJ0QW5pbWF0aW9uKCkgdG8gc2V0IGEg emVyby1kZWxheSB0aW1lcgogICAgICAgICAgICAgLy8gYW5kIGJhaWwgb3V0IGlmIHdlJ3JlIG5v dCBjYXVnaHQgdXAuCi0gICAgICAgICAgICBzdGFydEFuaW1hdGlvbihmYWxzZSk7CisgICAgICAg ICAgICBzdGFydEFuaW1hdGlvbihEb05vdENhdGNoVXApOwogICAgICAgICB9CiAgICAgfQogfQpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvQml0bWFwSW1hZ2Uu aCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0JpdG1hcEltYWdlLmgKaW5kZXgg MmU0NTBhMmQwNTQwMWY1MjZkZmUwZDcxNDdiOGM3NGI1ZWYxYzU0MS4uMzA3OTA1Yzc3MDVlYmY4 OWNhYzlkMTJiOTA0NmJhOTQ1YzRkZTc4ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvQml0bWFwSW1hZ2UuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9CaXRtYXBJbWFnZS5oCkBAIC0yNzIsNyArMjcyLDcgQEAgcHJvdGVjdGVkOgog ICAgIC8vIEFuaW1hdGlvbi4KICAgICBpbnQgcmVwZXRpdGlvbkNvdW50KGJvb2wgaW1hZ2VLbm93 blRvQmVDb21wbGV0ZSk7ICAvLyB8aW1hZ2VLbm93blRvQmVDb21wbGV0ZXwgc2hvdWxkIGJlIHNl dCBpZiB0aGUgY2FsbGVyIGtub3dzIHRoZSBlbnRpcmUgaW1hZ2UgaGFzIGJlZW4gZGVjb2RlZC4K ICAgICBib29sIHNob3VsZEFuaW1hdGUoKTsKLSAgICB2aXJ0dWFsIHZvaWQgc3RhcnRBbmltYXRp b24oYm9vbCBjYXRjaFVwSWZOZWNlc3NhcnkgPSB0cnVlKSBvdmVycmlkZTsKKyAgICB2aXJ0dWFs IHZvaWQgc3RhcnRBbmltYXRpb24oQ2F0Y2hVcEFuaW1hdGlvbiA9IENhdGNoVXApIG92ZXJyaWRl OwogICAgIHZvaWQgYWR2YW5jZUFuaW1hdGlvbihUaW1lcjxCaXRtYXBJbWFnZT4mKTsKIAogICAg IC8vIEZ1bmN0aW9uIHRoYXQgZG9lcyB0aGUgcmVhbCB3b3JrIG9mIGFkdmFuY2luZyB0aGUgYW5p bWF0aW9uLiAgV2hlbgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3MvSW1hZ2UuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvSW1hZ2UuY3Bw CmluZGV4IDZmNzU1ZTE1MDBjZmY1MDAyY2Q2NzI0ODg0NzE1YmY0OWZkZjIwN2IuLjFlYzNiYWIw ZmEwYWYzYWNmNjI2NTkyNDAyMjliNTJmZDA0ZjJkYWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL0ltYWdlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9JbWFnZS5jcHAKQEAgLTE4NSw3ICsxODUsNyBAQCB2b2lkIEltYWdlOjpk cmF3VGlsZWQoR3JhcGhpY3NDb250ZXh0KiBjdHh0LCBjb25zdCBGbG9hdFJlY3QmIGRlc3RSZWN0 LCBjb25zdCBGbAogICAgIGRyYXdQYXR0ZXJuKGN0eHQsIHRpbGVSZWN0LCBwYXR0ZXJuVHJhbnNm b3JtLCBvbmVUaWxlUmVjdC5sb2NhdGlvbigpLCBzdHlsZUNvbG9yU3BhY2UsIG9wLCBkZXN0UmVj dCwgYmxlbmRNb2RlKTsKIAogI2lmIFBMQVRGT1JNKElPUykKLSAgICBzdGFydEFuaW1hdGlvbihm YWxzZSk7CisgICAgc3RhcnRBbmltYXRpb24oRG9Ob3RDYXRjaFVwKTsKICNlbHNlCiAgICAgc3Rh cnRBbmltYXRpb24oKTsKICNlbmRpZgpAQCAtMjIzLDcgKzIyMyw3IEBAIHZvaWQgSW1hZ2U6OmRy YXdUaWxlZChHcmFwaGljc0NvbnRleHQqIGN0eHQsIGNvbnN0IEZsb2F0UmVjdCYgZHN0UmVjdCwg Y29uc3QgRmxvCiAgICAgZHJhd1BhdHRlcm4oY3R4dCwgc3JjUmVjdCwgcGF0dGVyblRyYW5zZm9y bSwgcGF0dGVyblBoYXNlLCBzdHlsZUNvbG9yU3BhY2UsIG9wLCBkc3RSZWN0KTsKIAogI2lmIFBM QVRGT1JNKElPUykKLSAgICBzdGFydEFuaW1hdGlvbihmYWxzZSk7CisgICAgc3RhcnRBbmltYXRp b24oRG9Ob3RDYXRjaFVwKTsKICNlbHNlCiAgICAgc3RhcnRBbmltYXRpb24oKTsKICNlbmRpZgpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvSW1hZ2UuaCBiL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0ltYWdlLmgKaW5kZXggYzNjNzhjOTFmYTRm YmM2NTVlMWM2YWU0MTc0NjUwY2U0MjgyOTVhOS4uNjExNzZkODVjMzkyM2JlZTczZGZiYjA2Mjhh N2M0MmU1MDAwNTMwMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3MvSW1hZ2UuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9JbWFnZS5o CkBAIC0xMTUsNyArMTE1LDggQEAgcHVibGljOgogCiAgICAgLy8gQW5pbWF0aW9uIGJlZ2lucyB3 aGVuZXZlciBzb21lb25lIGRyYXdzIHRoZSBpbWFnZSwgc28gc3RhcnRBbmltYXRpb24oKSBpcyBu b3Qgbm9ybWFsbHkgY2FsbGVkLgogICAgIC8vIEl0IHdpbGwgYXV0b21hdGljYWxseSBwYXVzZSBv bmNlIGFsbCBvYnNlcnZlcnMgbm8gbG9uZ2VyIHdhbnQgdG8gcmVuZGVyIHRoZSBpbWFnZSBhbnl3 aGVyZS4KLSAgICB2aXJ0dWFsIHZvaWQgc3RhcnRBbmltYXRpb24oYm9vbCAvKmNhdGNoVXBJZk5l Y2Vzc2FyeSovID0gdHJ1ZSkgeyB9CisgICAgZW51bSBDYXRjaFVwQW5pbWF0aW9uIHsgRG9Ob3RD YXRjaFVwLCBDYXRjaFVwIH07CisgICAgdmlydHVhbCB2b2lkIHN0YXJ0QW5pbWF0aW9uKENhdGNo VXBBbmltYXRpb24gPSBDYXRjaFVwKSB7IH0KICAgICB2aXJ0dWFsIHZvaWQgc3RvcEFuaW1hdGlv bigpIHt9CiAgICAgdmlydHVhbCB2b2lkIHJlc2V0QW5pbWF0aW9uKCkge30KICAgICAKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL3N2Zy9ncmFwaGljcy9TVkdJbWFnZS5jcHAgYi9Tb3VyY2Uv V2ViQ29yZS9zdmcvZ3JhcGhpY3MvU1ZHSW1hZ2UuY3BwCmluZGV4IDE1ZmNjOTQzYzM4NGViMTli MTA5NTJiZWE5YzBlNTk0ODczMWZkZDUuLjhmZjMyMzdhYjk1NTVhNDY1MTQ3NGNjNDUzM2Q0N2Vh YzFhMTgwZjggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3N2Zy9ncmFwaGljcy9TVkdJbWFn ZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvc3ZnL2dyYXBoaWNzL1NWR0ltYWdlLmNwcApAQCAt MzE2LDcgKzMxNiw3IEBAIHZvaWQgU1ZHSW1hZ2U6OmNvbXB1dGVJbnRyaW5zaWNEaW1lbnNpb25z KExlbmd0aCYgaW50cmluc2ljV2lkdGgsIExlbmd0aCYgaW50cmluCiB9CiAKIC8vIEZJWE1FOiBz dXBwb3J0IGNhdGNoVXBJZk5lY2Vzc2FyeS4KLXZvaWQgU1ZHSW1hZ2U6OnN0YXJ0QW5pbWF0aW9u KGJvb2wgLyogY2F0Y2hVcElmTmVjZXNzYXJ5ICovKQordm9pZCBTVkdJbWFnZTo6c3RhcnRBbmlt YXRpb24oQ2F0Y2hVcEFuaW1hdGlvbikKIHsKICAgICBpZiAoIW1fcGFnZSkKICAgICAgICAgcmV0 dXJuOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvc3ZnL2dyYXBoaWNzL1NWR0ltYWdlLmgg Yi9Tb3VyY2UvV2ViQ29yZS9zdmcvZ3JhcGhpY3MvU1ZHSW1hZ2UuaAppbmRleCA0ODkzZGFmZGE5 NjA2ZTlmZDMyM2U5ZjI5NTY3ZmY2MzBiMDBiOGQyLi43MjdjMGM5OTU4YzExYWViNzliZTUxNmJj NjE3Mjc1MDQyNjJkZWJjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9zdmcvZ3JhcGhpY3Mv U1ZHSW1hZ2UuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9zdmcvZ3JhcGhpY3MvU1ZHSW1hZ2UuaApA QCAtNjAsNyArNjAsNyBAQCBwdWJsaWM6CiAgICAgdmlydHVhbCBib29sIGhhc1JlbGF0aXZlV2lk dGgoKSBjb25zdCBvdmVycmlkZTsKICAgICB2aXJ0dWFsIGJvb2wgaGFzUmVsYXRpdmVIZWlnaHQo KSBjb25zdCBvdmVycmlkZTsKIAotICAgIHZpcnR1YWwgdm9pZCBzdGFydEFuaW1hdGlvbihib29s IC8qY2F0Y2hVcElmTmVjZXNzYXJ5Ki8gPSB0cnVlKSBvdmVycmlkZTsKKyAgICB2aXJ0dWFsIHZv aWQgc3RhcnRBbmltYXRpb24oQ2F0Y2hVcEFuaW1hdGlvbiA9IENhdGNoVXApIG92ZXJyaWRlOwog ICAgIHZpcnR1YWwgdm9pZCBzdG9wQW5pbWF0aW9uKCkgb3ZlcnJpZGU7CiAgICAgdmlydHVhbCB2 b2lkIHJlc2V0QW5pbWF0aW9uKCkgb3ZlcnJpZGU7CiAK