131738 2014-04-16 10:11:01 -0700 [New Multicolumn] columnTranslationForOffset is not column-span-aware 2014-04-22 13:06:09 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 hyatt hyatt commit-queue esprehn+autocc glenn jonlee kondapallykalyan webkit-bug-importer oldest_to_newest 1001178 0 hyatt 2014-04-16 10:11:01 -0700 columnTranslationForOffset needs to work with column-span and with multiple column sets. Right now it only works if the column set is the first one. A column set after a span won't add in its offset like it should. 1001876 1 webkit-bug-importer 2014-04-17 23:13:30 -0700 <rdar://problem/16656294> 1002655 2 hyatt 2014-04-21 13:43:02 -0700 This does not block turning the new columns on. 1003042 3 229909 hyatt 2014-04-22 13:00:48 -0700 Created attachment 229909 Patch Since I'm so close to turning new columns on, this is covered by tests that will be enabled when the flag is flipped. 1003043 4 hyatt 2014-04-22 13:06:09 -0700 Fixed in r167677. 229909 2014-04-22 13:00:48 -0700 2014-04-22 13:03:27 -0700 Patch patch.txt text/plain 3008 hyatt SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2NzY3NSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDE0LTA0LTIyICBEYXZpZCBI eWF0dCAgPGh5YXR0QGFwcGxlLmNvbT4KKworICAgICAgICBbTmV3IE11bHRpY29sdW1uXSBNYWtl IHN1cmUgY29sdW1uVHJhbnNsYXRpb25Gb3JPZmZzZXQgaGFzIHRoZSBzYW1lIGNvbHVtbi1zcGFu LWF3YXJlCisgICAgICAgIHRyYW5zbGF0aW9uIHRoYXQgZnJhZ21lbnQgY29sbGVjdGlvbiBkb2Vz LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMxNzM4 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiByZW5k ZXJpbmcvUmVuZGVyTXVsdGlDb2x1bW5TZXQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVy TXVsdGlDb2x1bW5TZXQ6OmNvbGxlY3RMYXllckZyYWdtZW50cyk6CisgICAgICAgIFJlbW92ZSBh IEZJWE1FIHRoYXQgaXMgbm8gbG9uZ2VyIG5lZWRlZCwgc2luY2UgdGhlIHRyYW5zbGF0aW9uIG9m ZnNldCBvZiB0aGUgCisgICAgICAgIGNvbHVtbiBzZXQgZGlkIGdldCBwYXRjaGVkLgorCisgICAg ICAgIChXZWJDb3JlOjpSZW5kZXJNdWx0aUNvbHVtblNldDo6Y29sdW1uVHJhbnNsYXRpb25Gb3JP ZmZzZXQpOgorICAgICAgICBBZGQgdGhlIGV4YWN0IHNhbWUgZml4IHRvIGNvbHVtblRyYW5zbGF0 aW9uRm9yT2Zmc2V0IHRoYXQgd2FzIGFwcGxpZWQgdG8gY29sbGVjdExheWVyRnJhZ21lbnRzLgor ICAgICAgICAKIDIwMTQtMDQtMjIgIE1hbnVlbCBSZWdvIENhc2Fzbm92YXMgIDxyZWdvQGlnYWxp YS5jb20+CiAKICAgICAgICAgUkVHUkVTU0lPTiAocjE2NzY1Mik6IEJyb2tlIGZhc3QvcmVnaW9u cy9jc3NvbS9yZWdpb24tcmFuZ2UtZm9yLWJveC1jcmFzaC5odG1sIGluIGRlYnVnIG1vZGUKSW5k ZXg6IFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJNdWx0aUNvbHVtblNldC5jcHAKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlck11bHRpQ29sdW1uU2V0 LmNwcAkocmV2aXNpb24gMTY3NjcyKQorKysgU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRl ck11bHRpQ29sdW1uU2V0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNzkwLDkgKzc5MCw3IEBAIHZv aWQgUmVuZGVyTXVsdGlDb2x1bW5TZXQ6OmNvbGxlY3RMYXllckYKICAgICAgICAgdHJhbnNsYXRp b25PZmZzZXQuc2V0WShibG9ja09mZnNldCk7CiAgICAgICAgIGlmICghaXNIb3Jpem9udGFsV3Jp dGluZ01vZGUoKSkKICAgICAgICAgICAgIHRyYW5zbGF0aW9uT2Zmc2V0ID0gdHJhbnNsYXRpb25P ZmZzZXQudHJhbnNwb3NlZFBvaW50KCk7Ci0gICAgICAgIC8vIEZJWE1FOiBUaGUgdHJhbnNsYXRp b24gbmVlZHMgdG8gaW5jbHVkZSB0aGUgbXVsdGljb2x1bW4gc2V0J3MgY29udGVudCBvZmZzZXQg d2l0aGluIHRoZQotICAgICAgICAvLyBtdWx0aWNvbHVtbiBibG9jayBhcyB3ZWxsLiBUaGlzIHdv bid0IGJlIGFuIGlzc3VlIHVudGlsIHdlIHN0YXJ0IGNyZWF0aW5nIG11bHRpcGxlIG11bHRpY29s dW1uIHNldHMuCi0KKyAgICAgICAgCiAgICAgICAgIC8vIFNoaWZ0IHRoZSBkaXJ0eSByZWN0IHRv IGJlIGluIGZsb3cgdGhyZWFkIGNvb3JkaW5hdGVzIHdpdGggdGhpcyB0cmFuc2xhdGlvbiBhcHBs aWVkLgogICAgICAgICBMYXlvdXRSZWN0IHRyYW5zbGF0ZWREaXJ0eVJlY3QoZGlydHlSZWN0KTsK ICAgICAgICAgdHJhbnNsYXRlZERpcnR5UmVjdC5tb3ZlQnkoLXRyYW5zbGF0aW9uT2Zmc2V0KTsK QEAgLTg0MCw3ICs4MzgsNyBAQCBMYXlvdXRQb2ludCBSZW5kZXJNdWx0aUNvbHVtblNldDo6Y29s dW1uCiAgICAgICAgICAgICBpbmxpbmVPZmZzZXQgKz0gY29udGVudExvZ2ljYWxXaWR0aCgpIC0g Y29sTG9naWNhbFdpZHRoOwogICAgIH0KICAgICB0cmFuc2xhdGlvbk9mZnNldC5zZXRYKGlubGlu ZU9mZnNldCk7Ci0gICAgTGF5b3V0VW5pdCBibG9ja09mZnNldCA9IGluaXRpYWxCbG9ja09mZnNl dCArIChpc0hvcml6b250YWxXcml0aW5nTW9kZSgpID8gLWZsb3dUaHJlYWRQb3J0aW9uLnkoKSA6 IC1mbG93VGhyZWFkUG9ydGlvbi54KCkpOworICAgIExheW91dFVuaXQgYmxvY2tPZmZzZXQgPSBp bml0aWFsQmxvY2tPZmZzZXQgKyBsb2dpY2FsVG9wKCkgLSBmbG93VGhyZWFkKCktPmxvZ2ljYWxU b3AoKSArIChpc0hvcml6b250YWxXcml0aW5nTW9kZSgpID8gLWZsb3dUaHJlYWRQb3J0aW9uLnko KSA6IC1mbG93VGhyZWFkUG9ydGlvbi54KCkpOwogICAgIGlmICghcHJvZ3Jlc3Npb25Jc0lubGlu ZSkgewogICAgICAgICBpZiAoIXByb2dyZXNzaW9uUmV2ZXJzZWQpCiAgICAgICAgICAgICBibG9j a09mZnNldCA9IHN0YXJ0Q29sdW1uICogY29sR2FwOwpAQCAtODU0LDggKzg1Miw2IEBAIExheW91 dFBvaW50IFJlbmRlck11bHRpQ29sdW1uU2V0Ojpjb2x1bW4KICAgICBpZiAoIWlzSG9yaXpvbnRh bFdyaXRpbmdNb2RlKCkpCiAgICAgICAgIHRyYW5zbGF0aW9uT2Zmc2V0ID0gdHJhbnNsYXRpb25P ZmZzZXQudHJhbnNwb3NlZFBvaW50KCk7CiAgICAgCi0gICAgLy8gRklYTUU6IFRoZSB0cmFuc2xh dGlvbiBuZWVkcyB0byBpbmNsdWRlIHRoZSBtdWx0aWNvbHVtbiBzZXQncyBjb250ZW50IG9mZnNl dCB3aXRoaW4gdGhlCi0gICAgLy8gbXVsdGljb2x1bW4gYmxvY2sgYXMgd2VsbC4gVGhpcyB3b24n dCBiZSBhbiBpc3N1ZSB1bnRpbCB3ZSBzdGFydCBjcmVhdGluZyBtdWx0aXBsZSBtdWx0aWNvbHVt biBzZXRzLgogICAgIHJldHVybiB0cmFuc2xhdGlvbk9mZnNldDsKIH0KIAo=