131733 2014-04-16 07:54:27 -0700 prepare-ChangeLog reports as deleted methods that has not been removed 2014-04-24 01:55:52 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rego llango.u-szeged commit-queue darin llango.u-szeged rniwa oldest_to_newest 1001139 0 rego 2014-04-16 07:54:27 -0700 After the changes introduced in r166156 prepare-ChangeLog is marking as deleted some methods that have not been modified at all. Take a look to the patch attached to bug #131732 (https://bug-131732-attachments.webkit.org/attachment.cgi?id=229443). prepare-ChangeLog is marking as deleted several methods (logicalContentHeightForChild, minContentForChild, etc.) that are not removed in the patch actually they're not even modified. 1003571 1 230058 llango.u-szeged 2014-04-24 00:46:45 -0700 Created attachment 230058 proposed patch 1003573 2 230058 rego 2014-04-24 00:55:34 -0700 Comment on attachment 230058 proposed patch I've tested it and it works properly for my patch. Thanks. 1003587 3 230058 commit-queue 2014-04-24 01:55:49 -0700 Comment on attachment 230058 proposed patch Clearing flags on attachment: 230058 Committed r167753: <http://trac.webkit.org/changeset/167753> 1003588 4 commit-queue 2014-04-24 01:55:52 -0700 All reviewed patches have been landed. Closing bug. 230058 2014-04-24 00:46:45 -0700 2014-04-24 01:55:49 -0700 proposed patch bug-131733-20140424094623.patch text/plain 1347 llango.u-szeged U3VidmVyc2lvbiBSZXZpc2lvbjogMTY3NzAwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMmJhYTJmZDllOWM5MDMyNzc0OTM1OWNjYzRiNDJiZmUy MDJhMjlmNy4uZjU3MzM0ZDQzMGYxOTYwZjA2YTliZTU2YjA3YzRlNTE1MjhiNzVkMyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDE0LTA0LTI0ICBMw6FzemzDsyBMYW5nw7MgIDxsbGFuZ28udS1zemVnZWRAcGFydG5l ci5zYW1zdW5nLmNvbT4KKworICAgICAgICBwcmVwYXJlLUNoYW5nZUxvZyByZXBvcnRzIGFzIGRl bGV0ZWQgbWV0aG9kcyB0aGF0IGhhcyBub3QgYmVlbiByZW1vdmVkLgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMxNzMzCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL3ByZXBhcmUtQ2hhbmdl TG9nOgorICAgICAgICAob3JpZ2luYWxGaWxlKTogU2V0IG1lcmdlIGJhc2UgdG8gb3JpZ2luL21h c3RlciBieSBkZWZhdWx0LgorCiAyMDE0LTA0LTIyICBUaW0gSG9ydG9uICA8dGltb3RoeV9ob3J0 b25AYXBwbGUuY29tPgogCiAgICAgICAgIER1bXBSZW5kZXJUcmVlIGdlbmVyYXRlcyBibGFjayBz bmFwc2hvdHMgb24gc29tZSBwbGF0Zm9ybXMKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvcHJl cGFyZS1DaGFuZ2VMb2cgYi9Ub29scy9TY3JpcHRzL3ByZXBhcmUtQ2hhbmdlTG9nCmluZGV4IGM1 ODFiN2U0MGRjMDdiOGU3MTZmMzEyNTYzODkwYjM0YzNkYjNjNDguLjM3YmVkZGU3MjE1NGZlZjFi MmFkZTViNGUwOWM4ODA3YzE3MzE5ZDQgMTAwNzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvcHJlcGFy ZS1DaGFuZ2VMb2cKKysrIGIvVG9vbHMvU2NyaXB0cy9wcmVwYXJlLUNoYW5nZUxvZwpAQCAtMjQy LDcgKzI0MiwxMSBAQCBzdWIgb3JpZ2luYWxGaWxlKCQkJCQpCiAgICAgICAgICRjb21tYW5kID0g U1ZOIC4gIiBjYXQgJGVzY2FwZWRQYXRoc1N0cmluZyI7CiAgICAgfSBlbHNpZiAoaXNHaXQoKSkg ewogICAgICAgICAkY29tbWFuZCA9IEdJVCAuICIgc2hvdyAiOwotICAgICAgICAkY29tbWFuZCAu PSAiJG1lcmdlQmFzZSIgaWYgJG1lcmdlQmFzZTsKKyAgICAgICAgaWYgKCRtZXJnZUJhc2UpIHsK KyAgICAgICAgICAgICRjb21tYW5kIC49ICIkbWVyZ2VCYXNlIjsKKyAgICAgICAgfSBlbHNlIHsK KyAgICAgICAgICAgICRjb21tYW5kIC49ICJvcmlnaW4vbWFzdGVyIjsKKyAgICAgICAgfQogICAg ICAgICAkY29tbWFuZCAuPSAiOiRmaWxlIjsKICAgICB9CiAK