131728 2014-04-16 03:55:51 -0700 [WebKit] Cleanup the build from uninitialized variable in JavaScriptCore 2014-04-29 23:11:47 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified VERIFIED FIXED P2 Normal --- 1 shiva.jm mhahnenberg commit-queue mhahnenberg shiva.jm oldest_to_newest 1001114 0 shiva.jm 2014-04-16 03:55:51 -0700 Found uninitialized variable used in JavaScriptCore/runtime/JSObject.cpp during webkit-efl port build. /home/shiva.jm/webkit-git/svngit/WebKit/Source/JavaScriptCore/runtime/JSObject.cpp:824:17: warning: ‘v’ is used uninitialized in this function [-Wuninitialized] JSValue v; 1001173 1 mhahnenberg 2014-04-16 10:04:39 -0700 (In reply to comment #0) > Found uninitialized variable used in JavaScriptCore/runtime/JSObject.cpp during webkit-efl port build. > > /home/shiva.jm/webkit-git/svngit/WebKit/Source/JavaScriptCore/runtime/JSObject.cpp:824:17: warning: ‘v’ is used uninitialized in this function [-Wuninitialized] > JSValue v; This seems wrong. JSValue has a default constructor, so it's not uninitialized. Sounds like your compiler is confused. One thing that might be worth fixing which would incidentally shut the compiler up is do add a default case with a RELEASE_ASSERT. If we don't hit a case in the switch statement then we have a debug ASSERT that will fire. Might as well add the release assert inside the branch that we'll never take. 1001181 2 229453 mhahnenberg 2014-04-16 10:12:05 -0700 Created attachment 229453 Patch 1001233 3 229453 commit-queue 2014-04-16 11:10:25 -0700 Comment on attachment 229453 Patch Clearing flags on attachment: 229453 Committed r167364: <http://trac.webkit.org/changeset/167364> 1001234 4 commit-queue 2014-04-16 11:10:27 -0700 All reviewed patches have been landed. Closing bug. 1005296 5 shiva.jm 2014-04-29 23:11:47 -0700 Bug is fixed tested in version 167979. 229453 2014-04-16 10:12:05 -0700 2014-04-16 11:10:24 -0700 Patch bug-131728-20140416101141.patch text/plain 1394 mhahnenberg SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTY3MzQ5KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBA CisyMDE0LTA0LTE2ICBNYXJrIEhhaG5lbmJlcmcgIDxtaGFobmVuYmVyZ0BhcHBsZS5jb20+CisK KyAgICAgICAgW1dlYktpdF0gQ2xlYW51cCB0aGUgYnVpbGQgZnJvbSB1bmluaXRpYWxpemVkIHZh cmlhYmxlIGluIEphdmFTY3JpcHRDb3JlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xMzE3MjgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIHJ1bnRpbWUvSlNPYmplY3QuY3BwOgorICAgICAgICAoSlNDOjpK U09iamVjdDo6Z2VuZXJpY0NvbnZlcnREb3VibGVUb0NvbnRpZ3VvdXMpOiBBZGQgYSBSRUxFQVNF X0FTU0VSVCBvbiB0aGUgCisgICAgICAgIHBhdGggd2UgZXhwZWN0IHRvIG5ldmVyIHRha2UuIEFs c28gc2h1dCB1cCBjb25mdXNlZCBjb21waWxlcnMgYWJvdXQgdW5pbml0aWFsaXplZCB0aGluZ3Mu CisKIDIwMTQtMDQtMTYgIEdhYm9yIFJhcGNzYW55aSAgPHJnYWJvckB3ZWJraXQub3JnPgogCiAg ICAgICAgIFVucmV2aWV3ZWQsIEFSTTY0IGJ1aWxkZml4IGFmdGVyIHIxNjczMzYuCkluZGV4OiBT b3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU09iamVjdC5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNPYmplY3QuY3BwCShyZXZpc2lvbiAxNjcz MjgpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU09iamVjdC5jcHAJKHdvcmtp bmcgY29weSkKQEAgLTgyOSw2ICs4MjksMTAgQEAgQ29udGlndW91c0pTVmFsdWVzIEpTT2JqZWN0 OjpnZW5lcmljQ29udgogICAgICAgICBjYXNlIFJhZ2VDb252ZXJ0RG91YmxlVG9WYWx1ZToKICAg ICAgICAgICAgIHYgPSBqc051bWJlcih2YWx1ZSk7CiAgICAgICAgICAgICBicmVhazsKKyAgICAg ICAgZGVmYXVsdDoKKyAgICAgICAgICAgIHYgPSBKU1ZhbHVlKCk7CisgICAgICAgICAgICBSRUxF QVNFX0FTU0VSVF9OT1RfUkVBQ0hFRCgpOworICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgIH0K ICAgICAgICAgQVNTRVJUKHYuaXNOdW1iZXIoKSk7CiAgICAgICAgIGN1cnJlbnRBc1ZhbHVlLT5z ZXRXaXRob3V0V3JpdGVCYXJyaWVyKHYpOwo=