131725 2014-04-16 02:41:50 -0700 REGRESSION(r166779): [GTK] Printing doesn't work since r166779 2014-04-16 03:20:33 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Gtk, Regression P2 Normal --- 1 cgarcia webkit-unassigned bunhere commit-queue gyuyoung.kim pnormand rakuco sergio oldest_to_newest 1001102 0 cgarcia 2014-04-16 02:41:50 -0700 Printing doesn't work since r166779, but that revision was not the one introduced the problem, but just revealing it. The problem is that due to some typos in the makefiles, we are always building with printing disabled. $ grep GTK_UNIX_PRINTING cmakeconfig.h #define HAVE_GTK_UNIX_PRINTING 0 1001103 1 229435 cgarcia 2014-04-16 02:44:37 -0700 Created attachment 229435 Patch 1001109 2 229435 pnormand 2014-04-16 03:17:12 -0700 Comment on attachment 229435 Patch Nice one Carlos :) 1001110 3 cgarcia 2014-04-16 03:20:33 -0700 Committed r167344: <http://trac.webkit.org/changeset/167344> 229435 2014-04-16 02:44:37 -0700 2014-04-16 03:17:11 -0700 Patch wk2-fix-printing.diff text/plain 1092 cgarcia ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCAzZGJjNDFlLi41MWMwMzQ4 IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAK KzIwMTQtMDQtMTYgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgor CisgICAgICAgIFJFR1JFU1NJT04ocjE2Njc3OSk6IFtHVEtdIFByaW50aW5nIGRvZXNuJ3Qgd29y ayBzaW5jZSByMTY2Nzc5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xMzE3MjUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIFNvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlOiBDaGVjayBHVEtfVU5JWF9Q UklOVF9GT1VORAorICAgICAgICBpbnN0ZWFkIG9mIEdUS19VTklYX1BSSU5USU5HX0ZPVU5EIGFu ZCBzZXQgdGhlIG1hY3JvCisgICAgICAgIEhBVkVfR1RLX1VOSVhfUFJJTlRJTkcgdG8gMSB3aGVu IGZvdW5kLgorCiAyMDE0LTA0LTExICBCcmlhbiBKLiBCdXJnICA8YnVyZ0Bjcy53YXNoaW5ndG9u LmVkdT4KIAogICAgICAgICBXZWIgUmVwbGF5OiBtZW1vaXplIG5vbmRldGVybWluaXN0aWMgYXR0 cmlidXRlcyBvZiB0aGUgTmF2aWdhdG9yIGludGVyZmFjZQpkaWZmIC0tZ2l0IGEvU291cmNlL2Nt YWtlL09wdGlvbnNHVEsuY21ha2UgYi9Tb3VyY2UvY21ha2UvT3B0aW9uc0dUSy5jbWFrZQppbmRl eCBlZGZmOTNlLi5lYWE1MDdlIDEwMDY0NAotLS0gYS9Tb3VyY2UvY21ha2UvT3B0aW9uc0dUSy5j bWFrZQorKysgYi9Tb3VyY2UvY21ha2UvT3B0aW9uc0dUSy5jbWFrZQpAQCAtMjEwLDggKzIxMCw4 IEBAIGlmIChFTkFCTEVfR0VPTE9DQVRJT04pCiBlbmRpZiAoKQogCiBmaW5kX3BhY2thZ2UoR1RL VW5peFByaW50KQotaWYgKEdUS19VTklYX1BSSU5USU5HX0ZPVU5EKQotICAgIHNldChIQVZFX0dU S19VTklYX1BSSU5USU5HKQoraWYgKEdUS19VTklYX1BSSU5UX0ZPVU5EKQorICAgIHNldChIQVZF X0dUS19VTklYX1BSSU5USU5HIDEpCiBlbmRpZiAoKQogCiBpZiAoRU5BQkxFX0NSRURFTlRJQUxf U1RPUkFHRSkK