131720 2014-04-15 21:02:07 -0700 [iOS][WK2] Improve the approximation of the scroll position of the dynamic viewport size updates 2014-04-16 18:26:33 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 benjamin benjamin enrica thorton oldest_to_newest 1001080 0 benjamin 2014-04-15 21:02:07 -0700 [iOS][WK2] Improve the approximation of the scroll position of the dynamic viewport size updates 1001084 1 229427 benjamin 2014-04-15 21:15:11 -0700 Created attachment 229427 Patch 1001448 2 229427 benjamin 2014-04-16 18:26:30 -0700 Comment on attachment 229427 Patch Clearing flags on attachment: 229427 Committed r167409: <http://trac.webkit.org/changeset/167409> 1001449 3 benjamin 2014-04-16 18:26:33 -0700 All reviewed patches have been landed. Closing bug. 229427 2014-04-15 21:15:11 -0700 2014-04-16 18:26:30 -0700 Patch bug-131720-20140415211450.patch text/plain 6687 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTY3Mjc0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggN2U4YTJlMDEzZTIwYjVj YWFhZjAyYTk2OTkwNGVjYTg3ZTJkZjAxMi4uOGM0YjcyNzcwYmM2MDM5NGI2N2YyZTZhYzc1ZTRh ZjRmODM3OTc4OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI5IEBACisyMDE0LTA0LTE1ICBCZW5q YW1pbiBQb3VsYWluICA8YnBvdWxhaW5AYXBwbGUuY29tPgorCisgICAgICAgIFtpT1NdW1dLMl0g SW1wcm92ZSB0aGUgYXBwcm94aW1hdGlvbiBvZiB0aGUgc2Nyb2xsIHBvc2l0aW9uIG9mIHRoZSBk eW5hbWljIHZpZXdwb3J0IHNpemUgdXBkYXRlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMxNzIwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL0NvY29hL1dLV2ViVmlldy5tbToK KyAgICAgICAgKC1bV0tXZWJWaWV3IF9zY3JvbGxUb0NvbnRlbnRPZmZzZXQ6XSk6CisgICAgICAg IFRoZSBzY3JvbGxpbmcgdHJlZSB3YXMgZm9yY2luZyBzY3JvbGwgYXQgdGhlIHdyb25nIHNjYWxl IGR1cmluZyB0aGUgdHJhbnNpdGlvbi4gCisKKyAgICAgICAgKC1bV0tXZWJWaWV3IF9zZXRNaW5p bXVtTGF5b3V0U2l6ZU92ZXJyaWRlOl0pOgorICAgICAgICBUaGlzIHdhcyBsZWZ0IG91dCBieSBh Y2NpZGVudC4gVGhlIFdlYlByb2Nlc3Mgd2FzIGdldHRpbmcgdGhlIG5ldyBsYXlvdXQgc2l6ZSB0 d2ljZSwgbWFraW5nCisgICAgICAgIFdlYlBhZ2U6OmR5bmFtaWNWaWV3cG9ydFNpemVVcGRhdGUo KSB2ZXJ5IGNvbmZ1c2VkIHdoZW4gdGhlIGNvbnRlbnQgc2l6ZSBjaGFuZ2VzLgorCisgICAgICAg ICogV2ViUHJvY2Vzcy9XZWJQYWdlL2lvcy9XZWJQYWdlSU9TLm1tOgorICAgICAgICAoV2ViS2l0 OjpXZWJQYWdlOjpkeW5hbWljVmlld3BvcnRTaXplVXBkYXRlKToKKyAgICAgICAgQWRkIHNjcm9s bGluZyBhZGp1c3RtZW50IGZvciB0aGUgZHluYW1pYyByZWxheW91dCBjYXNlOgorICAgICAgICAt U3RpY2t5IHRvcCBhbmQgYm90dG9tIGxpa2UgdGhlIFVJUHJvY2Vzcy4KKyAgICAgICAgLUtlZXAg dGhlIHNhbWUgcmVsYXRpdmUgcG9zaXRpb24gb2YgdGhlIHVub2JzY3VyZWQgcmVjdCdzIGNlbnRl ci4KKworICAgICAgICBBbHNvIGZpeCBhIGJ1ZyBpbiB0aGUgaG9yaXpvbnRhbCBhbmQgdmVydGlj YWwgYWRqdXN0bWVudHM6IHRoZSBjb2RlIHdhcyB1c2luZyB0aGUgZXhwb3NlZCByZWN0CisgICAg ICAgIGluc3RlYWQgb2YgdGhlIHVub2JzY3VyZWQgcmVjdCwgd2hpY2ggbWFkZSB0aGUgYWRqdXN0 bWVudHMgb2ZmIGJ5IHRoZSBzaXplIG9mIHRoZSBvYnNjdXJlZCBpbnNldHMuCisKKyAgICAgICAg VGhlIHR5cGUgaXMgY2hhbmdlZCBmcm9tIGRvdWJsZSB0byBmbG9hdCBzaW5jZSBBUk12NyBoYXMg YSBncnVkZ2UgYWdhaW5zdCBkb3VibGUuCisKIDIwMTQtMDQtMTQgIEJlbmphbWluIFBvdWxhaW4g IDxicG91bGFpbkBhcHBsZS5jb20+CiAKICAgICAgICAgW2lPU11bV0syXSBDaGFuZ2UgdGhlIFNQ SSB1c2VkIHdoZW4gc3RhcnRpbmcgdGhlIHJvdGF0aW9uIGFuaW1hdGlvbgpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXcubW0gYi9Tb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29hL1dLV2ViVmlldy5tbQppbmRleCBiNDNiODM3NTEw YTI3MDg3Mjc0NDlhZjE3ZDIwMTkxN2VlOWE0Y2Y3Li4yODVlZTBlMDkwMmRkYTk1YmE2ODRiNTRj YjdiNDZhNDlhYmYxMWU3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJ L0NvY29hL1dLV2ViVmlldy5tbQorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0Nv Y29hL1dLV2ViVmlldy5tbQpAQCAtNTQ2LDEwICs1NDYsMTQgQEAgc3RhdGljIFdlYkNvcmU6OkZs b2F0UG9pbnQgY29uc3RyYWluQ29udGVudE9mZnNldChXZWJDb3JlOjpGbG9hdFBvaW50IGNvbnRl bnRPZmYKIAogLSAodm9pZClfc2Nyb2xsVG9Db250ZW50T2Zmc2V0OihXZWJDb3JlOjpGbG9hdFBv aW50KWNvbnRlbnRPZmZzZXQKIHsKKyAgICBpZiAoX2lzQW5pbWF0aW5nUmVzaXplKQorICAgICAg ICByZXR1cm47CisKICAgICBXZWJDb3JlOjpGbG9hdFBvaW50IHNjYWxlZE9mZnNldCA9IGNvbnRl bnRPZmZzZXQ7CiAgICAgQ0dGbG9hdCB6b29tU2NhbGUgPSBjb250ZW50Wm9vbVNjYWxlKHNlbGYp OwogICAgIHNjYWxlZE9mZnNldC5zY2FsZSh6b29tU2NhbGUsIHpvb21TY2FsZSk7CiAKKyAgICAv LyBGSVhNRTogdGhlIG9mZnNldCBpcyByZWxhdGl2ZSB0byB0aGUgdW5vYnNjdXJlZCByZWN0IHRv cCwgbm90IHRoZSBjb250ZW50IGluc2V0cyEKICAgICBVSUVkZ2VJbnNldHMgaW5zZXQgPSBbX3Nj cm9sbFZpZXcgY29udGVudEluc2V0XTsKICAgICBzY2FsZWRPZmZzZXQgKz0gV2ViQ29yZTo6Rmxv YXRTaXplKC1pbnNldC5sZWZ0LCAtaW5zZXQudG9wKTsKIApAQCAtMTIwMSw3ICsxMjA1LDggQEAg c3RhdGljIGlubGluZSBXZWJLaXQ6OkZpbmRPcHRpb25zIHRvRmluZE9wdGlvbnMoX1dLRmluZE9w dGlvbnMgd2tGaW5kT3B0aW9ucykKIHsKICAgICBfaGFzU3RhdGljTWluaW11bUxheW91dFNpemUg PSBZRVM7CiAgICAgX21pbmltdW1MYXlvdXRTaXplT3ZlcnJpZGUgPSBtaW5pbXVtTGF5b3V0U2l6 ZU92ZXJyaWRlOwotICAgIHNldFZpZXdwb3J0Q29uZmlndXJhdGlvbk1pbmltdW1MYXlvdXRTaXpl KCpfcGFnZSwgbWluaW11bUxheW91dFNpemVPdmVycmlkZSk7CisgICAgaWYgKCFfaXNBbmltYXRp bmdSZXNpemUpCisgICAgICAgIHNldFZpZXdwb3J0Q29uZmlndXJhdGlvbk1pbmltdW1MYXlvdXRT aXplKCpfcGFnZSwgbWluaW11bUxheW91dFNpemVPdmVycmlkZSk7CiB9CiAKIC0gKFVJRWRnZUlu c2V0cylfb2JzY3VyZWRJbnNldHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nl c3MvV2ViUGFnZS9pb3MvV2ViUGFnZUlPUy5tbSBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3Mv V2ViUGFnZS9pb3MvV2ViUGFnZUlPUy5tbQppbmRleCAzMTc3MzZlYmFhNTAxMGIzMjEzNzg5NTdj NzA4OWIyMzUzNzRkYjRjLi43NzMyNzNiZmQyYzRmZmZjNDJhOTBkYjQ1ZjY5MDY4Y2FlMzRiYmY5 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvaW9zL1dlYlBh Z2VJT1MubW0KKysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL2lvcy9XZWJQ YWdlSU9TLm1tCkBAIC0xODAzLDE5ICsxODAzLDQzIEBAIHZvaWQgV2ViUGFnZTo6ZHluYW1pY1Zp ZXdwb3J0U2l6ZVVwZGF0ZShjb25zdCBJbnRTaXplJiBtaW5pbXVtTGF5b3V0U2l6ZSwgY29uc3QK ICAgICAgICAgbmV3VW5vYnNjdXJlZENvbnRlbnRSZWN0LnNldFdpZHRoKHN0ZDo6bWluKHN0YXRp Y19jYXN0PGZsb2F0PihuZXdDb250ZW50U2l6ZS53aWR0aCgpKSwgbmV3RXhwb3NlZENvbnRlbnRS ZWN0LndpZHRoKCkpKTsKICAgICAgICAgbmV3VW5vYnNjdXJlZENvbnRlbnRSZWN0LnNldEhlaWdo dChzdGQ6Om1pbihzdGF0aWNfY2FzdDxmbG9hdD4obmV3Q29udGVudFNpemUuaGVpZ2h0KCkpLCBu ZXdFeHBvc2VkQ29udGVudFJlY3QuaGVpZ2h0KCkpKTsKIAotICAgICAgICBkb3VibGUgaG9yaXpv bnRhbEFkanVzdG1lbnQgPSAwOworICAgICAgICBpZiAob2xkQ29udGVudFNpemUgIT0gbmV3Q29u dGVudFNpemUpIHsKKyAgICAgICAgICAgIC8vIElmIHRoZSBjb250ZW50IHNpemUgaGFzIGNoYW5n ZWQsIGtlZXAgdGhlIHNhbWUgcmVsYXRpdmUgcG9zaXRpb24uCisgICAgICAgICAgICBGbG9hdFBv aW50IG9sZENvbnRlbnRDZW50ZXIgPSB0YXJnZXRVbm9ic2N1cmVkUmVjdC5jZW50ZXIoKTsKKyAg ICAgICAgICAgIGZsb2F0IHJlbGF0aXZlSG9yaXpvbnRhbFBvc2l0aW9uID0gb2xkQ29udGVudENl bnRlci54KCkgLyBvbGRDb250ZW50U2l6ZS53aWR0aCgpOworICAgICAgICAgICAgZmxvYXQgcmVs YXRpdmVWZXJ0aWNhbFBvc2l0aW9uID0gIG9sZENvbnRlbnRDZW50ZXIueSgpIC8gb2xkQ29udGVu dFNpemUuaGVpZ2h0KCk7CisgICAgICAgICAgICBGbG9hdFBvaW50IG5ld1JlbGF0aXZlQ29udGVu dENlbnRlcihyZWxhdGl2ZUhvcml6b250YWxQb3NpdGlvbiAqIG5ld0NvbnRlbnRTaXplLndpZHRo KCksIHJlbGF0aXZlVmVydGljYWxQb3NpdGlvbiAqIG5ld0NvbnRlbnRTaXplLmhlaWdodCgpKTsK KyAgICAgICAgICAgIEZsb2F0UG9pbnQgbmV3VW5vYnNjdXJlZENvbnRlbnRSZWN0Q2VudGVyID0g bmV3VW5vYnNjdXJlZENvbnRlbnRSZWN0LmNlbnRlcigpOworICAgICAgICAgICAgRmxvYXRQb2lu dCBwb3NpdGlvbkRlbHRhKG5ld1JlbGF0aXZlQ29udGVudENlbnRlci54KCkgLSBuZXdVbm9ic2N1 cmVkQ29udGVudFJlY3RDZW50ZXIueCgpLCBuZXdSZWxhdGl2ZUNvbnRlbnRDZW50ZXIueSgpIC0g bmV3VW5vYnNjdXJlZENvbnRlbnRSZWN0Q2VudGVyLnkoKSk7CisgICAgICAgICAgICBuZXdVbm9i c2N1cmVkQ29udGVudFJlY3QubW92ZUJ5KHBvc2l0aW9uRGVsdGEpOworICAgICAgICAgICAgbmV3 RXhwb3NlZENvbnRlbnRSZWN0Lm1vdmVCeShwb3NpdGlvbkRlbHRhKTsKKyAgICAgICAgfQorCisg ICAgICAgIC8vIE1ha2UgdGhlIHRvcC9ib3R0b20gZWRnZXMgInN0aWNreSIgd2l0aGluIDEgcGl4 ZWwuCisgICAgICAgIGlmICh0YXJnZXRVbm9ic2N1cmVkUmVjdC5tYXhZKCkgPiBvbGRDb250ZW50 U2l6ZS5oZWlnaHQoKSAtIDEpIHsKKyAgICAgICAgICAgIGZsb2F0IGJvdHRvbVZlcnRpY2FsUG9z aXRpb24gPSBuZXdDb250ZW50U2l6ZS5oZWlnaHQoKSAtIG5ld1Vub2JzY3VyZWRDb250ZW50UmVj dC5oZWlnaHQoKTsKKyAgICAgICAgICAgIG5ld1Vub2JzY3VyZWRDb250ZW50UmVjdC5zZXRZKGJv dHRvbVZlcnRpY2FsUG9zaXRpb24pOworICAgICAgICAgICAgbmV3RXhwb3NlZENvbnRlbnRSZWN0 LnNldFkoYm90dG9tVmVydGljYWxQb3NpdGlvbik7CisgICAgICAgIH0KKyAgICAgICAgaWYgKHRh cmdldFVub2JzY3VyZWRSZWN0LnkoKSA8IDEpIHsKKyAgICAgICAgICAgIG5ld1Vub2JzY3VyZWRD b250ZW50UmVjdC5zZXRZKDApOworICAgICAgICAgICAgbmV3RXhwb3NlZENvbnRlbnRSZWN0LnNl dFkoMCk7CisgICAgICAgIH0KKworICAgICAgICBmbG9hdCBob3Jpem9udGFsQWRqdXN0bWVudCA9 IDA7CiAgICAgICAgIGlmIChuZXdFeHBvc2VkQ29udGVudFJlY3QubWF4WCgpID4gbmV3Q29udGVu dFNpemUud2lkdGgoKSkKLSAgICAgICAgICAgIGhvcml6b250YWxBZGp1c3RtZW50IC09IG5ld0V4 cG9zZWRDb250ZW50UmVjdC5tYXhYKCkgLSBuZXdDb250ZW50U2l6ZS53aWR0aCgpOwotICAgICAg ICBkb3VibGUgdmVydGljYWxBZGp1c3RtZW50ID0gMDsKKyAgICAgICAgICAgIGhvcml6b250YWxB ZGp1c3RtZW50IC09IG5ld1Vub2JzY3VyZWRDb250ZW50UmVjdC5tYXhYKCkgLSBuZXdDb250ZW50 U2l6ZS53aWR0aCgpOworICAgICAgICBmbG9hdCB2ZXJ0aWNhbEFkanVzdG1lbnQgPSAwOwogICAg ICAgICBpZiAobmV3RXhwb3NlZENvbnRlbnRSZWN0Lm1heFkoKSA+IG5ld0NvbnRlbnRTaXplLmhl aWdodCgpKQotICAgICAgICAgICAgdmVydGljYWxBZGp1c3RtZW50IC09IG5ld0V4cG9zZWRDb250 ZW50UmVjdC5tYXhZKCkgLSBuZXdDb250ZW50U2l6ZS5oZWlnaHQoKTsKKyAgICAgICAgICAgIHZl cnRpY2FsQWRqdXN0bWVudCAtPSBuZXdVbm9ic2N1cmVkQ29udGVudFJlY3QubWF4WSgpIC0gbmV3 Q29udGVudFNpemUuaGVpZ2h0KCk7CiAgICAgICAgIGlmIChuZXdFeHBvc2VkQ29udGVudFJlY3Qu eCgpIDwgMCkKLSAgICAgICAgICAgIGhvcml6b250YWxBZGp1c3RtZW50ICs9IC0gbmV3RXhwb3Nl ZENvbnRlbnRSZWN0LngoKTsKKyAgICAgICAgICAgIGhvcml6b250YWxBZGp1c3RtZW50ICs9IC0g bmV3VW5vYnNjdXJlZENvbnRlbnRSZWN0LngoKTsKICAgICAgICAgaWYgKG5ld0V4cG9zZWRDb250 ZW50UmVjdC55KCkgPCAwKQotICAgICAgICAgICAgdmVydGljYWxBZGp1c3RtZW50ICs9IC0gbmV3 RXhwb3NlZENvbnRlbnRSZWN0LnkoKTsKKyAgICAgICAgICAgIHZlcnRpY2FsQWRqdXN0bWVudCAr PSAtIG5ld1Vub2JzY3VyZWRDb250ZW50UmVjdC55KCk7CiAKLSAgICAgICAgbmV3VW5vYnNjdXJl ZENvbnRlbnRSZWN0Lm1vdmUoaG9yaXpvbnRhbEFkanVzdG1lbnQsIHZlcnRpY2FsQWRqdXN0bWVu dCk7Ci0gICAgICAgIG5ld0V4cG9zZWRDb250ZW50UmVjdC5tb3ZlKGhvcml6b250YWxBZGp1c3Rt ZW50LCB2ZXJ0aWNhbEFkanVzdG1lbnQpOworICAgICAgICBGbG9hdFBvaW50IGFkanVzdG1lbnRE ZWx0YShob3Jpem9udGFsQWRqdXN0bWVudCwgdmVydGljYWxBZGp1c3RtZW50KTsKKyAgICAgICAg bmV3VW5vYnNjdXJlZENvbnRlbnRSZWN0Lm1vdmVCeShhZGp1c3RtZW50RGVsdGEpOworICAgICAg ICBuZXdFeHBvc2VkQ29udGVudFJlY3QubW92ZUJ5KGFkanVzdG1lbnREZWx0YSk7CiAgICAgfQog CiAgICAgZnJhbWVWaWV3LnNldFNjcm9sbFZlbG9jaXR5KDAsIDAsIDAsIG1vbm90b25pY2FsbHlJ bmNyZWFzaW5nVGltZSgpKTsK