131690 2014-04-15 12:34:20 -0700 MacroAssemblerX86::moveDoubleToInts() shouldn't clobber the source 2014-09-12 15:03:44 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 fpizlo fpizlo barraclough ggaren jbriance mark.lam mhahnenberg msaboff oliver sam oldest_to_newest 1000923 0 fpizlo 2014-04-15 12:34:20 -0700 ... 1034943 1 238053 jbriance 2014-09-12 14:00:06 -0700 Created attachment 238053 Do not clobber src register in MacroAssemblerX86::moveDoubleToInts() 1034965 2 238053 oliver 2014-09-12 14:56:36 -0700 Comment on attachment 238053 Do not clobber src register in MacroAssemblerX86::moveDoubleToInts() r=me assuming perf is good 1034969 3 jbriance 2014-09-12 15:03:44 -0700 Manually committed r173580: http://trac.webkit.org/changeset/173580 238053 2014-09-12 14:00:06 -0700 2014-09-12 14:56:35 -0700 Do not clobber src register in MacroAssemblerX86::moveDoubleToInts() bug-131690.patch text/plain 3762 jbriance SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTczNTcyKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBA CisyMDE0LTA5LTEyICBKdWxpZW4gQnJpYW5jZWF1ICA8amJyaWFuY2VAY2lzY28uY29tPgorCisg ICAgICAgIFt4ODZdIG1vdmVEb3VibGVUb0ludHMoKSBkb2VzIG5vdCBjbG9iYmVyIGl0cyBzb3Vy Y2UgcmVnaXN0ZXIgYW55bW9yZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTMxNjkwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBhc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJYODYuaDoKKyAgICAgICAgKEpT Qzo6TWFjcm9Bc3NlbWJsZXJYODY6Om1vdmVEb3VibGVUb0ludHMpOgorICAgICAgICAqIGRmZy9E RkdTcGVjdWxhdGl2ZUpJVC5jcHA6CisgICAgICAgIChKU0M6OkRGRzo6U3BlY3VsYXRpdmVKSVQ6 OmNvbXBpbGVWYWx1ZVJlcCk6CisgICAgICAgICogaml0L1NwZWNpYWxpemVkVGh1bmtKSVQuaDoK KyAgICAgICAgKEpTQzo6U3BlY2lhbGl6ZWRUaHVua0pJVDo6cmV0dXJuRG91YmxlKToKKwogMjAx NC0wOS0xMiAgTWljaGFlbCBTYWJvZmYgIDxtc2Fib2ZmQGFwcGxlLmNvbT4KIAogICAgICAgICBS ZW1vdmUgdW5uZWVkZWQgZGVjbGFyYXRpb25zIGZyb20gSlNDYWxsZWUuaApJbmRleDogU291cmNl L0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlclg4Ni5oCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJYODYuaAko cmV2aXNpb24gMTczNTcxKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNy b0Fzc2VtYmxlclg4Ni5oCSh3b3JraW5nIGNvcHkpCkBAIC0xNjgsMTQgKzE2OCwxNCBAQCBwdWJs aWM6CiAgICAgICAgIG1fYXNzZW1ibGVyLm1vdmJfaThtKGltbS5tX3ZhbHVlLCBhZGRyZXNzKTsK ICAgICB9CiAgICAgCi0gICAgLy8gUG9zc2libHkgY2xvYmJlcnMgc3JjLgotICAgIC8vIEZJWE1F OiBEb24ndCBkbyB0aGF0LgotICAgIC8vIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xMzE2OTAKICAgICB2b2lkIG1vdmVEb3VibGVUb0ludHMoRlBSZWdpc3RlcklEIHNy YywgUmVnaXN0ZXJJRCBkZXN0MSwgUmVnaXN0ZXJJRCBkZXN0MikKICAgICB7CisgICAgICAgIEFT U0VSVChpc1NTRTJQcmVzZW50KCkpOworICAgICAgICBtX2Fzc2VtYmxlci5wZXh0cndfaXJyKDMs IHNyYywgZGVzdDEpOworICAgICAgICBtX2Fzc2VtYmxlci5wZXh0cndfaXJyKDIsIHNyYywgZGVz dDIpOworICAgICAgICBsc2hpZnQzMihUcnVzdGVkSW1tMzIoMTYpLCBkZXN0MSk7CisgICAgICAg IG9yMzIoZGVzdDEsIGRlc3QyKTsKICAgICAgICAgbW92ZVBhY2tlZFRvSW50MzIoc3JjLCBkZXN0 MSk7Ci0gICAgICAgIHJzaGlmdFBhY2tlZChUcnVzdGVkSW1tMzIoMzIpLCBzcmMpOwotICAgICAg ICBtb3ZlUGFja2VkVG9JbnQzMihzcmMsIGRlc3QyKTsKICAgICB9CiAKICAgICB2b2lkIG1vdmVJ bnRzVG9Eb3VibGUoUmVnaXN0ZXJJRCBzcmMxLCBSZWdpc3RlcklEIHNyYzIsIEZQUmVnaXN0ZXJJ RCBkZXN0LCBGUFJlZ2lzdGVySUQgc2NyYXRjaCkKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS9kZmcvREZHU3BlY3VsYXRpdmVKSVQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9kZmcvREZHU3BlY3VsYXRpdmVKSVQuY3BwCShyZXZpc2lvbiAxNzM1NzEpCisrKyBT b3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1NwZWN1bGF0aXZlSklULmNwcAkod29ya2luZyBj b3B5KQpAQCAtMjE3OCwxNCArMjE3OCw2IEBAIHZvaWQgU3BlY3VsYXRpdmVKSVQ6OmNvbXBpbGVW YWx1ZVJlcChOb2QKICAgICAgICAgaWYgKG5lZWRzVHlwZUNoZWNrKG5vZGUtPmNoaWxkMSgpLCB+ U3BlY0RvdWJsZUltcHVyZU5hTikpCiAgICAgICAgICAgICBtX2ppdC5wdXJpZnlOYU4odmFsdWVG UFIpOwogCi0jaWYgQ1BVKFg4NikKLSAgICAgICAgLy8gYm94RG91YmxlKCkgb24gWDg2IGNsb2Ji ZXJzIHRoZSBzb3VyY2UsIHNvIHdlIG5lZWQgdG8gY29weS4KLSAgICAgICAgLy8gRklYTUU6IERv bid0IGRvIHRoYXQhIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzE2 OTAKLSAgICAgICAgRlBSVGVtcG9yYXJ5IHRlbXAodGhpcyk7Ci0gICAgICAgIG1faml0Lm1vdmVE b3VibGUodmFsdWVGUFIsIHRlbXAuZnByKCkpOwotICAgICAgICB2YWx1ZUZQUiA9IHRlbXAuZnBy KCk7Ci0jZW5kaWYKLSAgICAgICAgCiAgICAgICAgIGJveERvdWJsZSh2YWx1ZUZQUiwgcmVzdWx0 UmVncyk7CiAgICAgICAgIAogICAgICAgICBqc1ZhbHVlUmVzdWx0KHJlc3VsdFJlZ3MsIG5vZGUp OwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9TcGVjaWFsaXplZFRodW5rSklULmgK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9TcGVjaWFsaXplZFRodW5r SklULmgJKHJldmlzaW9uIDE3MzU3MSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvU3Bl Y2lhbGl6ZWRUaHVua0pJVC5oCSh3b3JraW5nIGNvcHkpCkBAIC0xMjksMTQgKzEyOSw3IEBAIG5h bWVzcGFjZSBKU0MgewogICAgICAgICAgICAgbW92ZSh0YWdUeXBlTnVtYmVyUmVnaXN0ZXIsIHJl Z1QwKTsKICAgICAgICAgICAgIGRvbmUubGluayh0aGlzKTsKICNlbHNlCi0jaWYgIUNQVShYODYp Ci0gICAgICAgICAgICAvLyBUaGUgc3JjIHJlZ2lzdGVyIGlzIG5vdCBjbG9iYmVyZWQgYnkgbW92 ZURvdWJsZVRvSW50cyB3aXRoIEFSTSwgTUlQUyBhbmQgU0g0IG1hY3JvIGFzc2VtYmxlcnMsIHNv IGxldCdzIHVzZSBpdC4KICAgICAgICAgICAgIG1vdmVEb3VibGVUb0ludHMoc3JjLCByZWdUMCwg cmVnVDEpOwotI2Vsc2UKLSAgICAgICAgICAgIHN0b3JlRG91YmxlKHNyYywgQWRkcmVzcyhzdGFj a1BvaW50ZXJSZWdpc3RlciwgLShpbnQpc2l6ZW9mKGRvdWJsZSkpKTsKLSAgICAgICAgICAgIGxv YWRQdHIoQWRkcmVzcyhzdGFja1BvaW50ZXJSZWdpc3RlciwgT0JKRUNUX09GRlNFVE9GKEpTVmFs dWUsIHUuYXNCaXRzLnRhZykgLSBzaXplb2YoZG91YmxlKSksIHJlZ1QxKTsKLSAgICAgICAgICAg IGxvYWRQdHIoQWRkcmVzcyhzdGFja1BvaW50ZXJSZWdpc3RlciwgT0JKRUNUX09GRlNFVE9GKEpT VmFsdWUsIHUuYXNCaXRzLnBheWxvYWQpIC0gc2l6ZW9mKGRvdWJsZSkpLCByZWdUMCk7Ci0jZW5k aWYKICAgICAgICAgICAgIEp1bXAgbG93Tm9uWmVybyA9IGJyYW5jaFRlc3RQdHIoTm9uWmVybywg cmVnVDEpOwogICAgICAgICAgICAgSnVtcCBoaWdoTm9uWmVybyA9IGJyYW5jaFRlc3RQdHIoTm9u WmVybywgcmVnVDApOwogICAgICAgICAgICAgbW92ZShUcnVzdGVkSW1tMzIoMCksIHJlZ1QwKTsK