131677 2014-04-15 06:02:18 -0700 [EFL] Cleanup the build from unused parameters in WebKit-efl 2014-04-16 05:26:12 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Other Linux RESOLVED FIXED P2 Normal --- 1 je_julie.kim webkit-unassigned bunhere cdumez commit-queue gyuyoung.kim gyuyoung.kim lucas.de.marchi sergio oldest_to_newest 1000839 0 je_julie.kim 2014-04-15 06:02:18 -0700 There are some unused params on WebKit-efl. 1000840 1 229367 je_julie.kim 2014-04-15 06:08:21 -0700 Created attachment 229367 Patch 1000852 2 229367 gyuyoung.kim 2014-04-15 08:42:37 -0700 Comment on attachment 229367 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=229367&action=review > Source/WebKit/efl/ewk/ewk_network.cpp:-56 > -void ewk_network_tls_certificate_check_set(Eina_Bool checkCertificates) This isn't to remove only parameter name. This is to remove parameter itself. So, you have to say why you should change function argument. 1001070 3 je_julie.kim 2014-04-15 19:11:26 -0700 Gyuyoung, Thank you for your feedback. (In reply to comment #2) > > Source/WebKit/efl/ewk/ewk_network.cpp:-56 > > -void ewk_network_tls_certificate_check_set(Eina_Bool checkCertificates) > > This isn't to remove only parameter name. This is to remove parameter itself. So, you have to say why you should change function argument. I thought rule for removing parameter name is for cases that there is already predefined prototype. For instance, parent class has virtual member API with several params but child class which has real implementation doesn't need some of params. Or, some cases depending on Feature Enabled. In this case, ewk_network_tls_certificate_check_set is API based on C (I mean there is no dependency) and I thought that it's not necessary any more. How do you think? Thanks, 1001075 4 gyuyoung.kim 2014-04-15 20:18:57 -0700 (In reply to comment #3) > Gyuyoung, Thank you for your feedback. > (In reply to comment #2) > > > Source/WebKit/efl/ewk/ewk_network.cpp:-56 > > > -void ewk_network_tls_certificate_check_set(Eina_Bool checkCertificates) > > > > This isn't to remove only parameter name. This is to remove parameter itself. So, you have to say why you should change function argument. > > I thought rule for removing parameter name is for cases that there is already predefined prototype. > For instance, parent class has virtual member API with several params but child class which has real implementation doesn't need some of params. Or, some cases depending on Feature Enabled. > > In this case, > ewk_network_tls_certificate_check_set is API based on C (I mean there is no dependency) and I thought that it's not necessary any more. > > How do you think? > Thanks, ASSERT_UNUSED() is matched a rule to remove unused parameter. However, in ewk_network_tls_certificate_check_set() case, you are changing function behavior. So, ewk_network_tls_certificate_check_set() needs to be handled in new bug. 1001118 5 229438 je_julie.kim 2014-04-16 04:42:48 -0700 Created attachment 229438 Patch 1001120 6 je_julie.kim 2014-04-16 04:54:19 -0700 (In reply to comment #4) > ASSERT_UNUSED() is matched a rule to remove unused parameter. However, in ewk_network_tls_certificate_check_set() case, you are changing function behavior. So, ewk_network_tls_certificate_check_set() needs to be handled in new bug. Gyuyoung, thank you for your comment. I fixed unused param warning only on ewk_view_scroll with this issue. Please look into it. Thanks, 1001122 7 gyuyoung.kim 2014-04-16 04:56:47 -0700 LGTM. 1001123 8 229438 commit-queue 2014-04-16 05:26:06 -0700 Comment on attachment 229438 Patch Clearing flags on attachment: 229438 Committed r167346: <http://trac.webkit.org/changeset/167346> 1001124 9 commit-queue 2014-04-16 05:26:12 -0700 All reviewed patches have been landed. Closing bug. 229367 2014-04-15 06:08:21 -0700 2014-04-16 04:42:36 -0700 Patch bug-131677-20140415220756.patch text/plain 4092 je_julie.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTY3MzA0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Vm bC9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2VmbC9DaGFuZ2VMb2cKaW5kZXggMWE3ZDNiOWVm ZjEzOGUwNWM0OTMwZjY4MzU0ZWFmMzE1OGI2NDQyZC4uMGQ0ODdiNzNlM2FhM2QwM2Q0ODViNGUw YzY5YzY2ODdjM2IxOGZlMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE0 LTA0LTE1ICBKZW9uZ2V1biBLaW0gIDxqZV9qdWxpZS5raW1Ac2Ftc3VuZy5jb20+CisKKyAgICAg ICAgW0VGTF0gQ2xlYW51cCB0aGUgYnVpbGQgZnJvbSB1bnVzZWQgcGFyYW1ldGVycyBpbiBXZWJL aXQtZWZsLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTMxNjc3LgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFJlbW92ZWQgdW51c2VkIHBhcmFtIGZyb20gZXdrX25ldHdvcmtfdGxzX2NlcnRpZmljYXRlX2No ZWNrX3NldC4KKyAgICAgICAgQ2hhbmdlZCBBU1NFUlQgdG8gQVNTRVJUX1VOVVNFRCBpZiBpdCdz IGp1c3QgdXNlZCBmb3IgQVNTRVJULgorCisgICAgICAgICogZXdrL2V3a19tYWluLmNwcDoKKyAg ICAgICAgKF9ld2tfaW5pdF9ib2R5KToKKyAgICAgICAgKiBld2svZXdrX25ldHdvcmsuY3BwOgor ICAgICAgICAoZXdrX25ldHdvcmtfdGxzX2NlcnRpZmljYXRlX2NoZWNrX3NldCk6CisgICAgICAg ICogZXdrL2V3a19uZXR3b3JrLmg6CisgICAgICAgICogZXdrL2V3a192aWV3LmNwcDoKKyAgICAg ICAgKGV3a192aWV3X3Njcm9sbCk6CisKIDIwMTQtMDQtMTIgIFlvdWVubiBGYWJsZXQgIDx5b3Vl bm4uZmFibGV0QGNyZi5jYW5vbi5mcj4KIAogICAgICAgICBbU09VUF0gTGlic291cCBpbnRlcm5h bCBjcmVkZW50aWFsIHNldHRpbmcgc2hvdWxkIGJlIGNvbnRyb2xsZWQgYnkgbG9hZGVyIGRlY2lz aW9uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX21haW4uY3BwIGIvU291 cmNlL1dlYktpdC9lZmwvZXdrL2V3a19tYWluLmNwcAppbmRleCAyNjk4NzYyZGZkMjBkMWQyNzk0 ODc2OGU4NWQ1MjE4ZDQ2NGFkZWJhLi42NWZkY2Q1NTFkNmY1MmRiZTE5Y2E4N2MyOGRhZDE4N2My MjA5NGZlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX21haW4uY3BwCisr KyBiL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfbWFpbi5jcHAKQEAgLTIwMSw3ICsyMDEsNyBA QCBFaW5hX0Jvb2wgX2V3a19pbml0X2JvZHkodm9pZCkKICAgICBld2tfc2V0dGluZ3NfYXBwbGlj YXRpb25fY2FjaGVfcGF0aF9zZXQoYXBwbGljYXRpb25DYWNoZURpcmVjdG9yeS51dGY4KCkuZGF0 YSgpKTsKICAgICBld2tfc2V0dGluZ3NfZmlsZV9zeXN0ZW1fcGF0aF9zZXQoZmlsZVN5c3RlbURp cmVjdG9yeS51dGY4KCkuZGF0YSgpKTsKIAotICAgIGV3a19uZXR3b3JrX3Rsc19jZXJ0aWZpY2F0 ZV9jaGVja19zZXQoZmFsc2UpOworICAgIGV3a19uZXR3b3JrX3Rsc19jZXJ0aWZpY2F0ZV9jaGVj a19zZXQoKTsKIAogICAgIFdlYkNvcmU6OlN0b3JhZ2VUcmFja2VyOjppbml0aWFsaXplVHJhY2tl cihsb2NhbFN0b3JhZ2VEaXJlY3RvcnkudXRmOCgpLmRhdGEoKSwgdHJhY2tlckNsaWVudCgpKTsK IApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a19uZXR3b3JrLmNwcCBiL1Nv dXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfbmV0d29yay5jcHAKaW5kZXggYTdjMjFmNmYwZDRkMDQ3 MWNjYjliNzIxMTlmYmFkOTkwODk2MmQxYi4uM2U2ZWIzYjNhYTJhYjE3MDcyMmE0ZDkxMjY3MTJl YmYyYTFiZTRjNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a19uZXR3b3Jr LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX25ldHdvcmsuY3BwCkBAIC01Myw3 ICs1Myw3IEBAIEVpbmFfQm9vbCBld2tfbmV0d29ya190bHNfY2VydGlmaWNhdGVfY2hlY2tfZ2V0 KCkKICAgICByZXR1cm4gcG9saWN5ICYgV2ViQ29yZTo6U291cE5ldHdvcmtTZXNzaW9uOjpTU0xT dHJpY3Q7CiB9CiAKLXZvaWQgZXdrX25ldHdvcmtfdGxzX2NlcnRpZmljYXRlX2NoZWNrX3NldChF aW5hX0Jvb2wgY2hlY2tDZXJ0aWZpY2F0ZXMpCit2b2lkIGV3a19uZXR3b3JrX3Rsc19jZXJ0aWZp Y2F0ZV9jaGVja19zZXQodm9pZCkKIHsKICAgICB1bnNpZ25lZCBwb2xpY3kgPSBXZWJDb3JlOjpT b3VwTmV0d29ya1Nlc3Npb246OmRlZmF1bHRTZXNzaW9uKCkuc3NsUG9saWN5KCk7CiAgICAgV2Vi Q29yZTo6U291cE5ldHdvcmtTZXNzaW9uOjpkZWZhdWx0U2Vzc2lvbigpLnNldFNTTFBvbGljeShw b2xpY3kgfCBXZWJDb3JlOjpTb3VwTmV0d29ya1Nlc3Npb246OlNTTFN0cmljdCk7CmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX25ldHdvcmsuaCBiL1NvdXJjZS9XZWJLaXQv ZWZsL2V3ay9ld2tfbmV0d29yay5oCmluZGV4IGEwYWRkMGUyZDVhZDBmZDFlYWQ1MGJhY2ZmY2Uy NTAxOGM1ZDU5OTEuLjhhNWQ2NmE0OTUzZjlmMjNiNzdmNjBiNmUwM2I1N2ZhYTc1NzQwODIgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfbmV0d29yay5oCisrKyBiL1NvdXJj ZS9XZWJLaXQvZWZsL2V3ay9ld2tfbmV0d29yay5oCkBAIC02MSwxMSArNjEsOSBAQCBFQVBJIEVp bmFfQm9vbCAgICAgICAgZXdrX25ldHdvcmtfdGxzX2NlcnRpZmljYXRlX2NoZWNrX2dldCh2b2lk KTsKICAqCiAgKiBCeSBkZWZhdWx0LCBIVFRQUyBjb25uZWN0aW9ucyBhcmUgcGVyZm9ybWVkIHJl Z2FyZGxlc3Mgb2YgdGhlIHZhbGlkaXR5IG9mIHRoZSBjZXJ0aWZpY2F0ZSBwcm92aWRlZC4KICAq Ci0gKiBAcGFyYW0gZW5hYmxlIFdoZXRoZXIgdG8gY2hlY2sgdGhlIHByb3ZpZGVkIGNlcnRpZmlj YXRlcyBvciBub3QuCi0gKgogICogQHNhIGV3a19uZXR3b3JrX3Rsc19jYV9jZXJ0aWZpY2F0ZXNf cGF0aF9zZXQKICAqLwotRUFQSSB2b2lkICAgICAgICAgICAgIGV3a19uZXR3b3JrX3Rsc19jZXJ0 aWZpY2F0ZV9jaGVja19zZXQoRWluYV9Cb29sIGVuYWJsZSk7CitFQVBJIHZvaWQgICAgICAgICAg ICAgZXdrX25ldHdvcmtfdGxzX2NlcnRpZmljYXRlX2NoZWNrX3NldCh2b2lkKTsKIAogLyoqCiAg KiBSZXR1cm5zIHRoZSBwYXRoIHRvIGEgZmlsZSBjb250YWluaW5nIHRoZSBwbGF0Zm9ybSdzIHJv b3QgWC41MDkgQ0EgY2VydGlmaWNhdGVzLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9lZmwv ZXdrL2V3a192aWV3LmNwcCBiL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfdmlldy5jcHAKaW5k ZXggMjA4NDE0MWU2Njc2ZDBiNGFhNWY1ZGY4MGUzMTU4YjE2YWQ0YjU4NC4uNGZlMjNhMDBiMDY4 NDE0MDFjYjM2NjI4ODQwNWY5ZTM1NGViNWI0NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9l ZmwvZXdrL2V3a192aWV3LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3ZpZXcu Y3BwCkBAIC0zNTIwLDggKzM1MjAsOCBAQCB2b2lkIGV3a192aWV3X3JlcGFpbnQoRXZhc19PYmpl Y3QqIGV3a1ZpZXcsIEV2YXNfQ29vcmQgeCwgRXZhc19Db29yZCB5LCBFdmFzX0NvbwogCiB2b2lk IGV3a192aWV3X3Njcm9sbChFdmFzX09iamVjdCogZXdrVmlldywgY29uc3QgV2ViQ29yZTo6SW50 U2l6ZSYgZGVsdGEsIGNvbnN0IFdlYkNvcmU6OkludFJlY3QmIHJlY3RUb1Njcm9sbCwgY29uc3Qg V2ViQ29yZTo6SW50UmVjdCYpCiB7Ci0gICAgQVNTRVJUKCFyZWN0VG9TY3JvbGwuaXNFbXB0eSgp KTsKLSAgICBBU1NFUlQoZGVsdGEud2lkdGgoKSB8fCBkZWx0YS5oZWlnaHQoKSk7CisgICAgQVNT RVJUX1VOVVNFRChyZWN0VG9TY3JvbGwsICFyZWN0VG9TY3JvbGwuaXNFbXB0eSgpKTsKKyAgICBB U1NFUlRfVU5VU0VEKGRlbHRhLCBkZWx0YS53aWR0aCgpIHx8IGRlbHRhLmhlaWdodCgpKTsKIAog ICAgIEVXS19WSUVXX1NEX0dFVF9PUl9SRVRVUk4oZXdrVmlldywgc21hcnREYXRhKTsKICAgICBF V0tfVklFV19QUklWX0dFVF9PUl9SRVRVUk4oc21hcnREYXRhLCBwcml2KTsK 229438 2014-04-16 04:42:48 -0700 2014-04-16 05:26:06 -0700 Patch bug-131677-20140416204222.patch text/plain 1605 je_julie.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTY3MzA0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Vm bC9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2VmbC9DaGFuZ2VMb2cKaW5kZXggMWE3ZDNiOWVm ZjEzOGUwNWM0OTMwZjY4MzU0ZWFmMzE1OGI2NDQyZC4uNWJmMDdjMWNjMGJjYTBlOWUyNTA1ZDQ4 MWRkYjViYTVmNjJkNTgwZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE0 LTA0LTE2ICBKZW9uZ2V1biBLaW0gIDxqZV9qdWxpZS5raW1Ac2Ftc3VuZy5jb20+CisKKyAgICAg ICAgW0VGTF0gQ2xlYW51cCB0aGUgYnVpbGQgZnJvbSB1bnVzZWQgcGFyYW1ldGVycyBpbiBXZWJL aXQtZWZsLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTMxNjc3LgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IENoYW5nZWQgQVNTRVJUIHRvIEFTU0VSVF9VTlVTRUQgaWYgaXQncyBqdXN0IHVzZWQgZm9yIEFT U0VSVC4KKworICAgICAgICAqIGV3ay9ld2tfdmlldy5jcHA6CisgICAgICAgIChld2tfdmlld19z Y3JvbGwpOgorCiAyMDE0LTA0LTEyICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uLmZhYmxldEBjcmYu Y2Fub24uZnI+CiAKICAgICAgICAgW1NPVVBdIExpYnNvdXAgaW50ZXJuYWwgY3JlZGVudGlhbCBz ZXR0aW5nIHNob3VsZCBiZSBjb250cm9sbGVkIGJ5IGxvYWRlciBkZWNpc2lvbgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a192aWV3LmNwcCBiL1NvdXJjZS9XZWJLaXQvZWZs L2V3ay9ld2tfdmlldy5jcHAKaW5kZXggMjA4NDE0MWU2Njc2ZDBiNGFhNWY1ZGY4MGUzMTU4YjE2 YWQ0YjU4NC4uNGZlMjNhMDBiMDY4NDE0MDFjYjM2NjI4ODQwNWY5ZTM1NGViNWI0NSAxMDA2NDQK LS0tIGEvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a192aWV3LmNwcAorKysgYi9Tb3VyY2UvV2Vi S2l0L2VmbC9ld2svZXdrX3ZpZXcuY3BwCkBAIC0zNTIwLDggKzM1MjAsOCBAQCB2b2lkIGV3a192 aWV3X3JlcGFpbnQoRXZhc19PYmplY3QqIGV3a1ZpZXcsIEV2YXNfQ29vcmQgeCwgRXZhc19Db29y ZCB5LCBFdmFzX0NvbwogCiB2b2lkIGV3a192aWV3X3Njcm9sbChFdmFzX09iamVjdCogZXdrVmll dywgY29uc3QgV2ViQ29yZTo6SW50U2l6ZSYgZGVsdGEsIGNvbnN0IFdlYkNvcmU6OkludFJlY3Qm IHJlY3RUb1Njcm9sbCwgY29uc3QgV2ViQ29yZTo6SW50UmVjdCYpCiB7Ci0gICAgQVNTRVJUKCFy ZWN0VG9TY3JvbGwuaXNFbXB0eSgpKTsKLSAgICBBU1NFUlQoZGVsdGEud2lkdGgoKSB8fCBkZWx0 YS5oZWlnaHQoKSk7CisgICAgQVNTRVJUX1VOVVNFRChyZWN0VG9TY3JvbGwsICFyZWN0VG9TY3Jv bGwuaXNFbXB0eSgpKTsKKyAgICBBU1NFUlRfVU5VU0VEKGRlbHRhLCBkZWx0YS53aWR0aCgpIHx8 IGRlbHRhLmhlaWdodCgpKTsKIAogICAgIEVXS19WSUVXX1NEX0dFVF9PUl9SRVRVUk4oZXdrVmll dywgc21hcnREYXRhKTsKICAgICBFV0tfVklFV19QUklWX0dFVF9PUl9SRVRVUk4oc21hcnREYXRh LCBwcml2KTsK