131675 2014-04-15 03:45:34 -0700 REGRESSION(r165841): Messages sent before the child process is launched are never sent 2014-05-24 00:18:30 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Gtk, InRadar, Regression P2 Normal --- 130419 131729 132384 133215 1 cgarcia webkit-unassigned andersca ap clopez mitz mrobinson ossy ryuan.choi sam zsborbely.u-szeged oldest_to_newest 1000825 0 cgarcia 2014-04-15 03:45:34 -0700 Since r165841, the connection is opened after the pending messages are sent, because connectionWillOpen might send messages that we want to happen after the ones already pending. The problem is that Connection::canSendOutgoingMessages() returns false when connection hasn't been opened (m_isConnected). So, I think we should not send any message before Connection::open(). This broke a lot of GTK+ unit tests since it's very common in unit tests to have messages sent before the web process has been launched. I think we can change connectionWillOpen, and use ConnectionDidOpen instead, called after Connection::open. 1000829 1 229366 cgarcia 2014-04-15 04:51:17 -0700 Created attachment 229366 Patch I think we should ensure no messages are sent before the connection has been opened. This patch moves the visited link provider process initialization after the connection has been opened. 1000877 2 ap 2014-04-15 10:09:00 -0700 <rdar://problem/16621575> 1001201 3 ryuan.choi 2014-04-16 10:35:59 -0700 This patch solved many crashes of layout tests/unit tests on the EFL port. 1003559 4 cgarcia 2014-04-23 23:46:27 -0700 Could someone review this, please? Otherwise I would suggest to rollout r165841. 1010456 5 clopez 2014-05-20 04:39:57 -0700 This patch also fixes bug 127352. See: https://bugs.webkit.org/show_bug.cgi?id=127352#c14 1010458 6 ossy 2014-05-20 04:58:50 -0700 I think it is a duplicate of Bug131037. Zsolt, could you check if this patch solves the problem you ran into with EFL perf bot in Bug131037. As far as I know r165841 is reverted locally on the EFL perf bot. 1010752 7 zsborbely.u-szeged 2014-05-21 07:34:35 -0700 I have double-checked, this patch solves the problem that was mentioned in https://bugs.webkit.org/show_bug.cgi?id=131037 Thanks. 1010754 8 zsborbely.u-szeged 2014-05-21 07:36:25 -0700 *** Bug 131037 has been marked as a duplicate of this bug. *** 1011230 9 ossy 2014-05-23 05:59:13 -0700 In my opinion, if more than a month wasn't enough for WK2 owners to review the fix for the regression they caused, we should simply revert r165841. 1011261 10 mrobinson 2014-05-23 09:50:43 -0700 (In reply to comment #9) > In my opinion, if more than a month wasn't enough for WK2 owners to review > the fix for the regression they caused, we should simply revert r165841. Perhaps we should just send a polite request to the mailing list asking for a review. It seems like this patch is quite important, as it's causing our bots to rot. 1011268 11 clopez 2014-05-23 10:04:39 -0700 (In reply to comment #4) > Could someone review this, please? The patch not longer applies on trunk. It needs to be rebased. 1011284 12 cgarcia 2014-05-23 10:24:14 -0700 (In reply to comment #11) > (In reply to comment #4) > > Could someone review this, please? > > The patch not longer applies on trunk. It needs to be rebased. Yes, now we have the same problem with the user content controller. 1011285 13 231972 cgarcia 2014-05-23 10:26:33 -0700 Created attachment 231972 Rebased patch 1011314 14 231972 andersca 2014-05-23 11:28:14 -0700 Comment on attachment 231972 Rebased patch Patch looks good, please land it. If it turns out to be a problem for Mac we can roll it out and figure out a better way to solve it! 1011496 15 cgarcia 2014-05-24 00:18:30 -0700 Committed r169306: <http://trac.webkit.org/changeset/169306> 229366 2014-04-15 04:51:17 -0700 2014-05-23 10:26:33 -0700 Patch wk2-send-message-connection-open.diff text/plain 4856 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCAyNmYyY2QwLi4zNzYzODM0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMzEg QEAKKzIwMTQtMDQtMTUgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFJFR1JFU1NJT04ocjE2NTg0MSk6IE1lc3NhZ2VzIHNlbnQgYmVmb3JlIHRo ZSBjaGlsZCBwcm9jZXNzIGlzIGxhdW5jaGVkIGFyZSBuZXZlciBzZW50IGFmdGVyIHIxNjU4NDEK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMTY3NQor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFNpbmNlIHIx NjU4NDEgdGhlIGNvbm5lY3Rpb24gaXMgb3BlbmVkIGFmdGVyIHRoZSBwZW5kaW5nIG1lc3NhZ2Vz CisgICAgICAgIGFyZSBzZW50LCBiZWNhdXNlIGNvbm5lY3Rpb25XaWxsT3BlbiBtaWdodCBzZW5k IG1lc3NhZ2VzIHRoYXQgd2UKKyAgICAgICAgd2FudCB0byBoYXBwZW4gYWZ0ZXIgdGhlIG9uZXMg YWxyZWFkeSBwZW5kaW5nLiBUaGUgcHJvYmxlbSBpcyB0aGF0CisgICAgICAgIENvbm5lY3Rpb246 OmNhblNlbmRPdXRnb2luZ01lc3NhZ2VzKCkgcmV0dXJucyBmYWxzZSB3aGVuCisgICAgICAgIGNv bm5lY3Rpb24gaGFzbid0IGJlZW4gb3BlbmVkLiBXZSBzaG91bGQgZW5zdXJlIG5vIG1lc3NhZ2Vz IGFyZQorICAgICAgICBzZW50IGJ5IGNvbm5lY3Rpb25XaWxsT3Blbi4KKworICAgICAgICAqIFNo YXJlZC9DaGlsZFByb2Nlc3NQcm94eS5jcHA6CisgICAgICAgIChXZWJLaXQ6OkNoaWxkUHJvY2Vz c1Byb3h5OjpkaWRGaW5pc2hMYXVuY2hpbmcpOiBPcGVuIHRoZQorICAgICAgICBjb25uZWN0aW9u IGJlZm9yZSBzZW5kaW5nIHBlbmRpbmcgbWVzc2FnZXMuCisgICAgICAgICogVUlQcm9jZXNzL1dl YlBhZ2VQcm94eS5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlBhZ2VQcm94eTo6Y29ubmVjdGlv bldpbGxPcGVuKTogRG8gbm90IGNhbGwKKyAgICAgICAgVmlzaXRlZExpbmtQcm92aWRlcjo6YWRk UHJvY2VzcygpIGhlcmUgYmVjYXVzZSBpdCB0cmllcyB0byBzZW5kIGEKKyAgICAgICAgbWVzc2Fn ZSB0byB0aGUgd2ViIHByb2Nlc3MsIGJ1dCB0aGUgY29ubmVjdGlvbiBoYXNuJ3QgYmUgb3BlbmVk IHlldC4KKyAgICAgICAgKFdlYktpdDo6V2ViUGFnZVByb3h5Ojpwcm9jZXNzRGlkRmluaXNoTGF1 bmNoaW5nKTogQ2FsbAorICAgICAgICBWaXNpdGVkTGlua1Byb3ZpZGVyOjphZGRQcm9jZXNzKCkg aGVyZSBpbnN0ZWFkLgorICAgICAgICAqIFVJUHJvY2Vzcy9XZWJQYWdlUHJveHkuaDoKKyAgICAg ICAgKiBVSVByb2Nlc3MvV2ViUHJvY2Vzc1Byb3h5LmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2Vi UHJvY2Vzc1Byb3h5OjpkaWRGaW5pc2hMYXVuY2hpbmcpOiBDYWxsCisgICAgICAgIFdlYlBhZ2VQ cm94eTo6cHJvY2Vzc0RpZEZpbmlzaExhdW5jaGluZygpIGZvciBldmVyeSB3ZWIgcGFnZS4KKwog MjAxNC0wNC0xNSAgQ29tbWl0IFF1ZXVlICA8Y29tbWl0LXF1ZXVlQHdlYmtpdC5vcmc+CiAKICAg ICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjE2NzI5OC4KZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQyL1NoYXJlZC9DaGlsZFByb2Nlc3NQcm94eS5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9T aGFyZWQvQ2hpbGRQcm9jZXNzUHJveHkuY3BwCmluZGV4IGFhMTRhMWIuLmEyMjMxZTIgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9DaGlsZFByb2Nlc3NQcm94eS5jcHAKKysrIGIv U291cmNlL1dlYktpdDIvU2hhcmVkL0NoaWxkUHJvY2Vzc1Byb3h5LmNwcApAQCAtMTMyLDE1ICsx MzIsMTUgQEAgdm9pZCBDaGlsZFByb2Nlc3NQcm94eTo6ZGlkRmluaXNoTGF1bmNoaW5nKFByb2Nl c3NMYXVuY2hlciosIElQQzo6Q29ubmVjdGlvbjo6SWQKICAgICBtX2Nvbm5lY3Rpb24tPnNldFNo b3VsZENsb3NlQ29ubmVjdGlvbk9uTWFjaEV4Y2VwdGlvbnMoKTsKICNlbmRpZgogCisgICAgY29u bmVjdGlvbldpbGxPcGVuKG1fY29ubmVjdGlvbi5nZXQoKSk7CisgICAgbV9jb25uZWN0aW9uLT5v cGVuKCk7CisKICAgICBmb3IgKHNpemVfdCBpID0gMDsgaSA8IG1fcGVuZGluZ01lc3NhZ2VzLnNp emUoKTsgKytpKSB7CiAgICAgICAgIHN0ZDo6dW5pcXVlX3B0cjxJUEM6Ok1lc3NhZ2VFbmNvZGVy PiBtZXNzYWdlID0gc3RkOjptb3ZlKG1fcGVuZGluZ01lc3NhZ2VzW2ldLmZpcnN0KTsKICAgICAg ICAgdW5zaWduZWQgbWVzc2FnZVNlbmRGbGFncyA9IG1fcGVuZGluZ01lc3NhZ2VzW2ldLnNlY29u ZDsKICAgICAgICAgbV9jb25uZWN0aW9uLT5zZW5kTWVzc2FnZShzdGQ6Om1vdmUobWVzc2FnZSks IG1lc3NhZ2VTZW5kRmxhZ3MpOwogICAgIH0KIAotICAgIGNvbm5lY3Rpb25XaWxsT3BlbihtX2Nv bm5lY3Rpb24uZ2V0KCkpOwotICAgIG1fY29ubmVjdGlvbi0+b3BlbigpOwotCiAgICAgbV9wZW5k aW5nTWVzc2FnZXMuY2xlYXIoKTsKIH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFn ZVByb3h5LmNwcAppbmRleCAzZDM1MTM5Li5jNmIxYzQyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvV2ViUGFnZVByb3h5LmNwcApAQCAtMjgzMiw4ICsyODMyLDYgQEAgdm9pZCBXZWJQYWdl UHJveHk6OmNvbm5lY3Rpb25XaWxsT3BlbihJUEM6OkNvbm5lY3Rpb24qIGNvbm5lY3Rpb24pCiB7 CiAgICAgQVNTRVJUKGNvbm5lY3Rpb24gPT0gbV9wcm9jZXNzLT5jb25uZWN0aW9uKCkpOwogCi0g ICAgbV92aXNpdGVkTGlua1Byb3ZpZGVyLT5hZGRQcm9jZXNzKG1fcHJvY2Vzcy5nZXQoKSk7Ci0K ICAgICBtX3Byb2Nlc3MtPmNvbnRleHQoKS5zdG9yYWdlTWFuYWdlcigpLnNldEFsbG93ZWRTZXNz aW9uU3RvcmFnZU5hbWVzcGFjZUNvbm5lY3Rpb24obV9wYWdlSUQsIGNvbm5lY3Rpb24pOwogfQog CkBAIC0yODQ0LDYgKzI4NDIsMTEgQEAgdm9pZCBXZWJQYWdlUHJveHk6OmNvbm5lY3Rpb25XaWxs Q2xvc2UoSVBDOjpDb25uZWN0aW9uKiBjb25uZWN0aW9uKQogICAgIG1fcHJvY2Vzcy0+Y29udGV4 dCgpLnN0b3JhZ2VNYW5hZ2VyKCkuc2V0QWxsb3dlZFNlc3Npb25TdG9yYWdlTmFtZXNwYWNlQ29u bmVjdGlvbihtX3BhZ2VJRCwgMCk7CiB9CiAKK3ZvaWQgV2ViUGFnZVByb3h5Ojpwcm9jZXNzRGlk RmluaXNoTGF1bmNoaW5nKCkKK3sKKyAgICBtX3Zpc2l0ZWRMaW5rUHJvdmlkZXItPmFkZFByb2Nl c3MobV9wcm9jZXNzLmdldCgpKTsKK30KKwogI2lmIEVOQUJMRShORVRTQ0FQRV9QTFVHSU5fQVBJ KQogdm9pZCBXZWJQYWdlUHJveHk6OnVuYXZhaWxhYmxlUGx1Z2luQnV0dG9uQ2xpY2tlZCh1aW50 MzJfdCBvcGFxdWVQbHVnaW5VbmF2YWlsYWJpbGl0eVJlYXNvbiwgY29uc3QgU3RyaW5nJiBtaW1l VHlwZSwgY29uc3QgU3RyaW5nJiBwbHVnaW5VUkxTdHJpbmcsIGNvbnN0IFN0cmluZyYgcGx1Z2lu c3BhZ2VBdHRyaWJ1dGVVUkxTdHJpbmcsIGNvbnN0IFN0cmluZyYgZnJhbWVVUkxTdHJpbmcsIGNv bnN0IFN0cmluZyYgcGFnZVVSTFN0cmluZykKIHsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuaCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQ YWdlUHJveHkuaAppbmRleCAxY2NkZjAwLi5iNDNiOGNiZSAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9XZWJQYWdlUHJveHkuaApAQCAtMTAzNSw2ICsxMDM1LDggQEAgcHVibGljOgogICAgIHZv aWQgY29ubmVjdGlvbldpbGxPcGVuKElQQzo6Q29ubmVjdGlvbiopOwogICAgIHZvaWQgY29ubmVj dGlvbldpbGxDbG9zZShJUEM6OkNvbm5lY3Rpb24qKTsKIAorICAgIHZvaWQgcHJvY2Vzc0RpZEZp bmlzaExhdW5jaGluZygpOworCiAgICAgdm9pZCBkaWRTYXZlVG9QYWdlQ2FjaGUoKTsKICAgICAg ICAgCiAgICAgdm9pZCBzZXRTY3JvbGxQaW5uaW5nQmVoYXZpb3IoV2ViQ29yZTo6U2Nyb2xsUGlu bmluZ0JlaGF2aW9yKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQ cm9jZXNzUHJveHkuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYlByb2Nlc3NQcm94 eS5jcHAKaW5kZXggNjcwMGExMy4uN2NmYTc1OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL1dlYlByb2Nlc3NQcm94eS5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL1dlYlByb2Nlc3NQcm94eS5jcHAKQEAgLTQ1MSw2ICs0NTEsOSBAQCB2b2lkIFdlYlByb2Nl c3NQcm94eTo6ZGlkRmluaXNoTGF1bmNoaW5nKFByb2Nlc3NMYXVuY2hlciogbGF1bmNoZXIsIElQ Qzo6Q29ubmVjdAogewogICAgIENoaWxkUHJvY2Vzc1Byb3h5OjpkaWRGaW5pc2hMYXVuY2hpbmco bGF1bmNoZXIsIGNvbm5lY3Rpb25JZGVudGlmaWVyKTsKIAorICAgIGZvciAoYXV0byYgcGFnZSA6 IG1fcGFnZU1hcC52YWx1ZXMoKSkKKyAgICAgICAgcGFnZS0+cHJvY2Vzc0RpZEZpbmlzaExhdW5j aGluZygpOworCiAgICAgbV93ZWJDb25uZWN0aW9uID0gV2ViQ29ubmVjdGlvblRvV2ViUHJvY2Vz czo6Y3JlYXRlKHRoaXMpOwogCiAgICAgbV9jb250ZXh0LT5wcm9jZXNzRGlkRmluaXNoTGF1bmNo aW5nKHRoaXMpOwo= 231972 2014-05-23 10:26:33 -0700 2014-05-23 11:28:14 -0700 Rebased patch wk2-pending-messages.diff text/plain 5060 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBhNmUzZjljMy4uZDZmMGI2ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dDIvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMx IEBACisyMDE0LTA1LTIzICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNv bT4KKworICAgICAgICBSRUdSRVNTSU9OKHIxNjU4NDEpOiBNZXNzYWdlcyBzZW50IGJlZm9yZSB0 aGUgY2hpbGQgcHJvY2VzcyBpcyBsYXVuY2hlZCBhcmUgbmV2ZXIgc2VudCBhZnRlciByMTY1ODQx CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzE2NzUK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTaW5jZSBy MTY1ODQxIHRoZSBjb25uZWN0aW9uIGlzIG9wZW5lZCBhZnRlciB0aGUgcGVuZGluZyBtZXNzYWdl cworICAgICAgICBhcmUgc2VudCwgYmVjYXVzZSBjb25uZWN0aW9uV2lsbE9wZW4gbWlnaHQgc2Vu ZCBtZXNzYWdlcyB0aGF0IHdlCisgICAgICAgIHdhbnQgdG8gaGFwcGVuIGFmdGVyIHRoZSBvbmVz IGFscmVhZHkgcGVuZGluZy4gVGhlIHByb2JsZW0gaXMgdGhhdAorICAgICAgICBDb25uZWN0aW9u OjpjYW5TZW5kT3V0Z29pbmdNZXNzYWdlcygpIHJldHVybnMgZmFsc2Ugd2hlbgorICAgICAgICBj b25uZWN0aW9uIGhhc24ndCBiZWVuIG9wZW5lZC4gV2Ugc2hvdWxkIGVuc3VyZSBubyBtZXNzYWdl cyBhcmUKKyAgICAgICAgc2VudCBieSBjb25uZWN0aW9uV2lsbE9wZW4uCisKKyAgICAgICAgKiBT aGFyZWQvQ2hpbGRQcm9jZXNzUHJveHkuY3BwOgorICAgICAgICAoV2ViS2l0OjpDaGlsZFByb2Nl c3NQcm94eTo6ZGlkRmluaXNoTGF1bmNoaW5nKTogT3BlbiB0aGUKKyAgICAgICAgY29ubmVjdGlv biBiZWZvcmUgc2VuZGluZyBwZW5kaW5nIG1lc3NhZ2VzLgorICAgICAgICAqIFVJUHJvY2Vzcy9X ZWJQYWdlUHJveHkuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJQYWdlUHJveHk6OmNvbm5lY3Rp b25XaWxsT3Blbik6IERvIG5vdCBjYWxsCisgICAgICAgIFZpc2l0ZWRMaW5rUHJvdmlkZXI6OmFk ZFByb2Nlc3MoKSBoZXJlIGJlY2F1c2UgaXQgdHJpZXMgdG8gc2VuZCBhCisgICAgICAgIG1lc3Nh Z2UgdG8gdGhlIHdlYiBwcm9jZXNzLCBidXQgdGhlIGNvbm5lY3Rpb24gaGFzbid0IGJlIG9wZW5l ZCB5ZXQuCisgICAgICAgIChXZWJLaXQ6OldlYlBhZ2VQcm94eTo6cHJvY2Vzc0RpZEZpbmlzaExh dW5jaGluZyk6IENhbGwKKyAgICAgICAgVmlzaXRlZExpbmtQcm92aWRlcjo6YWRkUHJvY2Vzcygp IGhlcmUgaW5zdGVhZC4KKyAgICAgICAgKiBVSVByb2Nlc3MvV2ViUGFnZVByb3h5Lmg6CisgICAg ICAgICogVUlQcm9jZXNzL1dlYlByb2Nlc3NQcm94eS5jcHA6CisgICAgICAgIChXZWJLaXQ6Oldl YlByb2Nlc3NQcm94eTo6ZGlkRmluaXNoTGF1bmNoaW5nKTogQ2FsbAorICAgICAgICBXZWJQYWdl UHJveHk6OnByb2Nlc3NEaWRGaW5pc2hMYXVuY2hpbmcoKSBmb3IgZXZlcnkgd2ViIHBhZ2UuCisK IDIwMTQtMDUtMjMgIERhbiBCZXJuc3RlaW4gIDxtaXR6QGFwcGxlLmNvbT4KIAogICAgICAgICBb Q29jb2FdIFdLTmF2aWdhdGlvblJlc3BvbnNlUHJpdmF0ZS5oIGlzIGludGVybmFsCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvQ2hpbGRQcm9jZXNzUHJveHkuY3BwIGIvU291cmNl L1dlYktpdDIvU2hhcmVkL0NoaWxkUHJvY2Vzc1Byb3h5LmNwcAppbmRleCBmODVmNDk3Li4wMWVj NjE1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvQ2hpbGRQcm9jZXNzUHJveHku Y3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9DaGlsZFByb2Nlc3NQcm94eS5jcHAKQEAg LTEzOCwxNSArMTM4LDE1IEBAIHZvaWQgQ2hpbGRQcm9jZXNzUHJveHk6OmRpZEZpbmlzaExhdW5j aGluZyhQcm9jZXNzTGF1bmNoZXIqLCBJUEM6OkNvbm5lY3Rpb246OklkCiAgICAgbV9jb25uZWN0 aW9uLT5zZXRTaG91bGRDbG9zZUNvbm5lY3Rpb25Pbk1hY2hFeGNlcHRpb25zKCk7CiAjZW5kaWYK IAorICAgIGNvbm5lY3Rpb25XaWxsT3BlbihtX2Nvbm5lY3Rpb24uZ2V0KCkpOworICAgIG1fY29u bmVjdGlvbi0+b3BlbigpOworCiAgICAgZm9yIChzaXplX3QgaSA9IDA7IGkgPCBtX3BlbmRpbmdN ZXNzYWdlcy5zaXplKCk7ICsraSkgewogICAgICAgICBzdGQ6OnVuaXF1ZV9wdHI8SVBDOjpNZXNz YWdlRW5jb2Rlcj4gbWVzc2FnZSA9IHN0ZDo6bW92ZShtX3BlbmRpbmdNZXNzYWdlc1tpXS5maXJz dCk7CiAgICAgICAgIHVuc2lnbmVkIG1lc3NhZ2VTZW5kRmxhZ3MgPSBtX3BlbmRpbmdNZXNzYWdl c1tpXS5zZWNvbmQ7CiAgICAgICAgIG1fY29ubmVjdGlvbi0+c2VuZE1lc3NhZ2Uoc3RkOjptb3Zl KG1lc3NhZ2UpLCBtZXNzYWdlU2VuZEZsYWdzKTsKICAgICB9CiAKLSAgICBjb25uZWN0aW9uV2ls bE9wZW4obV9jb25uZWN0aW9uLmdldCgpKTsKLSAgICBtX2Nvbm5lY3Rpb24tPm9wZW4oKTsKLQog ICAgIG1fcGVuZGluZ01lc3NhZ2VzLmNsZWFyKCk7CiB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL1dlYlBhZ2VQcm94eS5jcHAKaW5kZXggN2Y3ZGEyYS4uNWQyYWM0ZCAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAKKysrIGIvU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAKQEAgLTI5MTgsMTAgKzI5MTgsNiBAQCB2 b2lkIFdlYlBhZ2VQcm94eTo6Y29ubmVjdGlvbldpbGxPcGVuKElQQzo6Q29ubmVjdGlvbiogY29u bmVjdGlvbikKIHsKICAgICBBU1NFUlQoY29ubmVjdGlvbiA9PSBtX3Byb2Nlc3MtPmNvbm5lY3Rp b24oKSk7CiAKLSAgICBpZiAobV91c2VyQ29udGVudENvbnRyb2xsZXIpCi0gICAgICAgIG1fdXNl ckNvbnRlbnRDb250cm9sbGVyLT5hZGRQcm9jZXNzKG1fcHJvY2Vzcy5nZXQoKSk7Ci0gICAgbV92 aXNpdGVkTGlua1Byb3ZpZGVyLT5hZGRQcm9jZXNzKG1fcHJvY2Vzcy5nZXQoKSk7Ci0KICAgICBt X3Byb2Nlc3MtPmNvbnRleHQoKS5zdG9yYWdlTWFuYWdlcigpLnNldEFsbG93ZWRTZXNzaW9uU3Rv cmFnZU5hbWVzcGFjZUNvbm5lY3Rpb24obV9wYWdlSUQsIGNvbm5lY3Rpb24pOwogfQogCkBAIC0y OTMyLDYgKzI5MjgsMTMgQEAgdm9pZCBXZWJQYWdlUHJveHk6OmNvbm5lY3Rpb25XaWxsQ2xvc2Uo SVBDOjpDb25uZWN0aW9uKiBjb25uZWN0aW9uKQogICAgIG1fcHJvY2Vzcy0+Y29udGV4dCgpLnN0 b3JhZ2VNYW5hZ2VyKCkuc2V0QWxsb3dlZFNlc3Npb25TdG9yYWdlTmFtZXNwYWNlQ29ubmVjdGlv bihtX3BhZ2VJRCwgMCk7CiB9CiAKK3ZvaWQgV2ViUGFnZVByb3h5Ojpwcm9jZXNzRGlkRmluaXNo TGF1bmNoaW5nKCkKK3sKKyAgICBpZiAobV91c2VyQ29udGVudENvbnRyb2xsZXIpCisgICAgICAg IG1fdXNlckNvbnRlbnRDb250cm9sbGVyLT5hZGRQcm9jZXNzKG1fcHJvY2Vzcy5nZXQoKSk7Cisg ICAgbV92aXNpdGVkTGlua1Byb3ZpZGVyLT5hZGRQcm9jZXNzKG1fcHJvY2Vzcy5nZXQoKSk7Cit9 CisKICNpZiBFTkFCTEUoTkVUU0NBUEVfUExVR0lOX0FQSSkKIHZvaWQgV2ViUGFnZVByb3h5Ojp1 bmF2YWlsYWJsZVBsdWdpbkJ1dHRvbkNsaWNrZWQodWludDMyX3Qgb3BhcXVlUGx1Z2luVW5hdmFp bGFiaWxpdHlSZWFzb24sIGNvbnN0IFN0cmluZyYgbWltZVR5cGUsIGNvbnN0IFN0cmluZyYgcGx1 Z2luVVJMU3RyaW5nLCBjb25zdCBTdHJpbmcmIHBsdWdpbnNwYWdlQXR0cmlidXRlVVJMU3RyaW5n LCBjb25zdCBTdHJpbmcmIGZyYW1lVVJMU3RyaW5nLCBjb25zdCBTdHJpbmcmIHBhZ2VVUkxTdHJp bmcpCiB7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5 LmggYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmgKaW5kZXggZGY1MDVj Mi4uZWJkZTM5OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VQ cm94eS5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuaApAQCAt MTA3NCw2ICsxMDc0LDggQEAgcHVibGljOgogICAgIHZvaWQgY29ubmVjdGlvbldpbGxPcGVuKElQ Qzo6Q29ubmVjdGlvbiopOwogICAgIHZvaWQgY29ubmVjdGlvbldpbGxDbG9zZShJUEM6OkNvbm5l Y3Rpb24qKTsKIAorICAgIHZvaWQgcHJvY2Vzc0RpZEZpbmlzaExhdW5jaGluZygpOworCiAgICAg dm9pZCBkaWRTYXZlVG9QYWdlQ2FjaGUoKTsKICAgICAgICAgCiAgICAgdm9pZCBzZXRTY3JvbGxQ aW5uaW5nQmVoYXZpb3IoV2ViQ29yZTo6U2Nyb2xsUGlubmluZ0JlaGF2aW9yKTsKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQcm9jZXNzUHJveHkuY3BwIGIvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL1dlYlByb2Nlc3NQcm94eS5jcHAKaW5kZXggMDYwNDhkNC4uNzRl YTJjOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYlByb2Nlc3NQcm94 eS5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYlByb2Nlc3NQcm94eS5jcHAK QEAgLTQ1NCw2ICs0NTQsOSBAQCB2b2lkIFdlYlByb2Nlc3NQcm94eTo6ZGlkRmluaXNoTGF1bmNo aW5nKFByb2Nlc3NMYXVuY2hlciogbGF1bmNoZXIsIElQQzo6Q29ubmVjdAogewogICAgIENoaWxk UHJvY2Vzc1Byb3h5OjpkaWRGaW5pc2hMYXVuY2hpbmcobGF1bmNoZXIsIGNvbm5lY3Rpb25JZGVu dGlmaWVyKTsKIAorICAgIGZvciAoYXV0byYgcGFnZSA6IG1fcGFnZU1hcC52YWx1ZXMoKSkKKyAg ICAgICAgcGFnZS0+cHJvY2Vzc0RpZEZpbmlzaExhdW5jaGluZygpOworCiAgICAgbV93ZWJDb25u ZWN0aW9uID0gV2ViQ29ubmVjdGlvblRvV2ViUHJvY2Vzczo6Y3JlYXRlKHRoaXMpOwogCiAgICAg bV9jb250ZXh0LT5wcm9jZXNzRGlkRmluaXNoTGF1bmNoaW5nKHRoaXMpOwo=