<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>131674</bug_id>
          
          <creation_ts>2014-04-15 01:49:39 -0700</creation_ts>
          <short_desc>Web Inspector: CodeMirror LICENSE is not properly added to combined files</short_desc>
          <delta_ts>2014-04-15 18:52:03 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Web Inspector</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Timothy Hatcher">timothy</reporter>
          <assigned_to name="Timothy Hatcher">timothy</assigned_to>
          <cc>bfulgham</cc>
    
    <cc>commit-queue</cc>
    
    <cc>graouts</cc>
    
    <cc>joepeck</cc>
    
    <cc>timothy</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1000817</commentid>
    <comment_count>0</comment_count>
    <who name="Timothy Hatcher">timothy</who>
    <bug_when>2014-04-15 01:49:39 -0700</bug_when>
    <thetext>The combined CodeMirror.js and CodeMirror.css files contain the WebKit license header not the CodeMirror license.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1000818</commentid>
    <comment_count>1</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2014-04-15 01:50:44 -0700</bug_when>
    <thetext>&lt;rdar://problem/16618318&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1000819</commentid>
    <comment_count>2</comment_count>
      <attachid>229363</attachid>
    <who name="Timothy Hatcher">timothy</who>
    <bug_when>2014-04-15 01:53:43 -0700</bug_when>
    <thetext>Created attachment 229363
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1000856</commentid>
    <comment_count>3</comment_count>
      <attachid>229363</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2014-04-15 09:16:54 -0700</bug_when>
    <thetext>Comment on attachment 229363
Patch

Clearing flags on attachment: 229363

Committed r167307: &lt;http://trac.webkit.org/changeset/167307&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1000857</commentid>
    <comment_count>4</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2014-04-15 09:16:57 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1001064</commentid>
    <comment_count>5</comment_count>
    <who name="Joseph Pecoraro">joepeck</who>
    <bug_when>2014-04-15 18:52:03 -0700</bug_when>
    <thetext>Doh! Good catch</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>229363</attachid>
            <date>2014-04-15 01:53:43 -0700</date>
            <delta_ts>2014-04-15 09:16:54 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-131674-20140415015321.patch</filename>
            <type>text/plain</type>
            <size>1902</size>
            <attacher name="Timothy Hatcher">timothy</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTY3Mjg2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj
dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCA5
NGEwYmUwODE2NWU4ZGM0MzJiZmE2Mzk3NDYzMjVhNmQ4NGY2MDhmLi45OWE2NmQ0NTE1MTBiOGI3
MTY0NjI5NTBmMTUyY2U5ZWRmZTA1NmUwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y
VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs
MyArMSwxMyBAQAorMjAxNC0wNC0xNSAgVGltb3RoeSBIYXRjaGVyICA8dGltb3RoeUBhcHBsZS5j
b20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogQ29kZU1pcnJvciBMSUNFTlNFIGlzIG5vdCBw
cm9wZXJseSBhZGRlZCB0byBjb21iaW5lZCBmaWxlcworICAgICAgICBodHRwczovL2J1Z3Mud2Vi
a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMxNjc0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C
T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL2NvcHktdXNlci1pbnRlcmZhY2UtcmVz
b3VyY2VzLnBsOiBVc2UgJENPREVfTUlSUk9SX0xJQ0VOU0UgaW5zdGVhZAorICAgICAgICBmb3Ig
Q29kZU1pcnJvci5jc3MgYW5kIENvZGVNaXJyb3IuanMuCisKIDIwMTQtMDQtMDggIEJyZW50IEZ1
bGdoYW0gIDxiZnVsZ2hhbUBhcHBsZS5jb20+CiAKICAgICAgICAgW1dpbmRvd3NdIEdlbmVyYXRl
IE9wdGltaXplZCBXZWJJbnNwZWN0b3JVSSBpbiBSZWxlYXNlIEJ1aWxkCmRpZmYgLS1naXQgYS9T
b3VyY2UvV2ViSW5zcGVjdG9yVUkvU2NyaXB0cy9jb3B5LXVzZXItaW50ZXJmYWNlLXJlc291cmNl
cy5wbCBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9TY3JpcHRzL2NvcHktdXNlci1pbnRlcmZhY2Ut
cmVzb3VyY2VzLnBsCmluZGV4IDZkYWZlYjFkMTVlZGI0MjRlYmZlM2UxODk3OTlhNzVhZjk4NzZj
ZDguLmJlMWUzYjZhNDhkN2ExZjQwOTBlMjRlZWI4NmE4YzE1NWViNGEzMzMgMTAwNzU1Ci0tLSBh
L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9TY3JpcHRzL2NvcHktdXNlci1pbnRlcmZhY2UtcmVzb3Vy
Y2VzLnBsCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9TY3JpcHRzL2NvcHktdXNlci1pbnRl
cmZhY2UtcmVzb3VyY2VzLnBsCkBAIC0xMzMsMTAgKzEzMywxMCBAQCBpZiAoZGVmaW5lZCAkRU5W
eydDT01CSU5FX0lOU1BFQ1RPUl9SRVNPVVJDRVMnfSAmJiAoJEVOVnsnQ09NQklORV9JTlNQRUNU
T1JfUkVTTwogCiAgICAgIyBFeHBvcnQgdGhlIGxpY2Vuc2UgaW50byBDb2RlTWlycm9yLmpzIGFu
ZCBDb2RlTWlycm9yLmNzcy4KICAgICBteSAkdGFyZ2V0Q29kZU1pcnJvckpTID0gRmlsZTo6U3Bl
Yy0+Y2F0ZmlsZSgkdGFyZ2V0UmVzb3VyY2VQYXRoLCAnQ29kZU1pcnJvci5qcycpOwotICAgIHNl
ZWRGaWxlKCR0YXJnZXRDb2RlTWlycm9ySlMsICRMSUNFTlNFKTsKKyAgICBzZWVkRmlsZSgkdGFy
Z2V0Q29kZU1pcnJvckpTLCAkQ09ERV9NSVJST1JfTElDRU5TRSk7CiAKICAgICBteSAkdGFyZ2V0
Q29kZU1pcnJvckNTUyA9IEZpbGU6OlNwZWMtPmNhdGZpbGUoJHRhcmdldFJlc291cmNlUGF0aCwg
J0NvZGVNaXJyb3IuY3NzJyk7Ci0gICAgc2VlZEZpbGUoJHRhcmdldENvZGVNaXJyb3JDU1MsICRM
SUNFTlNFKTsKKyAgICBzZWVkRmlsZSgkdGFyZ2V0Q29kZU1pcnJvckNTUywgJENPREVfTUlSUk9S
X0xJQ0VOU0UpOwogCiAgICAgIyBNaW5pZnkgdGhlIE1haW4uanMgYW5kIE1haW4uY3NzIGZpbGVz
LCB3aXRoIE1haW4uanMgYXBwZW5kaW5nIHRvIHRoZSBsaWNlbnNlIHRoYXQgd2FzIGV4cG9ydGVk
IGFib3ZlLgogICAgIG15ICRqc01pblNjcmlwdCA9IEZpbGU6OlNwZWMtPmNhdGZpbGUoJHNjcmlw
dHNSb290LCAnanNtaW4ucHknKTsK
</data>

          </attachment>
      

    </bug>

</bugzilla>