131663 2014-04-14 22:25:20 -0700 [EFL][WK2] Pass Mouse movement data to WebMouseEvent 2014-04-15 06:01:40 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jinwoo7.song jinwoo7.song bunhere cdumez commit-queue enmi.lee gyuyoung.kim gyuyoung.kim lucas.de.marchi sergio oldest_to_newest 1000744 0 jinwoo7.song 2014-04-14 22:25:20 -0700 Currently mouse movement data are not passed to WebMouseEvent. Instead, they are set to 0 as default. EFL port needs to send the deltaX and deltaY for PointerLock API which will be implemented later. 1000745 1 229347 jinwoo7.song 2014-04-14 22:27:03 -0700 Created attachment 229347 Patch 1000746 2 commit-queue 2014-04-14 22:28:53 -0700 Attachment 229347 did not pass style-queue: ERROR: Source/WebKit2/ChangeLog:8: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebKit2/ChangeLog:9: Line contains tab character. [whitespace/tab] [5] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1000748 3 229348 jinwoo7.song 2014-04-14 22:30:59 -0700 Created attachment 229348 Patch 1000758 4 229348 gyuyoung.kim 2014-04-14 23:07:38 -0700 Comment on attachment 229348 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=229348&action=review > Source/WebKit2/Shared/efl/WebEventFactory.cpp:138 > + (event->cur.canvas.x - event->prev.canvas.x) /* deltaX */, There are three createWebMouseEvent there. Don't you need to change all those functions together ? 1000759 5 gyuyoung.kim 2014-04-14 23:08:09 -0700 CC'ing Eunmi 1000820 6 229348 jinwoo7.song 2014-04-15 02:22:26 -0700 Comment on attachment 229348 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=229348&action=review >> Source/WebKit2/Shared/efl/WebEventFactory.cpp:138 >> + (event->cur.canvas.x - event->prev.canvas.x) /* deltaX */, > > There are three createWebMouseEvent there. Don't you need to change all those functions together ? In case of Evas_Event_Mouse_Down and Evas_Event_Mouse_Up, there is no movement data so we can set the delta values as 0. 1000824 7 229348 gyuyoung.kim 2014-04-15 03:14:26 -0700 Comment on attachment 229348 Patch Thank you for reply. LGTM. 1000837 8 229348 commit-queue 2014-04-15 06:01:30 -0700 Comment on attachment 229348 Patch Clearing flags on attachment: 229348 Committed r167305: <http://trac.webkit.org/changeset/167305> 1000838 9 commit-queue 2014-04-15 06:01:40 -0700 All reviewed patches have been landed. Closing bug. 229347 2014-04-14 22:27:03 -0700 2014-04-14 22:30:54 -0700 Patch bug-131663-20140415142642.patch text/plain 1725 jinwoo7.song U3VidmVyc2lvbiBSZXZpc2lvbjogMTY3MTkxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNGI0YTE2MzJjNmI0YjM0 YzgxMWNjOTQ4NWVjYWQ2NDliMWQyMTY5NC4uZjI5N2Y2Y2VmM2JjMjUxNzEwNzdmYzRhMTUzYjNi MjM5MmM0MjMzNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE0LTA0LTE0ICBKaW53 b28gU29uZyAgPGppbndvbzcuc29uZ0BzYW1zdW5nLmNvbT4KKworICAgICAgICBbRUZMXVtXSzJd IFBhc3MgTW91c2UgbW92ZW1lbnQgZGF0YSB0byBXZWJNb3VzZUV2ZW50CisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzE2NjMKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworCQlDdXJyZW50bHkgbW91c2UgbW92ZW1lbnQgZGF0 YSBhcmUgbm90IHBhc3NlZCB0byBXZWJNb3VzZUV2ZW50LiBJbnN0ZWFkLCB0aGV5IGFyZSBzZXQg dG8gMCBhcyBkZWZhdWx0LgorCQlFRkwgcG9ydCBuZWVkcyB0byBzZW5kIHRoZSBkZWx0YVggYW5k IGRlbHRhWSBmb3IgUG9pbnRlckxvY2sgQVBJIHdoaWNoIHdpbGwgYmUgaW1wbGVtZW50ZWQgbGF0 ZXIuCisKKyAgICAgICAgKiBTaGFyZWQvZWZsL1dlYkV2ZW50RmFjdG9yeS5jcHA6CisgICAgICAg IChXZWJLaXQ6OldlYkV2ZW50RmFjdG9yeTo6Y3JlYXRlV2ViTW91c2VFdmVudCk6CisKIDIwMTQt MDQtMTIgIEFuZHkgRXN0ZXMgIDxhZXN0ZXNAYXBwbGUuY29tPgogCiAgICAgICAgIFtpT1NdIE1v dmUgUXVpY2tMb29rSGFuZGxlIGZyb20gUmVzb3VyY2VMb2FkZXIgdG8gV2ViUmVzb3VyY2VMb2Fk ZXIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9lZmwvV2ViRXZlbnRGYWN0b3J5 LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9lZmwvV2ViRXZlbnRGYWN0b3J5LmNwcAppbmRl eCBhNTFlNDIwNjU1ZTY5MWE5NGE0NDI0MDYxMGQ3MDdjZDQ0MzJmNDI3Li43YjA5ZTdmZWM3NzZi NDA0ZDdjMTQyNjlhMGMyZWVmMzllOThjYzkxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9T aGFyZWQvZWZsL1dlYkV2ZW50RmFjdG9yeS5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvU2hhcmVk L2VmbC9XZWJFdmVudEZhY3RvcnkuY3BwCkBAIC0xMzUsOCArMTM1LDggQEAgV2ViTW91c2VFdmVu dCBXZWJFdmVudEZhY3Rvcnk6OmNyZWF0ZVdlYk1vdXNlRXZlbnQoY29uc3QgRXZhc19FdmVudF9N b3VzZV9Nb3ZlKgogICAgICAgICBidXR0b25Gb3JFdmVudChldmVudC0+YnV0dG9ucyksCiAgICAg ICAgIHRvV2ViQ29udGVudC5tYXBQb2ludChwb3MpLAogICAgICAgICB0b0RldmljZVNjcmVlbi5t YXBQb2ludChwb3MpLAotICAgICAgICAwIC8qIGRlbHRhWCAqLywKLSAgICAgICAgMCAvKiBkZWx0 YVkgKi8sCisgICAgICAgIChldmVudC0+Y3VyLmNhbnZhcy54IC0gZXZlbnQtPnByZXYuY2FudmFz LngpIC8qIGRlbHRhWCAqLywKKyAgICAgICAgKGV2ZW50LT5jdXIuY2FudmFzLnkgLSBldmVudC0+ cHJldi5jYW52YXMueSkgLyogZGVsdGFZICovLAogICAgICAgICAwIC8qIGRlbHRhWiAqLywKICAg ICAgICAgMCAvKiBjbGlja0NvdW50ICovLAogICAgICAgICBtb2RpZmllcnNGb3JFdmVudChldmVu dC0+bW9kaWZpZXJzKSwK 229348 2014-04-14 22:30:59 -0700 2014-04-15 06:01:28 -0700 Patch bug-131663-20140415143038.patch text/plain 1737 jinwoo7.song U3VidmVyc2lvbiBSZXZpc2lvbjogMTY3MTkxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNGI0YTE2MzJjNmI0YjM0 YzgxMWNjOTQ4NWVjYWQ2NDliMWQyMTY5NC4uN2RjYTU0NmU3YmQzMGE2Y2M3YTFjNGE2Nzc1ZmE4 MTI4ZWNlM2RkMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE0LTA0LTE0ICBKaW53 b28gU29uZyAgPGppbndvbzcuc29uZ0BzYW1zdW5nLmNvbT4KKworICAgICAgICBbRUZMXVtXSzJd IFBhc3MgTW91c2UgbW92ZW1lbnQgZGF0YSB0byBXZWJNb3VzZUV2ZW50CisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzE2NjMKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDdXJyZW50bHkgbW91c2UgbW92ZW1l bnQgZGF0YSBhcmUgbm90IHBhc3NlZCB0byBXZWJNb3VzZUV2ZW50LiBJbnN0ZWFkLCB0aGV5IGFy ZSBzZXQgdG8gMCBhcyBkZWZhdWx0LgorICAgICAgICBFRkwgcG9ydCBuZWVkcyB0byBzZW5kIHRo ZSBkZWx0YVggYW5kIGRlbHRhWSBmb3IgUG9pbnRlckxvY2sgQVBJIHdoaWNoIHdpbGwgYmUgaW1w bGVtZW50ZWQgbGF0ZXIuCisKKyAgICAgICAgKiBTaGFyZWQvZWZsL1dlYkV2ZW50RmFjdG9yeS5j cHA6CisgICAgICAgIChXZWJLaXQ6OldlYkV2ZW50RmFjdG9yeTo6Y3JlYXRlV2ViTW91c2VFdmVu dCk6CisKIDIwMTQtMDQtMTIgIEFuZHkgRXN0ZXMgIDxhZXN0ZXNAYXBwbGUuY29tPgogCiAgICAg ICAgIFtpT1NdIE1vdmUgUXVpY2tMb29rSGFuZGxlIGZyb20gUmVzb3VyY2VMb2FkZXIgdG8gV2Vi UmVzb3VyY2VMb2FkZXIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9lZmwvV2Vi RXZlbnRGYWN0b3J5LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9lZmwvV2ViRXZlbnRGYWN0 b3J5LmNwcAppbmRleCBhNTFlNDIwNjU1ZTY5MWE5NGE0NDI0MDYxMGQ3MDdjZDQ0MzJmNDI3Li43 YjA5ZTdmZWM3NzZiNDA0ZDdjMTQyNjlhMGMyZWVmMzllOThjYzkxIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0Mi9TaGFyZWQvZWZsL1dlYkV2ZW50RmFjdG9yeS5jcHAKKysrIGIvU291cmNlL1dl YktpdDIvU2hhcmVkL2VmbC9XZWJFdmVudEZhY3RvcnkuY3BwCkBAIC0xMzUsOCArMTM1LDggQEAg V2ViTW91c2VFdmVudCBXZWJFdmVudEZhY3Rvcnk6OmNyZWF0ZVdlYk1vdXNlRXZlbnQoY29uc3Qg RXZhc19FdmVudF9Nb3VzZV9Nb3ZlKgogICAgICAgICBidXR0b25Gb3JFdmVudChldmVudC0+YnV0 dG9ucyksCiAgICAgICAgIHRvV2ViQ29udGVudC5tYXBQb2ludChwb3MpLAogICAgICAgICB0b0Rl dmljZVNjcmVlbi5tYXBQb2ludChwb3MpLAotICAgICAgICAwIC8qIGRlbHRhWCAqLywKLSAgICAg ICAgMCAvKiBkZWx0YVkgKi8sCisgICAgICAgIChldmVudC0+Y3VyLmNhbnZhcy54IC0gZXZlbnQt PnByZXYuY2FudmFzLngpIC8qIGRlbHRhWCAqLywKKyAgICAgICAgKGV2ZW50LT5jdXIuY2FudmFz LnkgLSBldmVudC0+cHJldi5jYW52YXMueSkgLyogZGVsdGFZICovLAogICAgICAgICAwIC8qIGRl bHRhWiAqLywKICAgICAgICAgMCAvKiBjbGlja0NvdW50ICovLAogICAgICAgICBtb2RpZmllcnNG b3JFdmVudChldmVudC0+bW9kaWZpZXJzKSwK