131654 2014-04-14 18:11:40 -0700 emit_op_put_by_id should not emit a write barrier that filters on value 2014-04-14 19:20:56 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mhahnenberg mhahnenberg oldest_to_newest 1000692 0 mhahnenberg 2014-04-14 18:11:40 -0700 The 32-bit implementation does this, and it can cause crashes if we later repatch the code to allocate and store new Butterflies. 1000694 1 229331 mhahnenberg 2014-04-14 18:15:20 -0700 Created attachment 229331 Patch 1000695 2 mhahnenberg 2014-04-14 18:17:25 -0700 <rdar://problem/16513604> 1000698 3 229331 mark.lam 2014-04-14 18:35:34 -0700 Comment on attachment 229331 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=229331&action=review > Source/JavaScriptCore/ChangeLog:12 > + (JSC::JIT::emitWriteBarrier): We also weren't verify the base was a cell on 32-bit if /weren’t verify the/weren’t verifying that the/. 1000703 4 229331 fpizlo 2014-04-14 18:41:23 -0700 Comment on attachment 229331 Patch R=me with MarkL's suggestion. 1000710 5 mhahnenberg 2014-04-14 19:20:56 -0700 Committed r167288: <http://trac.webkit.org/changeset/167288> 229331 2014-04-14 18:15:20 -0700 2014-04-14 18:41:22 -0700 Patch bug-131654-20140414181458.patch text/plain 3646 mhahnenberg SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTY3Mjg3KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBA CisyMDE0LTA0LTE0ICBNYXJrIEhhaG5lbmJlcmcgIDxtaGFobmVuYmVyZ0BhcHBsZS5jb20+CisK KyAgICAgICAgZW1pdF9vcF9wdXRfYnlfaWQgc2hvdWxkIG5vdCBlbWl0IGEgd3JpdGUgYmFycmll ciB0aGF0IGZpbHRlcnMgb24gdmFsdWUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTEzMTY1NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFRoZSAzMi1iaXQgaW1wbGVtZW50YXRpb24gZG9lcyB0aGlzLCBhbmQg aXQgY2FuIGNhdXNlIGNyYXNoZXMgaWYgd2UgbGF0ZXIgcmVwYXRjaCB0aGUgCisgICAgICAgIGNv ZGUgdG8gYWxsb2NhdGUgYW5kIHN0b3JlIG5ldyBCdXR0ZXJmbGllcy4KKworICAgICAgICAqIGpp dC9KSVRQcm9wZXJ0eUFjY2Vzcy5jcHA6CisgICAgICAgIChKU0M6OkpJVDo6ZW1pdFdyaXRlQmFy cmllcik6IFdlIGFsc28gd2VyZW4ndCB2ZXJpZnkgdGhlIGJhc2Ugd2FzIGEgY2VsbCBvbiAzMi1i aXQgaWYgCisgICAgICAgIHdlIHdlcmUgcGFzc2VkIFNob3VsZEZpbHRlckJhc2UuIEkgYWxzbyB0 b29rIHRoZSBsaWJlcnR5IG9mIHNpbmtpbmcgdGhlIHRhZyBsb2FkIGRvd24gCisgICAgICAgIGlu dG8gdGhlIGlmIHN0YXRlbWVudCBzbyB0aGF0IHdlIGRvbid0IGRvIGl0IGlmIHdlJ3JlIG5vdCBm aWx0ZXJpbmcgb24gdGhlIHZhbHVlLgorICAgICAgICAqIGppdC9KSVRQcm9wZXJ0eUFjY2VzczMy XzY0LmNwcDoKKyAgICAgICAgKEpTQzo6SklUOjplbWl0X29wX3B1dF9ieV9pZCk6CisKIDIwMTQt MDQtMTQgIE9saXZlciBIdW50ICA8b2xpdmVyQGFwcGxlLmNvbT4KIAogICAgICAgICBGdW5jdGlv bi5iaW5kIGl0c2VsZiBpcyB0b28gc2xvdwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2pp dC9KSVRQcm9wZXJ0eUFjY2VzczMyXzY0LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNj cmlwdENvcmUvaml0L0pJVFByb3BlcnR5QWNjZXNzMzJfNjQuY3BwCShyZXZpc2lvbiAxNjcyNjAp CisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVFByb3BlcnR5QWNjZXNzMzJfNjQuY3Bw CSh3b3JraW5nIGNvcHkpCkBAIC01MTUsNyArNTE1LDcgQEAgdm9pZCBKSVQ6OmVtaXRfb3BfcHV0 X2J5X2lkKEluc3RydWN0aW9uKgogICAgIGludCB2YWx1ZSA9IGN1cnJlbnRJbnN0cnVjdGlvblsz XS51Lm9wZXJhbmQ7CiAgICAgaW50IGRpcmVjdCA9IGN1cnJlbnRJbnN0cnVjdGlvbls4XS51Lm9w ZXJhbmQ7CiAgICAgCi0gICAgZW1pdFdyaXRlQmFycmllcihiYXNlLCB2YWx1ZSwgU2hvdWxkRmls dGVyQmFzZUFuZFZhbHVlKTsKKyAgICBlbWl0V3JpdGVCYXJyaWVyKGJhc2UsIHZhbHVlLCBTaG91 bGRGaWx0ZXJCYXNlKTsKIAogICAgIGVtaXRMb2FkMihiYXNlLCByZWdUMSwgcmVnVDAsIHZhbHVl LCByZWdUMywgcmVnVDIpOwogICAgIApJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9K SVRQcm9wZXJ0eUFjY2Vzcy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3Jl L2ppdC9KSVRQcm9wZXJ0eUFjY2Vzcy5jcHAJKHJldmlzaW9uIDE2NzI2MCkKKysrIFNvdXJjZS9K YXZhU2NyaXB0Q29yZS9qaXQvSklUUHJvcGVydHlBY2Nlc3MuY3BwCSh3b3JraW5nIGNvcHkpCkBA IC05MzMsMjEgKzkzMywyMiBAQCB2b2lkIEpJVDo6ZW1pdFdyaXRlQmFycmllcihKU0NlbGwqIG93 bmVyCiB2b2lkIEpJVDo6ZW1pdFdyaXRlQmFycmllcih1bnNpZ25lZCBvd25lciwgdW5zaWduZWQg dmFsdWUsIFdyaXRlQmFycmllck1vZGUgbW9kZSkKIHsKICNpZiBFTkFCTEUoR0dDKQotICAgIGVt aXRMb2FkVGFnKHZhbHVlLCByZWdUMCk7CiAgICAgSnVtcCB2YWx1ZU5vdENlbGw7Ci0gICAgaWYg KG1vZGUgPT0gU2hvdWxkRmlsdGVyVmFsdWUgfHwgbW9kZSA9PSBTaG91bGRGaWx0ZXJCYXNlQW5k VmFsdWUpCisgICAgaWYgKG1vZGUgPT0gU2hvdWxkRmlsdGVyVmFsdWUgfHwgbW9kZSA9PSBTaG91 bGRGaWx0ZXJCYXNlQW5kVmFsdWUpIHsKKyAgICAgICAgZW1pdExvYWRUYWcodmFsdWUsIHJlZ1Qw KTsKICAgICAgICAgdmFsdWVOb3RDZWxsID0gYnJhbmNoMzIoTm90RXF1YWwsIHJlZ1QwLCBUcnVz dGVkSW1tMzIoSlNWYWx1ZTo6Q2VsbFRhZykpOworICAgIH0KICAgICAKICAgICBlbWl0TG9hZChv d25lciwgcmVnVDAsIHJlZ1QxKTsKICAgICBKdW1wIG93bmVyTm90Q2VsbDsKLSAgICBpZiAobW9k ZSA9PSBTaG91bGRGaWx0ZXJCYXNlQW5kVmFsdWUpCisgICAgaWYgKG1vZGUgPT0gU2hvdWxkRmls dGVyQmFzZSB8fCBtb2RlID09IFNob3VsZEZpbHRlckJhc2VBbmRWYWx1ZSkKICAgICAgICAgb3du ZXJOb3RDZWxsID0gYnJhbmNoMzIoTm90RXF1YWwsIHJlZ1QwLCBUcnVzdGVkSW1tMzIoSlNWYWx1 ZTo6Q2VsbFRhZykpOwogCiAgICAgSnVtcCBvd25lck5vdE1hcmtlZE9yQWxyZWFkeVJlbWVtYmVy ZWQgPSBjaGVja01hcmtCeXRlKHJlZ1QxKTsKICAgICBjYWxsT3BlcmF0aW9uKG9wZXJhdGlvblVu Y29uZGl0aW9uYWxXcml0ZUJhcnJpZXIsIHJlZ1QxKTsKICAgICBvd25lck5vdE1hcmtlZE9yQWxy ZWFkeVJlbWVtYmVyZWQubGluayh0aGlzKTsKIAotICAgIGlmIChtb2RlID09IFNob3VsZEZpbHRl ckJhc2VBbmRWYWx1ZSkKKyAgICBpZiAobW9kZSA9PSBTaG91bGRGaWx0ZXJCYXNlIHx8IG1vZGUg PT0gU2hvdWxkRmlsdGVyQmFzZUFuZFZhbHVlKQogICAgICAgICBvd25lck5vdENlbGwubGluayh0 aGlzKTsKICAgICBpZiAobW9kZSA9PSBTaG91bGRGaWx0ZXJWYWx1ZSB8fCBtb2RlID09IFNob3Vs ZEZpbHRlckJhc2VBbmRWYWx1ZSkgCiAgICAgICAgIHZhbHVlTm90Q2VsbC5saW5rKHRoaXMpOwpA QCAtOTYxLDEwICs5NjIsMTEgQEAgdm9pZCBKSVQ6OmVtaXRXcml0ZUJhcnJpZXIodW5zaWduZWQg b3duZQogdm9pZCBKSVQ6OmVtaXRXcml0ZUJhcnJpZXIoSlNDZWxsKiBvd25lciwgdW5zaWduZWQg dmFsdWUsIFdyaXRlQmFycmllck1vZGUgbW9kZSkKIHsKICNpZiBFTkFCTEUoR0dDKQotICAgIGVt aXRMb2FkVGFnKHZhbHVlLCByZWdUMCk7CiAgICAgSnVtcCB2YWx1ZU5vdENlbGw7Ci0gICAgaWYg KG1vZGUgPT0gU2hvdWxkRmlsdGVyVmFsdWUpCisgICAgaWYgKG1vZGUgPT0gU2hvdWxkRmlsdGVy VmFsdWUpIHsKKyAgICAgICAgZW1pdExvYWRUYWcodmFsdWUsIHJlZ1QwKTsKICAgICAgICAgdmFs dWVOb3RDZWxsID0gYnJhbmNoMzIoTm90RXF1YWwsIHJlZ1QwLCBUcnVzdGVkSW1tMzIoSlNWYWx1 ZTo6Q2VsbFRhZykpOworICAgIH0KIAogICAgIGVtaXRXcml0ZUJhcnJpZXIob3duZXIpOwogCg==