131648 2014-04-14 17:01:25 -0700 Sometimes-crash under handleSwipeGesture after closing a window or quitting 2014-04-14 17:42:10 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton thorton mitz sam simon.fraser oldest_to_newest 1000658 0 thorton 2014-04-14 17:01:25 -0700 The swipe-tracking callback has no way to know that the ViewGestureController that spawned it is still alive. We should provide it such a mechanism. <rdar://problem/15966106> 1000660 1 229324 thorton 2014-04-14 17:05:19 -0700 Created attachment 229324 patch I'm not totally sure this is the right approach, but I'm not sure what the idiomatic way to resolve this is. 1000686 2 thorton 2014-04-14 17:42:10 -0700 http://trac.webkit.org/changeset/167284 229324 2014-04-14 17:05:19 -0700 2014-04-14 17:39:21 -0700 patch crash.diff text/plain 5049 thorton ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCAzZTY1NDZiLi44YjQxZTRmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjcg QEAKKzIwMTQtMDQtMTQgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisK KyAgICAgICAgU29tZXRpbWVzLWNyYXNoIHVuZGVyIGhhbmRsZVN3aXBlR2VzdHVyZSBhZnRlciBj bG9zaW5nIGEgd2luZG93IG9yIHF1aXR0aW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xMzE2NDgKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzE1OTY2 MTA2PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog VUlQcm9jZXNzL21hYy9WaWV3R2VzdHVyZUNvbnRyb2xsZXIuaDoKKyAgICAgICAgKiBVSVByb2Nl c3MvbWFjL1ZpZXdHZXN0dXJlQ29udHJvbGxlck1hYy5tbToKKyAgICAgICAgKFdlYktpdDo6Vmll d0dlc3R1cmVDb250cm9sbGVyOjp+Vmlld0dlc3R1cmVDb250cm9sbGVyKToKKyAgICAgICAgKFdl YktpdDo6Vmlld0dlc3R1cmVDb250cm9sbGVyOjp0cmFja1N3aXBlR2VzdHVyZSk6CisgICAgICAg IEtlZXAgYSBPYmplY3RpdmUgQyBvYmplY3Qgd2l0aCBhIHNpbmdsZSBib29sZWFuIHByb3BlcnR5 LCBpc0NhbmNlbGxlZCwgb24KKyAgICAgICAgdGhlIFZpZXdHZXN0dXJlQ29udHJvbGxlciwgYW5k IGFsc28gcmV0YWluZWQgYnkgdGhlIHN3aXBlLXRyYWNraW5nIGJsb2NrLgorICAgICAgICBXaGVu IHRoZSBWaWV3R2VzdHVyZUNvbnRyb2xsZXIgaXMgZGVzdHJveWVkLCB3ZSBzZXQgaXNDYW5jZWxs ZWQgdG8gWUVTLAorICAgICAgICBhbmQgdGhlIG5leHQgdGltZSB0aGUgYmxvY2sgaXMgaW52b2tl ZCwgd2Ugd2lsbCBjYW5jZWwgdGhlIHN3aXBlIHdpdGhvdXQKKyAgICAgICAgdG91Y2hpbmcgdGhl IGRlc3Ryb3llZCBWaWV3R2VzdHVyZUNvbnRyb2xsZXIuCisKKyAgICAgICAgKFdlYktpdDo6Vmll d0dlc3R1cmVDb250cm9sbGVyOjpoYW5kbGVTd2lwZUdlc3R1cmUpOgorICAgICAgICBEb24ndCB0 cnkgdG8gaGFuZGxlIGEgc3dpcGUgZ2VzdHVyZSBpZiB0aGUgZHJhd2luZyBhcmVhIGlzIG1pc3Np bmcuCisKKyAgICAgICAgKFdlYktpdDo6Vmlld0dlc3R1cmVDb250cm9sbGVyOjplbmRTd2lwZUdl c3R1cmUpOgorICAgICAgICBDbGVhciB0aGUgc3dpcGUgY2FuY2VsbGF0aW9uIHRyYWNrZXIgd2hl biB0aGUgZ2VzdHVyZSBjb21wbGV0ZXMuCisKIDIwMTQtMDQtMTIgIEFudHRpIEtvaXZpc3RvICA8 YW50dGlAYXBwbGUuY29tPgogCiAgICAgICAgIEtlZXAgc2Vjb25kYXJ5IHRpbGUgZ3JpZCBmb3Ig em9vbWVkLW91dCBzY2FsZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL21h Yy9WaWV3R2VzdHVyZUNvbnRyb2xsZXIuaCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9tYWMv Vmlld0dlc3R1cmVDb250cm9sbGVyLmgKaW5kZXggMGIwZWE4ZS4uODcyOTVjOCAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL21hYy9WaWV3R2VzdHVyZUNvbnRyb2xsZXIuaAor KysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvbWFjL1ZpZXdHZXN0dXJlQ29udHJvbGxlci5o CkBAIC00MSw2ICs0MSw3IEBAIE9CSkNfQ0xBU1MgX1VJTmF2aWdhdGlvbkludGVyYWN0aXZlVHJh bnNpdGlvbkJhc2U7CiAjZWxzZQogT0JKQ19DTEFTUyBOU0V2ZW50OwogT0JKQ19DTEFTUyBOU1Zp ZXc7CitPQkpDX0NMQVNTIFdLU3dpcGVDYW5jZWxsYXRpb25UcmFja2VyOwogI2VuZGlmCiAKIG5h bWVzcGFjZSBXZWJDb3JlIHsKQEAgLTE0OCw2ICsxNDksNyBAQCBwcml2YXRlOgogICAgIGJvb2wg bV92aXNpYmxlQ29udGVudFJlY3RJc1ZhbGlkOwogICAgIGJvb2wgbV9mcmFtZUhhbmRsZXNNYWdu aWZpY2F0aW9uR2VzdHVyZTsKIAorICAgIFJldGFpblB0cjxXS1N3aXBlQ2FuY2VsbGF0aW9uVHJh Y2tlcj4gbV9zd2lwZUNhbmNlbGxhdGlvblRyYWNrZXI7CiAgICAgUmV0YWluUHRyPENBTGF5ZXI+ IG1fc3dpcGVTbmFwc2hvdExheWVyOwogICAgIFZlY3RvcjxSZXRhaW5QdHI8Q0FMYXllcj4+IG1f Y3VycmVudFN3aXBlTGl2ZUxheWVyczsKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL21hYy9WaWV3R2VzdHVyZUNvbnRyb2xsZXJNYWMubW0gYi9Tb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvbWFjL1ZpZXdHZXN0dXJlQ29udHJvbGxlck1hYy5tbQppbmRleCBiNTZlMzFkLi5i MWRlM2NlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvbWFjL1ZpZXdHZXN0 dXJlQ29udHJvbGxlck1hYy5tbQorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvbWFjL1Zp ZXdHZXN0dXJlQ29udHJvbGxlck1hYy5tbQpAQCAtNzksNiArNzksMTMgQEAgc3RhdGljIGNvbnN0 IGZsb2F0IG1pbmltdW1TY3JvbGxFdmVudFJhdGlvRm9yU3dpcGUgPSAwLjU7CiBzdGF0aWMgY29u c3QgZmxvYXQgc3dpcGVTbmFwc2hvdFJlbW92YWxSZW5kZXJUcmVlU2l6ZVRhcmdldEZyYWN0aW9u ID0gMC41Owogc3RhdGljIGNvbnN0IHN0ZDo6Y2hyb25vOjpzZWNvbmRzIHN3aXBlU25hcHNob3RS ZW1vdmFsV2F0Y2hkb2dEdXJhdGlvbiA9IDNfczsKIAorQGludGVyZmFjZSBXS1N3aXBlQ2FuY2Vs bGF0aW9uVHJhY2tlciA6IE5TT2JqZWN0CitAcHJvcGVydHkgKG5vbmF0b21pYykgQk9PTCBpc0Nh bmNlbGxlZDsKK0BlbmQKKworQGltcGxlbWVudGF0aW9uIFdLU3dpcGVDYW5jZWxsYXRpb25UcmFj a2VyCitAZW5kCisKIG5hbWVzcGFjZSBXZWJLaXQgewogCiBWaWV3R2VzdHVyZUNvbnRyb2xsZXI6 OlZpZXdHZXN0dXJlQ29udHJvbGxlcihXZWJQYWdlUHJveHkmIHdlYlBhZ2VQcm94eSkKQEAgLTk2 LDYgKzEwMyw5IEBAIFZpZXdHZXN0dXJlQ29udHJvbGxlcjo6Vmlld0dlc3R1cmVDb250cm9sbGVy KFdlYlBhZ2VQcm94eSYgd2ViUGFnZVByb3h5KQogCiBWaWV3R2VzdHVyZUNvbnRyb2xsZXI6On5W aWV3R2VzdHVyZUNvbnRyb2xsZXIoKQogeworICAgIGlmIChtX3N3aXBlQ2FuY2VsbGF0aW9uVHJh Y2tlcikKKyAgICAgICAgW21fc3dpcGVDYW5jZWxsYXRpb25UcmFja2VyIHNldElzQ2FuY2VsbGVk OllFU107CisKICAgICBtX3dlYlBhZ2VQcm94eS5wcm9jZXNzKCkucmVtb3ZlTWVzc2FnZVJlY2Vp dmVyKE1lc3NhZ2VzOjpWaWV3R2VzdHVyZUNvbnRyb2xsZXI6Om1lc3NhZ2VSZWNlaXZlck5hbWUo KSwgbV93ZWJQYWdlUHJveHkucGFnZUlEKCkpOwogfQogCkBAIC0zNDcsNyArMzU3LDE1IEBAIHZv aWQgVmlld0dlc3R1cmVDb250cm9sbGVyOjp0cmFja1N3aXBlR2VzdHVyZShOU0V2ZW50ICpldmVu dCwgU3dpcGVEaXJlY3Rpb24gZGlyCiAgICAgUmVmUHRyPFdlYkJhY2tGb3J3YXJkTGlzdEl0ZW0+ IHRhcmdldEl0ZW0gPSAoZGlyZWN0aW9uID09IFN3aXBlRGlyZWN0aW9uOjpMZWZ0KSA/IG1fd2Vi UGFnZVByb3h5LmJhY2tGb3J3YXJkTGlzdCgpLmJhY2tJdGVtKCkgOiBtX3dlYlBhZ2VQcm94eS5i YWNrRm9yd2FyZExpc3QoKS5mb3J3YXJkSXRlbSgpOwogICAgIF9fYmxvY2sgYm9vbCBzd2lwZUNh bmNlbGxlZCA9IGZhbHNlOwogCisgICAgQVNTRVJUKCFtX3N3aXBlQ2FuY2VsbGF0aW9uVHJhY2tl cik7CisgICAgUmV0YWluUHRyPFdLU3dpcGVDYW5jZWxsYXRpb25UcmFja2VyPiBzd2lwZUNhbmNl bGxhdGlvblRyYWNrZXIgPSBhZG9wdE5TKFtbV0tTd2lwZUNhbmNlbGxhdGlvblRyYWNrZXIgYWxs b2NdIGluaXRdKTsKKyAgICBtX3N3aXBlQ2FuY2VsbGF0aW9uVHJhY2tlciA9IHN3aXBlQ2FuY2Vs bGF0aW9uVHJhY2tlcjsKKwogICAgIFtldmVudCB0cmFja1N3aXBlRXZlbnRXaXRoT3B0aW9uczow IGRhbXBlbkFtb3VudFRocmVzaG9sZE1pbjptaW5Qcm9ncmVzcyBtYXg6bWF4UHJvZ3Jlc3MgdXNp bmdIYW5kbGVyOl4oQ0dGbG9hdCBwcm9ncmVzcywgTlNFdmVudFBoYXNlIHBoYXNlLCBCT09MIGlz Q29tcGxldGUsIEJPT0wgKnN0b3ApIHsKKyAgICAgICAgaWYgKFtzd2lwZUNhbmNlbGxhdGlvblRy YWNrZXIgaXNDYW5jZWxsZWRdKSB7CisgICAgICAgICAgICAqc3RvcCA9IFlFUzsKKyAgICAgICAg ICAgIHJldHVybjsKKyAgICAgICAgfQogICAgICAgICBpZiAocGhhc2UgPT0gTlNFdmVudFBoYXNl QmVnYW4pCiAgICAgICAgICAgICB0aGlzLT5iZWdpblN3aXBlR2VzdHVyZSh0YXJnZXRJdGVtLmdl dCgpLCBkaXJlY3Rpb24pOwogICAgICAgICBDR0Zsb2F0IGNsYW1wZWRQcm9ncmVzcyA9IHN0ZDo6 bWluKHN0ZDo6bWF4KHByb2dyZXNzLCBtaW5Qcm9ncmVzcyksIG1heFByb2dyZXNzKTsKQEAgLTQ4 Miw2ICs1MDAsOSBAQCB2b2lkIFZpZXdHZXN0dXJlQ29udHJvbGxlcjo6aGFuZGxlU3dpcGVHZXN0 dXJlKFdlYkJhY2tGb3J3YXJkTGlzdEl0ZW0qIHRhcmdldEl0ZQogewogICAgIEFTU0VSVChtX2Fj dGl2ZUdlc3R1cmVUeXBlID09IFZpZXdHZXN0dXJlVHlwZTo6U3dpcGUpOwogCisgICAgaWYgKCFt X3dlYlBhZ2VQcm94eS5kcmF3aW5nQXJlYSgpKQorICAgICAgICByZXR1cm47CisKICAgICBkb3Vi bGUgd2lkdGg7CiAgICAgaWYgKCFtX2N1c3RvbVN3aXBlVmlld3MuaXNFbXB0eSgpKQogICAgICAg ICB3aWR0aCA9IG1fY3VycmVudFN3aXBlQ3VzdG9tVmlld0JvdW5kcy53aWR0aCgpOwpAQCAtNTA5 LDYgKzUzMCw4IEBAIHZvaWQgVmlld0dlc3R1cmVDb250cm9sbGVyOjplbmRTd2lwZUdlc3R1cmUo V2ViQmFja0ZvcndhcmRMaXN0SXRlbSogdGFyZ2V0SXRlbSwKIHsKICAgICBBU1NFUlQobV9hY3Rp dmVHZXN0dXJlVHlwZSA9PSBWaWV3R2VzdHVyZVR5cGU6OlN3aXBlKTsKIAorICAgIG1fc3dpcGVD YW5jZWxsYXRpb25UcmFja2VyID0gbnVsbHB0cjsKKwogICAgIENBTGF5ZXIgKnJvb3RMYXllciA9 IG1fd2ViUGFnZVByb3h5LmFjY2VsZXJhdGVkQ29tcG9zaXRpbmdSb290TGF5ZXIoKTsKIAogICAg IFtyb290TGF5ZXIgc2V0U2hhZG93T3BhY2l0eTowXTsK