131640 2014-04-14 15:30:50 -0700 [iOS WK2] Hash table assertion closing a tab 2014-04-16 09:21:02 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 simon.fraser simon.fraser simon.fraser thorton oldest_to_newest 1000623 0 simon.fraser 2014-04-14 15:30:50 -0700 [iOS WK2] Hash table assertion closing a tab 1000626 1 229313 simon.fraser 2014-04-14 15:31:48 -0700 Created attachment 229313 Patch 1000628 2 229313 thorton 2014-04-14 15:32:47 -0700 Comment on attachment 229313 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=229313&action=review > Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeContext.h:74 > + HashMap<WebCore::GraphicsLayer::PlatformLayerID, PlatformCALayerRemote*> m_liveLayers; "live" might be a misnomer since they're not all in the tree, but whatever. > Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeContext.mm:52 > + for (auto& keyValuePair : m_liveLayers) m_liveLayers.values() 1000631 3 simon.fraser 2014-04-14 15:37:47 -0700 https://trac.webkit.org/r167273 1001156 4 thorton 2014-04-16 09:21:02 -0700 <rdar://problem/16612993> 229313 2014-04-14 15:31:48 -0700 2014-04-14 15:32:47 -0700 Patch bug-131640-20140414153126.patch text/plain 5582 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMTY3MjY1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggM2VmNWE1YWZhNTFkNWYx OTRjZGIxZDI2NWVlZDIzNDA2MmY4MmFlMC4uY2JlMjNhZWQ4YWM2ZWI3OTg3M2M1ZmMzZWE1YWE2 ZGE0ODY4MDY1YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI3IEBACiAyMDE0LTA0LTE0ICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCisgICAgICAgIFtpT1MgV0syXSBI YXNoIHRhYmxlIGFzc2VydGlvbiBjbG9zaW5nIGEgdGFiCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzE2NDAKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKyAgICAgICAgCisgICAgICAgIEhhdmUgUmVtb3RlTGF5ZXJUcmVlQ29u dGV4dCBrZWVwIHRyYWNrIG9mIGFsbCBQbGF0Zm9ybUNBTGF5ZXJSZW1vdGVzLAorICAgICAgICBh bmQgY2xlYXIgdGhlaXIgY29udGV4dCBwb2ludGVyIHdoZW4gaXQgaXMgYmVpbmcgZGVzdHJveWVk IHRvIGF2b2lkCisgICAgICAgIGNhbGxpbmcgaW50byBhIGRlbGV0ZWQgb2JqZWN0IGxhdGVyLgor CisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJQYWdlL21hYy9QbGF0Zm9ybUNBTGF5ZXJSZW1vdGUu Y3BwOgorICAgICAgICAoV2ViS2l0OjpQbGF0Zm9ybUNBTGF5ZXJSZW1vdGU6On5QbGF0Zm9ybUNB TGF5ZXJSZW1vdGUpOgorICAgICAgICAoV2ViS2l0OjpQbGF0Zm9ybUNBTGF5ZXJSZW1vdGU6OmFk ZEFuaW1hdGlvbkZvcktleSk6CisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJQYWdlL21hYy9QbGF0 Zm9ybUNBTGF5ZXJSZW1vdGUuaDoKKyAgICAgICAgKFdlYktpdDo6UGxhdGZvcm1DQUxheWVyUmVt b3RlOjpjbGVhckNvbnRleHQpOgorICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9tYWMvUmVt b3RlTGF5ZXJUcmVlQ29udGV4dC5oOgorICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9tYWMv UmVtb3RlTGF5ZXJUcmVlQ29udGV4dC5tbToKKyAgICAgICAgKFdlYktpdDo6UmVtb3RlTGF5ZXJU cmVlQ29udGV4dDo6flJlbW90ZUxheWVyVHJlZUNvbnRleHQpOgorICAgICAgICAoV2ViS2l0OjpS ZW1vdGVMYXllclRyZWVDb250ZXh0OjpsYXllcldhc0NyZWF0ZWQpOgorICAgICAgICAoV2ViS2l0 OjpSZW1vdGVMYXllclRyZWVDb250ZXh0OjpsYXllcldpbGxCZURlc3Ryb3llZCk6CisKKzIwMTQt MDQtMTQgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CisKICAgICAgICAg Rml4IHRoZSBidWlsZC4KIAogICAgICAgICAqIFVJUHJvY2Vzcy9tYWMvUGFnZUNsaWVudEltcGwu aDoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9tYWMvUGxh dGZvcm1DQUxheWVyUmVtb3RlLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFn ZS9tYWMvUGxhdGZvcm1DQUxheWVyUmVtb3RlLmNwcAppbmRleCA1MzU4NzdmMjNkMDc2NzVlZjlm ZGY5YzUxZmE4ZTg2OGMyOTQwOTc1Li5mZjg3OWRjNzNiNTFlNThhZGNjYTkxNzAxYjRjZjIxNTY5 OWIxOTc4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvbWFj L1BsYXRmb3JtQ0FMYXllclJlbW90ZS5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vz cy9XZWJQYWdlL21hYy9QbGF0Zm9ybUNBTGF5ZXJSZW1vdGUuY3BwCkBAIC0xMDksNyArMTA5LDkg QEAgUGxhdGZvcm1DQUxheWVyUmVtb3RlOjp+UGxhdGZvcm1DQUxheWVyUmVtb3RlKCkKIHsKICAg ICBmb3IgKGNvbnN0IGF1dG8mIGxheWVyIDogbV9jaGlsZHJlbikKICAgICAgICAgdG9QbGF0Zm9y bUNBTGF5ZXJSZW1vdGUobGF5ZXIuZ2V0KCkpLT5tX3N1cGVybGF5ZXIgPSBudWxscHRyOwotICAg IG1fY29udGV4dC0+bGF5ZXJXaWxsQmVEZXN0cm95ZWQodGhpcyk7CisKKyAgICBpZiAobV9jb250 ZXh0KQorICAgICAgICBtX2NvbnRleHQtPmxheWVyV2lsbEJlRGVzdHJveWVkKHRoaXMpOwogfQog CiB2b2lkIFBsYXRmb3JtQ0FMYXllclJlbW90ZTo6cmVjdXJzaXZlQnVpbGRUcmFuc2FjdGlvbihS ZW1vdGVMYXllclRyZWVUcmFuc2FjdGlvbiYgdHJhbnNhY3Rpb24pCkBAIC0yODYsOCArMjg4LDkg QEAgdm9pZCBQbGF0Zm9ybUNBTGF5ZXJSZW1vdGU6OmFkZEFuaW1hdGlvbkZvcktleShjb25zdCBT dHJpbmcmIGtleSwgUGxhdGZvcm1DQUFuaW0KIHsKICAgICBtX3Byb3BlcnRpZXMuYWRkZWRBbmlt YXRpb25zLnNldChrZXksIHRvUGxhdGZvcm1DQUFuaW1hdGlvblJlbW90ZShhbmltYXRpb24pLT5w cm9wZXJ0aWVzKCkpOwogICAgIG1fcHJvcGVydGllcy5ub3RlUHJvcGVydGllc0NoYW5nZWQoUmVt b3RlTGF5ZXJUcmVlVHJhbnNhY3Rpb246OkFuaW1hdGlvbnNDaGFuZ2VkKTsKLSAgICAKLSAgICBt X2NvbnRleHQtPndpbGxTdGFydEFuaW1hdGlvbk9uTGF5ZXIodGhpcyk7CisKKyAgICBpZiAobV9j b250ZXh0KQorICAgICAgICBtX2NvbnRleHQtPndpbGxTdGFydEFuaW1hdGlvbk9uTGF5ZXIodGhp cyk7CiB9CiAKIHZvaWQgUGxhdGZvcm1DQUxheWVyUmVtb3RlOjpyZW1vdmVBbmltYXRpb25Gb3JL ZXkoY29uc3QgU3RyaW5nJiBrZXkpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9j ZXNzL1dlYlBhZ2UvbWFjL1BsYXRmb3JtQ0FMYXllclJlbW90ZS5oIGIvU291cmNlL1dlYktpdDIv V2ViUHJvY2Vzcy9XZWJQYWdlL21hYy9QbGF0Zm9ybUNBTGF5ZXJSZW1vdGUuaAppbmRleCA4NmZk OTNmNTVlZmQ5ZDU0NjJkM2I2YTM5OTAyZmI4ZTEyMTgzMDUwLi42NTMxZTQ2ZjY0ZjUyZGY2YjE2 NTkxOGM1YzU0OGM2ZDBhMzExZDhiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9j ZXNzL1dlYlBhZ2UvbWFjL1BsYXRmb3JtQ0FMYXllclJlbW90ZS5oCisrKyBiL1NvdXJjZS9XZWJL aXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9tYWMvUGxhdGZvcm1DQUxheWVyUmVtb3RlLmgKQEAgLTE1 Myw2ICsxNTMsOCBAQCBwdWJsaWM6CiAKICAgICBSZW1vdGVMYXllclRyZWVUcmFuc2FjdGlvbjo6 TGF5ZXJQcm9wZXJ0aWVzJiBwcm9wZXJ0aWVzKCkgeyByZXR1cm4gbV9wcm9wZXJ0aWVzOyB9CiAK KyAgICB2b2lkIGNsZWFyQ29udGV4dCgpIHsgbV9jb250ZXh0ID0gbnVsbHB0cjsgfQorCiBwcm90 ZWN0ZWQ6CiAgICAgUGxhdGZvcm1DQUxheWVyUmVtb3RlKFdlYkNvcmU6OlBsYXRmb3JtQ0FMYXll cjo6TGF5ZXJUeXBlLCBXZWJDb3JlOjpQbGF0Zm9ybUNBTGF5ZXJDbGllbnQqIG93bmVyLCBSZW1v dGVMYXllclRyZWVDb250ZXh0KiBjb250ZXh0KTsKICAgICBQbGF0Zm9ybUNBTGF5ZXJSZW1vdGUo Y29uc3QgUGxhdGZvcm1DQUxheWVyUmVtb3RlJiwgV2ViQ29yZTo6UGxhdGZvcm1DQUxheWVyQ2xp ZW50KiwgUmVtb3RlTGF5ZXJUcmVlQ29udGV4dCopOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp dDIvV2ViUHJvY2Vzcy9XZWJQYWdlL21hYy9SZW1vdGVMYXllclRyZWVDb250ZXh0LmggYi9Tb3Vy Y2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvbWFjL1JlbW90ZUxheWVyVHJlZUNvbnRleHQu aAppbmRleCA0MDc0ZTFiMzlkZmQ2ODU4NWRiOTcyM2UyNDhlOGRkNzBiNzFhNWJhLi4xNzE3ZmM0 NjYzZTY0NjE2YTgxMGU5Mjc3ZTQzNjMwNmRkY2YxODU1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi S2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvbWFjL1JlbW90ZUxheWVyVHJlZUNvbnRleHQuaAorKysg Yi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvbWFjL1JlbW90ZUxheWVyVHJlZUNv bnRleHQuaApAQCAtNzEsNiArNzEsNyBAQCBwcml2YXRlOgogICAgIFZlY3RvcjxSZW1vdGVMYXll clRyZWVUcmFuc2FjdGlvbjo6TGF5ZXJDcmVhdGlvblByb3BlcnRpZXM+IG1fY3JlYXRlZExheWVy czsKICAgICBWZWN0b3I8V2ViQ29yZTo6R3JhcGhpY3NMYXllcjo6UGxhdGZvcm1MYXllcklEPiBt X2Rlc3Ryb3llZExheWVyczsKIAorICAgIEhhc2hNYXA8V2ViQ29yZTo6R3JhcGhpY3NMYXllcjo6 UGxhdGZvcm1MYXllcklELCBQbGF0Zm9ybUNBTGF5ZXJSZW1vdGUqPiBtX2xpdmVMYXllcnM7CiAg ICAgSGFzaE1hcDxXZWJDb3JlOjpHcmFwaGljc0xheWVyOjpQbGF0Zm9ybUxheWVySUQsIFBsYXRm b3JtQ0FMYXllclJlbW90ZSo+IG1fbGF5ZXJzQXdhaXRpbmdBbmltYXRpb25TdGFydDsKIAogICAg IFJlbW90ZUxheWVyQmFja2luZ1N0b3JlQ29sbGVjdGlvbiBtX2JhY2tpbmdTdG9yZUNvbGxlY3Rp b247CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvbWFjL1Jl bW90ZUxheWVyVHJlZUNvbnRleHQubW0gYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBh Z2UvbWFjL1JlbW90ZUxheWVyVHJlZUNvbnRleHQubW0KaW5kZXggZmRhYzI2MWI2Y2FlOGI4YmZk ZDFkZmI3YTJjMmY0MGE1NmYzODI0YS4uMDJjYjk3MTEyYWI2ZWQxMDZjMDcwYjg0NDk1NjUwZjA2 NTQ0YTk1MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL21h Yy9SZW1vdGVMYXllclRyZWVDb250ZXh0Lm1tCisrKyBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nl c3MvV2ViUGFnZS9tYWMvUmVtb3RlTGF5ZXJUcmVlQ29udGV4dC5tbQpAQCAtNDksNiArNDksOCBA QCBSZW1vdGVMYXllclRyZWVDb250ZXh0OjpSZW1vdGVMYXllclRyZWVDb250ZXh0KFdlYlBhZ2Uq IHdlYlBhZ2UpCiAKIFJlbW90ZUxheWVyVHJlZUNvbnRleHQ6On5SZW1vdGVMYXllclRyZWVDb250 ZXh0KCkKIHsKKyAgICBmb3IgKGF1dG8mIGtleVZhbHVlUGFpciA6IG1fbGl2ZUxheWVycykKKyAg ICAgICAga2V5VmFsdWVQYWlyLnZhbHVlLT5jbGVhckNvbnRleHQoKTsKIH0KIAogdm9pZCBSZW1v dGVMYXllclRyZWVDb250ZXh0OjpsYXllcldhc0NyZWF0ZWQoUGxhdGZvcm1DQUxheWVyUmVtb3Rl KiBsYXllciwgUGxhdGZvcm1DQUxheWVyOjpMYXllclR5cGUgdHlwZSkKQEAgLTYxLDEwICs2Mywx MyBAQCB2b2lkIFJlbW90ZUxheWVyVHJlZUNvbnRleHQ6OmxheWVyV2FzQ3JlYXRlZChQbGF0Zm9y bUNBTGF5ZXJSZW1vdGUqIGxheWVyLCBQbGF0ZgogICAgICAgICBjcmVhdGlvblByb3BlcnRpZXMu aG9zdGluZ0NvbnRleHRJRCA9IGxheWVyLT5ob3N0aW5nQ29udGV4dElEKCk7CiAKICAgICBtX2Ny ZWF0ZWRMYXllcnMuYXBwZW5kKGNyZWF0aW9uUHJvcGVydGllcyk7CisgICAgbV9saXZlTGF5ZXJz LmFkZChsYXllci0+bGF5ZXJJRCgpLCBsYXllcik7CiB9CiAKIHZvaWQgUmVtb3RlTGF5ZXJUcmVl Q29udGV4dDo6bGF5ZXJXaWxsQmVEZXN0cm95ZWQoUGxhdGZvcm1DQUxheWVyUmVtb3RlKiBsYXll cikKIHsKKyAgICBtX2xpdmVMYXllcnMucmVtb3ZlKGxheWVyLT5sYXllcklEKCkpOworCiAgICAg QVNTRVJUKCFtX2Rlc3Ryb3llZExheWVycy5jb250YWlucyhsYXllci0+bGF5ZXJJRCgpKSk7CiAg ICAgbV9kZXN0cm95ZWRMYXllcnMuYXBwZW5kKGxheWVyLT5sYXllcklEKCkpOwogICAgIAo=