131632 2014-04-14 14:09:35 -0700 RenderLayerCompositor's m_layerForOverhangAreas should be offset by the topContentInset 2014-04-14 14:49:21 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 bdakin bdakin bdakin commit-queue esprehn+autocc glenn kondapallykalyan simon.fraser thorton oldest_to_newest 1000593 0 bdakin 2014-04-14 14:09:35 -0700 RenderLayerCompositor's m_layerForOverhangAreas should be offset by the topContentInset. <rdar://problem/16609602> 1000595 1 229304 bdakin 2014-04-14 14:16:03 -0700 Created attachment 229304 Patch 1000599 2 229304 thorton 2014-04-14 14:32:16 -0700 Comment on attachment 229304 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=229304&action=review > Source/WebCore/rendering/RenderLayerCompositor.cpp:3007 > + m_layerForOverhangAreas->setPosition(FloatPoint(0, m_renderView.frameView().topContentInset())); should we shrink it by topContentInset? 1000607 3 bdakin 2014-04-14 14:49:21 -0700 (In reply to comment #2) > (From update of attachment 229304 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=229304&action=review > > > Source/WebCore/rendering/RenderLayerCompositor.cpp:3007 > > + m_layerForOverhangAreas->setPosition(FloatPoint(0, m_renderView.frameView().topContentInset())); > > should we shrink it by topContentInset? We should! Fixed that. http://trac.webkit.org/changeset/167270 229304 2014-04-14 14:16:03 -0700 2014-04-14 14:32:16 -0700 Patch for-review.txt text/plain 1655 bdakin SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2NzI2NikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE0LTA0LTE0ICBCZXRoIERh a2luICA8YmRha2luQGFwcGxlLmNvbT4KKworICAgICAgICBSZW5kZXJMYXllckNvbXBvc2l0b3In cyBtX2xheWVyRm9yT3ZlcmhhbmdBcmVhcyBzaG91bGQgYmUgb2Zmc2V0IGJ5IHRoZSAKKyAgICAg ICAgdG9wQ29udGVudEluc2V0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xMzE2MzIKKyAgICAgICAgLWFuZCBjb3JyZXNwb25kaW5nLQorICAgICAgICA8 cmRhcjovL3Byb2JsZW0vMTY2MDk2MDI+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgT2Zmc2V0IG1fbGF5ZXJGb3JPdmVyaGFuZ0FyZWFzIGJ5IHRoZSB0 b3BDb250ZW50SW5zZXQuIAorICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJMYXllckNvbXBvc2l0 b3IuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyTGF5ZXJDb21wb3NpdG9yOjp1cGRhdGVP dmVyZmxvd0NvbnRyb2xzTGF5ZXJzKToKKwogMjAxNC0wNC0xNCAgU2ltb24gRnJhc2VyICA8c2lt b24uZnJhc2VyQGFwcGxlLmNvbT4KIAogICAgICAgICBSdW4gZmlsdGVyIGFuaW1hdGlvbnMgaW4g dGhlIFVJIHByb2Nlc3Mgd2l0aCBVSS1zaWRlIGNvbXBvc2l0aW5nCkluZGV4OiBTb3VyY2UvV2Vi Q29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJDb21wb3NpdG9yLmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJDb21wb3NpdG9yLmNwcAkocmV2aXNp b24gMTY3MjU2KQorKysgU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQ29tcG9z aXRvci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTMwMDQsNiArMzAwNCw3IEBAIHZvaWQgUmVuZGVy TGF5ZXJDb21wb3NpdG9yOjp1cGRhdGVPdmVyZmwKICNlbmRpZgogICAgICAgICAgICAgbV9sYXll ckZvck92ZXJoYW5nQXJlYXMtPnNldERyYXdzQ29udGVudChmYWxzZSk7CiAgICAgICAgICAgICBt X2xheWVyRm9yT3ZlcmhhbmdBcmVhcy0+c2V0U2l6ZShtX3JlbmRlclZpZXcuZnJhbWVWaWV3KCku ZnJhbWVSZWN0KCkuc2l6ZSgpKTsKKyAgICAgICAgICAgIG1fbGF5ZXJGb3JPdmVyaGFuZ0FyZWFz LT5zZXRQb3NpdGlvbihGbG9hdFBvaW50KDAsIG1fcmVuZGVyVmlldy5mcmFtZVZpZXcoKS50b3BD b250ZW50SW5zZXQoKSkpOwogCiAgICAgICAgICAgICBpZiAobV9yZW5kZXJWaWV3LmZyYW1lVmll dygpLmZyYW1lKCkuc2V0dGluZ3MoKS5iYWNrZ3JvdW5kU2hvdWxkRXh0ZW5kQmV5b25kUGFnZSgp KQogICAgICAgICAgICAgICAgIG1fbGF5ZXJGb3JPdmVyaGFuZ0FyZWFzLT5zZXRCYWNrZ3JvdW5k Q29sb3IobV9yZW5kZXJWaWV3LmZyYW1lVmlldygpLmRvY3VtZW50QmFja2dyb3VuZENvbG9yKCkp Owo=