131628 2014-04-14 12:09:33 -0700 Allow dynamic changes of WKThumbnailView snapshot scale 2014-04-14 14:51:54 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton thorton bdakin sam simon.fraser oldest_to_newest 1000566 0 thorton 2014-04-14 12:09:33 -0700 <rdar://problem/16584156> 1000569 1 229298 thorton 2014-04-14 12:18:19 -0700 Created attachment 229298 patch 1000608 2 thorton 2014-04-14 14:51:54 -0700 http://trac.webkit.org/changeset/167271 229298 2014-04-14 12:18:19 -0700 2014-04-14 14:41:17 -0700 patch wkthumb.diff text/plain 5450 thorton ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA1NzRjYzdkLi5mYjNhMjY4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMzUg QEAKIDIwMTQtMDQtMTQgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CiAK KyAgICAgICAgQWxsb3cgZHluYW1pYyBjaGFuZ2VzIG9mIFdLVGh1bWJuYWlsVmlldyBzbmFwc2hv dCBzY2FsZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTMxNjI4CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8xNjU4NDE1Nj4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvQ29jb2Ev X1dLVGh1bWJuYWlsVmlldy5tbToKKyAgICAgICAgKC1bX1dLVGh1bWJuYWlsVmlldyBfcmVxdWVz dFNuYXBzaG90SWZOZWVkZWRdKToKKyAgICAgICAgRG9uJ3QgYmFpbCBmcm9tIHJlcXVlc3Rpbmcg YSBzbmFwc2hvdCBqdXN0IGJlY2F1c2Ugd2UgYWxyZWFkeSBoYWQgb25lOyB3ZSB3YW50IHRvIHJl c25hcHNob3QuCisgICAgICAgIEtlZXAgdHJhY2sgb2Ygd2hlbiB3ZSBiYWlsIGZyb20gcmVxdWVz dGluZyBhIHNuYXBzaG90IGJlY2F1c2Ugd2UgaGF2ZSBvbmUgaW4tZmxpZ2h0LCBzbyB3ZSBjYW4g cmVxdWVzdCBpdCBsYXRlci4KKworICAgICAgICAoLVtfV0tUaHVtYm5haWxWaWV3IF9kaWRUYWtl U25hcHNob3Q6XSk6CisgICAgICAgIEFwcGx5IHRoZSBzY2FsZSB0byB0aGUgYml0bWFwIHNpemUg KHdob29wcyEpLgorICAgICAgICBNYWtlIENBIGFsd2F5cyByZXNpemUgdGhlIGNvbnRlbnQgdG8g ZmlsbCB0aGUgdGh1bWJuYWlsIHZpZXcncyBsYXllciwgcmVzcGVjdGluZyBhc3BlY3QgcmF0aW8u CisgICAgICAgIFJlLXNuYXBzaG90IGlmIHdlIHByZXZpb3VzbHkgZGVmZXJyZWQgYSBzbmFwc2hv dC4KKworICAgICAgICAoLVtfV0tUaHVtYm5haWxWaWV3IHNldFNjYWxlOl0pOgorICAgICAgICBJ ZiB3ZSBnZXQgYSBzY2FsZSBjaGFuZ2UsIHJlcXVlc3QgYSBuZXcgc25hcHNob3QuCisKKyAgICAg ICAgKC1bX1dLVGh1bWJuYWlsVmlldyBzZXRVc2VzU25hcHNob3Q6XSk6CisgICAgICAgIE5ldmVy IGFwcGx5IHRodW1ibmFpbCBzY2FsZSB0byB0aGUgcGFnZSBpZiB3ZSdyZSB1c2luZyBzbmFwc2hv dHMuIEl0J3MgdW5uZWNlc3NhcnksCisgICAgICAgIGJlY2F1c2Ugc2NhbGUgd2lsbCBiZSBhcHBs aWVkIHNpbXBseSB3aGVuIHBhaW50aW5nIHRoZSBzb2Z0d2FyZSBzbmFwc2hvdC4KKyAgICAgICAg QXBwbHkgdGhlIHRodW1ibmFpbCBzY2FsZSBpZiB3ZSdyZSBnb2luZyBmcm9tIHVzZXNTbmFwc2hv dCAtPiAhdXNlc1NuYXBzaG90LgorCisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBh Z2UuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJQYWdlOjpzbmFwc2hvdEF0U2l6ZSk6CisgICAg ICAgIFNuYXBzaG90cyBzaG91bGQgdXNlIHRoZSBncmVhdGVyIG9mIHRoZSB0d28gc2NhbGVzLCBz byBhcyB0byBuZXZlciBsZWF2ZSBhIHBvcnRpb24gb2YgdGhlIHNuYXBzaG90IHVucGFpbnRlZC4K KworMjAxNC0wNC0xNCAgVGltIEhvcnRvbiAgPHRpbW90aHlfaG9ydG9uQGFwcGxlLmNvbT4KKwog ICAgICAgICBNYWtlIFdLKFdlYilWaWV3IG1hZ25pZmljYXRpb24gc2V0dGVycyBhY3R1YWxseSB1 c2Ugdmlldy1yZWxhdGl2ZSBwb3NpdGlvbnMKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTEzMTYxMQogICAgICAgICA8cmRhcjovL3Byb2JsZW0vMTU5NjUy Mzk+CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29hL19XS1Ro dW1ibmFpbFZpZXcubW0gYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29hL19XS1Ro dW1ibmFpbFZpZXcubW0KaW5kZXggM2JhNjdmZjQuLjFkYjFjNWQgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvX1dLVGh1bWJuYWlsVmlldy5tbQorKysgYi9T b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29hL19XS1RodW1ibmFpbFZpZXcubW0KQEAg LTUzLDYgKzUzLDggQEAgdXNpbmcgbmFtZXNwYWNlIFdlYktpdDsKICAgICBCT09MIF9vcmlnaW5h bFNvdXJjZVZpZXdJc0luV2luZG93OwogCiAgICAgQk9PTCBfc2hvdWxkQXBwbHlUaHVtYm5haWxT Y2FsZTsKKworICAgIEJPT0wgX3NuYXBzaG90V2FzRGVmZXJyZWQ7CiB9CiAKIEBzeW50aGVzaXpl IF93YWl0aW5nRm9yU25hcHNob3QgPSBfd2FpdGluZ0ZvclNuYXBzaG90OwpAQCAtMTA1LDggKzEw NywxMyBAQCB1c2luZyBuYW1lc3BhY2UgV2ViS2l0OwogCiAtICh2b2lkKV9yZXF1ZXN0U25hcHNo b3RJZk5lZWRlZAogewotICAgIGlmICghX3VzZXNTbmFwc2hvdCB8fCBfd2FpdGluZ0ZvclNuYXBz aG90IHx8IHNlbGYubGF5ZXIuY29udGVudHMpCisgICAgaWYgKCFfdXNlc1NuYXBzaG90KQorICAg ICAgICByZXR1cm47CisKKyAgICBpZiAoX3dhaXRpbmdGb3JTbmFwc2hvdCkgeworICAgICAgICBf c25hcHNob3RXYXNEZWZlcnJlZCA9IFlFUzsKICAgICAgICAgcmV0dXJuOworICAgIH0KIAogICAg IF93YWl0aW5nRm9yU25hcHNob3QgPSBZRVM7CiAKQEAgLTExNCw3ICsxMjEsNyBAQCB1c2luZyBu YW1lc3BhY2UgV2ViS2l0OwogICAgIEludFJlY3Qgc25hcHNob3RSZWN0KEludFBvaW50KCksIF93 ZWJQYWdlUHJveHktPnZpZXdTaXplKCkpOwogICAgIFNuYXBzaG90T3B0aW9ucyBvcHRpb25zID0g U25hcHNob3RPcHRpb25zUmVzcGVjdERyYXdpbmdBcmVhVHJhbnNmb3JtIHwgU25hcHNob3RPcHRp b25zSW5WaWV3Q29vcmRpbmF0ZXM7CiAgICAgSW50U2l6ZSBiaXRtYXBTaXplID0gc25hcHNob3RS ZWN0LnNpemUoKTsKLSAgICBiaXRtYXBTaXplLnNjYWxlKF93ZWJQYWdlUHJveHktPmRldmljZVNj YWxlRmFjdG9yKCkpOworICAgIGJpdG1hcFNpemUuc2NhbGUoX3NjYWxlICogX3dlYlBhZ2VQcm94 eS0+ZGV2aWNlU2NhbGVGYWN0b3IoKSk7CiAgICAgX3dlYlBhZ2VQcm94eS0+dGFrZVNuYXBzaG90 KHNuYXBzaG90UmVjdCwgYml0bWFwU2l6ZSwgb3B0aW9ucywgW3RodW1ibmFpbFZpZXddKGJvb2ws IGNvbnN0IFNoYXJlYWJsZUJpdG1hcDo6SGFuZGxlJiBpbWFnZUhhbmRsZSkgewogICAgICAgICBS ZWZQdHI8U2hhcmVhYmxlQml0bWFwPiBiaXRtYXAgPSBTaGFyZWFibGVCaXRtYXA6OmNyZWF0ZShp bWFnZUhhbmRsZSwgU2hhcmVkTWVtb3J5OjpSZWFkT25seSk7CiAgICAgICAgIFJldGFpblB0cjxD R0ltYWdlUmVmPiBjZ0ltYWdlID0gYml0bWFwLT5tYWtlQ0dJbWFnZSgpOwpAQCAtMTI2LDcgKzEz MywxNCBAQCB1c2luZyBuYW1lc3BhY2UgV2ViS2l0OwogewogICAgIF93YWl0aW5nRm9yU25hcHNo b3QgPSBOTzsKICAgICBzZWxmLmxheWVyLnN1YmxheWVycyA9IEBbXTsKKyAgICBzZWxmLmxheWVy LmNvbnRlbnRzR3Jhdml0eSA9IGtDQUdyYXZpdHlSZXNpemVBc3BlY3RGaWxsOwogICAgIHNlbGYu bGF5ZXIuY29udGVudHMgPSAoaWQpaW1hZ2U7CisKKyAgICAvLyBJZiB3ZSBnb3QgYSBzY2FsZSBj aGFuZ2Ugd2hpbGUgc25hcHNob3R0aW5nLCB3ZSdsbCB0YWtlIGFub3RoZXIgc25hcHNob3Qgb25j ZSB0aGUgZmlyc3Qgb25lIHJldHVybnMuCisgICAgaWYgKF9zbmFwc2hvdFdhc0RlZmVycmVkKSB7 CisgICAgICAgIF9zbmFwc2hvdFdhc0RlZmVycmVkID0gTk87CisgICAgICAgIFtzZWxmIF9yZXF1 ZXN0U25hcHNob3RJZk5lZWRlZF07CisgICAgfQogfQogCiAtICh2b2lkKXZpZXdEaWRNb3ZlVG9X aW5kb3cKQEAgLTE0Niw2ICsxNjAsOSBAQCB1c2luZyBuYW1lc3BhY2UgV2ViS2l0OwogCiAgICAg aWYgKHNlbGYud2luZG93ICYmIF9zaG91bGRBcHBseVRodW1ibmFpbFNjYWxlKQogICAgICAgICBf d2ViUGFnZVByb3h5LT5zZXRUaHVtYm5haWxTY2FsZShfc2NhbGUpOworCisgICAgaWYgKF91c2Vz U25hcHNob3QpCisgICAgICAgIFtzZWxmIF9yZXF1ZXN0U25hcHNob3RJZk5lZWRlZF07CiB9CiAK IC0gKHZvaWQpc2V0VXNlc1NuYXBzaG90OihCT09MKXVzZXNTbmFwc2hvdApAQCAtMTU0LDE0ICsx NzEsMTcgQEAgdXNpbmcgbmFtZXNwYWNlIFdlYktpdDsKICAgICAgICAgcmV0dXJuOwogCiAgICAg X3VzZXNTbmFwc2hvdCA9IHVzZXNTbmFwc2hvdDsKKyAgICBfc2hvdWxkQXBwbHlUaHVtYm5haWxT Y2FsZSA9IF91c2VzU25hcHNob3QgPyBmYWxzZSA6ICFfb3JpZ2luYWxTb3VyY2VWaWV3SXNJbldp bmRvdzsKIAogICAgIGlmICghc2VsZi53aW5kb3cpCiAgICAgICAgIHJldHVybjsKIAogICAgIGlm ICh1c2VzU25hcHNob3QpCiAgICAgICAgIFtzZWxmIF9yZXF1ZXN0U25hcHNob3RJZk5lZWRlZF07 Ci0gICAgZWxzZQorICAgIGVsc2UgeworICAgICAgICBfd2ViUGFnZVByb3h5LT5zZXRUaHVtYm5h aWxTY2FsZShfc2NhbGUpOwogICAgICAgICBbX3drVmlldyBfcmVwYXJlbnRMYXllclRyZWVJblRo dW1ibmFpbFZpZXddOworICAgIH0KIH0KIAogLSAodm9pZClfc2V0VGh1bWJuYWlsTGF5ZXI6KENB TGF5ZXIgKilsYXllcgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQ YWdlL1dlYlBhZ2UuY3BwIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBh Z2UuY3BwCmluZGV4IGIzNWE4Y2QuLjM3MmZmZDQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQy L1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQ cm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5jcHAKQEAgLTE1NzMsNyArMTU3Myw3IEBAIFBhc3NSZWZQ dHI8V2ViSW1hZ2U+IFdlYlBhZ2U6OnNuYXBzaG90QXRTaXplKGNvbnN0IEludFJlY3QmIHJlY3Qs IGNvbnN0IEludFNpemUmCiAKICAgICBmbG9hdCBob3Jpem9udGFsU2NhbGVGYWN0b3IgPSBzdGF0 aWNfY2FzdDxmbG9hdD4oYml0bWFwU2l6ZS53aWR0aCgpKSAvIHJlY3Qud2lkdGgoKTsKICAgICBm bG9hdCB2ZXJ0aWNhbFNjYWxlRmFjdG9yID0gc3RhdGljX2Nhc3Q8ZmxvYXQ+KGJpdG1hcFNpemUu aGVpZ2h0KCkpIC8gcmVjdC5oZWlnaHQoKTsKLSAgICBmbG9hdCBzY2FsZUZhY3RvciA9IHN0ZDo6 bWluKGhvcml6b250YWxTY2FsZUZhY3RvciwgdmVydGljYWxTY2FsZUZhY3Rvcik7CisgICAgZmxv YXQgc2NhbGVGYWN0b3IgPSBzdGQ6Om1heChob3Jpem9udGFsU2NhbGVGYWN0b3IsIHZlcnRpY2Fs U2NhbGVGYWN0b3IpOwogCiAgICAgUmVmUHRyPFdlYkltYWdlPiBzbmFwc2hvdCA9IFdlYkltYWdl OjpjcmVhdGUoYml0bWFwU2l6ZSwgc25hcHNob3RPcHRpb25zVG9JbWFnZU9wdGlvbnMob3B0aW9u cykpOwogICAgIGlmICghc25hcHNob3QtPmJpdG1hcCgpKQo=