131626 2014-04-14 11:26:56 -0700 Eliminate CachedFrame::m_mousePressNode 2014-04-14 14:24:33 -0700 1 1 1 Unclassified WebKit UI Events 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ap ap beidson commit-queue darin oldest_to_newest 1000552 0 ap 2014-04-14 11:26:56 -0700 It doesn't make sense to preserve EventHandler::m_mousePressNode in a cached frame (and we don't preserve EventHandler::m_mousePressed anyway, potentially breaking EventHandler invariants). How m_mousePressNode got into CachedFrame was by mechanically combining PageState and PageCache in r20837. 1000554 1 229294 ap 2014-04-14 11:31:34 -0700 Created attachment 229294 proposed patch 1000596 2 229294 commit-queue 2014-04-14 14:24:31 -0700 Comment on attachment 229294 proposed patch Clearing flags on attachment: 229294 Committed r167267: <http://trac.webkit.org/changeset/167267> 1000597 3 commit-queue 2014-04-14 14:24:33 -0700 All reviewed patches have been landed. Closing bug. 229294 2014-04-14 11:31:34 -0700 2014-04-14 14:24:31 -0700 proposed patch MousePressNode.txt text/plain 5100 ap SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2NzI1NSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI3IEBACisyMDE0LTA0LTE0ICBBbGV4ZXkg UHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIEVsaW1pbmF0ZSBDYWNoZWRG cmFtZTo6bV9tb3VzZVByZXNzTm9kZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTMxNjI2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgSSBjb3VsZG4ndCBmaW5kIGFueSBvYnNlcnZhYmxlIGVmZmVjdCBvZiB0 aGlzIGNoYW5nZS4KKworICAgICAgICAqIGhpc3RvcnkvQ2FjaGVkRnJhbWUuY3BwOgorICAgICAg ICAoV2ViQ29yZTo6Q2FjaGVkRnJhbWVCYXNlOjpDYWNoZWRGcmFtZUJhc2UpOgorICAgICAgICAo V2ViQ29yZTo6Q2FjaGVkRnJhbWVCYXNlOjpyZXN0b3JlKToKKyAgICAgICAgKFdlYkNvcmU6OkNh Y2hlZEZyYW1lOjpjbGVhcik6CisgICAgICAgICogaGlzdG9yeS9DYWNoZWRGcmFtZS5oOgorICAg ICAgICAoV2ViQ29yZTo6Q2FjaGVkRnJhbWU6OmRvY3VtZW50TG9hZGVyKToKKyAgICAgICAgKFdl YkNvcmU6OkNhY2hlZEZyYW1lOjptb3VzZVByZXNzTm9kZSk6IERlbGV0ZWQuCisgICAgICAgIEVs aW1pbmF0ZWQgbV9tb3VzZVByZXNzTm9kZSwgYWNjZXNzb3IsIGFuZCBjb2RlIHRoYXQgcmVhY2hl ZCBvdXQgdG8gRXZlbnRIYW5kbGVyLgorCisgICAgICAgICogcGFnZS9FdmVudEhhbmRsZXIuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6RXZlbnRIYW5kbGVyOjptb3VzZVByZXNzTm9kZSk6IERlbGV0 ZWQuCisgICAgICAgIChXZWJDb3JlOjpFdmVudEhhbmRsZXI6OnNldE1vdXNlUHJlc3NOb2RlKTog RGVsZXRlZC4KKyAgICAgICAgKiBwYWdlL0V2ZW50SGFuZGxlci5oOgorICAgICAgICAoV2ViQ29y ZTo6RXZlbnRIYW5kbGVyOjpzZXRNb3VzZVByZXNzZWQpOiBEZWxldGVkLiBUaGlzIGZ1bmN0aW9u IHdhcyBhbHJlYWR5IHVudXNlZC4KKwogMjAxNC0wNC0xNCAgT2xpdmVyIEh1bnQgIDxvbGl2ZXJA YXBwbGUuY29tPgogCiAgICAgICAgIFVwZGF0ZSB0ZXN0IHJlc3VsdApJbmRleDogU291cmNlL1dl YkNvcmUvaGlzdG9yeS9DYWNoZWRGcmFtZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNv cmUvaGlzdG9yeS9DYWNoZWRGcmFtZS5jcHAJKHJldmlzaW9uIDE2NzI0OCkKKysrIFNvdXJjZS9X ZWJDb3JlL2hpc3RvcnkvQ2FjaGVkRnJhbWUuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zMSw3ICsz MSw2IEBACiAjaW5jbHVkZSAiRE9NV2luZG93LmgiCiAjaW5jbHVkZSAiRG9jdW1lbnQuaCIKICNp bmNsdWRlICJEb2N1bWVudExvYWRlci5oIgotI2luY2x1ZGUgIkV2ZW50SGFuZGxlci5oIgogI2lu Y2x1ZGUgIkV2ZW50TmFtZXMuaCIKICNpbmNsdWRlICJFeGNlcHRpb25Db2RlLmgiCiAjaW5jbHVk ZSAiRm9jdXNDb250cm9sbGVyLmgiCkBAIC02NCw3ICs2Myw2IEBAIENhY2hlZEZyYW1lQmFzZTo6 Q2FjaGVkRnJhbWVCYXNlKEZyYW1lJiAKICAgICA6IG1fZG9jdW1lbnQoZnJhbWUuZG9jdW1lbnQo KSkKICAgICAsIG1fZG9jdW1lbnRMb2FkZXIoZnJhbWUubG9hZGVyKCkuZG9jdW1lbnRMb2FkZXIo KSkKICAgICAsIG1fdmlldyhmcmFtZS52aWV3KCkpCi0gICAgLCBtX21vdXNlUHJlc3NOb2RlKGZy YW1lLmV2ZW50SGFuZGxlcigpLm1vdXNlUHJlc3NOb2RlKCkpCiAgICAgLCBtX3VybChmcmFtZS5k b2N1bWVudCgpLT51cmwoKSkKICAgICAsIG1faXNNYWluRnJhbWUoIWZyYW1lLnRyZWUoKS5wYXJl bnQoKSkKICAgICAsIG1faXNDb21wb3NpdGVkKGZyYW1lLnZpZXcoKS0+aGFzQ29tcG9zaXRlZENv bnRlbnQoKSkKQEAgLTk0LDcgKzkyLDYgQEAgdm9pZCBDYWNoZWRGcmFtZUJhc2U6OnJlc3RvcmUo KQogICAgICAgICBtX2RvY3VtZW50LT5hY2Nlc3NTVkdFeHRlbnNpb25zKCktPnVucGF1c2VBbmlt YXRpb25zKCk7CiAKICAgICBmcmFtZS5hbmltYXRpb24oKS5yZXN1bWVBbmltYXRpb25zRm9yRG9j dW1lbnQobV9kb2N1bWVudC5nZXQoKSk7Ci0gICAgZnJhbWUuZXZlbnRIYW5kbGVyKCkuc2V0TW91 c2VQcmVzc05vZGUobV9tb3VzZVByZXNzTm9kZS5nZXQoKSk7CiAgICAgbV9kb2N1bWVudC0+cmVz dW1lQWN0aXZlRE9NT2JqZWN0cyhBY3RpdmVET01PYmplY3Q6OkRvY3VtZW50V2lsbEJlY29tZUlu YWN0aXZlKTsKICAgICBtX2RvY3VtZW50LT5yZXN1bWVTY3JpcHRlZEFuaW1hdGlvbkNvbnRyb2xs ZXJDYWxsYmFja3MoKTsKIApAQCAtMjM4LDcgKzIzNSw2IEBAIHZvaWQgQ2FjaGVkRnJhbWU6OmNs ZWFyKCkKIAogICAgIG1fZG9jdW1lbnQgPSBudWxscHRyOwogICAgIG1fdmlldyA9IG51bGxwdHI7 Ci0gICAgbV9tb3VzZVByZXNzTm9kZSA9IG51bGxwdHI7CiAgICAgbV91cmwgPSBVUkwoKTsKIAog ICAgIG1fY2FjaGVkRnJhbWVQbGF0Zm9ybURhdGEgPSBudWxscHRyOwpJbmRleDogU291cmNlL1dl YkNvcmUvaGlzdG9yeS9DYWNoZWRGcmFtZS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3Jl L2hpc3RvcnkvQ2FjaGVkRnJhbWUuaAkocmV2aXNpb24gMTY3MjQ4KQorKysgU291cmNlL1dlYkNv cmUvaGlzdG9yeS9DYWNoZWRGcmFtZS5oCSh3b3JraW5nIGNvcHkpCkBAIC01Niw3ICs1Niw2IEBA IHByb3RlY3RlZDoKICAgICBSZWZQdHI8RG9jdW1lbnQ+IG1fZG9jdW1lbnQ7CiAgICAgUmVmUHRy PERvY3VtZW50TG9hZGVyPiBtX2RvY3VtZW50TG9hZGVyOwogICAgIFJlZlB0cjxGcmFtZVZpZXc+ IG1fdmlldzsKLSAgICBSZWZQdHI8Tm9kZT4gbV9tb3VzZVByZXNzTm9kZTsKICAgICBVUkwgbV91 cmw7CiAgICAgc3RkOjp1bmlxdWVfcHRyPFNjcmlwdENhY2hlZEZyYW1lRGF0YT4gbV9jYWNoZWRG cmFtZVNjcmlwdERhdGE7CiAgICAgc3RkOjp1bmlxdWVfcHRyPENhY2hlZEZyYW1lUGxhdGZvcm1E YXRhPiBtX2NhY2hlZEZyYW1lUGxhdGZvcm1EYXRhOwpAQCAtODEsNyArODAsNiBAQCBwdWJsaWM6 CiAgICAgdXNpbmcgQ2FjaGVkRnJhbWVCYXNlOjp2aWV3OwogICAgIHVzaW5nIENhY2hlZEZyYW1l QmFzZTo6dXJsOwogICAgIERvY3VtZW50TG9hZGVyKiBkb2N1bWVudExvYWRlcigpIGNvbnN0IHsg cmV0dXJuIG1fZG9jdW1lbnRMb2FkZXIuZ2V0KCk7IH0KLSAgICBOb2RlKiBtb3VzZVByZXNzTm9k ZSgpIGNvbnN0IHsgcmV0dXJuIG1fbW91c2VQcmVzc05vZGUuZ2V0KCk7IH0KIAogICAgIGludCBk ZXNjZW5kYW50RnJhbWVDb3VudCgpIGNvbnN0OwogfTsKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3Bh Z2UvRXZlbnRIYW5kbGVyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wYWdlL0V2 ZW50SGFuZGxlci5jcHAJKHJldmlzaW9uIDE2NzI0OCkKKysrIFNvdXJjZS9XZWJDb3JlL3BhZ2Uv RXZlbnRIYW5kbGVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTA5NCwxNiArMTA5NCw2IEBAIHZv aWQgRXZlbnRIYW5kbGVyOjpzdG9wQXV0b3Njcm9sbFRpbWVyKGIKICAgICBtX2F1dG9zY3JvbGxD b250cm9sbGVyLT5zdG9wQXV0b3Njcm9sbFRpbWVyKHJlbmRlcmVySXNCZWluZ0Rlc3Ryb3llZCk7 CiB9CiAKLU5vZGUqIEV2ZW50SGFuZGxlcjo6bW91c2VQcmVzc05vZGUoKSBjb25zdAotewotICAg IHJldHVybiBtX21vdXNlUHJlc3NOb2RlLmdldCgpOwotfQotCi12b2lkIEV2ZW50SGFuZGxlcjo6 c2V0TW91c2VQcmVzc05vZGUoUGFzc1JlZlB0cjxOb2RlPiBub2RlKQotewotICAgIG1fbW91c2VQ cmVzc05vZGUgPSBub2RlOwotfQotCiBib29sIEV2ZW50SGFuZGxlcjo6c2Nyb2xsT3ZlcmZsb3co U2Nyb2xsRGlyZWN0aW9uIGRpcmVjdGlvbiwgU2Nyb2xsR3JhbnVsYXJpdHkgZ3JhbnVsYXJpdHks IE5vZGUqIHN0YXJ0aW5nTm9kZSkKIHsKICAgICBOb2RlKiBub2RlID0gc3RhcnRpbmdOb2RlOwpJ bmRleDogU291cmNlL1dlYkNvcmUvcGFnZS9FdmVudEhhbmRsZXIuaAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV2ViQ29yZS9wYWdlL0V2ZW50SGFuZGxlci5oCShyZXZpc2lvbiAxNjcyNDgpCisrKyBT b3VyY2UvV2ViQ29yZS9wYWdlL0V2ZW50SGFuZGxlci5oCSh3b3JraW5nIGNvcHkpCkBAIC0xMzAs OSArMTMwLDYgQEAgcHVibGljOgogICAgIHZvaWQgdXBkYXRlU2VsZWN0aW9uRm9yTW91c2VEcmFn KCk7CiAjZW5kaWYKIAotICAgIE5vZGUqIG1vdXNlUHJlc3NOb2RlKCkgY29uc3Q7Ci0gICAgdm9p ZCBzZXRNb3VzZVByZXNzTm9kZShQYXNzUmVmUHRyPE5vZGU+KTsKLQogI2lmIEVOQUJMRShQQU5f U0NST0xMSU5HKQogICAgIHZvaWQgZGlkUGFuU2Nyb2xsU3RhcnQoKTsKICAgICB2b2lkIGRpZFBh blNjcm9sbFN0b3AoKTsKQEAgLTE1NCw3ICsxNTEsNyBAQCBwdWJsaWM6CiAgICAgICAgIGNvbnN0 IExheW91dFNpemUmIHBhZGRpbmcgPSBMYXlvdXRTaXplKCkpOwogCiAgICAgYm9vbCBtb3VzZVBy ZXNzZWQoKSBjb25zdCB7IHJldHVybiBtX21vdXNlUHJlc3NlZDsgfQotICAgIHZvaWQgc2V0TW91 c2VQcmVzc2VkKGJvb2wgcHJlc3NlZCkgeyBtX21vdXNlUHJlc3NlZCA9IHByZXNzZWQ7IH0KKyAg ICBOb2RlKiBtb3VzZVByZXNzTm9kZSgpIGNvbnN0IHsgcmV0dXJuIG1fbW91c2VQcmVzc05vZGUu Z2V0KCk7IH0KIAogICAgIHZvaWQgc2V0Q2FwdHVyaW5nTW91c2VFdmVudHNFbGVtZW50KFBhc3NS ZWZQdHI8RWxlbWVudD4pOyAvLyBBIGNhbGxlciBpcyByZXNwb25zaWJsZSBmb3IgcmVzZXR0aW5n IGNhcHR1cmluZyBlbGVtZW50IHRvIDAuCiAK