131615 2014-04-14 07:16:36 -0700 fix potential truncation in x86assembler 2014-04-14 09:32:13 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) PC Windows 8 RESOLVED FIXED P2 Trivial --- 1 alex.christensen webkit-unassigned commit-queue darin ggaren oldest_to_newest 1000476 0 alex.christensen 2014-04-14 07:16:36 -0700 My solution to https://bugs.webkit.org/show_bug.cgi?id=131508 truncates the size_t (which is a 64-bit integer) to an unsigned (which is a 32-bit integer in Windows) before taking the minimum of it an 15, which could lead to truncation problems. Truncating after the call to std::min should fix it. 1000477 1 229281 alex.christensen 2014-04-14 07:17:35 -0700 Created attachment 229281 Patch 1000488 2 229281 darin 2014-04-14 08:30:12 -0700 Comment on attachment 229281 Patch Yes, this looks better. 1000503 3 229281 commit-queue 2014-04-14 09:32:10 -0700 Comment on attachment 229281 Patch Clearing flags on attachment: 229281 Committed r167250: <http://trac.webkit.org/changeset/167250> 1000504 4 commit-queue 2014-04-14 09:32:13 -0700 All reviewed patches have been landed. Closing bug. 229281 2014-04-14 07:17:35 -0700 2014-04-14 09:32:10 -0700 Patch bug-131615-20140414081713.patch text/plain 1409 alex.christensen SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTY3MjQ0KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBA CisyMDE0LTA0LTE0ICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+ CisKKyAgICAgICAgRml4ZWQgcG90ZW50aWFsIGludGVnZXIgdHJ1bmNhdGlvbi4KKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMTYxNQorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogYXNzZW1ibGVyL1g4NkFz c2VtYmxlci5oOgorICAgICAgICAoSlNDOjpYODZBc3NlbWJsZXI6OmZpbGxOb3BzKToKKyAgICAg ICAgVHJ1bmNhdGUgdGhlIHNpemVfdCB0byBhbiB1bnNpZ25lZCBhZnRlciBpdCBpcyBsaW1pdGVk IHRvIDE1IGluc3RlYWQgb2YgYmVmb3JlLgorCiAyMDE0LTA0LTE0ICBCZW5qYW1pbiBQb3VsYWlu ICA8YmVuamFtaW5Ad2Via2l0Lm9yZz4KIAogICAgICAgICBbSlNDXSBJbXByb3ZlIHRoZSBjYWxs IHNpdGUgb2Ygc3RyaW5nIGNvbXBhcmlzb24gaW4gc29tZSBob3QgcGF0aApJbmRleDogU291cmNl L0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9YODZBc3NlbWJsZXIuaAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL1g4NkFzc2VtYmxlci5oCShyZXZpc2lvbiAx NjcyNDQpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL1g4NkFzc2VtYmxlci5o CSh3b3JraW5nIGNvcHkpCkBAIC0yMjczLDcgKzIyNzMsNyBAQCBwdWJsaWM6CiAKICAgICAgICAg dWludDhfdCogd2hlcmUgPSByZWludGVycHJldF9jYXN0PHVpbnQ4X3QqPihiYXNlKTsKICAgICAg ICAgd2hpbGUgKHNpemUpIHsKLSAgICAgICAgICAgIHVuc2lnbmVkIG5vcFNpemUgPSBzdGQ6Om1p bjx1bnNpZ25lZD4oc2l6ZSwgMTVVTCk7CisgICAgICAgICAgICB1bnNpZ25lZCBub3BTaXplID0g c3RhdGljX2Nhc3Q8dW5zaWduZWQ+KHN0ZDo6bWluPHNpemVfdD4oc2l6ZSwgMTUpKTsKICAgICAg ICAgICAgIHVuc2lnbmVkIG51bVByZWZpeGVzID0gbm9wU2l6ZSA8PSAxMCA/IDAgOiBub3BTaXpl IC0gMTA7CiAgICAgICAgICAgICBmb3IgKHVuc2lnbmVkIGkgPSAwOyBpICE9IG51bVByZWZpeGVz OyArK2kpCiAgICAgICAgICAgICAgICAgKndoZXJlKysgPSAweDY2Owo=