131613 2014-04-14 05:18:27 -0700 Fix incorrect indentations in CodeGeneratorJS.pm introduced in r165521 2014-04-14 05:45:36 -0700 1 1 1 Unclassified WebKit Bindings 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 pmolnar.u-szeged pmolnar.u-szeged burg cdumez cgarcia commit-queue ossy oldest_to_newest 1000466 0 pmolnar.u-szeged 2014-04-14 05:18:27 -0700 They're causing the style problems mentioned here: https://bugs.webkit.org/show_bug.cgi?id=131557 1000467 1 229280 pmolnar.u-szeged 2014-04-14 05:21:08 -0700 Created attachment 229280 patch 1000471 2 229280 ossy 2014-04-14 05:27:59 -0700 Comment on attachment 229280 patch LGTM 1000473 3 229280 commit-queue 2014-04-14 05:45:31 -0700 Comment on attachment 229280 patch Clearing flags on attachment: 229280 Committed r167244: <http://trac.webkit.org/changeset/167244> 1000474 4 commit-queue 2014-04-14 05:45:36 -0700 All reviewed patches have been landed. Closing bug. 229280 2014-04-14 05:21:08 -0700 2014-04-14 05:45:31 -0700 patch fix-codegenjs.patch text/plain 5152 pmolnar.u-szeged ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA3MDY3Y2I1Li4wNjkyNjczIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTQtMDQtMTQgIFBldGVyIE1vbG5hciAgPHBtb2xuYXIudS1zemVnZWRAcGFydG5lci5z YW1zdW5nLmNvbT4KKworICAgICAgICBGaXggaW5jb3JyZWN0IGluZGVudGF0aW9ucyBpbiBDb2Rl R2VuZXJhdG9ySlMucG0gaW50cm9kdWNlZCBpbiByMTY1NTIxCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzE2MTMKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGJpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVy YXRvckpTLnBtOgorICAgICAgICAoR2VuZXJhdGVJbXBsZW1lbnRhdGlvbik6CisgICAgICAgIEZp eGVkIDUtc3BhY2UgaW5kZW50YXRpb24uCisgICAgICAgICogYmluZGluZ3Mvc2NyaXB0cy90ZXN0 L0pTL0pTVGVzdE5vbmRldGVybWluaXN0aWMuY3BwOgorICAgICAgICBVcGRhdGVkIHRoZSB0ZXN0 cyBhY2NvcmRpbmdseS4KKwogMjAxNC0wNC0xNCAgTWFudWVsIFJlZ28gQ2FzYXNub3ZhcyAgPHJl Z29AaWdhbGlhLmNvbT4KIAogICAgICAgICBbSlNDXSBDU1NTdHlsZURlY2xhcmF0aW9uIHJlcG9y dCBpbmNvcnJlY3QgZGVzY3JpcHRvcgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGlu Z3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9ySlMucG0gYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9z Y3JpcHRzL0NvZGVHZW5lcmF0b3JKUy5wbQppbmRleCBjZDNiZTA2Li45MGYxNWQ4IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JKUy5wbQor KysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JKUy5wbQpA QCAtMjE5Niw5ICsyMTk2LDkgQEAgc3ViIEdlbmVyYXRlSW1wbGVtZW50YXRpb24KICAgICAgICAg ICAgICAgICBwdXNoKEBpbXBsQ29udGVudCwgIiAgICAgICAgSlNWYWx1ZSByZXN1bHQgPSAiIC4g TmF0aXZlVG9KU1ZhbHVlKCRhdHRyaWJ1dGUtPnNpZ25hdHVyZSwgMCwgJGludGVyZmFjZU5hbWUs ICJtZW1vaXplZFJlc3VsdCIsICJjYXN0ZWRUaGlzIikgLiAiO1xuIik7CiAgICAgICAgICAgICAg ICAgcHVzaChAaW1wbENvbnRlbnQsICIgICAgICAgIHNldERPTUV4Y2VwdGlvbihleGVjLCBlYyk7 XG4iKSBpZiAkZ2V0dGVyRXhjZXB0aW9uczsKICAgICAgICAgICAgICAgICBwdXNoKEBpbXBsQ29u dGVudCwgIiAgICAgICAgcmV0dXJuIEpTVmFsdWU6OmVuY29kZShyZXN1bHQpO1xuIik7Ci0gICAg ICAgICAgICAgICAgcHVzaChAaW1wbENvbnRlbnQsICIgICAgIH1cbiIpOworICAgICAgICAgICAg ICAgIHB1c2goQGltcGxDb250ZW50LCAiICAgIH1cbiIpOwogICAgICAgICAgICAgICAgIHB1c2go QGltcGxDb250ZW50LCAiXG4iKTsKLSAgICAgICAgICAgICAgICBwdXNoKEBpbXBsQ29udGVudCwg IiAgICAgaWYgKGN1cnNvci5pc1JlcGxheWluZygpKSB7XG4iKTsKKyAgICAgICAgICAgICAgICBw dXNoKEBpbXBsQ29udGVudCwgIiAgICBpZiAoY3Vyc29yLmlzUmVwbGF5aW5nKCkpIHtcbiIpOwog ICAgICAgICAgICAgICAgIHB1c2goQGltcGxDb250ZW50LCAiICAgICAgICAkbWVtb2l6ZWRUeXBl IG1lbW9pemVkUmVzdWx0O1xuIik7CiAgICAgICAgICAgICAgICAgcHVzaChAaW1wbENvbnRlbnQs ICIgICAgICAgIE1lbW9pemVkRE9NUmVzdWx0QmFzZSogaW5wdXQgPSBjdXJzb3IuZmV0Y2hJbnB1 dDxNZW1vaXplZERPTVJlc3VsdEJhc2U+KCk7XG4iKTsKICAgICAgICAgICAgICAgICBwdXNoKEBp bXBsQ29udGVudCwgIiAgICAgICAgaWYgKGlucHV0ICYmIGlucHV0LT5jb252ZXJ0VG88JG1lbW9p emVkVHlwZT4obWVtb2l6ZWRSZXN1bHQpKSB7XG4iKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL2JpbmRpbmdzL3NjcmlwdHMvdGVzdC9KUy9KU1Rlc3ROb25kZXRlcm1pbmlzdGljLmNwcCBi L1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvdGVzdC9KUy9KU1Rlc3ROb25kZXRlcm1p bmlzdGljLmNwcAppbmRleCAyN2VlNjM1Li5lYmJmZGFkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9iaW5kaW5ncy9zY3JpcHRzL3Rlc3QvSlMvSlNUZXN0Tm9uZGV0ZXJtaW5pc3RpYy5jcHAK KysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy90ZXN0L0pTL0pTVGVzdE5vbmRl dGVybWluaXN0aWMuY3BwCkBAIC0xNjksOSArMTY5LDkgQEAgRW5jb2RlZEpTVmFsdWUganNUZXN0 Tm9uZGV0ZXJtaW5pc3RpY05vbmRldGVybWluaXN0aWNSZWFkb25seUF0dHIoRXhlY1N0YXRlKiBl eGUKICAgICAgICAgY3Vyc29yLmFwcGVuZElucHV0PE1lbW9pemVkRE9NUmVzdWx0PGludD4+KGJp bmRpbmdOYW1lLmdldCgpLnN0cmluZygpLCBtZW1vaXplZFJlc3VsdCwgMCk7CiAgICAgICAgIEpT VmFsdWUgcmVzdWx0ID0ganNOdW1iZXIobWVtb2l6ZWRSZXN1bHQpOwogICAgICAgICByZXR1cm4g SlNWYWx1ZTo6ZW5jb2RlKHJlc3VsdCk7Ci0gICAgIH0KKyAgICB9CiAKLSAgICAgaWYgKGN1cnNv ci5pc1JlcGxheWluZygpKSB7CisgICAgaWYgKGN1cnNvci5pc1JlcGxheWluZygpKSB7CiAgICAg ICAgIGludCBtZW1vaXplZFJlc3VsdDsKICAgICAgICAgTWVtb2l6ZWRET01SZXN1bHRCYXNlKiBp bnB1dCA9IGN1cnNvci5mZXRjaElucHV0PE1lbW9pemVkRE9NUmVzdWx0QmFzZT4oKTsKICAgICAg ICAgaWYgKGlucHV0ICYmIGlucHV0LT5jb252ZXJ0VG88aW50PihtZW1vaXplZFJlc3VsdCkpIHsK QEAgLTIwMyw5ICsyMDMsOSBAQCBFbmNvZGVkSlNWYWx1ZSBqc1Rlc3ROb25kZXRlcm1pbmlzdGlj Tm9uZGV0ZXJtaW5pc3RpY1dyaXRlYWJsZUF0dHIoRXhlY1N0YXRlKiBleAogICAgICAgICBjdXJz b3IuYXBwZW5kSW5wdXQ8TWVtb2l6ZWRET01SZXN1bHQ8U3RyaW5nPj4oYmluZGluZ05hbWUuZ2V0 KCkuc3RyaW5nKCksIG1lbW9pemVkUmVzdWx0LCAwKTsKICAgICAgICAgSlNWYWx1ZSByZXN1bHQg PSBqc1N0cmluZ1dpdGhDYWNoZShleGVjLCBtZW1vaXplZFJlc3VsdCk7CiAgICAgICAgIHJldHVy biBKU1ZhbHVlOjplbmNvZGUocmVzdWx0KTsKLSAgICAgfQorICAgIH0KIAotICAgICBpZiAoY3Vy c29yLmlzUmVwbGF5aW5nKCkpIHsKKyAgICBpZiAoY3Vyc29yLmlzUmVwbGF5aW5nKCkpIHsKICAg ICAgICAgU3RyaW5nIG1lbW9pemVkUmVzdWx0OwogICAgICAgICBNZW1vaXplZERPTVJlc3VsdEJh c2UqIGlucHV0ID0gY3Vyc29yLmZldGNoSW5wdXQ8TWVtb2l6ZWRET01SZXN1bHRCYXNlPigpOwog ICAgICAgICBpZiAoaW5wdXQgJiYgaW5wdXQtPmNvbnZlcnRUbzxTdHJpbmc+KG1lbW9pemVkUmVz dWx0KSkgewpAQCAtMjM3LDkgKzIzNyw5IEBAIEVuY29kZWRKU1ZhbHVlIGpzVGVzdE5vbmRldGVy bWluaXN0aWNOb25kZXRlcm1pbmlzdGljRXhjZXB0aW9uQXR0cihFeGVjU3RhdGUqIGV4CiAgICAg ICAgIGN1cnNvci5hcHBlbmRJbnB1dDxNZW1vaXplZERPTVJlc3VsdDxTdHJpbmc+PihiaW5kaW5n TmFtZS5nZXQoKS5zdHJpbmcoKSwgbWVtb2l6ZWRSZXN1bHQsIDApOwogICAgICAgICBKU1ZhbHVl IHJlc3VsdCA9IGpzU3RyaW5nV2l0aENhY2hlKGV4ZWMsIG1lbW9pemVkUmVzdWx0KTsKICAgICAg ICAgcmV0dXJuIEpTVmFsdWU6OmVuY29kZShyZXN1bHQpOwotICAgICB9CisgICAgfQogCi0gICAg IGlmIChjdXJzb3IuaXNSZXBsYXlpbmcoKSkgeworICAgIGlmIChjdXJzb3IuaXNSZXBsYXlpbmco KSkgewogICAgICAgICBTdHJpbmcgbWVtb2l6ZWRSZXN1bHQ7CiAgICAgICAgIE1lbW9pemVkRE9N UmVzdWx0QmFzZSogaW5wdXQgPSBjdXJzb3IuZmV0Y2hJbnB1dDxNZW1vaXplZERPTVJlc3VsdEJh c2U+KCk7CiAgICAgICAgIGlmIChpbnB1dCAmJiBpbnB1dC0+Y29udmVydFRvPFN0cmluZz4obWVt b2l6ZWRSZXN1bHQpKSB7CkBAIC0yNzMsOSArMjczLDkgQEAgRW5jb2RlZEpTVmFsdWUganNUZXN0 Tm9uZGV0ZXJtaW5pc3RpY05vbmRldGVybWluaXN0aWNHZXR0ZXJFeGNlcHRpb25BdHRyKEV4ZWNT dGEKICAgICAgICAgSlNWYWx1ZSByZXN1bHQgPSBqc1N0cmluZ1dpdGhDYWNoZShleGVjLCBtZW1v aXplZFJlc3VsdCk7CiAgICAgICAgIHNldERPTUV4Y2VwdGlvbihleGVjLCBlYyk7CiAgICAgICAg IHJldHVybiBKU1ZhbHVlOjplbmNvZGUocmVzdWx0KTsKLSAgICAgfQorICAgIH0KIAotICAgICBp ZiAoY3Vyc29yLmlzUmVwbGF5aW5nKCkpIHsKKyAgICBpZiAoY3Vyc29yLmlzUmVwbGF5aW5nKCkp IHsKICAgICAgICAgU3RyaW5nIG1lbW9pemVkUmVzdWx0OwogICAgICAgICBNZW1vaXplZERPTVJl c3VsdEJhc2UqIGlucHV0ID0gY3Vyc29yLmZldGNoSW5wdXQ8TWVtb2l6ZWRET01SZXN1bHRCYXNl PigpOwogICAgICAgICBpZiAoaW5wdXQgJiYgaW5wdXQtPmNvbnZlcnRUbzxTdHJpbmc+KG1lbW9p emVkUmVzdWx0KSkgewpAQCAtMzA5LDkgKzMwOSw5IEBAIEVuY29kZWRKU1ZhbHVlIGpzVGVzdE5v bmRldGVybWluaXN0aWNOb25kZXRlcm1pbmlzdGljU2V0dGVyRXhjZXB0aW9uQXR0cihFeGVjU3Rh CiAgICAgICAgIGN1cnNvci5hcHBlbmRJbnB1dDxNZW1vaXplZERPTVJlc3VsdDxTdHJpbmc+Pihi aW5kaW5nTmFtZS5nZXQoKS5zdHJpbmcoKSwgbWVtb2l6ZWRSZXN1bHQsIDApOwogICAgICAgICBK U1ZhbHVlIHJlc3VsdCA9IGpzU3RyaW5nV2l0aENhY2hlKGV4ZWMsIG1lbW9pemVkUmVzdWx0KTsK ICAgICAgICAgcmV0dXJuIEpTVmFsdWU6OmVuY29kZShyZXN1bHQpOwotICAgICB9CisgICAgfQog Ci0gICAgIGlmIChjdXJzb3IuaXNSZXBsYXlpbmcoKSkgeworICAgIGlmIChjdXJzb3IuaXNSZXBs YXlpbmcoKSkgewogICAgICAgICBTdHJpbmcgbWVtb2l6ZWRSZXN1bHQ7CiAgICAgICAgIE1lbW9p emVkRE9NUmVzdWx0QmFzZSogaW5wdXQgPSBjdXJzb3IuZmV0Y2hJbnB1dDxNZW1vaXplZERPTVJl c3VsdEJhc2U+KCk7CiAgICAgICAgIGlmIChpbnB1dCAmJiBpbnB1dC0+Y29udmVydFRvPFN0cmlu Zz4obWVtb2l6ZWRSZXN1bHQpKSB7Cg==