131608 2014-04-14 01:02:47 -0700 [sh4] SubImmediates can be used in sh4 LLINT 2014-04-14 14:48:31 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jbriance webkit-unassigned ggaren mark.lam msaboff oliver oldest_to_newest 1000430 0 jbriance 2014-04-14 01:02:47 -0700 SubImmediates can be used with sh4 const pool, so the sh4 arch can share the arm path for setEntryAddress. This will reduce architecture specific code and lead to a more optimal implementation for sh4. 1000436 1 229272 jbriance 2014-04-14 01:19:02 -0700 Created attachment 229272 Allow use of SubImmediates in sh4 const pool in LLINT. 1000592 2 229272 mark.lam 2014-04-14 13:54:16 -0700 Comment on attachment 229272 Allow use of SubImmediates in sh4 const pool in LLINT. View in context: https://bugs.webkit.org/attachment.cgi?id=229272&action=review r=me > Source/JavaScriptCore/llint/LowLevelInterpreter.asm:747 > + if SH4 > + flushcp # Force constant pool flush to avoid "pcrel too far" link error. > + end I'd be concerned if this proliferates. Ideally, it's be great if the offline backend knows to call flushcp automatically when needed without the LLINT assembly having to explicitly call it like this. For now, since there's is only this one use of flushcp (i.e. here), I'll let it go. 1000605 3 jbriance 2014-04-14 14:48:31 -0700 Committed r167269: <http://trac.webkit.org/changeset/167269> 229272 2014-04-14 01:19:02 -0700 2014-04-14 13:54:16 -0700 Allow use of SubImmediates in sh4 const pool in LLINT. bug-131608.patch text/plain 3476 jbriance SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTY3MjE1KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBA CisyMDE0LTA0LTE0ICBKdWxpZW4gQnJpYW5jZWF1ICA8amJyaWFuY2VAY2lzY28uY29tPgorCisg ICAgICAgIFtzaDRdIEFsbG93IHVzZSBvZiBTdWJJbW1lZGlhdGVzIGluIExMSU5ULgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMxNjA4CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWxsb3cgdXNlIG9mIFN1 YkltbWVkaWF0ZXMgd2l0aCBjb25zdCBwb29sIHNvIHRoZSBzaDQgYXJjaGl0ZWN0dXJlIGNhbgor ICAgICAgICBzaGFyZSB0aGUgYXJtIHBhdGggZm9yIHNldEVudHJ5QWRkcmVzcyBtYWNyby4gSXQg cmVkdWNlcyBhcmNoaXRlY3R1cmUKKyAgICAgICAgc3BlY2lmaWMgY29kZSBhbmQgbGVhZCB0byBh IG1vcmUgb3B0aW1hbCBnZW5lcmF0ZWQgY29kZSBmb3Igc2g0LgorCisgICAgICAgICogbGxpbnQv TG93TGV2ZWxJbnRlcnByZXRlci5hc206CisgICAgICAgICogb2ZmbGluZWFzbS9zaDQucmI6CisK IDIwMTQtMDQtMDggIE9saXZlciBIdW50ICA8b2xpdmVyQGFwcGxlLmNvbT4KIAogICAgICAgICBS ZXdyaXRlIEZ1bmN0aW9uLmJpbmQgYXMgYSBidWlsdGluCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlw dENvcmUvbGxpbnQvTG93TGV2ZWxJbnRlcnByZXRlci5hc20KPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L0phdmFTY3JpcHRDb3JlL2xsaW50L0xvd0xldmVsSW50ZXJwcmV0ZXIuYXNtCShyZXZpc2lvbiAx NjcyMTEpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvbGxpbnQvTG93TGV2ZWxJbnRlcnByZXRl ci5hc20JKHdvcmtpbmcgY29weSkKQEAgLTczNywyMCArNzM3LDE2IEBAIG1hY3JvIHNldEVudHJ5 QWRkcmVzcyhpbmRleCwgbGFiZWwpCiAgICAgICAgIHBjcnRvYWRkciBsYWJlbCwgdDEKICAgICAg ICAgbW92ZSBpbmRleCwgdDIKICAgICAgICAgc3RvcmVwIHQxLCBbYTAsIHQyLCA4XQotICAgIGVs c2lmIEFSTSBvciBBUk12NyBvciBBUk12N19UUkFESVRJT05BTAorICAgIGVsc2lmIEFSTSBvciBB Uk12NyBvciBBUk12N19UUkFESVRJT05BTCBvciBTSDQKICAgICAgICAgbW92ZSAobGFiZWwgLSBf cmVsYXRpdmVQQ0Jhc2UpLCB0MgogICAgICAgICBhZGRwIHQyLCB0MSwgdDIKICAgICAgICAgbW92 ZSBpbmRleCwgdDMKICAgICAgICAgc3RvcmVwIHQyLCBbYTAsIHQzLCA0XQorICAgICAgICBpZiBT SDQKKyAgICAgICAgICAgIGZsdXNoY3AgIyBGb3JjZSBjb25zdGFudCBwb29sIGZsdXNoIHRvIGF2 b2lkICJwY3JlbCB0b28gZmFyIiBsaW5rIGVycm9yLgorICAgICAgICBlbmQKICAgICBlbHNpZiBN SVBTCiAgICAgICAgIGNyYXNoKCkgICMgTmVlZCB0byByZXBsYWNlIHdpdGggY29kZSB0byB0dXJu IGxhYmVsIGludG8gYW5kIGFic29sdXRlIGFkZHJlc3MgYW5kIHNhdmUgYXQgaW5kZXgKLSAgICBl bHNpZiBTSDQKLSAgICAgICAgbW92ZSBsYWJlbCwgdDIKLSAgICAgICAgc3VicCBfcmVsYXRpdmVQ Q0Jhc2UsIHQyCi0gICAgICAgIGFkZHAgdDEsIHQyCi0gICAgICAgIG1vdmUgaW5kZXgsIHQzCi0g ICAgICAgIHN0b3JlcCB0MiwgW2EwLCB0MywgNF0KLSAgICAgICAgZmx1c2hjcCAjIEZvcmNlIGNv bnN0YW50IHBvb2wgZmx1c2ggdG8gYXZvaWQgInBjcmVsIHRvbyBmYXIiIGxpbmsgZXJyb3IuCiAg ICAgZW5kCiBlbmQKIApJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL29mZmxpbmVhc20vc2g0 LnJiCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9vZmZsaW5lYXNtL3NoNC5y YgkocmV2aXNpb24gMTY3MjExKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL29mZmxpbmVhc20v c2g0LnJiCSh3b3JraW5nIGNvcHkpCkBAIC0xNTYsNiArMTU2LDEyIEBAIGNsYXNzIExhYmVsUmVm ZXJlbmNlCiAgICAgZW5kCiBlbmQKIAorY2xhc3MgU3ViSW1tZWRpYXRlcyA8IE5vZGUKKyAgICBk ZWYgc2g0T3BlcmFuZAorICAgICAgICAiI3tAbGVmdC5zaDRPcGVyYW5kfSAtICN7QHJpZ2h0LnNo NE9wZXJhbmR9IgorICAgIGVuZAorZW5kCisKIGNsYXNzIENvbnN0UG9vbCA8IE5vZGUKICAgICBh dHRyX3JlYWRlciA6c2l6ZQogICAgIGF0dHJfcmVhZGVyIDplbnRyaWVzCkBAIC02MTAsNiArNjE2 LDEwIEBAIGRlZiBzaDRMb3dlckNvbnN0UG9vbChsaXN0KQogICAgICAgICAgICAgICAgICAgICAg ICAgY3VycmVudFBvb2wzMiA8PCBwb29sRW50cnkKICAgICAgICAgICAgICAgICAgICAgZW5kCiAg ICAgICAgICAgICAgICAgICAgIG5ld0xpc3QgPDwgSW5zdHJ1Y3Rpb24ubmV3KGNvZGVPcmlnaW4s ICJtb3ZlIiwgW3Bvb2xFbnRyeSwgbm9kZS5vcGVyYW5kc1sxXV0pCisgICAgICAgICAgICAgICAg ZWxzaWYgbm9kZS5vcGVyYW5kc1swXS5pc19hPyBTdWJJbW1lZGlhdGVzCisgICAgICAgICAgICAg ICAgICAgIHBvb2xFbnRyeSA9IENvbnN0UG9vbEVudHJ5Lm5ldyhjb2RlT3JpZ2luLCBub2RlLm9w ZXJhbmRzWzBdLnNoNE9wZXJhbmQsIDMyKQorICAgICAgICAgICAgICAgICAgICBjdXJyZW50UG9v bDMyIDw8IHBvb2xFbnRyeQorICAgICAgICAgICAgICAgICAgICBuZXdMaXN0IDw8IEluc3RydWN0 aW9uLm5ldyhjb2RlT3JpZ2luLCAibW92ZSIsIFtwb29sRW50cnksIG5vZGUub3BlcmFuZHNbMV1d KQogICAgICAgICAgICAgICAgIGVsc2UKICAgICAgICAgICAgICAgICAgICAgbmV3TGlzdCA8PCBu b2RlCiAgICAgICAgICAgICAgICAgZW5kCkBAIC0xMDI5LDcgKzEwMzksNyBAQCBjbGFzcyBJbnN0 cnVjdGlvbgogICAgICAgICB3aGVuICJsb2FkaSIsICJsb2FkaXMiLCAibG9hZHAiLCAic3RvcmVp IiwgInN0b3JlcCIKICAgICAgICAgICAgICRhc20ucHV0cyAibW92LmwgI3tzaDRPcGVyYW5kcyhv cGVyYW5kcyl9IgogICAgICAgICB3aGVuICJhbGlnbmZvcm1vdmEiCi0gICAgICAgICAgICAkYXNt LnB1dHMgIi5iYWxpZ24gNCIKKyAgICAgICAgICAgICRhc20ucHV0cyAiLmJhbGlnbiA0IiAjIEFz IGJhbGlnbiBkaXJlY3RpdmUgaXMgaW4gYSBjb2RlIHNlY3Rpb24sIGZpbGwgdmFsdWUgaXMgJ25v cCcgaW5zdHJ1Y3Rpb24uCiAgICAgICAgIHdoZW4gIm1vdmEiCiAgICAgICAgICAgICAkYXNtLnB1 dHMgIm1vdmEgI3tzaDRPcGVyYW5kcyhvcGVyYW5kcyl9IgogICAgICAgICB3aGVuICJtb3ZlIgo=