131605 2014-04-13 22:59:23 -0700 [JSC] Improve the call site of string comparison in some hot path 2014-04-14 01:47:01 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 benjamin benjamin cmarcelo commit-queue esprehn+autocc kangil.han kling oldest_to_newest 1000391 0 benjamin 2014-04-13 22:59:23 -0700 [JSC] Improve the call site of string comparison in some hot path 1000392 1 229262 benjamin 2014-04-13 23:05:08 -0700 Created attachment 229262 Patch 1000446 2 229262 commit-queue 2014-04-14 01:46:57 -0700 Comment on attachment 229262 Patch Clearing flags on attachment: 229262 Committed r167220: <http://trac.webkit.org/changeset/167220> 1000447 3 commit-queue 2014-04-14 01:47:01 -0700 All reviewed patches have been landed. Closing bug. 229262 2014-04-13 23:05:08 -0700 2014-04-14 01:46:57 -0700 Patch bug-131605-20140413230447.patch text/plain 6906 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTY3MTgyCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAz YTc4ZWVmMWRhNjhmOWY3ZTNkYTExNDc5Y2FkZWEwNzBmMmVjMGY1Li40ZWQ5YTgwNWYxZGY4NWUy ZGJkM2NlM2JlZjJjYzFhMjdmZWQyMWY2IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMiBAQAorMjAxNC0wNC0xMyAgQmVuamFtaW4gUG91bGFpbiAgPGJlbmphbWluQHdlYmtp dC5vcmc+CisKKyAgICAgICAgW0pTQ10gSW1wcm92ZSB0aGUgY2FsbCBzaXRlIG9mIHN0cmluZyBj b21wYXJpc29uIGluIHNvbWUgaG90IHBhdGgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTEzMTYwNQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFdoZW4gcmVzb2x2ZWQsIHRoZSBTdHJpbmcgb2YgYSBKU1N0cmlu ZyBpcyBuZXZlciBudWxsLiBJdCBjYW4gYmUgZW1wdHkgYnV0IG5vdCBudWxsLgorICAgICAgICBU aGUgbnVsbCB2YWx1ZSBpcyByZXNlcnZlZCBmb3Igcm9wZXMgYnV0IHRob3NlIHdvdWxkIGJlIHJl c29sdmVkIHdoZW4gZ2V0dGluZyB0aGUgdmFsdWUuCisKKyAgICAgICAgQ29uc2VxdWVudGx5LCB3 ZSBzaG91bGQgdXNlIHRoZSBlcXVhbCgpIG9wZXJhdGlvbiB0aGF0IGRvIG5vdCBoYW5kbGUgbnVs bCB2YWx1ZXMuCisgICAgICAgIFVzaW5nIHRoZSBTdHJpbmdJbXBsIGRpcmVjdGx5IGlzIGFscmVh ZHkgY29tbW9uIGluIFN0cmluZ1Byb3RvdHlwZSBidXQgaXQgd2FzIG5vdCB1c2VkIGhlcmUgZm9y IHNvbWUgcmVhc29uLgorCisgICAgICAgICogaml0L0pJVE9wZXJhdGlvbnMuY3BwOgorICAgICAg ICAqIHJ1bnRpbWUvSlNDSlNWYWx1ZUlubGluZXMuaDoKKyAgICAgICAgKEpTQzo6SlNWYWx1ZTo6 ZXF1YWxTbG93Q2FzZUlubGluZSk6CisgICAgICAgIChKU0M6OkpTVmFsdWU6OnN0cmljdEVxdWFs U2xvd0Nhc2VJbmxpbmUpOgorICAgICAgICAoSlNDOjpKU1ZhbHVlOjpwdXJlU3RyaWN0RXF1YWwp OgorCiAyMDE0LTA0LTExICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CiAKICAgICAg ICAgREZHOjpGaXh1cFBoYXNlIHNob3VsZCBpbnNlcnQgY29udmVyc2lvbiBub2RlcyBhZnRlciB0 aGUgcmVzdCBvZiBmaXh1cCBzbyB0aGF0IHdlIGtub3cgaG93IHRoZSB0eXBlcyBzZXR0bGVkCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5nZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmlu ZGV4IDM2ZWQ4YjhiZDhlNzhjYzE0ZGY4NjU0OTM3Y2UxYjgyNjMwYjExYzQuLmZmOWU0Yjg3M2Rk ZTcyNGEyOTI5MjkyMjExMDQyMjlmMzFlYjU2OTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTQt MDQtMTMgIEJlbmphbWluIFBvdWxhaW4gIDxiZW5qYW1pbkB3ZWJraXQub3JnPgorCisgICAgICAg IFtKU0NdIEltcHJvdmUgdGhlIGNhbGwgc2l0ZSBvZiBzdHJpbmcgY29tcGFyaXNvbiBpbiBzb21l IGhvdCBwYXRoCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMzE2MDUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIHd0Zi90ZXh0L1N0cmluZ0ltcGwuY3BwOgorICAgICAgICAoV1RGOjpzdHJpbmdJbXBsQ29u dGVudEVxdWFsKToKKyAgICAgICAgSW5saW5lIHRoYXQgZnVuY3Rpb24gdG8gcmVkdWNlIHRoZSBj YWxsIG92ZXJoZWFkIGZvciBKU0MuCisgICAgICAgIFRoaXMgaXMgb25seSBpbmxpbmVkIHR3aWNl LCBpdCBpcyBub3QgY2F0YXN0cm9waGljIGZvciBvdXIgYmluYXJ5LgorCiAyMDE0LTA0LTEwICBC cmVudCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgogCiAgICAgICAgIFtXaW5dIENsZWFu IHVwIHNvbWUgNjQtYml0IHdhcm5pbmdzIGZyb20gVmlzdWFsIFN0dWRpbyBhbmFseXplcgpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCmluZGV4IGJlNGE5NGM0YzU2ZWM3ZGQwMTM3MDNhM2IwNjcwNDQ1NzA4MjkyOTIuLjQ4ZGZh M2NlMjM0Y2EwN2ZiYTdmNmE0YmM5MWVjMzdhMjA4YWQ5NjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsNSAr MSwxNiBAQAogMjAxNC0wNC0xMyAgQmVuamFtaW4gUG91bGFpbiAgPGJlbmphbWluQHdlYmtpdC5v cmc+CiAKKyAgICAgICAgW0pTQ10gSW1wcm92ZSB0aGUgY2FsbCBzaXRlIG9mIHN0cmluZyBjb21w YXJpc29uIGluIHNvbWUgaG90IHBhdGgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTEzMTYwNQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogZG9tL05vZGVSYXJlRGF0YS5oOgorICAgICAgICAoV2ViQ29yZTo6 Tm9kZUxpc3RzTm9kZURhdGE6Ok5vZGVMaXN0Q2FjaGVNYXBFbnRyeUhhc2g6OmVxdWFsKToKKyAg ICAgICAgV2Ugc2hvdWxkIHVzZSB0aGUgcmlnaHQgY29tcGFyaXNvbiBvcGVyYXRpb24gZGVwZW5k aW5nIG9uIHRoZSBIYXNoIFRyYWl0cy4KKworMjAxNC0wNC0xMyAgQmVuamFtaW4gUG91bGFpbiAg PGJlbmphbWluQHdlYmtpdC5vcmc+CisKICAgICAgICAgQ1NTIEpJVDogY29tcGlsZSB0aGUgOm50 aC1jaGlsZCgpIHBzZXVkbyBjbGFzcwogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTMxNjAyCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9qaXQvSklUT3BlcmF0aW9ucy5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVE9w ZXJhdGlvbnMuY3BwCmluZGV4IDUyYmFhOGI3ODFhZmM1ZjljODFjZDY3ZDE4YWVjMGU1ODllZDg0 ODUuLjhiMjA1ZjY2NGQ2YmExYzlhYzZmNWE1OTg0YmMwNjNkMjNhYTkxMDAgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklUT3BlcmF0aW9ucy5jcHAKKysrIGIvU291cmNl L0phdmFTY3JpcHRDb3JlL2ppdC9KSVRPcGVyYXRpb25zLmNwcApAQCAtOTEyLDcgKzkxMiw3IEBA IHNpemVfdCBKSVRfT1BFUkFUSU9OIG9wZXJhdGlvbkNvbXBhcmVTdHJpbmdFcShFeGVjU3RhdGUq IGV4ZWMsIEpTQ2VsbCogbGVmdCwgSlNDCiAgICAgVk0qIHZtID0gJmV4ZWMtPnZtKCk7CiAgICAg TmF0aXZlQ2FsbEZyYW1lVHJhY2VyIHRyYWNlcih2bSwgZXhlYyk7CiAKLSAgICBib29sIHJlc3Vs dCA9IGFzU3RyaW5nKGxlZnQpLT52YWx1ZShleGVjKSA9PSBhc1N0cmluZyhyaWdodCktPnZhbHVl KGV4ZWMpOworICAgIGJvb2wgcmVzdWx0ID0gV1RGOjplcXVhbCgqYXNTdHJpbmcobGVmdCktPnZh bHVlKGV4ZWMpLmltcGwoKSwgKmFzU3RyaW5nKHJpZ2h0KS0+dmFsdWUoZXhlYykuaW1wbCgpKTsK ICNpZiBVU0UoSlNWQUxVRTY0KQogICAgIHJldHVybiBKU1ZhbHVlOjplbmNvZGUoanNCb29sZWFu KHJlc3VsdCkpOwogI2Vsc2UKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50 aW1lL0pTQ0pTVmFsdWVJbmxpbmVzLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9K U0NKU1ZhbHVlSW5saW5lcy5oCmluZGV4IDI2YjRlMTVjYjMyODNmOGQ2YjI0Y2JiZjQ0MDU2ZGNi MDc5ODFkZDUuLjZhMTM3ZjhhODdhZDk1OTJiY2Q1NGFiMTY0YWEwOTcyY2YxZTRiZmUgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTQ0pTVmFsdWVJbmxpbmVzLmgK KysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNDSlNWYWx1ZUlubGluZXMuaApA QCAtMzAsNiArMzAsNyBAQAogI2luY2x1ZGUgIkpTQ0pTVmFsdWUuaCIKICNpbmNsdWRlICJKU0Nl bGxJbmxpbmVzLmgiCiAjaW5jbHVkZSAiSlNGdW5jdGlvbi5oIgorI2luY2x1ZGUgPHd0Zi90ZXh0 L1N0cmluZ0ltcGwuaD4KIAogbmFtZXNwYWNlIEpTQyB7CiAKQEAgLTczOCw3ICs3MzksNyBAQCBB TFdBWVNfSU5MSU5FIGJvb2wgSlNWYWx1ZTo6ZXF1YWxTbG93Q2FzZUlubGluZShFeGVjU3RhdGUq IGV4ZWMsIEpTVmFsdWUgdjEsIEpTVgogICAgICAgICBib29sIHMxID0gdjEuaXNTdHJpbmcoKTsK ICAgICAgICAgYm9vbCBzMiA9IHYyLmlzU3RyaW5nKCk7CiAgICAgICAgIGlmIChzMSAmJiBzMikK LSAgICAgICAgICAgIHJldHVybiBhc1N0cmluZyh2MSktPnZhbHVlKGV4ZWMpID09IGFzU3RyaW5n KHYyKS0+dmFsdWUoZXhlYyk7CisgICAgICAgICAgICByZXR1cm4gV1RGOjplcXVhbCgqYXNTdHJp bmcodjEpLT52YWx1ZShleGVjKS5pbXBsKCksICphc1N0cmluZyh2MiktPnZhbHVlKGV4ZWMpLmlt cGwoKSk7CiAKICAgICAgICAgaWYgKHYxLmlzVW5kZWZpbmVkT3JOdWxsKCkpIHsKICAgICAgICAg ICAgIGlmICh2Mi5pc1VuZGVmaW5lZE9yTnVsbCgpKQpAQCAtODAwLDcgKzgwMSw3IEBAIEFMV0FZ U19JTkxJTkUgYm9vbCBKU1ZhbHVlOjpzdHJpY3RFcXVhbFNsb3dDYXNlSW5saW5lKEV4ZWNTdGF0 ZSogZXhlYywgSlNWYWx1ZSB2CiAgICAgQVNTRVJUKHYxLmlzQ2VsbCgpICYmIHYyLmlzQ2VsbCgp KTsKIAogICAgIGlmICh2MS5hc0NlbGwoKS0+aXNTdHJpbmcoKSAmJiB2Mi5hc0NlbGwoKS0+aXNT dHJpbmcoKSkKLSAgICAgICAgcmV0dXJuIGFzU3RyaW5nKHYxKS0+dmFsdWUoZXhlYykgPT0gYXNT dHJpbmcodjIpLT52YWx1ZShleGVjKTsKKyAgICAgICAgcmV0dXJuIFdURjo6ZXF1YWwoKmFzU3Ry aW5nKHYxKS0+dmFsdWUoZXhlYykuaW1wbCgpLCAqYXNTdHJpbmcodjIpLT52YWx1ZShleGVjKS5p bXBsKCkpOwogCiAgICAgcmV0dXJuIHYxID09IHYyOwogfQpAQCAtODM1LDcgKzgzNiw3IEBAIGlu bGluZSBUcmlTdGF0ZSBKU1ZhbHVlOjpwdXJlU3RyaWN0RXF1YWwoSlNWYWx1ZSB2MSwgSlNWYWx1 ZSB2MikKICAgICAgICAgY29uc3QgU3RyaW5nSW1wbCogdjJTdHJpbmcgPSBhc1N0cmluZyh2Mikt PnRyeUdldFZhbHVlSW1wbCgpOwogICAgICAgICBpZiAoIXYxU3RyaW5nIHx8ICF2MlN0cmluZykK ICAgICAgICAgICAgIHJldHVybiBNaXhlZFRyaVN0YXRlOwotICAgICAgICByZXR1cm4gdHJpU3Rh dGUoV1RGOjplcXVhbCh2MVN0cmluZywgdjJTdHJpbmcpKTsKKyAgICAgICAgcmV0dXJuIHRyaVN0 YXRlKFdURjo6ZXF1YWwoKnYxU3RyaW5nLCAqdjJTdHJpbmcpKTsKICAgICB9CiAgICAgCiAgICAg cmV0dXJuIHRyaVN0YXRlKHYxID09IHYyKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL3Rl eHQvU3RyaW5nSW1wbC5jcHAgYi9Tb3VyY2UvV1RGL3d0Zi90ZXh0L1N0cmluZ0ltcGwuY3BwCmlu ZGV4IDg0OGNjZjY3OWM3MDhkZGVkM2RhZDhkNjdiMTRlNjMzMzhlZTEyNzQuLmM2ODQ3MTA5ZTQ2 Zjk4MzQ2Njk5MWU4NzJjZWQxMWIyOGQ4ZDM4ZmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3Rm L3RleHQvU3RyaW5nSW1wbC5jcHAKKysrIGIvU291cmNlL1dURi93dGYvdGV4dC9TdHJpbmdJbXBs LmNwcApAQCAtMTc2NCw3ICsxNzY0LDcgQEAgUGFzc1JlZjxTdHJpbmdJbXBsPiBTdHJpbmdJbXBs OjpyZXBsYWNlKFN0cmluZ0ltcGwqIHBhdHRlcm4sIFN0cmluZ0ltcGwqIHJlcGxhY2UKICAgICBy ZXR1cm4gbmV3SW1wbDsKIH0KIAotc3RhdGljIGlubGluZSBib29sIHN0cmluZ0ltcGxDb250ZW50 RXF1YWwoY29uc3QgU3RyaW5nSW1wbCYgYSwgY29uc3QgU3RyaW5nSW1wbCYgYikKK3N0YXRpYyBB TFdBWVNfSU5MSU5FIGJvb2wgc3RyaW5nSW1wbENvbnRlbnRFcXVhbChjb25zdCBTdHJpbmdJbXBs JiBhLCBjb25zdCBTdHJpbmdJbXBsJiBiKQogewogICAgIHVuc2lnbmVkIGFMZW5ndGggPSBhLmxl bmd0aCgpOwogICAgIHVuc2lnbmVkIGJMZW5ndGggPSBiLmxlbmd0aCgpOwpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvZG9tL05vZGVSYXJlRGF0YS5oIGIvU291cmNlL1dlYkNvcmUvZG9tL05v ZGVSYXJlRGF0YS5oCmluZGV4IGU1YjcwNjIzZWExNDUzYzFmZDJiYjdlMGZkY2NmYjFmZWYzMDBk NGQuLjk5MjQ1ZDZjYWMzZmYxNTgyYmMzZGVkYmMyOGQyZjYxNGE1ZWYwMGMgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL2RvbS9Ob2RlUmFyZURhdGEuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9k b20vTm9kZVJhcmVEYXRhLmgKQEAgLTEwOCw3ICsxMDgsNyBAQCBwdWJsaWM6CiAgICAgICAgIHsK ICAgICAgICAgICAgIHJldHVybiBEZWZhdWx0SGFzaDxTdHJpbmdUeXBlPjo6SGFzaDo6aGFzaChl bnRyeS5zZWNvbmQpICsgZW50cnkuZmlyc3Q7CiAgICAgICAgIH0KLSAgICAgICAgc3RhdGljIGJv b2wgZXF1YWwoY29uc3Qgc3RkOjpwYWlyPHVuc2lnbmVkIGNoYXIsIFN0cmluZ1R5cGU+JiBhLCBj b25zdCBzdGQ6OnBhaXI8dW5zaWduZWQgY2hhciwgU3RyaW5nVHlwZT4mIGIpIHsgcmV0dXJuIGEg PT0gYjsgfQorICAgICAgICBzdGF0aWMgYm9vbCBlcXVhbChjb25zdCBzdGQ6OnBhaXI8dW5zaWdu ZWQgY2hhciwgU3RyaW5nVHlwZT4mIGEsIGNvbnN0IHN0ZDo6cGFpcjx1bnNpZ25lZCBjaGFyLCBT dHJpbmdUeXBlPiYgYikgeyByZXR1cm4gYS5maXJzdCA9PSBiLmZpcnN0ICYmIERlZmF1bHRIYXNo PFN0cmluZ1R5cGU+OjpIYXNoOjplcXVhbChhLnNlY29uZCwgYi5zZWNvbmQpOyB9CiAgICAgICAg IHN0YXRpYyBjb25zdCBib29sIHNhZmVUb0NvbXBhcmVUb0VtcHR5T3JEZWxldGVkID0gRGVmYXVs dEhhc2g8U3RyaW5nVHlwZT46Okhhc2g6OnNhZmVUb0NvbXBhcmVUb0VtcHR5T3JEZWxldGVkOwog ICAgIH07CiAK