131563 2014-04-11 14:51:35 -0700 [iOS WebKit2] Expose a simplified zoom-to-rect to the WebProcess 2017-03-07 23:34:28 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 131510 1 thorton thorton adele commit-queue sam simon.fraser oldest_to_newest 1000043 0 thorton 2014-04-11 14:51:35 -0700 Add a simple message that calls WKContentView's zoom-to-rect code given just a rect and min/max scale. 1000045 1 229163 thorton 2014-04-11 14:53:00 -0700 Created attachment 229163 patch 1000047 2 commit-queue 2014-04-11 14:54:51 -0700 Attachment 229163 did not pass style-queue: ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:610: The parameter name "rect" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit2/UIProcess/PageClient.h:252: The parameter name "rect" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit2/UIProcess/ios/PageClientImplIOS.h:125: The parameter name "rect" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 3 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style. 1000048 3 thorton 2014-04-11 14:55:53 -0700 http://trac.webkit.org/changeset/167154 1000049 4 thorton 2014-04-11 14:57:31 -0700 And http://trac.webkit.org/changeset/167155 for the stylebot. 1284781 5 thorton 2017-03-07 23:34:28 -0800 Why did I do this? Nothing calls it? 229163 2014-04-11 14:53:00 -0700 2014-04-11 14:54:25 -0700 patch zoom.diff text/plain 6719 thorton ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA3NWQwOWQzLi5lNzI4NGRlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjYg QEAKIDIwMTQtMDQtMTEgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CiAK KyAgICAgICAgW2lPUyBXZWJLaXQyXSBFeHBvc2UgYSBzaW1wbGlmaWVkIHpvb20tdG8tcmVjdCB0 byB0aGUgV2ViUHJvY2VzcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTMxNTYzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBVSVByb2Nlc3MvUGFnZUNsaWVudC5oOgorICAgICAgICAqIFVJUHJvY2Vzcy9X ZWJQYWdlUHJveHkuaDoKKyAgICAgICAgKiBVSVByb2Nlc3MvV2ViUGFnZVByb3h5Lm1lc3NhZ2Vz LmluOgorICAgICAgICAqIFVJUHJvY2Vzcy9pb3MvUGFnZUNsaWVudEltcGxJT1MuaDoKKyAgICAg ICAgKiBVSVByb2Nlc3MvaW9zL1BhZ2VDbGllbnRJbXBsSU9TLm1tOgorICAgICAgICAoV2ViS2l0 OjpQYWdlQ2xpZW50SW1wbDo6em9vbVRvUmVjdCk6CisgICAgICAgICogVUlQcm9jZXNzL2lvcy9X ZWJQYWdlUHJveHlJT1MubW06CisgICAgICAgIChXZWJLaXQ6OldlYlBhZ2VQcm94eTo6em9vbVRv UmVjdCk6CisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuaDoKKyAgICAgICAg KiBXZWJQcm9jZXNzL1dlYlBhZ2UvaW9zL1dlYlBhZ2VJT1MubW06CisgICAgICAgIChXZWJLaXQ6 OldlYlBhZ2U6Onpvb21Ub1JlY3QpOgorICAgICAgICBBZGQgYSBzaW1wbGUgbWVzc2FnZSB0aGF0 IGNhbGxzIFdLQ29udGVudFZpZXcncyB6b29tLXRvLXJlY3QgY29kZSBnaXZlbiBqdXN0IGEgcmVj dCBhbmQgbWluL21heCBzY2FsZS4KKyAgICAgICAgV2Ugd2lsbCB1c2UgdGhlIGNlbnRlciBvZiB0 aGUgcmVjdCBhcyB0aGUgem9vbSBvcmlnaW4sIGFuZCB3aWxsIHRyeSB0byBzaG93IHRoZSB3aG9s ZSByZWN0LgorCisyMDE0LTA0LTExICBUaW0gSG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUu Y29tPgorCiAgICAgICAgIFN1cHBvcnQgZG9jdW1lbnQtcmVsYXRpdmUgYW5kIGN1c3RvbS1mcmFt ZSBwYWdlIG92ZXJsYXlzCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xMzE1NjAKICAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzE2NTk1NTU2PgpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1BhZ2VDbGllbnQuaCBiL1NvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9QYWdlQ2xpZW50LmgKaW5kZXggZjg5NGQ2NS4uNWIwYzRiYyAxMDA2NDQK LS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1BhZ2VDbGllbnQuaAorKysgYi9Tb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvUGFnZUNsaWVudC5oCkBAIC0yNDksNiArMjQ5LDcgQEAgcHVibGlj OgogICAgIHZpcnR1YWwgdm9pZCBzYXZlSW1hZ2VUb0xpYnJhcnkoUGFzc1JlZlB0cjxXZWJDb3Jl OjpTaGFyZWRCdWZmZXI+KSA9IDA7CiAgICAgdmlydHVhbCB2b2lkIGRpZFVwZGF0ZUJsb2NrU2Vs ZWN0aW9uV2l0aFRvdWNoKHVpbnQzMl90IHRvdWNoLCB1aW50MzJfdCBmbGFncywgZmxvYXQgZ3Jv d1RocmVzaG9sZCwgZmxvYXQgc2hyaW5rVGhyZXNob2xkKSA9IDA7CiAgICAgdmlydHVhbCB2b2lk IHNob3dQbGF5YmFja1RhcmdldFBpY2tlcihib29sIGhhc1ZpZGVvLCBjb25zdCBXZWJDb3JlOjpJ bnRSZWN0JiBlbGVtZW50UmVjdCkgPSAwOworICAgIHZpcnR1YWwgdm9pZCB6b29tVG9SZWN0KFdl YkNvcmU6OkZsb2F0UmVjdCByZWN0LCBkb3VibGUgbWluaW11bVNjYWxlLCBkb3VibGUgbWF4aW11 bVNjYWxlKSA9IDA7CiAKICNpZiBFTkFCTEUoSU5TUEVDVE9SKQogICAgIHZpcnR1YWwgdm9pZCBz aG93SW5zcGVjdG9ySW5kaWNhdGlvbigpID0gMDsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuaCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQ YWdlUHJveHkuaAppbmRleCBkZjNiNWUwLi43OWEyYzZhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmgKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL1dlYlBhZ2VQcm94eS5oCkBAIC02MDcsNiArNjA3LDcgQEAgcHVibGljOgogICAgIHZvaWQg YXBwbGljYXRpb25XaWxsRW50ZXJGb3JlZ3JvdW5kKCk7CiAgICAgdm9pZCBhcHBsaWNhdGlvbldp bGxSZXNpZ25BY3RpdmUoKTsKICAgICB2b2lkIGFwcGxpY2F0aW9uRGlkQmVjb21lQWN0aXZlKCk7 CisgICAgdm9pZCB6b29tVG9SZWN0KFdlYkNvcmU6OkZsb2F0UmVjdCByZWN0LCBkb3VibGUgbWlu aW11bVNjYWxlLCBkb3VibGUgbWF4aW11bVNjYWxlKTsKICNlbmRpZgogCiAgICAgY29uc3QgRWRp dG9yU3RhdGUmIGVkaXRvclN0YXRlKCkgY29uc3QgeyByZXR1cm4gbV9lZGl0b3JTdGF0ZTsgfQpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5tZXNzYWdl cy5pbiBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkubWVzc2FnZXMuaW4K aW5kZXggMGQ3MTI0MS4uZDc4Mzc2NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL1dlYlBhZ2VQcm94eS5tZXNzYWdlcy5pbgorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvV2ViUGFnZVByb3h5Lm1lc3NhZ2VzLmluCkBAIC0xNjgsNiArMTY4LDcgQEAgbWVzc2FnZXMg LT4gV2ViUGFnZVByb3h5IHsKICAgICBTYXZlSW1hZ2VUb0xpYnJhcnkoV2ViS2l0OjpTaGFyZWRN ZW1vcnk6OkhhbmRsZSBoYW5kbGUsIHVpbnQ2NF90IHNpemUpCiAgICAgRGlkVXBkYXRlQmxvY2tT ZWxlY3Rpb25XaXRoVG91Y2godWludDMyX3QgdG91Y2gsIHVpbnQzMl90IGZsYWdzLCBmbG9hdCBn cm93VGhyZXNob2xkLCBmbG9hdCBzaHJpbmtUaHJlc2hvbGQpCiAgICAgU2hvd1BsYXliYWNrVGFy Z2V0UGlja2VyKGJvb2wgaGFzVmlkZW8sIFdlYkNvcmU6OkludFJlY3QgZWxlbWVudFJlY3QpCisg ICAgWm9vbVRvUmVjdChXZWJDb3JlOjpGbG9hdFJlY3QgcmVjdCwgZG91YmxlIG1pbmltdW1TY2Fs ZSwgZG91YmxlIG1heGltdW1TY2FsZSkKICNlbmRpZgogI2lmIFBMQVRGT1JNKEdUSykKICAgICBQ cmludEZpbmlzaGVkQ2FsbGJhY2soV2ViQ29yZTo6UmVzb3VyY2VFcnJvciBlcnJvciwgdWludDY0 X3QgY2FsbGJhY2tJRCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3Mv UGFnZUNsaWVudEltcGxJT1MuaCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3MvUGFnZUNs aWVudEltcGxJT1MuaAppbmRleCAwMDJmZGQ5Li4zNmI3YmU4IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvaW9zL1BhZ2VDbGllbnRJbXBsSU9TLmgKKysrIGIvU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL2lvcy9QYWdlQ2xpZW50SW1wbElPUy5oCkBAIC0xMjIsNiArMTIyLDgg QEAgcHJpdmF0ZToKICAgICB2aXJ0dWFsIHZvaWQgaGlkZUluc3BlY3RvckluZGljYXRpb24oKSBv dmVycmlkZTsKICNlbmRpZgogCisgICAgdmlydHVhbCB2b2lkIHpvb21Ub1JlY3QoV2ViQ29yZTo6 RmxvYXRSZWN0IHJlY3QsIGRvdWJsZSBtaW5pbXVtU2NhbGUsIGRvdWJsZSBtYXhpbXVtU2NhbGUp IG92ZXJyaWRlOworCiAgICAgLy8gQXV4aWxpYXJ5IENsaWVudCBDcmVhdGlvbgogI2lmIEVOQUJM RShGVUxMU0NSRUVOX0FQSSkKICAgICB2aXJ1YWwgV2ViRnVsbFNjcmVlbk1hbmFnZXJQcm94eUNs aWVudCYgZnVsbFNjcmVlbk1hbmFnZXJQcm94eUNsaWVudCgpIG92ZXJyaWRlOwpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2lvcy9QYWdlQ2xpZW50SW1wbElPUy5tbSBiL1Nv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3MvUGFnZUNsaWVudEltcGxJT1MubW0KaW5kZXggNWY3 Y2ZiMi4uYTQwODY2NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2lvcy9Q YWdlQ2xpZW50SW1wbElPUy5tbQorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvaW9zL1Bh Z2VDbGllbnRJbXBsSU9TLm1tCkBAIC00NTUsNiArNDU1LDExIEBAIHZvaWQgUGFnZUNsaWVudElt cGw6OmRpZEZpbmlzaExvYWRpbmdEYXRhRm9yQ3VzdG9tQ29udGVudFByb3ZpZGVyKGNvbnN0IFN0 cmluZyYKICAgICBbbV93ZWJWaWV3IF9kaWRGaW5pc2hMb2FkaW5nRGF0YUZvckN1c3RvbUNvbnRl bnRQcm92aWRlcldpdGhTdWdnZXN0ZWRGaWxlbmFtZTpzdWdnZXN0ZWRGaWxlbmFtZSBkYXRhOmRh dGEuZ2V0KCldOwogfQogCit2b2lkIFBhZ2VDbGllbnRJbXBsOjp6b29tVG9SZWN0KEZsb2F0UmVj dCByZWN0LCBkb3VibGUgbWluaW11bVNjYWxlLCBkb3VibGUgbWF4aW11bVNjYWxlKQoreworICAg IFttX2NvbnRlbnRWaWV3IF96b29tVG9SZWN0OnJlY3Qgd2l0aE9yaWdpbjpyZWN0LmNlbnRlcigp IGZpdEVudGlyZVJlY3Q6WUVTIG1pbmltdW1TY2FsZTptaW5pbXVtU2NhbGUgbWF4aW11bVNjYWxl Om1heGltdW1TY2FsZSBtaW5pbXVtU2Nyb2xsRGlzdGFuY2U6MF07Cit9CisKIH0gLy8gbmFtZXNw YWNlIFdlYktpdAogCiAjZW5kaWYgLy8gUExBVEZPUk0oSU9TKQpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL2lvcy9XZWJQYWdlUHJveHlJT1MubW0gYi9Tb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvaW9zL1dlYlBhZ2VQcm94eUlPUy5tbQppbmRleCAyYTQyN2Y4Li5jZjNjNzYz IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvaW9zL1dlYlBhZ2VQcm94eUlP Uy5tbQorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvaW9zL1dlYlBhZ2VQcm94eUlPUy5t bQpAQCAtNTUwLDYgKzU1MCwxMSBAQCB2b2lkIFdlYlBhZ2VQcm94eTo6c2hvd1BsYXliYWNrVGFy Z2V0UGlja2VyKGJvb2wgaGFzVmlkZW8sIGNvbnN0IEludFJlY3QmIGVsZW1lbgogICAgIG1fcGFn ZUNsaWVudC5zaG93UGxheWJhY2tUYXJnZXRQaWNrZXIoaGFzVmlkZW8sIGVsZW1lbnRSZWN0KTsK IH0KIAordm9pZCBXZWJQYWdlUHJveHk6Onpvb21Ub1JlY3QoRmxvYXRSZWN0IHJlY3QsIGRvdWJs ZSBtaW5pbXVtU2NhbGUsIGRvdWJsZSBtYXhpbXVtU2NhbGUpCit7CisgICAgbV9wYWdlQ2xpZW50 Lnpvb21Ub1JlY3QocmVjdCwgbWluaW11bVNjYWxlLCBtYXhpbXVtU2NhbGUpOworfQorCiB9IC8v IG5hbWVzcGFjZSBXZWJLaXQKIAogI2VuZGlmIC8vIFBMQVRGT1JNKElPUykKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmggYi9Tb3VyY2UvV2Vi S2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5oCmluZGV4IDNkZjg0ZjcuLjczZGRiYmQg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmgK KysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuaApAQCAtMjIy LDcgKzIyMiw3IEBAIHB1YmxpYzoKICAgICBib29sIHNjcm9sbEJ5KHVpbnQzMl90IHNjcm9sbERp cmVjdGlvbiwgdWludDMyX3Qgc2Nyb2xsR3JhbnVsYXJpdHkpOwogCiAgICAgdm9pZCBjZW50ZXJT ZWxlY3Rpb25JblZpc2libGVBcmVhKCk7Ci0gICAgCisKICNpZiBQTEFURk9STShDT0NPQSkKICAg ICB2b2lkIHdpbGxDb21taXRMYXllclRyZWUoUmVtb3RlTGF5ZXJUcmVlVHJhbnNhY3Rpb24mKTsK ICNlbmRpZgpAQCAtNzAwLDYgKzcwMCw3IEBAIHB1YmxpYzoKICAgICB2b2lkIGFwcGxpY2F0aW9u V2lsbFJlc2lnbkFjdGl2ZSgpOwogICAgIHZvaWQgYXBwbGljYXRpb25XaWxsRW50ZXJGb3JlZ3Jv dW5kKCk7CiAgICAgdm9pZCBhcHBsaWNhdGlvbkRpZEJlY29tZUFjdGl2ZSgpOworICAgIHZvaWQg em9vbVRvUmVjdChXZWJDb3JlOjpGbG9hdFJlY3QsIGRvdWJsZSBtaW5pbXVtU2NhbGUsIGRvdWJs ZSBtYXhpbXVtU2NhbGUpOwogI2VuZGlmCiAKICNpZiBQTEFURk9STShHVEspICYmIFVTRShURVhU VVJFX01BUFBFUl9HTCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2Vi UGFnZS9pb3MvV2ViUGFnZUlPUy5tbSBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFn ZS9pb3MvV2ViUGFnZUlPUy5tbQppbmRleCBlZDFlMDAzLi4xYmZiNzYzIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvaW9zL1dlYlBhZ2VJT1MubW0KKysrIGIv U291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL2lvcy9XZWJQYWdlSU9TLm1tCkBAIC0x OTE0LDYgKzE5MTQsMTEgQEAgV2ViQ29yZTo6V2ViR0xMb2FkUG9saWN5IFdlYlBhZ2U6OnJlc29s dmVXZWJHTFBvbGljeUZvclVSTChXZWJGcmFtZSosIGNvbnN0IFN0cmkKIH0KICNlbmRpZgogCit2 b2lkIFdlYlBhZ2U6Onpvb21Ub1JlY3QoRmxvYXRSZWN0IHJlY3QsIGRvdWJsZSBtaW5pbXVtU2Nh bGUsIGRvdWJsZSBtYXhpbXVtU2NhbGUpCit7CisgICAgc2VuZChNZXNzYWdlczo6V2ViUGFnZVBy b3h5Ojpab29tVG9SZWN0KHJlY3QsIG1pbmltdW1TY2FsZSwgbWF4aW11bVNjYWxlKSk7Cit9CisK IH0gLy8gbmFtZXNwYWNlIFdlYktpdAogCiAjZW5kaWYgLy8gUExBVEZPUk0oSU9TKQo=