131557 2014-04-11 12:33:50 -0700 check-webkit-style should skip in-tree bindings tests results 2014-04-14 10:07:08 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 burg webkit-unassigned llango.u-szeged ossy pmolnar.u-szeged oldest_to_newest 999984 0 burg 2014-04-11 12:33:50 -0700 Whenever you rebaseline results, the style bot complains about generated code. e.g, <https://bugs.webkit.org/show_bug.cgi?id=131407> 1000322 1 burg 2014-04-13 12:48:35 -0700 I think it just needs to include these paths in _SKIPPED_FILES_WITHOUT_WARNING of checker.py 1000437 2 ossy 2014-04-14 01:22:50 -0700 (In reply to comment #1) > I think it just needs to include these paths in _SKIPPED_FILES_WITHOUT_WARNING of checker.py Yes, it can works. But I prefer fixing the generator instead of disabling style checker for these files. I don't like 5-space indentation. :-/ 1000452 3 ossy 2014-04-14 02:27:50 -0700 (In reply to comment #2) > (In reply to comment #1) > > I think it just needs to include these paths in _SKIPPED_FILES_WITHOUT_WARNING of checker.py > > Yes, it can works. But I prefer fixing the generator > instead of disabling style checker for these files. > > I don't like 5-space indentation. :-/ The bug isn't in check-webkit-style, but the change in code generator which added 5-space indentation accidentally: https://trac.webkit.org/changeset/165521 1000468 4 pmolnar.u-szeged 2014-04-14 05:23:45 -0700 (In reply to comment #3) > (In reply to comment #2) > > (In reply to comment #1) > > > I think it just needs to include these paths in _SKIPPED_FILES_WITHOUT_WARNING of checker.py > > > > Yes, it can works. But I prefer fixing the generator > > instead of disabling style checker for these files. > > > > I don't like 5-space indentation. :-/ > > The bug isn't in check-webkit-style, but the change in code generator > which added 5-space indentation accidentally: https://trac.webkit.org/changeset/165521 Created a fix for the code generator: https://bugs.webkit.org/show_bug.cgi?id=131613 1000516 5 burg 2014-04-14 10:07:08 -0700 Oops, I guess it was my fault all along. Thanks everyone.