131555 2014-04-11 12:14:24 -0700 AX: Cleanup AccessibilityObject::getAttribute 2014-04-12 13:06:46 -0700 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 cfleizach cfleizach aboxhall apinheiro commit-queue dmazzoni jcraig jdiggs mario samuel_white webkit-bug-importer oldest_to_newest 999976 0 cfleizach 2014-04-11 12:14:24 -0700 This method can be reduced in size by using more helper methods 999977 1 webkit-bug-importer 2014-04-11 12:14:41 -0700 <rdar://problem/16594425> 999978 2 229148 cfleizach 2014-04-11 12:15:20 -0700 Created attachment 229148 patch 1000218 3 229148 commit-queue 2014-04-12 13:06:42 -0700 Comment on attachment 229148 patch Clearing flags on attachment: 229148 Committed r167186: <http://trac.webkit.org/changeset/167186> 1000219 4 commit-queue 2014-04-12 13:06:46 -0700 All reviewed patches have been landed. Closing bug. 229148 2014-04-11 12:15:20 -0700 2014-04-12 13:06:41 -0700 patch patch text/plain 1550 cfleizach SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2NzEzOSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE0LTA0LTExICBDaHJpcyBG bGVpemFjaCAgPGNmbGVpemFjaEBhcHBsZS5jb20+CisKKyAgICAgICAgQVg6IENsZWFudXAgQWNj ZXNzaWJpbGl0eU9iamVjdDo6Z2V0QXR0cmlidXRlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzE1NTUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgZnVuY3Rpb25hbGl0eS4KKworICAgICAgICAq IGFjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eU9iamVjdC5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpBY2Nlc3NpYmlsaXR5T2JqZWN0OjpnZXRBdHRyaWJ1dGUpOgorCiAyMDE0LTA0LTExICBBbnR0 aSBLb2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KIAogICAgICAgICBQaXBlIGluaXRpYWwgc2Nh bGUgZmFjdG9yIHRvIFRpbGVDb250cm9sbGVyCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9hY2Nlc3Np YmlsaXR5L0FjY2Vzc2liaWxpdHlPYmplY3QuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJD b3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eU9iamVjdC5jcHAJKHJldmlzaW9uIDE2Njg4 OCkKKysrIFNvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eU9iamVjdC5j cHAJKHdvcmtpbmcgY29weSkKQEAgLTE2MDEsMTUgKzE2MDEsOSBAQAogICAgIAogY29uc3QgQXRv bWljU3RyaW5nJiBBY2Nlc3NpYmlsaXR5T2JqZWN0OjpnZXRBdHRyaWJ1dGUoY29uc3QgUXVhbGlm aWVkTmFtZSYgYXR0cmlidXRlKSBjb25zdAogewotICAgIE5vZGUqIGVsZW1lbnROb2RlID0gbm9k ZSgpOwotICAgIGlmICghZWxlbWVudE5vZGUpCi0gICAgICAgIHJldHVybiBudWxsQXRvbTsKLSAg ICAKLSAgICBpZiAoIWVsZW1lbnROb2RlLT5pc0VsZW1lbnROb2RlKCkpCi0gICAgICAgIHJldHVy biBudWxsQXRvbTsKLSAgICAKLSAgICBFbGVtZW50KiBlbGVtZW50ID0gdG9FbGVtZW50KGVsZW1l bnROb2RlKTsKLSAgICByZXR1cm4gZWxlbWVudC0+ZmFzdEdldEF0dHJpYnV0ZShhdHRyaWJ1dGUp OworICAgIGlmIChFbGVtZW50KiBlbGVtZW50ID0gdGhpcy0+ZWxlbWVudCgpKQorICAgICAgICBy ZXR1cm4gZWxlbWVudC0+ZmFzdEdldEF0dHJpYnV0ZShhdHRyaWJ1dGUpOworICAgIHJldHVybiBu dWxsQXRvbTsKIH0KICAgICAKIC8vIExhY2tpbmcgY29uY3JldGUgZXZpZGVuY2Ugb2Ygb3JpZW50 YXRpb24sIGhvcml6b250YWwgbWVhbnMgd2lkdGggPiBoZWlnaHQuIHZlcnRpY2FsIGlzIGhlaWdo dCA+IHdpZHRoOwo=